mirror of
https://github.com/lukaszraczylo/gohoarder.git
synced 2026-07-14 05:06:14 +00:00
e39d6a0f0d
Multi-agent audit + fix pass covering bugs, security, dead config wiring,
and missing features. All quality gates green: build/vet/test -race/govulncheck/
golangci-lint. Frontend tests 47/47.
SECURITY & CORRECTNESS
- Scanner pipeline fail-closed: cache.go scan timeout now 503 (was goto servePkg);
scanner.go all-scanners-fail saves ScanStatusError; CheckVulnerabilities blocks
on missing/error result instead of allowing.
- Scanner argv corrections: govulncheck source-mode + go.mod discovery;
npm-audit generates lockfile via npm install --package-lock-only --ignore-scripts;
pip-audit per-extension dispatch (wheel direct / sdist extract+pyproject).
- GHSA version-range filtering implemented (was always-include); url.QueryEscape
on package name.
- pypi SSRF closed via host allowlist on original_url; url.QueryEscape on
rewriteURL output.
- Path traversal: cache temp file uses os.CreateTemp; smb keyToPath sanitized;
filesystem keyToPath returns error + filepath.Abs prefix-verify.
- Goroutine leaks plugged: cache.cleanupWorker stop channel; auth.ValidationCache
Stop() with sync.Once; ws.unregister buffered with non-blocking send.
- WebSocket double-close panic fixed via sync.Once Client.closeSend().
- Race conditions: gormstore.registryCache sync.RWMutex (was concurrent map
panic); auth.LastUsedAt no longer mutated under RLock; analytics strict
lock-ordering invariant (statsMu before downloadsMu).
- Auth validator fails CLOSED on transport/unknown-status errors (was returning
true,err 'allow cache fallback').
- Credential cache hash full SHA256 (was 8-byte truncate; eliminates 2^32
collision risk).
- filesystem.fs.used incremented after successful rename (no quota inflation
race).
- gormstore aggregation events deleted in same tx as insert (no double-counting).
- gormstore.SavePackage uses Updates(map) so zero-value security flags
(RequiresAuth=false) can be cleared.
- partition_manager validates partition name regex before DROP TABLE.
- vcs/git: version regex validation rejects --option-injection; checkout uses
--detach -- separator; removed TrimPrefix(repo,'v') that corrupted vault/
vitess/vim-go.
- WebSocket CheckOrigin allowlist (was return true; CSWSH closed); same-origin
default + ServerConfig.AllowedOrigins.
- fiber CVE GO-2026-4543 patched (v2.52.10 -> v2.52.12).
FUNCTIONAL FEATURES
- API key DB persistence: APIKeyModel + migration 202604280002, full CRUD,
async LastUsedAt updates with WaitGroup-tracked goroutines drained on Close.
- Admin bootstrap via GOHOARDER_BOOTSTRAP_ADMIN_KEY env var; idempotent
(skipped when non-revoked admin already exists).
- Auth middleware factory in pkg/app: RequireAuth, RequireRole, RequirePermission,
OptionalAuth. Mounted on proxy + read APIs when Auth.Enabled=true.
DELETE /api/packages/* requires admin role. /health public for k8s probes.
- NFS storage backend: pkg/storage/nfs wraps filesystem with /proc/mounts
detection (Linux), post-write fsync, read-after-write health probe.
- WebSocket real-time pipeline: pkg/events Broadcaster interface; cache + scanner
managers emit EventPackageCached / EventPackageDownloaded / EventScanComplete;
app.go runs 30s EventStatsUpdate ticker. Frontend has full WS client (reconnect
with exponential backoff 1s->30s, 25s heartbeat, subscriber pattern), Pinia
realtime store, Dashboard live indicator + activity feed + reactive stats
override.
- TLS termination: fiber.ListenTLS when Server.TLS.Enabled.
- Pre-warming: Prewarming.Enabled flag wired (was hardcoded false); Interval,
MaxConcurrent, TopPackages plumbed.
- NetworkConfig wired (timeouts, retry, rate-limit, circuit-breaker).
- AuthConfig.BcryptCost wired.
- Security.Scanners.Static.MaxPackageSize plumbed to cache.io.LimitReader.
- Handlers.{Go,NPM,PyPI}.Enabled gates route mounting.
- Graceful shutdown: authManager.Close drains async writes.
LINT/HYGIENE
- 80 golangci-lint issues resolved: errcheck (Close/Write/RemoveAll wrapped),
gofmt, gosec G104/G306, govet shadow renames + fieldalignment reorders,
staticcheck ST1000 pkg comments + QF1003 tagged switches + QF1008 embedded
field selectors + QF1001 De Morgan's law.
BEHAVIOR CHANGES
- Scanner now fail-closed: deployments without scanner binaries
(trivy/govulncheck/npm-audit/pip-audit/grype) BLOCK packages instead of
serving unscanned. Add binaries or plan a future allow-on-scan-error flag.
- WS origin defaults to same-origin; cross-origin dashboards must set
server.allowed_origins.
- Validator no longer fails open; private packages won't serve from cache when
validation can't be performed.
- download_events retention dropped from 24h to ~5min (deleted in agg tx).
Migration 202604280001 purges pre-upgrade events.
- DELETE /api/packages/* requires admin role when auth enabled.
NEW PACKAGES
- pkg/events - Broadcaster interface
- pkg/storage/nfs - NFS-aware filesystem wrapper
DEFERRED (out of scope this pass)
- Static scanner implementation (config defines AllowedLicenses/MaxPackageSize/
BlockSuspicious but pkg/scanner/static/ does not exist).
- AuthConfig.AuditLog wiring (no audit log infra yet).
- CacheConfig.TTLOverrides passthrough (would touch cache.Config beyond
integrator scope).
259 lines
6.2 KiB
Go
259 lines
6.2 KiB
Go
package main
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
"flag"
|
|
"fmt"
|
|
stdlog "log"
|
|
"os"
|
|
"time"
|
|
|
|
"github.com/go-gormigrate/gormigrate/v2"
|
|
_ "github.com/go-sql-driver/mysql"
|
|
_ "github.com/lib/pq"
|
|
"github.com/lukaszraczylo/gohoarder/pkg/metadata/gormstore"
|
|
"github.com/rs/zerolog"
|
|
"github.com/rs/zerolog/log"
|
|
"gorm.io/driver/mysql"
|
|
"gorm.io/driver/postgres"
|
|
"gorm.io/driver/sqlite"
|
|
"gorm.io/gorm"
|
|
"gorm.io/gorm/logger"
|
|
)
|
|
|
|
type MigrationConfig struct {
|
|
Driver string
|
|
DSN string
|
|
Action string // migrate, rollback, rollback-to, list
|
|
TargetID string // For rollback-to
|
|
LogLevel string
|
|
Timeout time.Duration
|
|
}
|
|
|
|
func main() {
|
|
cfg := MigrationConfig{}
|
|
|
|
flag.StringVar(&cfg.Driver, "driver", os.Getenv("DB_DRIVER"), "Database driver (postgres, mysql, sqlite)")
|
|
flag.StringVar(&cfg.DSN, "dsn", os.Getenv("DATABASE_URL"), "Database connection string")
|
|
flag.DurationVar(&cfg.Timeout, "timeout", 10*time.Minute, "Migration timeout")
|
|
flag.StringVar(&cfg.Action, "action", "migrate", "Action: migrate, rollback, rollback-to, list")
|
|
flag.StringVar(&cfg.TargetID, "target", "", "Target migration ID (for rollback-to)")
|
|
flag.StringVar(&cfg.LogLevel, "log-level", "info", "Log level: debug, info, warn, error")
|
|
flag.Parse()
|
|
|
|
// Setup logging
|
|
setupLogging(cfg.LogLevel)
|
|
|
|
log.Info().
|
|
Str("driver", cfg.Driver).
|
|
Str("action", cfg.Action).
|
|
Msg("Starting database migration")
|
|
|
|
if err := RunMigration(cfg); err != nil {
|
|
log.Fatal().Err(err).Msg("Migration failed")
|
|
}
|
|
|
|
log.Info().Msg("Migration completed successfully")
|
|
}
|
|
|
|
func setupLogging(level string) {
|
|
zerolog.TimeFieldFormat = zerolog.TimeFormatUnix
|
|
log.Logger = log.Output(zerolog.ConsoleWriter{Out: os.Stdout, TimeFormat: time.RFC3339})
|
|
|
|
switch level {
|
|
case "debug":
|
|
zerolog.SetGlobalLevel(zerolog.DebugLevel)
|
|
case "info":
|
|
zerolog.SetGlobalLevel(zerolog.InfoLevel)
|
|
case "warn":
|
|
zerolog.SetGlobalLevel(zerolog.WarnLevel)
|
|
case "error":
|
|
zerolog.SetGlobalLevel(zerolog.ErrorLevel)
|
|
default:
|
|
zerolog.SetGlobalLevel(zerolog.InfoLevel)
|
|
}
|
|
}
|
|
|
|
func RunMigration(cfg MigrationConfig) error {
|
|
// Validate config
|
|
if cfg.Driver == "" {
|
|
return fmt.Errorf("driver is required (set DB_DRIVER or --driver)")
|
|
}
|
|
if cfg.DSN == "" {
|
|
return fmt.Errorf("DSN is required (set DATABASE_URL or --dsn)")
|
|
}
|
|
|
|
ctx, cancel := context.WithTimeout(context.Background(), cfg.Timeout)
|
|
defer cancel()
|
|
|
|
// Connect to database
|
|
db, err := connectToDatabase(cfg.Driver, cfg.DSN)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to connect to database: %w", err)
|
|
}
|
|
|
|
sqlDB, err := db.DB()
|
|
if err != nil {
|
|
return fmt.Errorf("failed to get sql.DB: %w", err)
|
|
}
|
|
defer func() { _ = sqlDB.Close() }()
|
|
|
|
// Wait for database to be ready
|
|
if err := waitForDB(ctx, sqlDB, 60*time.Second); err != nil {
|
|
return fmt.Errorf("database not ready: %w", err)
|
|
}
|
|
|
|
// Initialize gormigrate with custom options
|
|
opts := gormigrate.DefaultOptions
|
|
opts.TableName = "gohoarder_migrations"
|
|
m := gormigrate.New(db, opts, gormstore.GetMigrations())
|
|
|
|
log.Info().
|
|
Str("table", "gohoarder_migrations").
|
|
Msg("Migration tracking table initialized")
|
|
|
|
// Execute action
|
|
switch cfg.Action {
|
|
case "migrate":
|
|
return runMigrate(m)
|
|
case "rollback":
|
|
return runRollback(m)
|
|
case "rollback-to":
|
|
if cfg.TargetID == "" {
|
|
return fmt.Errorf("target migration ID required for rollback-to")
|
|
}
|
|
return runRollbackTo(m, cfg.TargetID)
|
|
case "list":
|
|
return listMigrations(db)
|
|
default:
|
|
return fmt.Errorf("unknown action: %s (use: migrate, rollback, rollback-to, list)", cfg.Action)
|
|
}
|
|
}
|
|
|
|
func connectToDatabase(driver, dsn string) (*gorm.DB, error) {
|
|
// Configure GORM logger using standard library log
|
|
gormLogger := logger.New(
|
|
stdlog.New(os.Stdout, "\r\n", stdlog.LstdFlags),
|
|
logger.Config{
|
|
SlowThreshold: 200 * time.Millisecond,
|
|
LogLevel: logger.Info,
|
|
IgnoreRecordNotFoundError: true,
|
|
Colorful: true,
|
|
},
|
|
)
|
|
|
|
var dialector gorm.Dialector
|
|
switch driver {
|
|
case "sqlite":
|
|
dialector = sqlite.Open(dsn)
|
|
case "postgres", "postgresql":
|
|
dialector = postgres.Open(dsn)
|
|
case "mysql":
|
|
dialector = mysql.Open(dsn)
|
|
default:
|
|
return nil, fmt.Errorf("unsupported driver: %s", driver)
|
|
}
|
|
|
|
db, err := gorm.Open(dialector, &gorm.Config{
|
|
Logger: gormLogger,
|
|
SkipDefaultTransaction: false, // Migrations should be transactional
|
|
PrepareStmt: true,
|
|
})
|
|
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return db, nil
|
|
}
|
|
|
|
func waitForDB(ctx context.Context, db *sql.DB, timeout time.Duration) error {
|
|
deadline := time.Now().Add(timeout)
|
|
attempt := 0
|
|
|
|
for {
|
|
attempt++
|
|
if time.Now().After(deadline) {
|
|
return fmt.Errorf("timeout waiting for database after %d attempts", attempt)
|
|
}
|
|
|
|
if err := db.PingContext(ctx); err == nil {
|
|
log.Info().
|
|
Int("attempts", attempt).
|
|
Msg("Database is ready")
|
|
return nil
|
|
}
|
|
|
|
log.Debug().
|
|
Int("attempt", attempt).
|
|
Msg("Waiting for database...")
|
|
time.Sleep(2 * time.Second)
|
|
}
|
|
}
|
|
|
|
func runMigrate(m *gormigrate.Gormigrate) error {
|
|
log.Info().Msg("Running migrations...")
|
|
|
|
if err := m.Migrate(); err != nil {
|
|
return fmt.Errorf("migration failed: %w", err)
|
|
}
|
|
|
|
log.Info().Msg("✓ All migrations applied successfully")
|
|
return nil
|
|
}
|
|
|
|
func runRollback(m *gormigrate.Gormigrate) error {
|
|
log.Warn().Msg("Rolling back last migration...")
|
|
|
|
if err := m.RollbackLast(); err != nil {
|
|
return fmt.Errorf("rollback failed: %w", err)
|
|
}
|
|
|
|
log.Info().Msg("✓ Rollback completed")
|
|
return nil
|
|
}
|
|
|
|
func runRollbackTo(m *gormigrate.Gormigrate, targetID string) error {
|
|
log.Warn().
|
|
Str("target_id", targetID).
|
|
Msg("Rolling back to migration...")
|
|
|
|
if err := m.RollbackTo(targetID); err != nil {
|
|
return fmt.Errorf("rollback to %s failed: %w", targetID, err)
|
|
}
|
|
|
|
log.Info().
|
|
Str("target_id", targetID).
|
|
Msg("✓ Rollback completed")
|
|
return nil
|
|
}
|
|
|
|
func listMigrations(db *gorm.DB) error {
|
|
log.Info().Msg("Applied migrations:")
|
|
|
|
type Migration struct {
|
|
ID string
|
|
}
|
|
|
|
var migrations []Migration
|
|
if err := db.Table("gohoarder_migrations").Find(&migrations).Error; err != nil {
|
|
return fmt.Errorf("failed to list migrations: %w", err)
|
|
}
|
|
|
|
if len(migrations) == 0 {
|
|
log.Info().Msg(" (no migrations applied yet)")
|
|
return nil
|
|
}
|
|
|
|
for _, m := range migrations {
|
|
log.Info().Str("id", m.ID).Msg(" ✓")
|
|
}
|
|
|
|
log.Info().
|
|
Int("total", len(migrations)).
|
|
Msg("Applied migrations")
|
|
|
|
return nil
|
|
}
|