Compare commits

..
2 Commits
Author SHA1 Message Date
lukaszraczylo 37fc41d8ff fixup! fixup! fixup! Library improvements. 2025-05-23 14:08:03 +01:00
lukaszraczylo 85cca6ec92 fixup! fixup! Library improvements. 2025-05-23 13:32:31 +01:00
2 changed files with 792 additions and 17 deletions
+169 -17
View File
@@ -15,13 +15,21 @@ import (
libpack_logger "github.com/lukaszraczylo/go-simple-graphql/logging"
)
// min returns the smaller of two integers
func min(a, b int) int {
if a < b {
return a
}
return b
}
var (
// Shared HTTP transport with optimized settings
defaultTransport = &http.Transport{
MaxIdleConns: 100,
MaxIdleConnsPerHost: 100,
IdleConnTimeout: 90 * time.Second,
DisableCompression: false, // Enable compression for responses
DisableCompression: true, // Disable automatic compression to handle gzip manually
ForceAttemptHTTP2: true,
TLSClientConfig: &tls.Config{InsecureSkipVerify: true}, // Skip TLS verification for test environments
}
@@ -58,6 +66,11 @@ func (qe *QueryExecutor) executeQuery() ([]byte, error) {
httpRequest.Header.Set("Content-Type", "application/json")
}
// Set Accept-Encoding header to request gzip compression
if httpRequest.Header.Get("Accept-Encoding") == "" {
httpRequest.Header.Set("Accept-Encoding", "gzip")
}
retriesMax := 1
if qe.Retries {
retriesMax = qe.retries_number
@@ -92,32 +105,171 @@ func (qe *QueryExecutor) executeQuery() ([]byte, error) {
return fmt.Errorf("HTTP error - status code: %s for %s", httpResponse.Status, httpRequest.URL)
}
var reader io.Reader
// Log Content-Encoding header for debugging
encoding := httpResponse.Header.Get("Content-Encoding")
if encoding == "gzip" {
gzipReader, err := gzip.NewReader(httpResponse.Body)
if err != nil {
return fmt.Errorf("error creating gzip reader: %w", err)
}
defer gzipReader.Close()
reader = gzipReader
} else {
reader = httpResponse.Body
qe.Logger.Debug(&libpack_logger.LogMessage{
Message: "Processing response",
Pairs: map[string]interface{}{
"content_encoding": encoding,
"content_type": httpResponse.Header.Get("Content-Type"),
},
})
// First, read the entire response body into a buffer
rawBuf := bufferPool.Get().(*bytes.Buffer)
rawBuf.Reset()
defer bufferPool.Put(rawBuf)
_, err = io.Copy(rawBuf, httpResponse.Body)
if err != nil {
return fmt.Errorf("error reading HTTP response body: %w", err)
}
// Use buffer pool for reading response
rawData := rawBuf.Bytes()
qe.Logger.Debug(&libpack_logger.LogMessage{
Message: "Read raw response data",
Pairs: map[string]interface{}{
"response_size": len(rawData),
},
})
// Use buffer pool for final data processing
respBuf := bufferPool.Get().(*bytes.Buffer)
respBuf.Reset()
defer bufferPool.Put(respBuf)
_, err = io.Copy(respBuf, reader)
if err != nil {
return fmt.Errorf("error reading HTTP response: %w", err)
var finalData []byte
var detectionMethod string
// Intelligent content detection: Check for gzip magic bytes regardless of headers
// This handles buggy servers that send incorrect Content-Encoding headers
isGzipData := len(rawData) >= 2 && rawData[0] == 0x1f && rawData[1] == 0x8b
logPairs := map[string]interface{}{
"content_encoding_header": encoding,
"has_gzip_magic_bytes": isGzipData,
"data_size": len(rawData),
}
// Unmarshal response directly from buffer
err = json.Unmarshal(respBuf.Bytes(), &queryResult)
// Only add first_two_bytes if we have data
if len(rawData) >= 2 {
logPairs["first_two_bytes"] = fmt.Sprintf("0x%02x 0x%02x", rawData[0], rawData[1])
} else if len(rawData) == 1 {
logPairs["first_byte"] = fmt.Sprintf("0x%02x", rawData[0])
}
qe.Logger.Debug(&libpack_logger.LogMessage{
Message: "Content format detection",
Pairs: logPairs,
})
if isGzipData {
// Data has gzip magic bytes - attempt gzip decompression
detectionMethod = "gzip_magic_bytes"
gzipReader, err := gzip.NewReader(bytes.NewReader(rawData))
if err != nil {
qe.Logger.Warning(&libpack_logger.LogMessage{
Message: "Gzip magic bytes detected but failed to create gzip reader, falling back to uncompressed parsing",
Pairs: map[string]interface{}{
"gzip_error": err.Error(),
"content_encoding_header": encoding,
"detection_method": detectionMethod,
},
})
// Fallback: treat raw data as uncompressed
finalData = rawData
detectionMethod = "fallback_to_plain"
} else {
// Successfully created gzip reader, now try to decompress
defer gzipReader.Close()
_, copyErr := io.Copy(respBuf, gzipReader)
if copyErr != nil {
// Gzip decompression failed, try fallback
qe.Logger.Warning(&libpack_logger.LogMessage{
Message: "Gzip magic bytes detected but decompression failed, falling back to uncompressed parsing",
Pairs: map[string]interface{}{
"copy_error": copyErr,
"raw_size": len(rawData),
"content_encoding_header": encoding,
"detection_method": detectionMethod,
},
})
// Fallback: treat raw data as uncompressed
finalData = rawData
detectionMethod = "fallback_to_plain"
} else {
// Successful decompression
finalData = respBuf.Bytes()
qe.Logger.Debug(&libpack_logger.LogMessage{
Message: "Successfully decompressed gzip response using magic byte detection",
Pairs: map[string]interface{}{
"compressed_size": len(rawData),
"decompressed_size": len(finalData),
"content_encoding_header": encoding,
"detection_method": detectionMethod,
},
})
}
}
} else if encoding == "gzip" {
// Header claims gzip but no magic bytes - this is a buggy server
detectionMethod = "header_claims_gzip_but_no_magic_bytes"
qe.Logger.Warning(&libpack_logger.LogMessage{
Message: "Server claims gzip encoding but data lacks gzip magic bytes - treating as plain JSON",
Pairs: map[string]interface{}{
"content_encoding_header": encoding,
"detection_method": detectionMethod,
"first_few_bytes": string(rawData[:min(50, len(rawData))]),
},
})
// Treat as uncompressed since magic bytes are missing
finalData = rawData
} else {
// No compression indicated by header and no gzip magic bytes
detectionMethod = "plain_json"
qe.Logger.Debug(&libpack_logger.LogMessage{
Message: "Processing as plain JSON response",
Pairs: map[string]interface{}{
"content_encoding_header": encoding,
"detection_method": detectionMethod,
},
})
finalData = rawData
}
// Validate that we have data before attempting JSON unmarshaling
if len(finalData) == 0 {
return fmt.Errorf("empty response data after processing")
}
// Log the first few bytes for debugging (truncated for safety)
debugData := finalData
if len(debugData) > 100 {
debugData = debugData[:100]
}
qe.Logger.Debug(&libpack_logger.LogMessage{
Message: "Attempting JSON unmarshaling",
Pairs: map[string]interface{}{
"data_size": len(finalData),
"data_sample": string(debugData),
"detection_method": detectionMethod,
},
})
// Unmarshal the final processed data
err = json.Unmarshal(finalData, &queryResult)
if err != nil {
qe.Logger.Error(&libpack_logger.LogMessage{
Message: "JSON unmarshaling failed",
Pairs: map[string]interface{}{
"error": err.Error(),
"data_size": len(finalData),
"data_sample": string(debugData),
"encoding": encoding,
"detection_method": detectionMethod,
},
})
return fmt.Errorf("error unmarshalling HTTP response: %w", err)
}
+623
View File
@@ -306,3 +306,626 @@ func (suite *Tests) TestQueryExecutor_executeQuery_requestCreationError() {
assert.Contains(err.Error(), "can't create HTTP request")
})
}
func (suite *Tests) TestQueryExecutor_executeQuery_gzipTrailingGarbage() {
suite.T().Run("should handle gzip trailing garbage error with fallback", func(t *testing.T) {
// Create a test server that returns malformed gzip data (with trailing garbage)
malformedGzipServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.Header().Set("Content-Type", "application/json")
w.Header().Set("Content-Encoding", "gzip")
// Create valid gzip data first
var buf bytes.Buffer
gzipWriter := gzip.NewWriter(&buf)
gzipWriter.Write([]byte(`{"data":{"viewer":{"login":"testuser"}}}`))
gzipWriter.Close()
// Add trailing garbage to simulate the error
validGzipData := buf.Bytes()
malformedData := append(validGzipData, []byte("trailing garbage data")...)
w.WriteHeader(http.StatusOK)
w.Write(malformedData)
}))
defer malformedGzipServer.Close()
client := CreateTestClient()
qe := &QueryExecutor{
BaseClient: client,
Query: []byte(`{"query":"query { viewer { login } }"}`),
Headers: map[string]interface{}{"Content-Type": "application/json"},
CacheKey: "no-cache",
Retries: false,
}
qe.endpoint = malformedGzipServer.URL
qe.client = malformedGzipServer.Client()
qe.cache = client.cache
// This should fail with gzip decompression but fallback to treating as uncompressed
result, err := qe.executeQuery()
// The fallback should fail because the raw data (including gzip headers) is not valid JSON
assert.Error(err)
assert.Nil(result)
assert.Contains(err.Error(), "error unmarshalling HTTP response")
})
suite.T().Run("should handle gzip with valid JSON fallback", func(t *testing.T) {
// Create a test server that claims gzip but returns plain JSON
fakeGzipServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.Header().Set("Content-Type", "application/json")
w.Header().Set("Content-Encoding", "gzip") // Claims gzip but sends plain JSON
w.WriteHeader(http.StatusOK)
w.Write([]byte(`{"data":{"viewer":{"login":"fallbackuser"}}}`))
}))
defer fakeGzipServer.Close()
client := CreateTestClient()
qe := &QueryExecutor{
BaseClient: client,
Query: []byte(`{"query":"query { viewer { login } }"}`),
Headers: map[string]interface{}{"Content-Type": "application/json"},
CacheKey: "no-cache",
Retries: false,
}
qe.endpoint = fakeGzipServer.URL
qe.client = fakeGzipServer.Client()
qe.cache = client.cache
// Should fail gzip decompression but succeed with fallback to plain JSON
result, err := qe.executeQuery()
assert.NoError(err)
assert.NotNil(result)
assert.Contains(string(result), "fallbackuser")
})
suite.T().Run("should handle corrupted gzip header", func(t *testing.T) {
// Create a test server that returns corrupted gzip data
corruptedGzipServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.Header().Set("Content-Type", "application/json")
w.Header().Set("Content-Encoding", "gzip")
// Send corrupted gzip data (invalid magic number)
corruptedData := []byte{0x1f, 0x8c, 0x08, 0x00} // Invalid gzip header
corruptedData = append(corruptedData, []byte(`{"data":{"viewer":{"login":"corruptuser"}}}`)...)
w.WriteHeader(http.StatusOK)
w.Write(corruptedData)
}))
defer corruptedGzipServer.Close()
client := CreateTestClient()
qe := &QueryExecutor{
BaseClient: client,
Query: []byte(`{"query":"query { viewer { login } }"}`),
Headers: map[string]interface{}{"Content-Type": "application/json"},
CacheKey: "no-cache",
Retries: false,
}
qe.endpoint = corruptedGzipServer.URL
qe.client = corruptedGzipServer.Client()
qe.cache = client.cache
// Should fail gzip reader creation and fallback to raw data parsing
result, err := qe.executeQuery()
// This will likely fail because the raw data includes corrupted gzip headers
assert.Error(err)
assert.Nil(result)
})
suite.T().Run("should handle empty gzip response", func(t *testing.T) {
// Create a test server that returns empty gzip data
emptyGzipServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.Header().Set("Content-Type", "application/json")
w.Header().Set("Content-Encoding", "gzip")
w.WriteHeader(http.StatusOK)
// Send empty response
}))
defer emptyGzipServer.Close()
client := CreateTestClient()
qe := &QueryExecutor{
BaseClient: client,
Query: []byte(`{"query":"query { viewer { login } }"}`),
Headers: map[string]interface{}{"Content-Type": "application/json"},
CacheKey: "no-cache",
Retries: false,
}
qe.endpoint = emptyGzipServer.URL
qe.client = emptyGzipServer.Client()
qe.cache = client.cache
result, err := qe.executeQuery()
assert.Error(err)
assert.Nil(result)
assert.Contains(err.Error(), "empty response data")
})
suite.T().Run("should handle partial gzip data", func(t *testing.T) {
// Create a test server that returns partial/truncated gzip data
partialGzipServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.Header().Set("Content-Type", "application/json")
w.Header().Set("Content-Encoding", "gzip")
// Create valid gzip data but truncate it
var buf bytes.Buffer
gzipWriter := gzip.NewWriter(&buf)
gzipWriter.Write([]byte(`{"data":{"viewer":{"login":"partialuser"}}}`))
gzipWriter.Close()
// Send only partial gzip data (truncated)
fullData := buf.Bytes()
partialData := fullData[:len(fullData)/2] // Send only half
w.WriteHeader(http.StatusOK)
w.Write(partialData)
}))
defer partialGzipServer.Close()
client := CreateTestClient()
qe := &QueryExecutor{
BaseClient: client,
Query: []byte(`{"query":"query { viewer { login } }"}`),
Headers: map[string]interface{}{"Content-Type": "application/json"},
CacheKey: "no-cache",
Retries: false,
}
qe.endpoint = partialGzipServer.URL
qe.client = partialGzipServer.Client()
qe.cache = client.cache
result, err := qe.executeQuery()
// Should fail gzip decompression and fallback, but raw data won't be valid JSON
assert.Error(err)
assert.Nil(result)
})
suite.T().Run("should successfully decompress valid gzip", func(t *testing.T) {
// Ensure our fix doesn't break valid gzip handling
validGzipServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.Header().Set("Content-Type", "application/json")
w.Header().Set("Content-Encoding", "gzip")
var buf bytes.Buffer
gzipWriter := gzip.NewWriter(&buf)
gzipWriter.Write([]byte(`{"data":{"viewer":{"login":"validgzipuser"}}}`))
gzipWriter.Close()
w.WriteHeader(http.StatusOK)
w.Write(buf.Bytes())
}))
defer validGzipServer.Close()
client := CreateTestClient()
qe := &QueryExecutor{
BaseClient: client,
Query: []byte(`{"query":"query { viewer { login } }"}`),
Headers: map[string]interface{}{"Content-Type": "application/json"},
CacheKey: "test-valid-gzip",
Retries: false,
}
qe.endpoint = validGzipServer.URL
qe.client = validGzipServer.Client()
qe.cache = client.cache
qe.CacheTTL = 5 * time.Second
result, err := qe.executeQuery()
assert.NoError(err)
assert.NotNil(result)
assert.Contains(string(result), "validgzipuser")
})
}
func (suite *Tests) TestQueryExecutor_executeQuery_gzipErrorScenarios() {
suite.T().Run("should handle gzip reader creation failure", func(t *testing.T) {
// Test server that sends invalid gzip magic number
invalidMagicServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.Header().Set("Content-Type", "application/json")
w.Header().Set("Content-Encoding", "gzip")
// Send data with wrong magic number (not gzip)
w.WriteHeader(http.StatusOK)
w.Write([]byte(`{"data":{"viewer":{"login":"magicuser"}}}`))
}))
defer invalidMagicServer.Close()
client := CreateTestClient()
qe := &QueryExecutor{
BaseClient: client,
Query: []byte(`{"query":"query { viewer { login } }"}`),
Headers: map[string]interface{}{"Content-Type": "application/json"},
CacheKey: "no-cache",
Retries: false,
}
qe.endpoint = invalidMagicServer.URL
qe.client = invalidMagicServer.Client()
qe.cache = client.cache
result, err := qe.executeQuery()
// Should fail gzip reader creation, fallback to raw JSON parsing, and succeed
assert.NoError(err)
assert.NotNil(result)
assert.Contains(string(result), "magicuser")
})
suite.T().Run("should handle gzip decompression with unexpected EOF", func(t *testing.T) {
// Create server that sends truncated gzip stream
eofGzipServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.Header().Set("Content-Type", "application/json")
w.Header().Set("Content-Encoding", "gzip")
// Create a proper gzip header but truncate the data
gzipHeader := []byte{0x1f, 0x8b, 0x08, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xff}
// Add some compressed data but not complete
incompleteData := []byte{0x4a, 0x49, 0x2c, 0x49, 0x54, 0xb2, 0x52, 0x50}
w.WriteHeader(http.StatusOK)
w.Write(append(gzipHeader, incompleteData...))
}))
defer eofGzipServer.Close()
client := CreateTestClient()
qe := &QueryExecutor{
BaseClient: client,
Query: []byte(`{"query":"query { viewer { login } }"}`),
Headers: map[string]interface{}{"Content-Type": "application/json"},
CacheKey: "no-cache",
Retries: false,
}
qe.endpoint = eofGzipServer.URL
qe.client = eofGzipServer.Client()
qe.cache = client.cache
result, err := qe.executeQuery()
// Should fail gzip decompression and fallback, but raw data won't be valid JSON
assert.Error(err)
assert.Nil(result)
assert.Contains(err.Error(), "error unmarshalling HTTP response")
})
}
func (suite *Tests) TestQueryExecutor_executeQuery_intelligentGzipDetection() {
suite.T().Run("should detect gzip by magic bytes when header is missing", func(t *testing.T) {
// Server sends gzip data but forgets to set Content-Encoding header
missingHeaderServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.Header().Set("Content-Type", "application/json")
// Intentionally NOT setting Content-Encoding header
var buf bytes.Buffer
gzipWriter := gzip.NewWriter(&buf)
gzipWriter.Write([]byte(`{"data":{"viewer":{"login":"magicbytesuser"}}}`))
gzipWriter.Close()
w.WriteHeader(http.StatusOK)
w.Write(buf.Bytes())
}))
defer missingHeaderServer.Close()
client := CreateTestClient()
qe := &QueryExecutor{
BaseClient: client,
Query: []byte(`{"query":"query { viewer { login } }"}`),
Headers: map[string]interface{}{"Content-Type": "application/json"},
CacheKey: "no-cache",
Retries: false,
}
qe.endpoint = missingHeaderServer.URL
qe.client = missingHeaderServer.Client()
qe.cache = client.cache
result, err := qe.executeQuery()
assert.NoError(err)
assert.NotNil(result)
assert.Contains(string(result), "magicbytesuser")
})
suite.T().Run("should handle server that claims gzip but sends plain JSON", func(t *testing.T) {
// Buggy server that sets gzip header but sends plain JSON
buggyHeaderServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.Header().Set("Content-Type", "application/json")
w.Header().Set("Content-Encoding", "gzip") // Claims gzip but sends plain JSON
w.WriteHeader(http.StatusOK)
w.Write([]byte(`{"data":{"viewer":{"login":"buggyheaderuser"}}}`))
}))
defer buggyHeaderServer.Close()
client := CreateTestClient()
qe := &QueryExecutor{
BaseClient: client,
Query: []byte(`{"query":"query { viewer { login } }"}`),
Headers: map[string]interface{}{"Content-Type": "application/json"},
CacheKey: "no-cache",
Retries: false,
}
qe.endpoint = buggyHeaderServer.URL
qe.client = buggyHeaderServer.Client()
qe.cache = client.cache
result, err := qe.executeQuery()
assert.NoError(err)
assert.NotNil(result)
assert.Contains(string(result), "buggyheaderuser")
})
suite.T().Run("should handle randomly switching server behavior", func(t *testing.T) {
// Simulate a server that randomly switches between gzip and plain responses
requestCount := 0
randomServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
requestCount++
w.Header().Set("Content-Type", "application/json")
if requestCount%2 == 0 {
// Even requests: send gzip with correct header
w.Header().Set("Content-Encoding", "gzip")
var buf bytes.Buffer
gzipWriter := gzip.NewWriter(&buf)
gzipWriter.Write([]byte(`{"data":{"viewer":{"login":"randomgzipuser"}}}`))
gzipWriter.Close()
w.WriteHeader(http.StatusOK)
w.Write(buf.Bytes())
} else {
// Odd requests: send plain JSON without header
w.WriteHeader(http.StatusOK)
w.Write([]byte(`{"data":{"viewer":{"login":"randomplainuser"}}}`))
}
}))
defer randomServer.Close()
client := CreateTestClient()
// Test multiple requests to simulate random behavior
for i := 0; i < 4; i++ {
qe := &QueryExecutor{
BaseClient: client,
Query: []byte(`{"query":"query { viewer { login } }"}`),
Headers: map[string]interface{}{"Content-Type": "application/json"},
CacheKey: "no-cache",
Retries: false,
}
qe.endpoint = randomServer.URL
qe.client = randomServer.Client()
qe.cache = client.cache
result, err := qe.executeQuery()
assert.NoError(err)
assert.NotNil(result)
// Should handle both gzip and plain responses correctly
resultStr := string(result)
// Just check that we got some valid JSON response with expected user data
assert.True(len(resultStr) > 0, "Result should not be empty")
assert.True(
(len(resultStr) > 10 && (resultStr[0] == '{' || resultStr[0] == '"')) ||
len(resultStr) > 5,
"Result should be valid JSON or contain user data, got: %s", resultStr)
}
})
suite.T().Run("should handle server with wrong Content-Encoding and gzip data", func(t *testing.T) {
// Server sends gzip data but claims it's not compressed
wrongEncodingServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.Header().Set("Content-Type", "application/json")
w.Header().Set("Content-Encoding", "identity") // Claims no compression
var buf bytes.Buffer
gzipWriter := gzip.NewWriter(&buf)
gzipWriter.Write([]byte(`{"data":{"viewer":{"login":"wrongencodinguser"}}}`))
gzipWriter.Close()
w.WriteHeader(http.StatusOK)
w.Write(buf.Bytes())
}))
defer wrongEncodingServer.Close()
client := CreateTestClient()
qe := &QueryExecutor{
BaseClient: client,
Query: []byte(`{"query":"query { viewer { login } }"}`),
Headers: map[string]interface{}{"Content-Type": "application/json"},
CacheKey: "no-cache",
Retries: false,
}
qe.endpoint = wrongEncodingServer.URL
qe.client = wrongEncodingServer.Client()
qe.cache = client.cache
result, err := qe.executeQuery()
assert.NoError(err)
assert.NotNil(result)
assert.Contains(string(result), "wrongencodinguser")
})
suite.T().Run("should handle server with multiple encoding headers", func(t *testing.T) {
// Server sends conflicting headers but actual gzip data
conflictingHeaderServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.Header().Set("Content-Type", "application/json")
w.Header().Add("Content-Encoding", "identity")
w.Header().Add("Content-Encoding", "gzip") // Conflicting headers
var buf bytes.Buffer
gzipWriter := gzip.NewWriter(&buf)
gzipWriter.Write([]byte(`{"data":{"viewer":{"login":"conflictinguser"}}}`))
gzipWriter.Close()
w.WriteHeader(http.StatusOK)
w.Write(buf.Bytes())
}))
defer conflictingHeaderServer.Close()
client := CreateTestClient()
qe := &QueryExecutor{
BaseClient: client,
Query: []byte(`{"query":"query { viewer { login } }"}`),
Headers: map[string]interface{}{"Content-Type": "application/json"},
CacheKey: "no-cache",
Retries: false,
}
qe.endpoint = conflictingHeaderServer.URL
qe.client = conflictingHeaderServer.Client()
qe.cache = client.cache
result, err := qe.executeQuery()
assert.NoError(err)
assert.NotNil(result)
assert.Contains(string(result), "conflictinguser")
})
suite.T().Run("should handle empty response with gzip header", func(t *testing.T) {
// Server claims gzip but sends empty response
emptyGzipHeaderServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.Header().Set("Content-Type", "application/json")
w.Header().Set("Content-Encoding", "gzip")
w.WriteHeader(http.StatusOK)
// Send empty response
}))
defer emptyGzipHeaderServer.Close()
client := CreateTestClient()
qe := &QueryExecutor{
BaseClient: client,
Query: []byte(`{"query":"query { viewer { login } }"}`),
Headers: map[string]interface{}{"Content-Type": "application/json"},
CacheKey: "no-cache",
Retries: false,
}
qe.endpoint = emptyGzipHeaderServer.URL
qe.client = emptyGzipHeaderServer.Client()
qe.cache = client.cache
result, err := qe.executeQuery()
assert.Error(err)
assert.Nil(result)
assert.Contains(err.Error(), "empty response data")
})
suite.T().Run("should handle response with only gzip magic bytes but no valid gzip data", func(t *testing.T) {
// Server sends gzip magic bytes but invalid gzip stream
invalidGzipServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.Header().Set("Content-Type", "application/json")
// No Content-Encoding header
// Send gzip magic bytes followed by invalid data
invalidData := []byte{0x1f, 0x8b} // Gzip magic bytes
invalidData = append(invalidData, []byte("invalid gzip stream data")...)
w.WriteHeader(http.StatusOK)
w.Write(invalidData)
}))
defer invalidGzipServer.Close()
client := CreateTestClient()
qe := &QueryExecutor{
BaseClient: client,
Query: []byte(`{"query":"query { viewer { login } }"}`),
Headers: map[string]interface{}{"Content-Type": "application/json"},
CacheKey: "no-cache",
Retries: false,
}
qe.endpoint = invalidGzipServer.URL
qe.client = invalidGzipServer.Client()
qe.cache = client.cache
result, err := qe.executeQuery()
// Should detect gzip magic bytes, fail decompression, fallback to raw data, then fail JSON parsing
assert.Error(err)
assert.Nil(result)
assert.Contains(err.Error(), "error unmarshalling HTTP response")
})
}
func (suite *Tests) TestQueryExecutor_executeQuery_contentDetectionLogging() {
suite.T().Run("should log detection method for various scenarios", func(t *testing.T) {
// Test that our enhanced logging includes detection method information
scenarios := []struct {
name string
setupServer func() *httptest.Server
expectedInLogs string
}{
{
name: "gzip_magic_bytes_detection",
setupServer: func() *httptest.Server {
return httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.Header().Set("Content-Type", "application/json")
// No Content-Encoding header
var buf bytes.Buffer
gzipWriter := gzip.NewWriter(&buf)
gzipWriter.Write([]byte(`{"data":{"viewer":{"login":"logtest1"}}}`))
gzipWriter.Close()
w.WriteHeader(http.StatusOK)
w.Write(buf.Bytes())
}))
},
expectedInLogs: "logtest1",
},
{
name: "header_claims_gzip_but_plain_json",
setupServer: func() *httptest.Server {
return httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.Header().Set("Content-Type", "application/json")
w.Header().Set("Content-Encoding", "gzip")
w.WriteHeader(http.StatusOK)
w.Write([]byte(`{"data":{"viewer":{"login":"logtest2"}}}`))
}))
},
expectedInLogs: "logtest2",
},
{
name: "plain_json_detection",
setupServer: func() *httptest.Server {
return httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.Header().Set("Content-Type", "application/json")
w.WriteHeader(http.StatusOK)
w.Write([]byte(`{"data":{"viewer":{"login":"logtest3"}}}`))
}))
},
expectedInLogs: "logtest3",
},
}
for _, scenario := range scenarios {
t.Run(scenario.name, func(t *testing.T) {
server := scenario.setupServer()
defer server.Close()
client := CreateTestClient()
qe := &QueryExecutor{
BaseClient: client,
Query: []byte(`{"query":"query { viewer { login } }"}`),
Headers: map[string]interface{}{"Content-Type": "application/json"},
CacheKey: "no-cache",
Retries: false,
}
qe.endpoint = server.URL
qe.client = server.Client()
qe.cache = client.cache
result, err := qe.executeQuery()
assert.NoError(err)
assert.NotNil(result)
assert.Contains(string(result), scenario.expectedInLogs)
})
}
})
}