Micro improvements on connection handling.

execute_query.go

@@ -18,7 +18,11 @@ func (qe *QueryExecutor) executeQuery() ([]byte, error) {
 	}
 
 	for key, value := range qe.Headers {
-		httpRequest.Header.Set(key, value.(string))
+		strValue, ok := value.(string)
+		if !ok {
+			strValue = fmt.Sprintf("%v", value)
+		}
+		httpRequest.Header.Set(key, strValue)
 	}
 
 	var retries_max int
@@ -41,8 +45,13 @@ func (qe *QueryExecutor) executeQuery() ([]byte, error) {
 				qe.Logger.Debug("Error while executing http request", map[string]interface{}{"error": err.Error()})
 				return err
 			}
-			defer io.Copy(io.Discard, httpResponse.Body)
-			defer httpResponse.Body.Close()
+			defer func() {
+				_, err := io.Copy(io.Discard, httpResponse.Body)
+				if err != nil {
+					qe.Logger.Debug("Error while discarding http response body;", map[string]interface{}{"error": err.Error()})
+				}
+				httpResponse.Body.Close()
+			}()
 
 			if httpResponse.StatusCode < 200 || httpResponse.StatusCode >= 204 {
 				return fmt.Errorf("HTTP error - unacceptable status code: \"%s\" for \"%s\"", httpResponse.Status, httpRequest.URL)
@@ -59,7 +68,6 @@ func (qe *QueryExecutor) executeQuery() ([]byte, error) {
 				qe.Logger.Debug("Error while unmarshalling http response;", map[string]interface{}{"error": err.Error()})
 				return fmt.Errorf("Error while unmarshalling http response: %s", err.Error())
 			}
-
 			return nil
 		},
 		retry.OnRetry(func(n uint, err error) {

http.go

@@ -11,14 +11,18 @@ import (
 
 func (b *BaseClient) createHttpClient() (http_client *http.Client) {
 	httpTransport := &http.Transport{
-		MaxIdleConns:          10,
+		MaxIdleConns:          512,
+		MaxConnsPerHost:       512,
+		MaxIdleConnsPerHost:   512,
 		IdleConnTimeout:       15 * time.Second,
 		ResponseHeaderTimeout: 15 * time.Second,
 		DisableKeepAlives:     false,
+		DisableCompression:    false,
 	}
 
 	if strings.HasPrefix(b.endpoint, "http://") {
 		http_client = &http.Client{
+			Timeout:   15 * time.Second,
 			Transport: httpTransport,
 			CheckRedirect: func(req *http.Request, via []*http.Request) error {
 				return http.ErrUseLastResponse

main.go

@@ -11,7 +11,7 @@ import (
 func NewConnection() (b *BaseClient) {
 	b = &BaseClient{
 		endpoint:       envutil.Getenv("GRAPHQL_ENDPOINT", "https://api.github.com/graphql"),
-		responseType:   envutil.Getenv("GRAPHQL_RESPONSE_TYPE", "string"),
+		responseType:   envutil.Getenv("GRAPHQL_OUTPUT", "string"),
 		Logger:         logging.NewLogger(),
 		cache:          cache.New(time.Duration(envutil.GetInt("GRAPHQL_CACHE_TTL", 5)) * time.Second),
 		cache_global:   envutil.GetBool("GRAPHQL_CACHE_ENABLED", false),