mirror of
https://github.com/lukaszraczylo/claude-mnemonic.git
synced 2026-06-05 23:03:55 +00:00
lukaszraczylo
5c2685c7b6
* feat(leann-phase2): implement hybrid vector storage and graph-based search
- [x] Add AST-aware code chunking for Go, Python, and TypeScript using tree-sitter
- [x] Implement LEANN-inspired hybrid vector storage with hub detection and selective embedding storage (60-80% savings)
- [x] Add observation relationship graph with CSR format and edge detection (file overlap, semantic similarity, temporal, concept)
- [x] Implement graph-aware search with two-level traversal and relationship-based ranking
- [x] Add auto-tuning system for dynamic hub threshold adjustment based on query performance
- [x] Add comprehensive metrics tracking for vector storage, queries, latency, and graph traversals
- [x] Update configuration system with graph and hybrid storage settings
- [x] Add graph stats and vector metrics endpoints to worker service
- [x] Enhance UI sidebar with advanced metrics display and graph visualization
- [x] Optimize struct field alignment throughout codebase for memory efficiency
- [x] Update documentation with LEANN Phase 2 features and performance benefits
- [x] Add tree-sitter dependency for AST parsing
* fix: add fts5 build tag to CI workflow
Pass build-tags: "fts5" to shared workflow to properly compile
sqlite-vec-go-bindings with SQLite FTS5 support.
This fixes test failures in hybrid vector storage tests that require
CGO and FTS5 build tags.
Requires shared-actions@8f7f235 or later.
* docs: add testing documentation and macOS ARM64 known issue
Document the macOS ARM64 CGO linking issue with sqlite-vec-go-bindings
that prevents hybrid package tests from compiling locally.
Added:
- .github/TESTING.md: Comprehensive testing guide with platform-specific
issues, workarounds, and CI configuration details
- internal/vector/hybrid/README.md: Package-specific documentation
explaining the macOS limitation
- .github/CI_FIX_SUMMARY.md: Technical details of the CI fix
Key points:
- 41 out of 42 packages test successfully on all platforms
- hybrid package tests fail only on macOS ARM64 (local dev issue)
- Linux CI tests pass with proper build-tags: "fts5" configuration
- Production builds and runtime functionality unaffected
This is a known limitation of sqlite-vec-go-bindings on macOS ARM64
and does not impact CI/CD or production deployments.
* fix: add SQLite busy_timeout to prevent database locked errors
Set PRAGMA busy_timeout=5000 (5 seconds) to allow SQLite to retry
when the database is locked instead of failing immediately.
This fixes race conditions when multiple goroutines try to write
simultaneously, particularly in tests where StoreObservation spawns
async cleanup goroutines.
Root cause:
- StoreObservation launches goroutine -> CleanupOldObservations
- Multiple concurrent cleanups caused "database is locked" errors
- Without busy_timeout, SQLite fails immediately on lock contention
Solution:
- Add 5-second busy timeout for automatic retry on lock
- Standard practice for concurrent SQLite usage
- Works with existing WAL mode configuration
Fixes TestObservationStore_CleanupOldObservations in CI.
* docs: complete summary of all CI test fixes
Comprehensive documentation of all fixes applied:
1. Missing build tags (fts5)
2. Database locked errors (busy_timeout)
All 41/42 packages now pass tests. The hybrid package has a known
macOS ARM64 limitation that doesn't affect CI or production.
No functionality was removed - all fixes are additive only.
* fix: add SQLite driver import to hybrid tests for CGO linking
Add blank import of mattn/go-sqlite3 to hybrid test files to ensure
the SQLite driver is linked into the test binary. This provides the
SQLite symbols that sqlite-vec-go-bindings requires.
Root cause:
- hybrid package imports sqlitevec (transitively depends on sqlite-vec CGO)
- Test binary needs SQLite symbols for linking
- sqlitevec tests already had this import, but hybrid tests didn't
- Without the driver import, linker fails with "undefined symbols"
This fix enables hybrid tests to run with -race flag on all platforms.
Before: 41/42 packages pass (hybrid failed to link)
After: 42/42 packages pass ✅
Fixes hybrid test compilation on macOS ARM64, Linux, and Windows.
* docs: remove outdated macOS limitation documentation
The hybrid test linking issue has been fixed by adding the SQLite
driver import. All tests now pass on all platforms including macOS.
Removed:
- internal/vector/hybrid/README.md (documented workaround no longer needed)
- .github/TESTING.md (macOS limitation section obsolete)
All 42/42 packages now test successfully with -race flag.
* docs: final comprehensive summary of all CI fixes
All three issues now resolved:
1. Missing fts5 build tags
2. Database busy_timeout for concurrent writes
3. Missing SQLite driver import in hybrid tests
Result: 42/42 packages pass with -race on all platforms.
Credit to reviewer for identifying the race detector concern.
64 lines
2.2 KiB
Markdown
64 lines
2.2 KiB
Markdown
# CI Test Failure Fix Summary
|
|
|
|
## Problem
|
|
|
|
Tests were failing in GitHub Actions for PR #20 because the `go-pr.yaml` shared workflow didn't support:
|
|
1. CGO_ENABLED=1 (required for sqlite-vec-go-bindings)
|
|
2. Build tags `-tags "fts5"` (required for SQLite FTS5 support)
|
|
|
|
## Root Cause
|
|
|
|
The hybrid vector storage feature in PR #20 depends on:
|
|
- `github.com/asg017/sqlite-vec-go-bindings/cgo` - requires CGO
|
|
- SQLite with FTS5 support - requires `-tags "fts5"` build flag
|
|
|
|
The shared workflow was running `go test` without these requirements.
|
|
|
|
## Solution
|
|
|
|
### 1. Updated shared-actions (commit 8f7f235)
|
|
|
|
**`.github/actions/go-test/action.yml`**
|
|
- Added `build-tags` input parameter
|
|
- Modified test command to use tags when provided
|
|
|
|
**`.github/workflows/go-pr.yaml`**
|
|
- Added `build-tags` input parameter
|
|
- Set `CGO_ENABLED: 1` in test job
|
|
- Pass tags to test command
|
|
|
|
**`.github/workflows/go-release-cgo.yaml`**
|
|
- Pass `build-tags: "fts5"` to go-test action
|
|
|
|
### 2. Updated claude-mnemonic (commit 90ab909)
|
|
|
|
**`.github/workflows/ci.yaml`**
|
|
- Pass `build-tags: "fts5"` to shared workflow
|
|
|
|
## What Was Already Working
|
|
|
|
The `workflow-prepare.sh` script already handled:
|
|
- Downloading ONNX runtime libraries
|
|
- Setting up SQLite on Windows for CGO
|
|
|
|
## Testing Status
|
|
|
|
✅ **Linux CI** - Should now pass (ubuntu-latest in GitHub Actions)
|
|
⚠️ **macOS Local** - Still has linking issues (macOS-specific sqlite-vec-go-bindings problem)
|
|
|
|
The macOS local testing issue is unrelated to CI and is caused by how sqlite-vec-go-bindings links on macOS ARM64 with Homebrew Go. This doesn't affect CI since it runs on Linux.
|
|
|
|
## Verification
|
|
|
|
The next CI run for PR #20 should pass. The workflow will:
|
|
1. Run `workflow-prepare.sh` to download ONNX libs
|
|
2. Run `go test -tags "fts5" -race -coverprofile=coverage.out -covermode=atomic ./...` with CGO_ENABLED=1
|
|
3. All packages including `internal/vector/hybrid` should compile and test successfully
|
|
|
|
## References
|
|
|
|
- PR #20: https://github.com/lukaszraczylo/claude-mnemonic/pull/20
|
|
- Failed CI run: https://github.com/lukaszraczylo/claude-mnemonic/actions/runs/20795930707/job/59729327008
|
|
- shared-actions fix: https://github.com/lukaszraczylo/shared-actions/commit/8f7f235
|
|
- claude-mnemonic fix: https://github.com/lukaszraczylo/claude-mnemonic/commit/90ab909
|