mirror of
https://github.com/lukaszraczylo/traefikoidc.git
synced 2026-10-14 04:07:46 +00:00
* Fix bug affecting Azure OIDC authentication ( and most likely others ) * Fixes issue #51 * Ensure that appended roles are unique. Update the documentation. * Improvements targetting possible memory usage spikes. * Additional fixes and cleanup * Refactoring code to fix the issues identified by the users. * Modernize run * Fieldalignment * Multiple changes to improve performance and reduce complexity. - Optimise the errors and recovery. - Deduplicate code in metadata cache. - Remove unused performance monitoring code. - Simplify session management and settings handling. * Fix claims issue. * Add ability to overwrite the default scopes in the settings file * Well.. that escalated quickly. Completely forgot that Traefik uses outdated Yaegi and requires compatibility with 1.20 ( pre-generic Go code ). * Bugfix #51: Ensures that user provided scopes overrides work. * fixup! Bugfix #51: Ensures that user provided scopes overrides work. * fixup! fixup! Bugfix #51: Ensures that user provided scopes overrides work. * Abstract the provider logic into a separate package. * Additional micro fixes and cleanups. * Simplify all the things. * fixup! Simplify all the things. * fixup! fixup! Simplify all the things. * fixup! fixup! fixup! Simplify all the things. * fixup! fixup! fixup! fixup! Simplify all the things. * ... * Cleanup tests. * fixup! Cleanup tests. * fixup! fixup! fixup! Cleanup tests. * fixup! fixup! fixup! fixup! Cleanup tests. * fixup! fixup! fixup! fixup! fixup! Cleanup tests. * Issue #53: Fix CSRF token handling in reverse proxy 1. ✅ HTTPS Detection Fixed (session.go:723) - Now uses X-Forwarded-Proto header instead of r.URL.Scheme - Properly detects HTTPS in reverse proxy environments 2. ✅ SameSite Cookie Attribute Fixed - Removed automatic SameSiteStrictMode for HTTPS (would break OAuth) - Keeps SameSiteLaxMode to allow OAuth callbacks from external domains - Only uses Strict for AJAX requests which don't involve OAuth redirects 3. ✅ Cookie Domain Handling Fixed - Now respects X-Forwarded-Host header for cookie domain - Ensures cookies are set for the public domain, not internal proxy domain 4. ✅ EnhanceSessionSecurity Properly Integrated - Function is now actually called during session save - Applies security enhancements without breaking OAuth flow Why Issue #53 Failed Before: 1. Cookies were not marked Secure in HTTPS environments (browser wouldn't send them back) 2. If they had been Secure with SameSite=Strict, Azure callbacks would still fail 3. Cookie domain might have been wrong (internal vs public domain) Why It Works Now: 1. Cookies are properly marked Secure for HTTPS 2. Uses SameSite=Lax to allow OAuth provider callbacks 3. Cookie domain uses public domain from X-Forwarded-Host 4. CSRF token persists through the entire OAuth flow * Next set of enhancements together with memory usage improvements. * Memory leak fixes and optimisations. * CSRF and Cookie Domain fixes * fixup! CSRF and Cookie Domain fixes * Metadata cache leak fix + profiling * fixup! Metadata cache leak fix + profiling * Memory leaks hunting, part 1337. * Further pursue of perfection. * fixup! Further pursue of perfection. * fixup! fixup! Further pursue of perfection. * fixup! fixup! fixup! Further pursue of perfection. * fixup! fixup! fixup! fixup! Further pursue of perfection. * fixup! fixup! fixup! fixup! fixup! Further pursue of perfection. * fixup! fixup! fixup! fixup! fixup! fixup! Further pursue of perfection. * fixup! fixup! fixup! fixup! fixup! fixup! fixup! Further pursue of perfection. * fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Further pursue of perfection. * fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Further pursue of perfection. * Clear race conditions * fixup! Clear race conditions * Weekend fun with memory leaks * Splitting code into multiple files with reasonable testing coverage. ``` ok github.com/lukaszraczylo/traefikoidc 117.017s coverage: 72.6% of statements ok github.com/lukaszraczylo/traefikoidc/auth 0.505s coverage: 87.1% of statements ok github.com/lukaszraczylo/traefikoidc/circuit_breaker 0.283s coverage: 99.0% of statements github.com/lukaszraczylo/traefikoidc/config coverage: 0.0% of statements ok github.com/lukaszraczylo/traefikoidc/handlers 0.349s coverage: 98.2% of statements ok github.com/lukaszraczylo/traefikoidc/internal/providers (cached) coverage: 94.3% of statements ok github.com/lukaszraczylo/traefikoidc/middleware 0.808s coverage: 78.0% of statements ok github.com/lukaszraczylo/traefikoidc/recovery 0.653s coverage: 100.0% of statements ok github.com/lukaszraczylo/traefikoidc/session/chunking (cached) coverage: 87.8% of statements ok github.com/lukaszraczylo/traefikoidc/session/core (cached) coverage: 85.6% of statements ok github.com/lukaszraczylo/traefikoidc/session/crypto (cached) coverage: 81.8% of statements ok github.com/lukaszraczylo/traefikoidc/session/storage (cached) coverage: 93.5% of statements ok github.com/lukaszraczylo/traefikoidc/session/validators (cached) coverage: 98.8% of statements ```` * fixup! Splitting code into multiple files with reasonable testing coverage. * fixup! fixup! Splitting code into multiple files with reasonable testing coverage. * Weekend fun with further optimisations. * fixup! Weekend fun with further optimisations. * fixup! fixup! Weekend fun with further optimisations. * fixup! fixup! fixup! Weekend fun with further optimisations. * fixup! fixup! fixup! fixup! Weekend fun with further optimisations. * fixup! fixup! fixup! fixup! fixup! Weekend fun with further optimisations. * Pre-release cleanup. * Enhance test coverage. * fixup! Enhance test coverage. * fixup! fixup! Enhance test coverage. * fixup! fixup! fixup! Enhance test coverage.
149 lines
5.8 KiB
Go
149 lines
5.8 KiB
Go
/*
|
|
* Copyright (c) 2013-2016 Dave Collins <[email protected]>
|
|
*
|
|
* Permission to use, copy, modify, and distribute this software for any
|
|
* purpose with or without fee is hereby granted, provided that the above
|
|
* copyright notice and this permission notice appear in all copies.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
|
|
* WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
|
|
* MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
|
|
* ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
|
|
* WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
|
|
* ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
|
|
* OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
|
|
*/
|
|
|
|
package spew
|
|
|
|
import (
|
|
"fmt"
|
|
"io"
|
|
)
|
|
|
|
// Errorf is a wrapper for fmt.Errorf that treats each argument as if it were
|
|
// passed with a default Formatter interface returned by NewFormatter. It
|
|
// returns the formatted string as a value that satisfies error. See
|
|
// NewFormatter for formatting details.
|
|
//
|
|
// This function is shorthand for the following syntax:
|
|
//
|
|
// fmt.Errorf(format, spew.NewFormatter(a), spew.NewFormatter(b))
|
|
func Errorf(format string, a ...interface{}) (err error) {
|
|
return fmt.Errorf(format, convertArgs(a)...)
|
|
}
|
|
|
|
// Fprint is a wrapper for fmt.Fprint that treats each argument as if it were
|
|
// passed with a default Formatter interface returned by NewFormatter. It
|
|
// returns the number of bytes written and any write error encountered. See
|
|
// NewFormatter for formatting details.
|
|
//
|
|
// This function is shorthand for the following syntax:
|
|
//
|
|
// fmt.Fprint(w, spew.NewFormatter(a), spew.NewFormatter(b))
|
|
func Fprint(w io.Writer, a ...interface{}) (n int, err error) {
|
|
return fmt.Fprint(w, convertArgs(a)...)
|
|
}
|
|
|
|
// Fprintf is a wrapper for fmt.Fprintf that treats each argument as if it were
|
|
// passed with a default Formatter interface returned by NewFormatter. It
|
|
// returns the number of bytes written and any write error encountered. See
|
|
// NewFormatter for formatting details.
|
|
//
|
|
// This function is shorthand for the following syntax:
|
|
//
|
|
// fmt.Fprintf(w, format, spew.NewFormatter(a), spew.NewFormatter(b))
|
|
func Fprintf(w io.Writer, format string, a ...interface{}) (n int, err error) {
|
|
return fmt.Fprintf(w, format, convertArgs(a)...)
|
|
}
|
|
|
|
// Fprintln is a wrapper for fmt.Fprintln that treats each argument as if it
|
|
// passed with a default Formatter interface returned by NewFormatter. See
|
|
// NewFormatter for formatting details.
|
|
//
|
|
// This function is shorthand for the following syntax:
|
|
//
|
|
// fmt.Fprintln(w, spew.NewFormatter(a), spew.NewFormatter(b))
|
|
func Fprintln(w io.Writer, a ...interface{}) (n int, err error) {
|
|
return fmt.Fprintln(w, convertArgs(a)...)
|
|
}
|
|
|
|
// Print is a wrapper for fmt.Print that treats each argument as if it were
|
|
// passed with a default Formatter interface returned by NewFormatter. It
|
|
// returns the number of bytes written and any write error encountered. See
|
|
// NewFormatter for formatting details.
|
|
//
|
|
// This function is shorthand for the following syntax:
|
|
//
|
|
// fmt.Print(spew.NewFormatter(a), spew.NewFormatter(b))
|
|
func Print(a ...interface{}) (n int, err error) {
|
|
return fmt.Print(convertArgs(a)...)
|
|
}
|
|
|
|
// Printf is a wrapper for fmt.Printf that treats each argument as if it were
|
|
// passed with a default Formatter interface returned by NewFormatter. It
|
|
// returns the number of bytes written and any write error encountered. See
|
|
// NewFormatter for formatting details.
|
|
//
|
|
// This function is shorthand for the following syntax:
|
|
//
|
|
// fmt.Printf(format, spew.NewFormatter(a), spew.NewFormatter(b))
|
|
func Printf(format string, a ...interface{}) (n int, err error) {
|
|
return fmt.Printf(format, convertArgs(a)...)
|
|
}
|
|
|
|
// Println is a wrapper for fmt.Println that treats each argument as if it were
|
|
// passed with a default Formatter interface returned by NewFormatter. It
|
|
// returns the number of bytes written and any write error encountered. See
|
|
// NewFormatter for formatting details.
|
|
//
|
|
// This function is shorthand for the following syntax:
|
|
//
|
|
// fmt.Println(spew.NewFormatter(a), spew.NewFormatter(b))
|
|
func Println(a ...interface{}) (n int, err error) {
|
|
return fmt.Println(convertArgs(a)...)
|
|
}
|
|
|
|
// Sprint is a wrapper for fmt.Sprint that treats each argument as if it were
|
|
// passed with a default Formatter interface returned by NewFormatter. It
|
|
// returns the resulting string. See NewFormatter for formatting details.
|
|
//
|
|
// This function is shorthand for the following syntax:
|
|
//
|
|
// fmt.Sprint(spew.NewFormatter(a), spew.NewFormatter(b))
|
|
func Sprint(a ...interface{}) string {
|
|
return fmt.Sprint(convertArgs(a)...)
|
|
}
|
|
|
|
// Sprintf is a wrapper for fmt.Sprintf that treats each argument as if it were
|
|
// passed with a default Formatter interface returned by NewFormatter. It
|
|
// returns the resulting string. See NewFormatter for formatting details.
|
|
//
|
|
// This function is shorthand for the following syntax:
|
|
//
|
|
// fmt.Sprintf(format, spew.NewFormatter(a), spew.NewFormatter(b))
|
|
func Sprintf(format string, a ...interface{}) string {
|
|
return fmt.Sprintf(format, convertArgs(a)...)
|
|
}
|
|
|
|
// Sprintln is a wrapper for fmt.Sprintln that treats each argument as if it
|
|
// were passed with a default Formatter interface returned by NewFormatter. It
|
|
// returns the resulting string. See NewFormatter for formatting details.
|
|
//
|
|
// This function is shorthand for the following syntax:
|
|
//
|
|
// fmt.Sprintln(spew.NewFormatter(a), spew.NewFormatter(b))
|
|
func Sprintln(a ...interface{}) string {
|
|
return fmt.Sprintln(convertArgs(a)...)
|
|
}
|
|
|
|
// convertArgs accepts a slice of arguments and returns a slice of the same
|
|
// length with each argument converted to a default spew Formatter interface.
|
|
func convertArgs(args []interface{}) (formatters []interface{}) {
|
|
formatters = make([]interface{}, len(args))
|
|
for index, arg := range args {
|
|
formatters[index] = NewFormatter(arg)
|
|
}
|
|
return formatters
|
|
}
|