mirror of
https://github.com/lukaszraczylo/traefikoidc.git
synced 2026-10-14 04:07:46 +00:00
* Fix bug affecting Azure OIDC authentication ( and most likely others ) * Fixes issue #51 * Ensure that appended roles are unique. Update the documentation. * Improvements targetting possible memory usage spikes. * Additional fixes and cleanup * Refactoring code to fix the issues identified by the users. * Modernize run * Fieldalignment * Multiple changes to improve performance and reduce complexity. - Optimise the errors and recovery. - Deduplicate code in metadata cache. - Remove unused performance monitoring code. - Simplify session management and settings handling. * Fix claims issue. * Add ability to overwrite the default scopes in the settings file * Well.. that escalated quickly. Completely forgot that Traefik uses outdated Yaegi and requires compatibility with 1.20 ( pre-generic Go code ). * Bugfix #51: Ensures that user provided scopes overrides work. * fixup! Bugfix #51: Ensures that user provided scopes overrides work. * fixup! fixup! Bugfix #51: Ensures that user provided scopes overrides work. * Abstract the provider logic into a separate package. * Additional micro fixes and cleanups. * Simplify all the things. * fixup! Simplify all the things. * fixup! fixup! Simplify all the things. * fixup! fixup! fixup! Simplify all the things. * fixup! fixup! fixup! fixup! Simplify all the things. * ... * Cleanup tests. * fixup! Cleanup tests. * fixup! fixup! fixup! Cleanup tests. * fixup! fixup! fixup! fixup! Cleanup tests. * fixup! fixup! fixup! fixup! fixup! Cleanup tests. * Issue #53: Fix CSRF token handling in reverse proxy 1. ✅ HTTPS Detection Fixed (session.go:723) - Now uses X-Forwarded-Proto header instead of r.URL.Scheme - Properly detects HTTPS in reverse proxy environments 2. ✅ SameSite Cookie Attribute Fixed - Removed automatic SameSiteStrictMode for HTTPS (would break OAuth) - Keeps SameSiteLaxMode to allow OAuth callbacks from external domains - Only uses Strict for AJAX requests which don't involve OAuth redirects 3. ✅ Cookie Domain Handling Fixed - Now respects X-Forwarded-Host header for cookie domain - Ensures cookies are set for the public domain, not internal proxy domain 4. ✅ EnhanceSessionSecurity Properly Integrated - Function is now actually called during session save - Applies security enhancements without breaking OAuth flow Why Issue #53 Failed Before: 1. Cookies were not marked Secure in HTTPS environments (browser wouldn't send them back) 2. If they had been Secure with SameSite=Strict, Azure callbacks would still fail 3. Cookie domain might have been wrong (internal vs public domain) Why It Works Now: 1. Cookies are properly marked Secure for HTTPS 2. Uses SameSite=Lax to allow OAuth provider callbacks 3. Cookie domain uses public domain from X-Forwarded-Host 4. CSRF token persists through the entire OAuth flow * Next set of enhancements together with memory usage improvements. * Memory leak fixes and optimisations. * CSRF and Cookie Domain fixes * fixup! CSRF and Cookie Domain fixes * Metadata cache leak fix + profiling * fixup! Metadata cache leak fix + profiling * Memory leaks hunting, part 1337. * Further pursue of perfection. * fixup! Further pursue of perfection. * fixup! fixup! Further pursue of perfection. * fixup! fixup! fixup! Further pursue of perfection. * fixup! fixup! fixup! fixup! Further pursue of perfection. * fixup! fixup! fixup! fixup! fixup! Further pursue of perfection. * fixup! fixup! fixup! fixup! fixup! fixup! Further pursue of perfection. * fixup! fixup! fixup! fixup! fixup! fixup! fixup! Further pursue of perfection. * fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Further pursue of perfection. * fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Further pursue of perfection. * Clear race conditions * fixup! Clear race conditions * Weekend fun with memory leaks * Splitting code into multiple files with reasonable testing coverage. ``` ok github.com/lukaszraczylo/traefikoidc 117.017s coverage: 72.6% of statements ok github.com/lukaszraczylo/traefikoidc/auth 0.505s coverage: 87.1% of statements ok github.com/lukaszraczylo/traefikoidc/circuit_breaker 0.283s coverage: 99.0% of statements github.com/lukaszraczylo/traefikoidc/config coverage: 0.0% of statements ok github.com/lukaszraczylo/traefikoidc/handlers 0.349s coverage: 98.2% of statements ok github.com/lukaszraczylo/traefikoidc/internal/providers (cached) coverage: 94.3% of statements ok github.com/lukaszraczylo/traefikoidc/middleware 0.808s coverage: 78.0% of statements ok github.com/lukaszraczylo/traefikoidc/recovery 0.653s coverage: 100.0% of statements ok github.com/lukaszraczylo/traefikoidc/session/chunking (cached) coverage: 87.8% of statements ok github.com/lukaszraczylo/traefikoidc/session/core (cached) coverage: 85.6% of statements ok github.com/lukaszraczylo/traefikoidc/session/crypto (cached) coverage: 81.8% of statements ok github.com/lukaszraczylo/traefikoidc/session/storage (cached) coverage: 93.5% of statements ok github.com/lukaszraczylo/traefikoidc/session/validators (cached) coverage: 98.8% of statements ```` * fixup! Splitting code into multiple files with reasonable testing coverage. * fixup! fixup! Splitting code into multiple files with reasonable testing coverage. * Weekend fun with further optimisations. * fixup! Weekend fun with further optimisations. * fixup! fixup! Weekend fun with further optimisations. * fixup! fixup! fixup! Weekend fun with further optimisations. * fixup! fixup! fixup! fixup! Weekend fun with further optimisations. * fixup! fixup! fixup! fixup! fixup! Weekend fun with further optimisations. * Pre-release cleanup. * Enhance test coverage. * fixup! Enhance test coverage. * fixup! fixup! Enhance test coverage. * fixup! fixup! fixup! Enhance test coverage.
116 lines
3.3 KiB
Go
116 lines
3.3 KiB
Go
package providers
|
|
|
|
import (
|
|
"fmt"
|
|
"net/url"
|
|
"strings"
|
|
)
|
|
|
|
// ProviderFactory encapsulates the logic for creating and configuring OIDC providers.
|
|
type ProviderFactory struct {
|
|
registry *ProviderRegistry
|
|
}
|
|
|
|
// NewProviderFactory creates a new factory with a pre-configured registry.
|
|
func NewProviderFactory() *ProviderFactory {
|
|
registry := NewProviderRegistry()
|
|
|
|
registry.RegisterProvider(NewGenericProvider())
|
|
registry.RegisterProvider(NewGoogleProvider())
|
|
registry.RegisterProvider(NewAzureProvider())
|
|
|
|
return &ProviderFactory{
|
|
registry: registry,
|
|
}
|
|
}
|
|
|
|
// CreateProvider creates an OIDC provider based on the issuer URL.
|
|
// It automatically detects the provider type and returns a configured instance.
|
|
func (f *ProviderFactory) CreateProvider(issuerURL string) (OIDCProvider, error) {
|
|
if issuerURL == "" {
|
|
return nil, fmt.Errorf("issuer URL cannot be empty")
|
|
}
|
|
|
|
if _, err := url.Parse(issuerURL); err != nil {
|
|
return nil, fmt.Errorf("invalid issuer URL format: %w", err)
|
|
}
|
|
|
|
provider := f.registry.DetectProvider(issuerURL)
|
|
if provider == nil {
|
|
return nil, fmt.Errorf("unable to detect provider for issuer URL: %s", issuerURL)
|
|
}
|
|
|
|
if err := provider.ValidateConfig(); err != nil {
|
|
return nil, fmt.Errorf("provider configuration validation failed: %w", err)
|
|
}
|
|
|
|
return provider, nil
|
|
}
|
|
|
|
// CreateProviderByType creates a provider instance of the specified type.
|
|
// This is useful when you want to force a specific provider type regardless of URL.
|
|
func (f *ProviderFactory) CreateProviderByType(providerType ProviderType) (OIDCProvider, error) {
|
|
var provider OIDCProvider
|
|
|
|
switch providerType {
|
|
case ProviderTypeGeneric:
|
|
provider = NewGenericProvider()
|
|
case ProviderTypeGoogle:
|
|
provider = NewGoogleProvider()
|
|
case ProviderTypeAzure:
|
|
provider = NewAzureProvider()
|
|
default:
|
|
return nil, fmt.Errorf("unsupported provider type: %d", providerType)
|
|
}
|
|
|
|
if err := provider.ValidateConfig(); err != nil {
|
|
return nil, fmt.Errorf("provider configuration validation failed: %w", err)
|
|
}
|
|
|
|
return provider, nil
|
|
}
|
|
|
|
// GetSupportedProviders returns a list of all supported provider types and their detection patterns.
|
|
func (f *ProviderFactory) GetSupportedProviders() map[ProviderType][]string {
|
|
return map[ProviderType][]string{
|
|
ProviderTypeGeneric: {"*"},
|
|
ProviderTypeGoogle: {"accounts.google.com"},
|
|
ProviderTypeAzure: {"login.microsoftonline.com", "sts.windows.net"},
|
|
}
|
|
}
|
|
|
|
// DetectProviderType determines the provider type for a given issuer URL.
|
|
// This is useful for diagnostic purposes or UI display.
|
|
func (f *ProviderFactory) DetectProviderType(issuerURL string) (ProviderType, error) {
|
|
provider, err := f.CreateProvider(issuerURL)
|
|
if err != nil {
|
|
return ProviderTypeGeneric, err
|
|
}
|
|
return provider.GetType(), nil
|
|
}
|
|
|
|
// IsProviderSupported checks if a given issuer URL is supported by any registered provider.
|
|
func (f *ProviderFactory) IsProviderSupported(issuerURL string) bool {
|
|
if issuerURL == "" {
|
|
return false
|
|
}
|
|
|
|
normalizedURL, err := url.Parse(issuerURL)
|
|
if err != nil {
|
|
return false
|
|
}
|
|
|
|
host := strings.ToLower(normalizedURL.Host)
|
|
supportedProviders := f.GetSupportedProviders()
|
|
|
|
for _, patterns := range supportedProviders {
|
|
for _, pattern := range patterns {
|
|
if pattern == "*" || strings.Contains(host, strings.ToLower(pattern)) {
|
|
return true
|
|
}
|
|
}
|
|
}
|
|
|
|
return false
|
|
}
|