mirror of
https://github.com/lukaszraczylo/traefikoidc.git
synced 2026-06-05 22:44:17 +00:00
546ceb949c
* fix(security): encrypt session cookies + fail closed on invalid config
Batch 1 of security audit remediation (ranks 1, 2, 6).
- session.go: derive independent HMAC + AES-256 keys via stdlib HKDF-SHA256
and build the gorilla cookie store with both, so session cookies are now
encrypted, not merely signed. The single-key store previously left OIDC
access/refresh/ID tokens recoverable from raw cookie bytes. Cookie format
changes, so existing sessions are invalidated on deploy (one-time re-login).
- main.go: call config.Validate() at construction and error out on failure,
instead of silently substituting a public hardcoded encryption key for
empty/short keys (which allowed session forgery). The yaegi analyzer
passes via .traefik.yml testData.
- settings.go: isValidSecureURL permits plaintext HTTP for loopback hosts
only (RFC 8252); remote providers must still use HTTPS.
- tests: complete configs that did not satisfy Validate(); add regression
tests in security_audit_fixes_test.go.
Configs below documented minimums (rateLimit < 10, key < 32 chars) are now
rejected at startup (fail closed).
* fix(security): validate discovered OIDC endpoints + pin introspection host
Batch 2 of security audit remediation (ranks 3, 4).
- url_helpers.go: add validateDiscoveredEndpoint, an SSRF screen for endpoints
taken from the provider discovery document (jwks_uri, token, authorization,
revocation, end_session, introspection, registration). Blocks link-local
(cloud metadata 169.254.169.254), multicast, unspecified and private
addresses (unless allowPrivateIPAddresses); blocks loopback unless the
configured providerURL is itself loopback (dev/test). Cross-domain JWKS
hosts (e.g. Google) stay allowed. Add sameHost helper.
- main.go: updateMetadataEndpoints screens every discovered endpoint and
blanks any that fail (fail closed downstream). The introspection endpoint
carries the client secret via HTTP Basic, so it is additionally pinned to
the providerURL host to stop a poisoned discovery document exfiltrating the
secret to an attacker-controlled host.
- tests: regression tests for the SSRF guard and the host pin.
* fix(security): close open redirects + anchor excluded-URL matching
Batch 3 of security audit remediation (ranks 5, 14, 15).
- auth_flow.go: run the stored incoming path through normalizeLogoutPath
before using it as the post-login redirect, so //evil.com and /\evil.com
payloads become host-relative (open-redirect, rank 5).
- url_helpers.go: excluded-URL matching is anchored at a natural boundary
(exact, sub-path "/", or file extension "."), so excluding "/public" no
longer also bypasses auth on "/publicsecret"; "/favicon" still matches
"/favicon.ico" (rank 14).
- internal/utils: X-Forwarded-Host is sanitized (first value only; reject
CRLF/whitespace/multi-value) before building redirect URLs (rank 15).
- helpers.go: the logout redirect used when there is no provider end-session
endpoint is host-relative, never an absolute URL derived from the
client-controllable request host (logout open-redirect, rank 15).
- tests: update two logout cases that asserted the old absolute redirect;
add regression tests.
* fix(security): reject unverified Azure tokens; fix transport TLS reuse
Batch 4 of security audit remediation (ranks 7, 11).
- token_validation_rs.go: an Azure nonce-bearing access token that cannot be
cryptographically verified no longer returns "authenticated" when there is
no ID token to corroborate it; it refreshes (if possible) or forces
re-authentication instead of failing open (rank 7).
- http_client_pool.go: the at-limit transport-reuse path now takes the write
lock before mutating refCount (fixes a data race) and only reuses a
transport whose TLS settings (CA pool + InsecureSkipVerify) match the
caller's, never one with a different trust store; if none matches it returns
nil so the caller falls back to a verifying default transport (rank 11).
- tests: add a transport-pool TLS-isolation regression test.
* fix(security): stop logging templated header values (token leak)
Batch 5 of security audit remediation (rank 16).
middleware.go: templated downstream headers commonly carry the access token
(e.g. "Authorization: Bearer {{.AccessToken}}"). The debug log line printed
the full header value, leaking credentials into logs. Log the header name and
byte length instead.
* fix(security): cache-key collision, cache-config divergence, fleet cleanup
Batch 6 of security audit remediation (ranks 9, 10, 12).
- token_manager.go: detectTokenType keys its cache on a SHA-256 hash of the
full token instead of the first 32 chars (which are only the base64url JWT
header). Distinct tokens sharing alg+kid no longer collide and get
mis-classified (rank 10).
- cache_manager.go: the process-global cache manager is initialized once and
shared across plugin instances; it now logs a loud warning when a later
instance requests a different explicit Redis backend that is silently
ignored, surfacing the cross-instance state-isolation hazard (rank 9).
- singleton_resources.go / main.go / utilities.go: track a process-global live
instance count; the shared singleton-token-cleanup task is stopped only when
the LAST instance shuts down, so one instance's Close() (e.g. a config reload)
no longer kills cleanup for surviving instances (rank 12).
- tests: update TestDetectTokenTypeCaching for the new key; add regression tests.
* fix(security): bound introspection cache + cookie lifetime to config
Batch 7 of security audit remediation (ranks 8, 13).
- token_introspection.go: when requireTokenIntrospection is enabled, cap the
positive introspection-result cache at 30s (instead of 5m) so a token
revoked at the provider stops passing within ~30s, matching the operator's
near-real-time revocation expectation (rank 8).
- session.go: bind the cookie store's MaxAge to the configured sessionMaxAge,
so the cookie codec's cryptographic timestamp validity is no longer fixed at
gorilla's 30-day default; a stolen cookie is valid only for the configured
session lifetime (rank 13).
- tests: add a cookie-lifetime regression test.
* fix(security): low-severity hardening (cache, DoS caps, PKCE, throttle)
Batch 8 of security audit remediation — low severity
(ranks 24, 25, 27, 29, 31, 36, 37, 41, 45, 46, 49).
- universal_cache.go: updateLocalCache updates an existing key in place instead
of orphaning its LRU element and double-counting currentSize/currentMemory
(rank 36 — the only production-reachable bug in this batch).
- jwk.go / metadata_cache.go / token_introspection.go: bound response bodies
with io.LimitReader (1 MiB) to prevent memory exhaustion from a hostile or
buggy provider (ranks 24, 25).
- jwk.go: skip JWKs not usable for signature verification (use != sig, or
key_ops without "verify") when building the key set (rank 49).
- auth_flow.go: fail closed at the callback when PKCE is enabled but the code
verifier is missing, instead of silently dropping it (rank 27).
- utilities.go / main.go: match allowedUserDomains case-insensitively (rank 31).
- bearer_auth.go: a single success no longer wipes an active per-IP penalty;
the counter resets only when no penalty is in effect (rank 29).
- main.go: handle (not discard) the NewSessionManager error (rank 37).
- error_recovery.go: take a write lock in isServiceDegraded (it deletes from a
map); compare retryable-error substrings case-insensitively (ranks 45, 46).
- singleton_resources.go: bind the generic-cache cleanup goroutine to the
resource-manager shutdown channel so it cannot outlive its owner (rank 41).
- tests: update the bearer throttle test to the corrected penalty semantics.
* fix(security): header sanitization, issuer pinning, fail-closed paths
Batch 9 of security audit remediation (ranks 18, 19, 20, 21, 22, 30, 33, 34).
- middleware.go / bearer_auth.go: sanitize claim-derived values on the cookie
auth path before injecting them into downstream headers. Drop group/role and
identifier values containing control chars, bidi-override runes, or the
, ; = delimiters (a comma would inject phantom entries into X-User-Groups);
reject control/bidi/over-length in rendered templated header output (but
permit , ; = in free-form values such as a bearer token). The bearer path
already sanitized; the cookie path did not (ranks 33, 34).
- main.go / metadata_cache.go: pin the discovered issuer to the configured
provider host (sameHost) and refuse/never-cache a mismatch, so a poisoned
discovery document cannot redefine the JWT trust anchor (ranks 21, 22).
- token_introspection.go: when a distinct API audience is configured, fail
closed on a missing or mismatched introspection audience; aud parsed as
string-or-array per RFC 7662 (rank 19).
- logout.go: front-channel logout requires a matching issuer; an empty iss is
rejected (blocks unauthenticated forced-logout via a known sid) (rank 30).
- token_validation_rs.go: an opaque access token with no ID token and no
successful introspection fails closed (re-auth) instead of authenticating
(ranks 18, 20).
- tests: realistic same-host provider mocks; regression tests for the header
sanitization distinction and the fail-closed paths.
* chore(security): remove unwired dead code with latent footguns
Batch 10 of security audit remediation — delete confirmed-dead, unwired
subsystems (ranks 26, 35, 50). None had a production caller (grep-verified);
removal eliminates the latent footguns and ~2.1k lines of dead code.
- token_validator.go (deleted): an unused *TokenValidator whose validateJWT set
Valid=true with NO signature verification — a severe footgun if ever wired
(rank 50). The wired RS-aware validators are unaffected.
- security_monitoring.go (deleted): an unused *SecurityMonitor / ExtractClientIP
that trusted spoofable X-Forwarded-For / X-Real-IP. The live bearer throttle
uses clientIPForBearer (RemoteAddr-only), unchanged (rank 35).
- dynamic_client_registration.go: removed the RFC 7592 management methods
(Update/Read/DeleteClientRegistration) that dereferenced an attacker-
influenced RegistrationClientURI with the registration token attached and no
HTTPS/SSRF gate, and had no callers. The wired RFC 7591 RegisterClient and
credential-store helpers are kept (rank 26).
- tests: removed the tests covering the deleted code.
* chore: add Makefile with yaegi load validation
No Makefile existed. The new `yaegi-validate` target interprets the plugin
under the yaegi interpreter the same way Traefik loads it, catching yaegi-only
incompatibilities (unsupported stdlib symbols, reflection edge cases) that the
native `go build` / `go test` toolchain does not. Importing the plugin forces
yaegi to interpret every file plus its vendored deps; CreateConfig + New
exercise the instantiation path.
- cmd/yaegicheck/main.go: the load driver, marked //go:build ignore so it is
excluded from `go build ./...` (avoids VCS-stamping a main binary, which
fails in git-worktree layouts) yet is run explicitly by yaegi.
- Makefile: build / fmt / vet / lint / test / vendor / yaegi-validate / check
targets; `make check` runs vet + tests + yaegi-validate.
Verified: `make yaegi-validate` passes on this branch — the HKDF cookie
encryption, net-based endpoint validation, and claim sanitizers all interpret
and instantiate cleanly under yaegi.
* ci: bump workflow Go toolchain to 1.25; pin yaegi-validate to v0.16.1
Traefik v3.7.1 (the deployed version) is built with `go 1.25.0`, so the PR and
release workflows now use Go 1.25.x to match the toolchain Traefik uses.
Important distinction: the CI Go version is the build TOOLCHAIN. The plugin's
actual interpreter-compatibility ceiling is the yaegi version Traefik bundles
(v0.16.1, which declares go 1.21 and ships a ~Go 1.22 stdlib symbol surface),
NOT the CI Go version. That ceiling is enforced by `make yaegi-validate` plus
the go.mod language directive — e.g. it is why HKDF is hand-rolled with
hmac+sha256 rather than Go 1.24's crypto/hkdf, which yaegi v0.16.1 lacks.
Also pin Makefile YAEGI_VERSION to v0.16.1 (what Traefik v3.7.1 vendors) so
yaegi-validate exercises the real deployed interpreter instead of @latest,
which could pass on a newer yaegi that supports symbols the deployed one does
not.
* docs: align README/CONFIGURATION with branch behavior changes
- excludedURLs: documented as segment/extension-boundary matching (was
"prefix-matched") — "/public" no longer also matches "/publicsecret" (rank 14).
- Front-channel logout now requires a matching `iss`; requests without one are
rejected with 400 (rank 30).
- Add an "Upgrading from an earlier release" note: session cookies are now
AES-256 encrypted with lifetime tracking sessionMaxAge (one-time re-login on
upgrade), and invalid configuration (rateLimit < 10, key < 32 bytes, missing
callbackURL, non-HTTPS remote providerURL) now fails closed at startup.
* fix: remove staticcheck-flagged unused functions; wire staticcheck into make check
CI Static Analysis (standalone staticcheck) failed with U1000 "unused":
- dynamic_client_registration.go: deleteCredentialsFromStore — its only caller
was the RFC 7592 DeleteClientRegistration removed in the dead-code batch.
- token_test.go: createTestJWTSimple — its only callers were the TokenValidator
tests removed in the same batch.
Both confirmed to have zero remaining callers and removed. build / vet /
go test ./... / staticcheck ./... all green.
The pre-commit hook runs golangci-lint, but CI runs standalone staticcheck
(which flags U1000). Add a `staticcheck` Makefile target and include it in
`make check` so this class of finding is caught locally before push.
* fix(test): stabilize flaky TestWorkerPool_TaskPanic
tasksFailed is incremented in the worker's deferred recover(), which runs after the panicking task's own defer wg.Done(). wg.Wait() could therefore return before the failure was recorded, so reading the counter immediately raced and flaked on slow CI runners. Poll until the failure lands (2s budget) instead. Verified 200x plain + 50x under -race/GOMAXPROCS=1.
506 lines
16 KiB
Go
506 lines
16 KiB
Go
// Package traefikoidc provides OIDC authentication middleware for Traefik.
|
|
// This file implements OIDC Backchannel Logout (OpenID Connect Back-Channel Logout 1.0)
|
|
// and Front-Channel Logout (OpenID Connect Front-Channel Logout 1.0) functionality.
|
|
package traefikoidc
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"io"
|
|
"net/http"
|
|
"strings"
|
|
"time"
|
|
)
|
|
|
|
const (
|
|
// logoutTokenType is the expected typ claim for logout tokens
|
|
// #nosec G101 -- This is a JWT type claim value from OIDC spec, not a credential
|
|
logoutTokenType = "logout+jwt"
|
|
|
|
// sessionInvalidationTTL is how long to remember invalidated sessions
|
|
// Should be at least as long as your session max age
|
|
sessionInvalidationTTL = 25 * time.Hour
|
|
)
|
|
|
|
// LogoutTokenClaims represents the claims in an OIDC logout token
|
|
// as defined in OpenID Connect Back-Channel Logout 1.0
|
|
type LogoutTokenClaims struct {
|
|
Issuer string `json:"iss"`
|
|
Subject string `json:"sub,omitempty"`
|
|
Audience interface{} `json:"aud"` // Can be string or []string
|
|
IssuedAt int64 `json:"iat"`
|
|
JTI string `json:"jti"`
|
|
Events map[string]interface{} `json:"events"`
|
|
SessionID string `json:"sid,omitempty"`
|
|
Nonce string `json:"nonce,omitempty"` // Must NOT be present
|
|
}
|
|
|
|
// handleBackchannelLogout processes OIDC Backchannel Logout requests.
|
|
// It accepts POST requests with a logout_token parameter containing a JWT
|
|
// that identifies which session(s) to terminate.
|
|
//
|
|
// According to OpenID Connect Back-Channel Logout 1.0:
|
|
// - The logout_token is a JWT signed by the IdP
|
|
// - It contains either a 'sid' (session ID) or 'sub' (subject) claim to identify the session
|
|
// - The RP must validate the token and invalidate the matching session(s)
|
|
//
|
|
// Parameters:
|
|
// - rw: The HTTP response writer
|
|
// - req: The HTTP request containing the logout_token
|
|
func (t *TraefikOidc) handleBackchannelLogout(rw http.ResponseWriter, req *http.Request) {
|
|
t.logger.Debug("Processing backchannel logout request")
|
|
|
|
// Backchannel logout must be POST
|
|
if req.Method != http.MethodPost {
|
|
t.logger.Errorf("Backchannel logout: invalid method %s, expected POST", req.Method)
|
|
http.Error(rw, "Method not allowed", http.StatusMethodNotAllowed)
|
|
return
|
|
}
|
|
|
|
// Parse form data to get logout_token
|
|
if err := req.ParseForm(); err != nil {
|
|
t.logger.Errorf("Backchannel logout: failed to parse form: %v", err)
|
|
http.Error(rw, "Bad request", http.StatusBadRequest)
|
|
return
|
|
}
|
|
|
|
logoutToken := req.FormValue("logout_token")
|
|
if logoutToken == "" {
|
|
// Also try reading from request body as raw JWT
|
|
body, err := io.ReadAll(io.LimitReader(req.Body, 64*1024)) // 64KB limit
|
|
if err == nil && len(body) > 0 {
|
|
logoutToken = string(body)
|
|
}
|
|
}
|
|
|
|
if logoutToken == "" {
|
|
t.logger.Error("Backchannel logout: missing logout_token")
|
|
http.Error(rw, "logout_token required", http.StatusBadRequest)
|
|
return
|
|
}
|
|
|
|
// Parse and validate the logout token
|
|
claims, err := t.validateLogoutToken(logoutToken)
|
|
if err != nil {
|
|
t.logger.Errorf("Backchannel logout: token validation failed: %v", err)
|
|
// Return 400 for invalid token per spec
|
|
http.Error(rw, "Invalid logout token", http.StatusBadRequest)
|
|
return
|
|
}
|
|
|
|
// Invalidate session(s) based on sid or sub
|
|
if err := t.invalidateSession(claims.SessionID, claims.Subject); err != nil {
|
|
t.logger.Errorf("Backchannel logout: failed to invalidate session: %v", err)
|
|
http.Error(rw, "Failed to invalidate session", http.StatusInternalServerError)
|
|
return
|
|
}
|
|
|
|
t.logger.Infof("Backchannel logout: successfully invalidated session (sid=%s, sub=%s)",
|
|
claims.SessionID, claims.Subject)
|
|
|
|
// Return 200 OK with empty body per spec
|
|
rw.WriteHeader(http.StatusOK)
|
|
}
|
|
|
|
// handleFrontchannelLogout processes OIDC Front-Channel Logout requests.
|
|
// It accepts GET requests with 'iss' and 'sid' query parameters that identify
|
|
// which session to terminate. The IdP typically loads this URL in an iframe.
|
|
//
|
|
// According to OpenID Connect Front-Channel Logout 1.0:
|
|
// - The request contains 'iss' (issuer) and optionally 'sid' (session ID)
|
|
// - The RP should clear the session and return a response (typically empty or image)
|
|
// - The response must be cacheable to allow the IdP to load it in an iframe
|
|
//
|
|
// Parameters:
|
|
// - rw: The HTTP response writer
|
|
// - req: The HTTP request containing iss and sid parameters
|
|
func (t *TraefikOidc) handleFrontchannelLogout(rw http.ResponseWriter, req *http.Request) {
|
|
t.logger.Debug("Processing front-channel logout request")
|
|
|
|
// Front-channel logout should be GET
|
|
if req.Method != http.MethodGet {
|
|
t.logger.Errorf("Front-channel logout: invalid method %s, expected GET", req.Method)
|
|
http.Error(rw, "Method not allowed", http.StatusMethodNotAllowed)
|
|
return
|
|
}
|
|
|
|
// Get iss and sid from query parameters
|
|
iss := req.URL.Query().Get("iss")
|
|
sid := req.URL.Query().Get("sid")
|
|
|
|
// Validate issuer matches our expected issuer
|
|
t.metadataMu.RLock()
|
|
expectedIssuer := t.issuerURL
|
|
t.metadataMu.RUnlock()
|
|
|
|
// Require a matching issuer. An empty iss must be rejected too: accepting a
|
|
// missing issuer would let an unauthenticated attacker force-logout any
|
|
// session whose sid is known by simply omitting iss.
|
|
if iss == "" || iss != expectedIssuer {
|
|
t.logger.Errorf("Front-channel logout: issuer validation failed: got %q, expected %q", iss, expectedIssuer)
|
|
http.Error(rw, "Invalid issuer", http.StatusBadRequest)
|
|
return
|
|
}
|
|
|
|
// Must have at least sid for front-channel logout
|
|
if sid == "" {
|
|
t.logger.Error("Front-channel logout: missing sid parameter")
|
|
http.Error(rw, "sid parameter required", http.StatusBadRequest)
|
|
return
|
|
}
|
|
|
|
// Invalidate the session
|
|
if err := t.invalidateSession(sid, ""); err != nil {
|
|
t.logger.Errorf("Front-channel logout: failed to invalidate session: %v", err)
|
|
http.Error(rw, "Failed to invalidate session", http.StatusInternalServerError)
|
|
return
|
|
}
|
|
|
|
t.logger.Infof("Front-channel logout: successfully invalidated session (sid=%s)", sid)
|
|
|
|
// Return a minimal HTML response that's suitable for iframe loading
|
|
// Set headers to allow embedding and caching
|
|
rw.Header().Set("Content-Type", "text/html; charset=utf-8")
|
|
rw.Header().Set("Cache-Control", "no-cache, no-store")
|
|
rw.Header().Set("Pragma", "no-cache")
|
|
// Allow embedding in iframes from any origin (required for front-channel logout)
|
|
rw.Header().Del("X-Frame-Options")
|
|
rw.WriteHeader(http.StatusOK)
|
|
_, _ = rw.Write([]byte("<!DOCTYPE html><html><head><title>Logged Out</title></head><body></body></html>"))
|
|
}
|
|
|
|
// validateLogoutToken parses and validates a logout token JWT.
|
|
// It verifies the token signature, issuer, audience, and required claims.
|
|
//
|
|
// Parameters:
|
|
// - tokenString: The raw JWT logout token
|
|
//
|
|
// Returns:
|
|
// - The parsed logout token claims
|
|
// - An error if validation fails
|
|
func (t *TraefikOidc) validateLogoutToken(tokenString string) (*LogoutTokenClaims, error) {
|
|
// Parse the JWT
|
|
jwt, err := parseJWT(tokenString)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to parse logout token: %w", err)
|
|
}
|
|
|
|
// Check token type if present
|
|
if typ, ok := jwt.Header["typ"].(string); ok {
|
|
// The typ should be "logout+jwt" or omitted
|
|
if typ != "" && typ != logoutTokenType && typ != "JWT" {
|
|
return nil, fmt.Errorf("invalid token type: %s", typ)
|
|
}
|
|
}
|
|
|
|
// Verify signature only (not standard claims - logout tokens don't have 'exp')
|
|
if err := t.verifyLogoutTokenSignature(jwt, tokenString); err != nil {
|
|
return nil, fmt.Errorf("signature verification failed: %w", err)
|
|
}
|
|
|
|
// Extract claims
|
|
claims := &LogoutTokenClaims{}
|
|
claimsJSON, err := json.Marshal(jwt.Claims)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to marshal claims: %w", err)
|
|
}
|
|
if err := json.Unmarshal(claimsJSON, claims); err != nil {
|
|
return nil, fmt.Errorf("failed to unmarshal claims: %w", err)
|
|
}
|
|
|
|
// Validate required claims
|
|
t.metadataMu.RLock()
|
|
expectedIssuer := t.issuerURL
|
|
t.metadataMu.RUnlock()
|
|
|
|
// Validate issuer
|
|
if claims.Issuer != expectedIssuer {
|
|
return nil, fmt.Errorf("issuer mismatch: got %s, expected %s", claims.Issuer, expectedIssuer)
|
|
}
|
|
|
|
// Validate audience (must contain our client_id)
|
|
if !t.validateLogoutTokenAudience(claims.Audience) {
|
|
return nil, fmt.Errorf("audience validation failed")
|
|
}
|
|
|
|
// Validate iat (issued at) - must be present and not too old
|
|
if claims.IssuedAt == 0 {
|
|
return nil, fmt.Errorf("missing iat claim")
|
|
}
|
|
iatTime := time.Unix(claims.IssuedAt, 0)
|
|
// Allow up to 5 minutes clock skew and 10 minutes token age
|
|
if time.Since(iatTime) > 15*time.Minute {
|
|
return nil, fmt.Errorf("logout token too old: issued at %v", iatTime)
|
|
}
|
|
// Token should not be from the future (with 5 min clock skew tolerance)
|
|
if iatTime.After(time.Now().Add(5 * time.Minute)) {
|
|
return nil, fmt.Errorf("logout token issued in the future: %v", iatTime)
|
|
}
|
|
|
|
// Validate events claim - must contain the logout event
|
|
if claims.Events == nil {
|
|
return nil, fmt.Errorf("missing events claim")
|
|
}
|
|
if _, ok := claims.Events["http://schemas.openid.net/event/backchannel-logout"]; !ok {
|
|
return nil, fmt.Errorf("missing backchannel-logout event in events claim")
|
|
}
|
|
|
|
// Validate that nonce is NOT present (per spec)
|
|
if claims.Nonce != "" {
|
|
return nil, fmt.Errorf("nonce claim must not be present in logout token")
|
|
}
|
|
|
|
// Must have either sid or sub (or both)
|
|
if claims.SessionID == "" && claims.Subject == "" {
|
|
return nil, fmt.Errorf("logout token must contain either sid or sub claim")
|
|
}
|
|
|
|
return claims, nil
|
|
}
|
|
|
|
// validateLogoutTokenAudience checks if the logout token audience contains our client_id
|
|
func (t *TraefikOidc) validateLogoutTokenAudience(aud interface{}) bool {
|
|
switch v := aud.(type) {
|
|
case string:
|
|
return v == t.clientID
|
|
case []interface{}:
|
|
for _, a := range v {
|
|
if s, ok := a.(string); ok && s == t.clientID {
|
|
return true
|
|
}
|
|
}
|
|
case []string:
|
|
for _, a := range v {
|
|
if a == t.clientID {
|
|
return true
|
|
}
|
|
}
|
|
}
|
|
return false
|
|
}
|
|
|
|
// verifyLogoutTokenSignature verifies only the signature of a logout token.
|
|
// Unlike VerifyJWTSignatureAndClaims, this does NOT validate standard claims like 'exp'
|
|
// because logout tokens don't have an expiration claim per OIDC Back-Channel Logout spec.
|
|
//
|
|
// Parameters:
|
|
// - jwt: The parsed JWT structure
|
|
// - tokenString: The raw token string for signature verification
|
|
//
|
|
// Returns:
|
|
// - An error if signature verification fails
|
|
func (t *TraefikOidc) verifyLogoutTokenSignature(jwt *JWT, tokenString string) error {
|
|
t.logger.Debug("Verifying logout token signature")
|
|
|
|
// Read jwksURL with RLock
|
|
t.metadataMu.RLock()
|
|
jwksURL := t.jwksURL
|
|
t.metadataMu.RUnlock()
|
|
|
|
jwks, err := t.jwkCache.GetJWKS(context.Background(), jwksURL, t.httpClient)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to get JWKS: %w", err)
|
|
}
|
|
|
|
if jwks == nil {
|
|
return fmt.Errorf("JWKS is nil, cannot verify token")
|
|
}
|
|
|
|
kid, ok := jwt.Header["kid"].(string)
|
|
if !ok || kid == "" {
|
|
return fmt.Errorf("missing key ID in token header")
|
|
}
|
|
|
|
alg, ok := jwt.Header["alg"].(string)
|
|
if !ok || alg == "" {
|
|
return fmt.Errorf("missing algorithm in token header")
|
|
}
|
|
|
|
// Find the matching key in JWKS
|
|
var matchingKey *JWK
|
|
for i := range jwks.Keys {
|
|
if jwks.Keys[i].Kid == kid {
|
|
matchingKey = &jwks.Keys[i]
|
|
break
|
|
}
|
|
}
|
|
|
|
if matchingKey == nil {
|
|
return fmt.Errorf("no matching public key found for kid: %s", kid)
|
|
}
|
|
|
|
publicKeyPEM, err := jwkToPEM(matchingKey)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to convert JWK to PEM: %w", err)
|
|
}
|
|
|
|
if err := verifySignature(tokenString, publicKeyPEM, alg); err != nil {
|
|
return fmt.Errorf("signature verification failed: %w", err)
|
|
}
|
|
|
|
t.logger.Debug("Logout token signature verified successfully")
|
|
return nil
|
|
}
|
|
|
|
// invalidateSession marks a session as invalidated in the session invalidation cache.
|
|
// It stores entries by both sid and sub if available.
|
|
//
|
|
// Parameters:
|
|
// - sid: The session ID to invalidate (from the 'sid' claim)
|
|
// - sub: The subject to invalidate (from the 'sub' claim)
|
|
//
|
|
// Returns:
|
|
// - An error if the invalidation fails
|
|
func (t *TraefikOidc) invalidateSession(sid, sub string) error {
|
|
if t.sessionInvalidationCache == nil {
|
|
return fmt.Errorf("session invalidation cache not initialized")
|
|
}
|
|
|
|
now := time.Now().Unix()
|
|
|
|
// Store by session ID
|
|
if sid != "" {
|
|
key := t.buildSessionInvalidationKey("sid", sid)
|
|
t.sessionInvalidationCache.Set(key, now, sessionInvalidationTTL)
|
|
t.logger.Debugf("Invalidated session by sid: %s", sid)
|
|
}
|
|
|
|
// Store by subject (invalidates all sessions for this user)
|
|
if sub != "" {
|
|
key := t.buildSessionInvalidationKey("sub", sub)
|
|
t.sessionInvalidationCache.Set(key, now, sessionInvalidationTTL)
|
|
t.logger.Debugf("Invalidated session by sub: %s", sub)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// isSessionInvalidated checks if a session has been invalidated via backchannel
|
|
// or front-channel logout.
|
|
//
|
|
// Parameters:
|
|
// - sid: The session ID to check
|
|
// - sub: The subject to check
|
|
// - sessionCreatedAt: When the session was created (to compare against invalidation time)
|
|
//
|
|
// Returns:
|
|
// - true if the session has been invalidated, false otherwise
|
|
func (t *TraefikOidc) isSessionInvalidated(sid, sub string, sessionCreatedAt time.Time) bool {
|
|
if t.sessionInvalidationCache == nil {
|
|
return false
|
|
}
|
|
|
|
// Truncate session creation time to seconds for fair comparison with Unix timestamps
|
|
sessionCreatedAtSec := sessionCreatedAt.Truncate(time.Second)
|
|
|
|
// Check by session ID first (more specific)
|
|
if sid != "" {
|
|
key := t.buildSessionInvalidationKey("sid", sid)
|
|
if val, found := t.sessionInvalidationCache.Get(key); found {
|
|
if invalidatedAt, ok := val.(int64); ok {
|
|
// Session was invalidated at or after it was created
|
|
invalidationTime := time.Unix(invalidatedAt, 0)
|
|
if !invalidationTime.Before(sessionCreatedAtSec) {
|
|
t.logger.Debugf("Session invalidated by sid: %s", sid)
|
|
return true
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
// Check by subject (all sessions for this user)
|
|
if sub != "" {
|
|
key := t.buildSessionInvalidationKey("sub", sub)
|
|
if val, found := t.sessionInvalidationCache.Get(key); found {
|
|
if invalidatedAt, ok := val.(int64); ok {
|
|
// Sessions for this subject created at or before invalidation are invalid
|
|
invalidationTime := time.Unix(invalidatedAt, 0)
|
|
if !invalidationTime.Before(sessionCreatedAtSec) {
|
|
t.logger.Debugf("Session invalidated by sub: %s", sub)
|
|
return true
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
return false
|
|
}
|
|
|
|
// buildSessionInvalidationKey creates a cache key for session invalidation
|
|
func (t *TraefikOidc) buildSessionInvalidationKey(keyType, value string) string {
|
|
return fmt.Sprintf("session_invalidation:%s:%s", keyType, value)
|
|
}
|
|
|
|
// extractSessionInfo extracts sid and sub from an ID token for session tracking
|
|
func (t *TraefikOidc) extractSessionInfo(idToken string) (sid, sub string, createdAt time.Time) {
|
|
if idToken == "" {
|
|
return "", "", time.Time{}
|
|
}
|
|
|
|
jwt, err := parseJWT(idToken)
|
|
if err != nil {
|
|
return "", "", time.Time{}
|
|
}
|
|
|
|
// Extract sid (session ID)
|
|
if sidVal, ok := jwt.Claims["sid"].(string); ok {
|
|
sid = sidVal
|
|
}
|
|
|
|
// Extract sub (subject)
|
|
if subVal, ok := jwt.Claims["sub"].(string); ok {
|
|
sub = subVal
|
|
}
|
|
|
|
// Extract iat for session creation time
|
|
if iatVal, ok := jwt.Claims["iat"].(float64); ok {
|
|
createdAt = time.Unix(int64(iatVal), 0)
|
|
} else {
|
|
// Default to now if iat not present
|
|
createdAt = time.Now()
|
|
}
|
|
|
|
return sid, sub, createdAt
|
|
}
|
|
|
|
// determineLogoutPath checks if the given path matches any logout URL
|
|
func (t *TraefikOidc) determineLogoutPath(path string) string {
|
|
// Check backchannel logout path
|
|
if t.backchannelLogoutPath != "" && path == t.backchannelLogoutPath {
|
|
return "backchannel"
|
|
}
|
|
|
|
// Check front-channel logout path
|
|
if t.frontchannelLogoutPath != "" && path == t.frontchannelLogoutPath {
|
|
return "frontchannel"
|
|
}
|
|
|
|
// Check regular logout path (for RP-initiated logout)
|
|
if path == t.logoutURLPath {
|
|
return "rp"
|
|
}
|
|
|
|
return ""
|
|
}
|
|
|
|
// normalizeLogoutPath ensures logout paths start with / and prevents open redirects
|
|
func normalizeLogoutPath(path string) string {
|
|
if path == "" {
|
|
return ""
|
|
}
|
|
if !strings.HasPrefix(path, "/") {
|
|
path = "/" + path
|
|
}
|
|
// Prevent open redirect: ensure second character is not / or \
|
|
// This prevents URLs like //example.com or /\example.com from being treated as absolute URLs
|
|
if len(path) > 1 && (path[1] == '/' || path[1] == '\\') {
|
|
// Strip leading slashes/backslashes and re-normalize
|
|
path = strings.TrimLeft(path, "/\\")
|
|
if path != "" {
|
|
path = "/" + path
|
|
}
|
|
}
|
|
return path
|
|
}
|