mirror of
https://github.com/lukaszraczylo/traefikoidc.git
synced 2026-10-14 04:07:46 +00:00
Audit review (rounds 1-31): fix confirmed issues, remove dead code, harden tests
Security/correctness fixes: - fail-open token validation preserved with lenient-audience; access token that fails verification and has no ID token to corroborate now fails closed - token_manager blacklist-expiry: fix impossible tautology (x>24h && x<24h) - constant-time OAuth state compare; clear state/nonce/code_verifier on callback token-exchange failure to prevent replay of half-failed flows - StopAllTasks gated on last-instance close - background-task panic recovery; remove task-registry counter leak - circuit breaker half-open: release probe slot; CB + per-session outcome recorded once per refresh operation, not once per waiter - Redis connection pool: handle nil receive when pool closed concurrently - FileStore: atomic temp-write + rename - errors_recovery health-check data race -> atomic Test-isolation / hardening: - reset helpers for Once-pinned global cache manager and transport pool - coverage: utils 70->93% (redirect URL security contract); fuzz targets for bearer parsers; concurrent ServeHTTP race tests for the shared request path Dead-code removal (verified orphaned, build+suite green): internal/providers (30 files, 0 importers), internal/compat, internal/features, input_validation. Verified: govulncheck, go mod tidy, yaegi-validate, cross-compile (darwin+ linux), golangci-lint (new-from-rev clean), 3x full race+shuffle green.
This commit is contained in:
Vendored
+7
@@ -1223,6 +1223,10 @@ func TestCacheManagerCompat(t *testing.T) {
|
||||
if err != nil {
|
||||
t.Errorf("CacheManagerCompat Close should not error: %v", err)
|
||||
}
|
||||
// Close() shuts down the process-global manager. Recreate it so later
|
||||
// tests using the compat wrappers see an open cache (order-independent;
|
||||
// the singleton is otherwise pinned closed for the process lifetime).
|
||||
resetGlobalManagerForTest()
|
||||
}
|
||||
|
||||
// TestUniversalCacheManagerCompat tests UniversalCacheManagerCompat methods
|
||||
@@ -1262,6 +1266,9 @@ func TestUniversalCacheManagerCompat(t *testing.T) {
|
||||
if err != nil && err.Error() != "cache already closed" {
|
||||
t.Errorf("UniversalCacheManagerCompat Close should not error (unless already closed): %v", err)
|
||||
}
|
||||
// Close() shuts down the process-global manager. Recreate it so later
|
||||
// tests using the compat wrappers see an open cache (order-independent).
|
||||
resetGlobalManagerForTest()
|
||||
}
|
||||
|
||||
// TestTypedCacheWrapper tests TypedCache methods
|
||||
|
||||
Reference in New Issue
Block a user