Complete rebuild of the plugin

* Fix bug affecting Azure OIDC authentication ( and most likely others ) * Fixes issue #51 * Ensure that appended roles are unique. Update the documentation. * Improvements targetting possible memory usage spikes. * Additional fixes and cleanup * Refactoring code to fix the issues identified by the users. * Modernize run * Fieldalignment * Multiple changes to improve performance and reduce complexity. - Optimise the errors and recovery. - Deduplicate code in metadata cache. - Remove unused performance monitoring code. - Simplify session management and settings handling. * Fix claims issue. * Add ability to overwrite the default scopes in the settings file * Well.. that escalated quickly. Completely forgot that Traefik uses outdated Yaegi and requires compatibility with 1.20 ( pre-generic Go code ). * Bugfix #51: Ensures that user provided scopes overrides work. * fixup! Bugfix #51: Ensures that user provided scopes overrides work. * fixup! fixup! Bugfix #51: Ensures that user provided scopes overrides work. * Abstract the provider logic into a separate package. * Additional micro fixes and cleanups. * Simplify all the things. * fixup! Simplify all the things. * fixup! fixup! Simplify all the things. * fixup! fixup! fixup! Simplify all the things. * fixup! fixup! fixup! fixup! Simplify all the things. * ... * Cleanup tests. * fixup! Cleanup tests. * fixup! fixup! fixup! Cleanup tests. * fixup! fixup! fixup! fixup! Cleanup tests. * fixup! fixup! fixup! fixup! fixup! Cleanup tests. * Issue #53: Fix CSRF token handling in reverse proxy 1. ✅ HTTPS Detection Fixed (session.go:723) - Now uses X-Forwarded-Proto header instead of r.URL.Scheme - Properly detects HTTPS in reverse proxy environments 2. ✅ SameSite Cookie Attribute Fixed - Removed automatic SameSiteStrictMode for HTTPS (would break OAuth) - Keeps SameSiteLaxMode to allow OAuth callbacks from external domains - Only uses Strict for AJAX requests which don't involve OAuth redirects 3. ✅ Cookie Domain Handling Fixed - Now respects X-Forwarded-Host header for cookie domain - Ensures cookies are set for the public domain, not internal proxy domain 4. ✅ EnhanceSessionSecurity Properly Integrated - Function is now actually called during session save - Applies security enhancements without breaking OAuth flow Why Issue #53 Failed Before: 1. Cookies were not marked Secure in HTTPS environments (browser wouldn't send them back) 2. If they had been Secure with SameSite=Strict, Azure callbacks would still fail 3. Cookie domain might have been wrong (internal vs public domain) Why It Works Now: 1. Cookies are properly marked Secure for HTTPS 2. Uses SameSite=Lax to allow OAuth provider callbacks 3. Cookie domain uses public domain from X-Forwarded-Host 4. CSRF token persists through the entire OAuth flow * Next set of enhancements together with memory usage improvements. * Memory leak fixes and optimisations. * CSRF and Cookie Domain fixes * fixup! CSRF and Cookie Domain fixes * Metadata cache leak fix + profiling * fixup! Metadata cache leak fix + profiling * Memory leaks hunting, part 1337. * Further pursue of perfection. * fixup! Further pursue of perfection. * fixup! fixup! Further pursue of perfection. * fixup! fixup! fixup! Further pursue of perfection. * fixup! fixup! fixup! fixup! Further pursue of perfection. * fixup! fixup! fixup! fixup! fixup! Further pursue of perfection. * fixup! fixup! fixup! fixup! fixup! fixup! Further pursue of perfection. * fixup! fixup! fixup! fixup! fixup! fixup! fixup! Further pursue of perfection. * fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Further pursue of perfection. * fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Further pursue of perfection. * Clear race conditions * fixup! Clear race conditions * Weekend fun with memory leaks * Splitting code into multiple files with reasonable testing coverage. ``` ok github.com/lukaszraczylo/traefikoidc 117.017s coverage: 72.6% of statements ok github.com/lukaszraczylo/traefikoidc/auth 0.505s coverage: 87.1% of statements ok github.com/lukaszraczylo/traefikoidc/circuit_breaker 0.283s coverage: 99.0% of statements github.com/lukaszraczylo/traefikoidc/config coverage: 0.0% of statements ok github.com/lukaszraczylo/traefikoidc/handlers 0.349s coverage: 98.2% of statements ok github.com/lukaszraczylo/traefikoidc/internal/providers (cached) coverage: 94.3% of statements ok github.com/lukaszraczylo/traefikoidc/middleware 0.808s coverage: 78.0% of statements ok github.com/lukaszraczylo/traefikoidc/recovery 0.653s coverage: 100.0% of statements ok github.com/lukaszraczylo/traefikoidc/session/chunking (cached) coverage: 87.8% of statements ok github.com/lukaszraczylo/traefikoidc/session/core (cached) coverage: 85.6% of statements ok github.com/lukaszraczylo/traefikoidc/session/crypto (cached) coverage: 81.8% of statements ok github.com/lukaszraczylo/traefikoidc/session/storage (cached) coverage: 93.5% of statements ok github.com/lukaszraczylo/traefikoidc/session/validators (cached) coverage: 98.8% of statements ```` * fixup! Splitting code into multiple files with reasonable testing coverage. * fixup! fixup! Splitting code into multiple files with reasonable testing coverage. * Weekend fun with further optimisations. * fixup! Weekend fun with further optimisations. * fixup! fixup! Weekend fun with further optimisations. * fixup! fixup! fixup! Weekend fun with further optimisations. * fixup! fixup! fixup! fixup! Weekend fun with further optimisations. * fixup! fixup! fixup! fixup! fixup! Weekend fun with further optimisations. * Pre-release cleanup. * Enhance test coverage. * fixup! Enhance test coverage. * fixup! fixup! Enhance test coverage. * fixup! fixup! fixup! Enhance test coverage.
2026-06-05 22:44:17 +00:00 · 2025-09-18 11:01:30 +01:00
parent 784b161732
commit 1b49e133da
181 changed files with 78067 additions and 8289 deletions
@@ -204,8 +204,8 @@ func TestSanitizeInput(t *testing.T) {
 	tests := []struct {
 		name     string
 		input    string
-		maxLen   int
 		expected string
+		maxLen   int
 	}{
 		{
 			name:     "Normal text",
@@ -419,3 +419,477 @@ func TestInputValidationEdgeCases(t *testing.T) {
 		validator.ValidateUsername(unicodeUsername) // Don't fail on unicode
 	})
 }
+
+// TestInputValidatorValidateToken tests comprehensive token validation
+func TestInputValidatorValidateToken(t *testing.T) {
+	config := DefaultInputValidationConfig()
+	validator, _ := NewInputValidator(config, newNoOpLogger())
+
+	tests := []struct {
+		name        string
+		token       string
+		expectValid bool
+		description string
+	}{
+		{
+			name:        "ValidJWTToken",
+			token:       "eyJhbGciOiJSUzI1NiJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6IkpvaG4gRG9lIiwiZXhwIjoxNTE2MjM5MDIyLCJpYXQiOjE1MTYyMzkwMjJ9.signature",
+			expectValid: true,
+			description: "Valid JWT token should pass validation",
+		},
+		{
+			name:        "InvalidOpaqueToken",
+			token:       "opaque_access_token_that_is_long_enough_to_pass",
+			expectValid: false,
+			description: "Opaque token (non-JWT) should fail validation",
+		},
+		{
+			name:        "EmptyToken",
+			token:       "",
+			expectValid: false,
+			description: "Empty token should fail validation",
+		},
+		{
+			name:        "TokenWithNullBytes",
+			token:       "token_with_null\x00byte",
+			expectValid: false,
+			description: "Token with null bytes should fail validation",
+		},
+		{
+			name:        "TokenTooLong",
+			token:       strings.Repeat("a", config.MaxTokenLength+1),
+			expectValid: false,
+			description: "Token exceeding max length should fail validation",
+		},
+		{
+			name:        "TokenWithControlCharacters",
+			token:       "token_with_control\x01character",
+			expectValid: false,
+			description: "Token with control characters should fail validation",
+		},
+		{
+			name:        "TokenWithHighUnicode",
+			token:       "token_with_unicode_\uffff",
+			expectValid: false,
+			description: "Token with high unicode characters should fail validation",
+		},
+		{
+			name:        "MaliciousJWTWithExtraData",
+			token:       "eyJhbGciOiJSUzI1NiJ9.eyJzdWIiOiIxMjM0NTY3ODkwIn0.sig.malicious_extra",
+			expectValid: false,
+			description: "JWT with extra malicious data should fail validation",
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			result := validator.ValidateToken(tt.token)
+
+			if result.IsValid != tt.expectValid {
+				t.Errorf("Expected valid=%v, got %v. %s", tt.expectValid, result.IsValid, tt.description)
+			}
+		})
+	}
+}
+
+// TestInputValidatorValidateEmail tests email validation edge cases
+func TestInputValidatorValidateEmail(t *testing.T) {
+	config := DefaultInputValidationConfig()
+	validator, _ := NewInputValidator(config, newNoOpLogger())
+
+	tests := []struct {
+		name        string
+		email       string
+		expectValid bool
+		description string
+	}{
+		{
+			name:        "ValidEmail",
+			email:       "user@example.com",
+			expectValid: true,
+			description: "Valid email should pass validation",
+		},
+		{
+			name:        "ValidEmailWithSubdomain",
+			email:       "user@mail.example.com",
+			expectValid: true,
+			description: "Valid email with subdomain should pass validation",
+		},
+		{
+			name:        "EmptyEmail",
+			email:       "",
+			expectValid: false,
+			description: "Empty email should fail validation",
+		},
+		{
+			name:        "EmailWithoutAtSign",
+			email:       "userexample.com",
+			expectValid: false,
+			description: "Email without @ sign should fail validation",
+		},
+		{
+			name:        "EmailWithNullBytes",
+			email:       "user@example\x00.com",
+			expectValid: false,
+			description: "Email with null bytes should fail validation",
+		},
+		{
+			name:        "EmailTooLong",
+			email:       strings.Repeat("a", config.MaxEmailLength-10) + "@example.com",
+			expectValid: false,
+			description: "Email exceeding max length should fail validation",
+		},
+		{
+			name:        "EmailWithControlCharacters",
+			email:       "user\x01@example.com",
+			expectValid: false,
+			description: "Email with control characters should fail validation",
+		},
+		{
+			name:        "MaliciousEmailWithScriptTag",
+			email:       "user<script>@example.com",
+			expectValid: false,
+			description: "Email with script tag should fail validation",
+		},
+		{
+			name:        "EmailWithUnicodeCharacters",
+			email:       "üser@éxample.com",
+			expectValid: false,
+			description: "Email with unicode should fail basic validation",
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			result := validator.ValidateEmail(tt.email)
+
+			if result.IsValid != tt.expectValid {
+				t.Errorf("Expected valid=%v, got %v. %s", tt.expectValid, result.IsValid, tt.description)
+			}
+		})
+	}
+}
+
+// TestInputValidatorValidateURL tests URL validation with security focus
+func TestInputValidatorValidateURL(t *testing.T) {
+	config := DefaultInputValidationConfig()
+	validator, _ := NewInputValidator(config, newNoOpLogger())
+
+	tests := []struct {
+		name        string
+		url         string
+		expectValid bool
+		description string
+	}{
+		{
+			name:        "ValidHTTPSURL",
+			url:         "https://example.com/path",
+			expectValid: true,
+			description: "Valid HTTPS URL should pass validation",
+		},
+		{
+			name:        "ValidHTTPURL",
+			url:         "http://example.com/path",
+			expectValid: true,
+			description: "Valid HTTP URL should pass validation",
+		},
+		{
+			name:        "EmptyURL",
+			url:         "",
+			expectValid: false,
+			description: "Empty URL should fail validation",
+		},
+		{
+			name:        "InvalidScheme",
+			url:         "ftp://example.com",
+			expectValid: false,
+			description: "URL with invalid scheme should fail validation",
+		},
+		{
+			name:        "URLWithNullBytes",
+			url:         "https://example\x00.com",
+			expectValid: false,
+			description: "URL with null bytes should fail validation",
+		},
+		{
+			name:        "URLTooLong",
+			url:         "https://" + strings.Repeat("a", config.MaxURLLength) + ".com",
+			expectValid: false,
+			description: "URL exceeding max length should fail validation",
+		},
+		{
+			name:        "MalformedURL",
+			url:         "https://",
+			expectValid: false,
+			description: "Malformed URL should fail validation",
+		},
+		{
+			name:        "HTTPSLocalhostURL",
+			url:         "https://localhost:8080/path",
+			expectValid: true,
+			description: "HTTPS localhost URL should be allowed for development",
+		},
+		{
+			name:        "HTTPLocalhostURL",
+			url:         "http://localhost:8080/path",
+			expectValid: false,
+			description: "HTTP localhost URL should fail validation for security",
+		},
+		{
+			name:        "PrivateIPURL",
+			url:         "https://192.168.1.1/path",
+			expectValid: false,
+			description: "Private IP URL should fail validation for security",
+		},
+		{
+			name:        "JavaScriptURL",
+			url:         "javascript:alert(1)",
+			expectValid: false,
+			description: "JavaScript URL should fail validation",
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			result := validator.ValidateURL(tt.url)
+
+			if result.IsValid != tt.expectValid {
+				t.Errorf("Expected valid=%v, got %v. %s", tt.expectValid, result.IsValid, tt.description)
+			}
+		})
+	}
+}
+
+// TestInputValidatorValidateClaim tests claim validation with security focus
+func TestInputValidatorValidateClaim(t *testing.T) {
+	config := DefaultInputValidationConfig()
+	validator, _ := NewInputValidator(config, newNoOpLogger())
+
+	tests := []struct {
+		name        string
+		claimName   string
+		claimValue  string
+		expectValid bool
+		description string
+	}{
+		{
+			name:        "ValidStringClaim",
+			claimName:   "email",
+			claimValue:  "user@example.com",
+			expectValid: true,
+			description: "Valid string claim should pass validation",
+		},
+		{
+			name:        "ValidNumberClaim",
+			claimName:   "exp",
+			claimValue:  "1516239022",
+			expectValid: true,
+			description: "Valid number claim should pass validation",
+		},
+		{
+			name:        "EmptyClaimName",
+			claimName:   "",
+			claimValue:  "value",
+			expectValid: false,
+			description: "Empty claim name should fail validation",
+		},
+		{
+			name:        "ClaimWithNullBytes",
+			claimName:   "test",
+			claimValue:  "value\x00with_null",
+			expectValid: false,
+			description: "Claim with null bytes should fail validation",
+		},
+		{
+			name:        "ClaimValueTooLong",
+			claimName:   "test",
+			claimValue:  strings.Repeat("a", config.MaxClaimLength+1),
+			expectValid: false,
+			description: "Claim value exceeding max length should fail validation",
+		},
+		{
+			name:        "ClaimWithControlCharacters",
+			claimName:   "test",
+			claimValue:  "value\x01with_control",
+			expectValid: false,
+			description: "Claim with control characters should fail validation",
+		},
+		{
+			name:        "MaliciousClaimWithHTML",
+			claimName:   "test",
+			claimValue:  "<script>alert('xss')</script>",
+			expectValid: false,
+			description: "Claim with HTML/script should fail validation",
+		},
+		{
+			name:        "ClaimWithExcessiveUnicode",
+			claimName:   "test",
+			claimValue:  strings.Repeat("🚀", 100), // Many unicode chars
+			expectValid: false,
+			description: "Claim with excessive unicode should fail validation",
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			result := validator.ValidateClaim(tt.claimName, tt.claimValue)
+
+			if result.IsValid != tt.expectValid {
+				t.Errorf("Expected valid=%v, got %v. %s", tt.expectValid, result.IsValid, tt.description)
+			}
+		})
+	}
+}
+
+// TestInputValidatorValidateHeader tests HTTP header validation
+func TestInputValidatorValidateHeader(t *testing.T) {
+	config := DefaultInputValidationConfig()
+	validator, _ := NewInputValidator(config, newNoOpLogger())
+
+	tests := []struct {
+		name        string
+		headerName  string
+		headerValue string
+		expectValid bool
+		description string
+	}{
+		{
+			name:        "ValidHeader",
+			headerName:  "Authorization",
+			headerValue: "Bearer token123",
+			expectValid: true,
+			description: "Valid header should pass validation",
+		},
+		{
+			name:        "ValidContentType",
+			headerName:  "Content-Type",
+			headerValue: "application/json",
+			expectValid: true,
+			description: "Valid content type header should pass validation",
+		},
+		{
+			name:        "EmptyHeaderName",
+			headerName:  "",
+			headerValue: "value",
+			expectValid: false,
+			description: "Empty header name should fail validation",
+		},
+		{
+			name:        "HeaderWithNullBytes",
+			headerName:  "test",
+			headerValue: "value\x00with_null",
+			expectValid: false,
+			description: "Header with null bytes should fail validation",
+		},
+		{
+			name:        "HeaderValueTooLong",
+			headerName:  "test",
+			headerValue: strings.Repeat("a", config.MaxHeaderLength+1),
+			expectValid: false,
+			description: "Header value exceeding max length should fail validation",
+		},
+		{
+			name:        "HeaderWithCRLF",
+			headerName:  "test",
+			headerValue: "value\r\nMalicious: header",
+			expectValid: false,
+			description: "Header with CRLF should fail validation to prevent injection",
+		},
+		{
+			name:        "HeaderWithControlCharacters",
+			headerName:  "test",
+			headerValue: "value\x01with_control",
+			expectValid: false,
+			description: "Header with control characters should fail validation",
+		},
+		{
+			name:        "MaliciousHeaderWithHTML",
+			headerName:  "test",
+			headerValue: "<script>alert('xss')</script>",
+			expectValid: false,
+			description: "Header with HTML/script should fail validation",
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			result := validator.ValidateHeader(tt.headerName, tt.headerValue)
+
+			if result.IsValid != tt.expectValid {
+				t.Errorf("Expected valid=%v, got %v. %s", tt.expectValid, result.IsValid, tt.description)
+			}
+		})
+	}
+}
+
+// TestInputValidatorValidateUsername tests username validation
+func TestInputValidatorValidateUsername(t *testing.T) {
+	config := DefaultInputValidationConfig()
+	validator, _ := NewInputValidator(config, newNoOpLogger())
+
+	tests := []struct {
+		name        string
+		username    string
+		expectValid bool
+		description string
+	}{
+		{
+			name:        "ValidUsername",
+			username:    "john_doe",
+			expectValid: true,
+			description: "Valid username should pass validation",
+		},
+		{
+			name:        "ValidUsernameWithNumbers",
+			username:    "user123",
+			expectValid: true,
+			description: "Valid username with numbers should pass validation",
+		},
+		{
+			name:        "EmptyUsername",
+			username:    "",
+			expectValid: false,
+			description: "Empty username should fail validation",
+		},
+		{
+			name:        "UsernameWithNullBytes",
+			username:    "user\x00name",
+			expectValid: false,
+			description: "Username with null bytes should fail validation",
+		},
+		{
+			name:        "UsernameTooLong",
+			username:    strings.Repeat("a", config.MaxUsernameLength+1),
+			expectValid: false,
+			description: "Username exceeding max length should fail validation",
+		},
+		{
+			name:        "UsernameWithSpecialChars",
+			username:    "user@name",
+			expectValid: false,
+			description: "Username with special characters should fail validation",
+		},
+		{
+			name:        "UsernameWithSpaces",
+			username:    "user name",
+			expectValid: false,
+			description: "Username with spaces should fail validation",
+		},
+		{
+			name:        "UsernameWithControlCharacters",
+			username:    "user\x01name",
+			expectValid: false,
+			description: "Username with control characters should fail validation",
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			result := validator.ValidateUsername(tt.username)
+
+			if result.IsValid != tt.expectValid {
+				t.Errorf("Expected valid=%v, got %v. %s", tt.expectValid, result.IsValid, tt.description)
+			}
+		})
+	}
+}