fix(passthrough): fail closed on a duplicate top-level model key

RFC 8259 permits duplicate names and every mainstream upstream parser
resolves them last-wins, while a passthrough body is forwarded verbatim.
Reporting the first occurrence let a model-restricted caller authorize
{"model":"allowed","model":"expensive"} against the allowed one and
execute the expensive one. Refuse to answer instead, matching
extractMultipartModel's existing duplicate rule.

Found by the security audit; a padded-duplicate variant that hides the
second key beyond the 64KiB peek window is tracked separately.
This commit is contained in:
2026-08-22 13:11:10 +01:00
parent e57a97d63e
commit e06d8bf5cd
2 changed files with 62 additions and 7 deletions
+35
View File
@@ -1708,3 +1708,38 @@ func TestHandlePassthrough_ZeroConfig_NewFieldsUnset_BehavesIdenticallyToBefore(
t.Errorf("upstream body = %q, want the client body preserved unchanged", gotBody)
}
}
// TestScanTopLevelModel_DuplicateModelKeyFailsClosed pins the fail-closed
// rule for a duplicate top-level "model" key (security audit, 2026-08-22,
// round 3). RFC 8259 permits duplicate names and every mainstream upstream
// parser resolves them LAST-wins, while this gateway forwards a passthrough
// body byte-for-byte — so reporting the FIRST occurrence (the behaviour
// before this test existed) let a model-restricted caller authorize against
// "allowed" and execute "expensive". scanTopLevelModel refuses to answer
// instead, matching extractMultipartModel's errDuplicateModelField rule.
func TestScanTopLevelModel_DuplicateModelKeyFailsClosed(t *testing.T) {
cases := []struct {
name string
body string
wantModel string
wantFound bool
}{
{"single model", `{"model":"allowed","messages":[]}`, "allowed", true},
{"model after other keys", `{"stream":true,"model":"allowed"}`, "allowed", true},
{"model found then body truncated", `{"model":"allowed","messages":[{"role":"user"`, "allowed", true},
{"duplicate model", `{"model":"allowed","model":"expensive","messages":[]}`, "", false},
{"duplicate across a nested object", `{"model":"allowed","opts":{"a":1},"model":"expensive"}`, "", false},
{"duplicate with identical values", `{"model":"same","model":"same"}`, "", false},
{"no model", `{"messages":[]}`, "", false},
{"nested model only", `{"opts":{"model":"x"}}`, "", false},
}
for _, tc := range cases {
t.Run(tc.name, func(t *testing.T) {
gotModel, gotFound := scanTopLevelModel([]byte(tc.body))
if gotModel != tc.wantModel || gotFound != tc.wantFound {
t.Fatalf("scanTopLevelModel(%s) = (%q, %v), want (%q, %v)",
tc.body, gotModel, gotFound, tc.wantModel, tc.wantFound)
}
})
}
}