mirror of
https://github.com/lukaszraczylo/traefik-llmgateway.git
synced 2026-10-21 05:57:53 +00:00
feat(providers): success-rate accounting
Track per-provider and per-(provider,upstream-model) upstream-attempt outcomes using the existing fixed-window counter machinery (limits.go), following mcp_a2a.go's per-target counter pattern: kind-embedded keys (kindProvider="prov", kindProviderModel="provmodel") keep a provider scope collision-safe against a user/group/MCP-target/agent of the same name. limiter.recordProviderAttempt(provider, model, resp, err) increments an "attempts" counter on every call, and a "failures" counter only for a provider-fault outcome — reusing retry.go's own isTransient(resp, err) classification exactly (transport/connection error, HTTP 429, or a 5xx), not forking it. Both counters are written at minute and day granularity only; provider health is a now-and-today question, not a billing one, so there is no month window. limiter.providerUsage batches every scope's read into one storeGetMulti round trip, mirroring targetUsage's own single-batch discipline. Wired at every chokepoint an upstream HTTP attempt resolves: - providers.go's upstreamJSON/upstreamRawBytes path (chat, embeddings, images, audio) via retry.go's retryPolicy.do, which now looks up an optional attemptRecorder from ctx and invokes it once per retry attempt (attempt-accounting: a request retried twice before succeeding reports three attempts, not one). - routes_unified.go's runUnified (chat/embeddings, streaming and non-streaming alike — both funnel through the same upstreamJSON call). - routes_media.go's three media handlers (images.generations, audio.speech, audio.transcriptions). - routes_passthrough.go's proxyUpstream (native provider passthrough) — a single un-retried attempt, provider-level only: the upstream model lives in the response body, read only after the attempt resolves. The attemptRecorder is threaded via context (providers.go's withAttemptRecorder/attemptRecorderFromContext), not a new function parameter on every call site — proxyUpstream and retryPolicy.do are both shared with paths that must NOT record provider accounting (registry.go's discovery listModels calls, and the MCP/A2A target proxy, mcp_a2a.go's handleTargetProxy), so scoping via context keeps their signatures unchanged and those callers correctly opt out by simply never wrapping their context.
This commit is contained in:
@@ -179,6 +179,24 @@ func TestHandleImagesGenerations_OpenAI_HappyPath_NativeForward(t *testing.T) {
|
||||
if !ok || totalReq != 1 {
|
||||
t.Errorf("total request/min counter = %d (ok=%v), want 1", totalReq, ok)
|
||||
}
|
||||
|
||||
// Feature A (v0.22): handleImagesGenerations wraps the request context
|
||||
// with an attemptRecorder before calling adapter.imagesGeneration
|
||||
// (routes_media.go) — a successful 200 upstream attempt must land as
|
||||
// one attempt, zero failures, at both provider and (provider, model)
|
||||
// scope.
|
||||
attempts, ok := gw.limiter.getCounter(kindProvider, "openai", metricProvAttempt, windowDay, time.Now())
|
||||
if !ok || attempts != 1 {
|
||||
t.Errorf("provider attempts/day = %d (ok=%v), want 1", attempts, ok)
|
||||
}
|
||||
fails, _ := gw.limiter.getCounter(kindProvider, "openai", metricProvFail, windowDay, time.Now())
|
||||
if fails != 0 {
|
||||
t.Errorf("provider fails/day = %d, want 0", fails)
|
||||
}
|
||||
modelAttempts, ok := gw.limiter.getCounter(kindProviderModel, "openai/img-test", metricProvAttempt, windowDay, time.Now())
|
||||
if !ok || modelAttempts != 1 {
|
||||
t.Errorf("model attempts/day = %d (ok=%v), want 1", modelAttempts, ok)
|
||||
}
|
||||
}
|
||||
|
||||
// TestHandleImagesGenerations_ModelAlias_ResolvesToTargetUpstreamModel
|
||||
|
||||
Reference in New Issue
Block a user