gosec govulncheck runs (#1)

* gosec govulncheck runs

* Fix flaky TestRateLimiter_Matrix test

The test was failing due to two issues:
1. Test name generation used invalid character conversion (string(rune('0'+limit)))
   which produced non-printable characters for limits >= 10
2. Using 10ms windows with 100 requests caused race conditions - early requests
   would expire before all 100 were made, allowing the 101st request

Changed to use struct-based test cases with proper fmt.Sprintf naming and
a consistent 1-second window that won't expire during rapid test execution.
This commit is contained in:
2025-12-09 01:07:16 +00:00
committed by GitHub
parent 27d5011ab1
commit 29263dc8a2
17 changed files with 80 additions and 215 deletions
+23 -17
View File
@@ -1,6 +1,7 @@
package daemon
import (
"fmt"
"os"
"path/filepath"
"testing"
@@ -145,26 +146,31 @@ func TestPeerCredentials(t *testing.T) {
// Matrix test for rate limiting
func TestRateLimiter_Matrix(t *testing.T) {
limits := []int{1, 5, 10, 100}
windows := []time.Duration{10 * time.Millisecond, 100 * time.Millisecond, time.Second}
testCases := []struct {
limit int
window time.Duration
}{
{1, time.Second},
{5, time.Second},
{10, time.Second},
{100, time.Second},
}
for _, limit := range limits {
for _, window := range windows {
t.Run(
"limit="+string(rune('0'+limit))+"_window="+window.String(),
func(t *testing.T) {
rl := NewRateLimiter(limit, window)
for _, tc := range testCases {
t.Run(
fmt.Sprintf("limit=%d_window=%s", tc.limit, tc.window),
func(t *testing.T) {
rl := NewRateLimiter(tc.limit, tc.window)
// Should allow exactly 'limit' requests
for i := 0; i < limit; i++ {
assert.True(t, rl.Allow(1))
}
// Should allow exactly 'limit' requests
for i := 0; i < tc.limit; i++ {
assert.True(t, rl.Allow(1), "request %d should be allowed", i)
}
// Next should be blocked
assert.False(t, rl.Allow(1))
},
)
}
// Next should be blocked
assert.False(t, rl.Allow(1), "request after limit should be blocked")
},
)
}
}