lukaszraczylo/llm-testbench
1
0
Fork 0
mirror of https://github.com/lukaszraczylo/llm-testbench.git synced 2026-10-12 00:45:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(eval): accept multiplier-suffix numbers like 64x

Browse Source 
The strict word-boundary rule rejected the multiplier form. A single
trailing x with no word character after it now counts as a valid
number. Hex literals and identifiers stay rejected.
This commit is contained in:
lukaszraczylo
2026-08-17 01:57:58 +01:00
parent 1b29019325
commit 586700758f
2 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/eval/numeric.go
+7
View File
@@ -74,8 +74,15 @@ func classifyMatch(text string, start, end int) (numberCandidate, bool) {
return numberCandidate{}, false // e.g. the "64" in "LP64" return numberCandidate{}, false // e.g. the "64" in "LP64"
} }
if end < len(text) && isWordByte(text[end]) { if end < len(text) && isWordByte(text[end]) {
// Permit a multiplier suffix ("64x" = 64 times): a single trailing
// x/X with nothing word-like after it. Hex ("0x2A") and identifiers
// ("float64x2") keep a word byte after the x and stay rejected.
isMultiplier := (text[end] == 'x' || text[end] == 'X') &&
(end+1 >= len(text) || !isWordByte(text[end+1]))
if !isMultiplier {
return numberCandidate{}, false // e.g. "24bytes" with no separator return numberCandidate{}, false // e.g. "24bytes" with no separator
} }
}
compound := start > 0 && text[start-1] == '-' && start-2 >= 0 && isWordByte(text[start-2]) compound := start > 0 && text[start-1] == '-' && start-2 >= 0 && isWordByte(text[start-2])
internal/eval/numeric_test.go
+3
View File
@@ -26,6 +26,9 @@ func TestExtractLastNumber(t *testing.T) {
{"platform qualifier with parenthetical acronym", "24 bytes on a 64-bit (LP64) platform.", 24, false}, {"platform qualifier with parenthetical acronym", "24 bytes on a 64-bit (LP64) platform.", 24, false},
{"digits glued into an identifier via underscore", "sizeof = 24 bytes on x86_64", 24, false}, {"digits glued into an identifier via underscore", "sizeof = 24 bytes on x86_64", 24, false},
{"digits glued into an identifier via hyphen (bogus sign)", "sizeof = 24 bytes on x86-64", 24, false}, {"digits glued into an identifier via hyphen (bogus sign)", "sizeof = 24 bytes on x86-64", 24, false},
{"multiplier suffix accepted", "The compression ratio is 64x.", 64, false},
{"multiplier suffix at end of text", "speedup: 8x", 8, false},
{"hex literal never a multiplier", "the flag is 0x2A so the answer is 42", 42, false},
{"hyphen-compound number accepted as a last resort", "It is a 24-byte struct.", 24, false}, {"hyphen-compound number accepted as a last resort", "It is a 24-byte struct.", 24, false},
// Documented limitation, not a regression: the heuristic has no // Documented limitation, not a regression: the heuristic has no
// notion of "the total" vs. "a breakdown component" and returns // notion of "the total" vs. "a breakdown component" and returns