CRD discovery, log noise reduction, e2e tests

pkg/hash/content.go

@@ -10,6 +10,8 @@ import (
 	corev1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
 	"k8s.io/apimachinery/pkg/runtime"
+
+	"github.com/lukaszraczylo/kubemirror/pkg/constants"
 )
 
 // ComputeContentHash computes a SHA256 hash of the resource's actual content.
@@ -109,7 +111,7 @@ func NeedsSync(source, target runtime.Object, targetAnnotations map[string]strin
 	// Layer 1: Generation-based check (for resources that support it)
 	sourceGen := getGeneration(source)
 	if sourceGen > 0 {
-		targetSourceGen := targetAnnotations["source-generation"]
+		targetSourceGen := targetAnnotations[constants.AnnotationSourceGeneration]
 		if fmt.Sprintf("%d", sourceGen) != targetSourceGen {
 			return true, nil // Generation changed
 		}
@@ -121,7 +123,7 @@ func NeedsSync(source, target runtime.Object, targetAnnotations map[string]strin
 		return false, fmt.Errorf("failed to compute source hash: %w", err)
 	}
 
-	targetSourceHash := targetAnnotations["source-content-hash"]
+	targetSourceHash := targetAnnotations[constants.AnnotationSourceContentHash]
 	if sourceHash != targetSourceHash {
 		return true, nil // Content changed
 	}

pkg/hash/content_test.go

@@ -3,6 +3,7 @@ package hash
 import (
 	"testing"
 
+	"github.com/lukaszraczylo/kubemirror/pkg/constants"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 	corev1 "k8s.io/api/core/v1"
@@ -374,8 +375,8 @@ func TestNeedsSync(t *testing.T) {
 			},
 			target: &unstructured.Unstructured{},
 			targetAnnotations: map[string]string{
-				"source-generation":   "3",
-				"source-content-hash": "abc123",
+				constants.AnnotationSourceGeneration:  "3",
+				constants.AnnotationSourceContentHash: "abc123",
 			},
 			want:      true,
 			wantError: false,
@@ -387,8 +388,8 @@ func TestNeedsSync(t *testing.T) {
 			},
 			target: &corev1.Secret{},
 			targetAnnotations: map[string]string{
-				"source-generation":   "0",
-				"source-content-hash": mustComputeHash(t, &corev1.Secret{Data: map[string][]byte{"key": []byte("value")}}),
+				constants.AnnotationSourceGeneration:  "0",
+				constants.AnnotationSourceContentHash: mustComputeHash(t, &corev1.Secret{Data: map[string][]byte{"key": []byte("value")}}),
 			},
 			want:      false,
 			wantError: false,
@@ -400,7 +401,7 @@ func TestNeedsSync(t *testing.T) {
 			},
 			target: &corev1.ConfigMap{},
 			targetAnnotations: map[string]string{
-				"source-content-hash": "oldhash",
+				constants.AnnotationSourceContentHash: "oldhash",
 			},
 			want:      true,
 			wantError: false,