mirror of
https://github.com/lukaszraczylo/kportal.git
synced 2026-07-05 06:05:39 +00:00
style: Extract UI constants and refactor main view rendering (#30)
- [x] Add golangci-lint configuration with gocritic ifElseChain disabled
- [x] Rename error variables to avoid shadowing (createErr, watcherErr, watchErr, etc.)
- [x] Replace `interface{}` with `any` type alias throughout codebase
- [x] Add package-level documentation comments to all internal packages
- [x] Reorder struct fields alphabetically for consistency
- [x] Extract UI constants (terminal dimensions, column widths, colors) to constants.go
- [x] Refactor BubbleTeaUI main view rendering into smaller helper functions
- [x] Simplify nested conditionals and improve code clarity
- [x] Add `isForwardDisabled()` helper method to BubbleTeaUI
- [x] Update file permissions from 0644 to 0600 in config tests
- [x] Add `#nosec` comments and error suppression where appropriate
- [x] Improve test table struct field ordering for readability
- [x] Fix resource parsing in AddForward using strings.SplitN
- [x] Add comprehensive tests for new UI helper functions and constants
This commit is contained in:
@@ -14,17 +14,17 @@ type ForwardStatus struct {
|
||||
Context string
|
||||
Namespace string
|
||||
Alias string
|
||||
Type string // "service", "pod", etc.
|
||||
Resource string // name without type prefix
|
||||
Type string
|
||||
Resource string
|
||||
Status string
|
||||
RemotePort int
|
||||
LocalPort int
|
||||
Status string // "Starting", "Active", "Reconnecting", "Error"
|
||||
}
|
||||
|
||||
// TableUI manages the terminal table display
|
||||
type TableUI struct {
|
||||
forwards map[string]*ForwardStatus
|
||||
mu sync.RWMutex
|
||||
forwards map[string]*ForwardStatus // key is forward ID
|
||||
verbose bool
|
||||
}
|
||||
|
||||
@@ -101,12 +101,12 @@ func (t *TableUI) Render() {
|
||||
|
||||
// Sort forwards by local port for consistent display
|
||||
type sortEntry struct {
|
||||
id string
|
||||
fwd *ForwardStatus
|
||||
id string
|
||||
}
|
||||
var entries []sortEntry
|
||||
for id, fwd := range t.forwards {
|
||||
entries = append(entries, sortEntry{id, fwd})
|
||||
entries = append(entries, sortEntry{fwd: fwd, id: id})
|
||||
}
|
||||
|
||||
// Simple sort by local port
|
||||
|
||||
Reference in New Issue
Block a user