mirror of
https://github.com/lukaszraczylo/kportal.git
synced 2026-07-12 07:41:42 +00:00
style: Extract UI constants and refactor main view rendering (#30)
- [x] Add golangci-lint configuration with gocritic ifElseChain disabled
- [x] Rename error variables to avoid shadowing (createErr, watcherErr, watchErr, etc.)
- [x] Replace `interface{}` with `any` type alias throughout codebase
- [x] Add package-level documentation comments to all internal packages
- [x] Reorder struct fields alphabetically for consistency
- [x] Extract UI constants (terminal dimensions, column widths, colors) to constants.go
- [x] Refactor BubbleTeaUI main view rendering into smaller helper functions
- [x] Simplify nested conditionals and improve code clarity
- [x] Add `isForwardDisabled()` helper method to BubbleTeaUI
- [x] Update file permissions from 0644 to 0600 in config tests
- [x] Add `#nosec` comments and error suppression where appropriate
- [x] Improve test table struct field ordering for readability
- [x] Fix resource parsing in AddForward using strings.SplitN
- [x] Add comprehensive tests for new UI helper functions and constants
This commit is contained in:
@@ -28,11 +28,11 @@ func NewDiscovery(pool *ClientPool) *Discovery {
|
||||
|
||||
// PodInfo contains information about a pod relevant for port forwarding.
|
||||
type PodInfo struct {
|
||||
Created metav1.Time
|
||||
Name string
|
||||
Namespace string
|
||||
Containers []ContainerInfo
|
||||
Status string
|
||||
Created metav1.Time
|
||||
Containers []ContainerInfo
|
||||
}
|
||||
|
||||
// ContainerInfo contains information about a container within a pod.
|
||||
@@ -44,17 +44,17 @@ type ContainerInfo struct {
|
||||
// PortInfo describes a port exposed by a container or service.
|
||||
type PortInfo struct {
|
||||
Name string
|
||||
Port int32
|
||||
TargetPort int32 // For services: the actual pod port to forward to
|
||||
Protocol string
|
||||
Port int32
|
||||
TargetPort int32
|
||||
}
|
||||
|
||||
// ServiceInfo contains information about a service.
|
||||
type ServiceInfo struct {
|
||||
Name string
|
||||
Namespace string
|
||||
Ports []PortInfo
|
||||
Type string
|
||||
Ports []PortInfo
|
||||
}
|
||||
|
||||
// ListContexts returns all available Kubernetes contexts from kubeconfig.
|
||||
|
||||
Reference in New Issue
Block a user