mirror of
https://github.com/lukaszraczylo/kportal.git
synced 2026-07-11 07:22:15 +00:00
style: Extract UI constants and refactor main view rendering (#30)
- [x] Add golangci-lint configuration with gocritic ifElseChain disabled
- [x] Rename error variables to avoid shadowing (createErr, watcherErr, watchErr, etc.)
- [x] Replace `interface{}` with `any` type alias throughout codebase
- [x] Add package-level documentation comments to all internal packages
- [x] Reorder struct fields alphabetically for consistency
- [x] Extract UI constants (terminal dimensions, column widths, colors) to constants.go
- [x] Refactor BubbleTeaUI main view rendering into smaller helper functions
- [x] Simplify nested conditionals and improve code clarity
- [x] Add `isForwardDisabled()` helper method to BubbleTeaUI
- [x] Update file permissions from 0644 to 0600 in config tests
- [x] Add `#nosec` comments and error suppression where appropriate
- [x] Improve test table struct field ordering for readability
- [x] Fix resource parsing in AddForward using strings.SplitN
- [x] Add comprehensive tests for new UI helper functions and constants
This commit is contained in:
@@ -19,25 +19,25 @@ const (
|
||||
// the watchdog polls workers periodically. This reduces goroutine count and
|
||||
// simplifies worker implementation.
|
||||
type Watchdog struct {
|
||||
mu sync.RWMutex
|
||||
workers map[string]*workerState // key: forward ID
|
||||
checkInterval time.Duration
|
||||
hangThreshold time.Duration // How long without heartbeat before considered hung
|
||||
heartbeatInterval time.Duration // How often to poll workers for heartbeat
|
||||
ctx context.Context
|
||||
workers map[string]*workerState
|
||||
cancel context.CancelFunc
|
||||
eventBus *events.Bus
|
||||
wg sync.WaitGroup
|
||||
eventBus *events.Bus // Optional event bus for decoupled communication
|
||||
checkInterval time.Duration
|
||||
hangThreshold time.Duration
|
||||
heartbeatInterval time.Duration
|
||||
mu sync.RWMutex
|
||||
}
|
||||
|
||||
// workerState tracks the health of a single worker
|
||||
type workerState struct {
|
||||
forwardID string
|
||||
lastHeartbeat time.Time
|
||||
worker HeartbeatResponder
|
||||
onHungCallback func(forwardID string)
|
||||
forwardID string
|
||||
heartbeatCount uint64
|
||||
isHung bool
|
||||
onHungCallback func(forwardID string)
|
||||
worker HeartbeatResponder // Reference to worker for heartbeat polling
|
||||
}
|
||||
|
||||
// HeartbeatResponder is an interface for workers that can respond to heartbeat checks
|
||||
@@ -204,8 +204,8 @@ func (w *Watchdog) pollHeartbeats() {
|
||||
|
||||
// hungWorkerInfo stores information about a hung worker for deferred callback execution
|
||||
type hungWorkerInfo struct {
|
||||
forwardID string
|
||||
callback func(string)
|
||||
forwardID string
|
||||
}
|
||||
|
||||
// checkWorkers checks all registered workers for hung state
|
||||
|
||||
Reference in New Issue
Block a user