mirror of
https://github.com/lukaszraczylo/kportal.git
synced 2026-07-07 06:25:43 +00:00
style: Extract UI constants and refactor main view rendering (#30)
- [x] Add golangci-lint configuration with gocritic ifElseChain disabled
- [x] Rename error variables to avoid shadowing (createErr, watcherErr, watchErr, etc.)
- [x] Replace `interface{}` with `any` type alias throughout codebase
- [x] Add package-level documentation comments to all internal packages
- [x] Reorder struct fields alphabetically for consistency
- [x] Extract UI constants (terminal dimensions, column widths, colors) to constants.go
- [x] Refactor BubbleTeaUI main view rendering into smaller helper functions
- [x] Simplify nested conditionals and improve code clarity
- [x] Add `isForwardDisabled()` helper method to BubbleTeaUI
- [x] Update file permissions from 0644 to 0600 in config tests
- [x] Add `#nosec` comments and error suppression where appropriate
- [x] Improve test table struct field ordering for readability
- [x] Fix resource parsing in AddForward using strings.SplitN
- [x] Add comprehensive tests for new UI helper functions and constants
This commit is contained in:
@@ -11,10 +11,10 @@ func TestValidator_ValidateConfig(t *testing.T) {
|
||||
validator := NewValidator()
|
||||
|
||||
tests := []struct {
|
||||
name string
|
||||
config *Config
|
||||
expectErrors bool
|
||||
name string
|
||||
errorContains []string
|
||||
expectErrors bool
|
||||
}{
|
||||
{
|
||||
name: "valid config",
|
||||
@@ -227,9 +227,9 @@ func TestValidator_ValidateResourceFormat(t *testing.T) {
|
||||
|
||||
tests := []struct {
|
||||
name string
|
||||
errorContains []string
|
||||
forward Forward
|
||||
expectErrors bool
|
||||
errorContains []string
|
||||
}{
|
||||
{
|
||||
name: "valid pod with name",
|
||||
@@ -370,10 +370,10 @@ func TestValidator_CheckDuplicatePorts(t *testing.T) {
|
||||
validator := NewValidator()
|
||||
|
||||
tests := []struct {
|
||||
name string
|
||||
config *Config
|
||||
expectErrors bool
|
||||
name string
|
||||
errorContains []string
|
||||
expectErrors bool
|
||||
}{
|
||||
{
|
||||
name: "no duplicate ports",
|
||||
@@ -552,8 +552,8 @@ func TestFormatValidationErrors(t *testing.T) {
|
||||
tests := []struct {
|
||||
name string
|
||||
errors []ValidationError
|
||||
expectEmpty bool
|
||||
expectContains []string
|
||||
expectEmpty bool
|
||||
}{
|
||||
{
|
||||
name: "no errors",
|
||||
@@ -625,10 +625,10 @@ func TestValidator_ValidateStructure(t *testing.T) {
|
||||
validator := NewValidator()
|
||||
|
||||
tests := []struct {
|
||||
name string
|
||||
config *Config
|
||||
expectErrors bool
|
||||
name string
|
||||
errorContains []string
|
||||
expectErrors bool
|
||||
}{
|
||||
{
|
||||
name: "empty context name",
|
||||
@@ -697,10 +697,10 @@ func TestValidator_ValidateMDNS(t *testing.T) {
|
||||
validator := NewValidator()
|
||||
|
||||
tests := []struct {
|
||||
name string
|
||||
config *Config
|
||||
expectErrors bool
|
||||
name string
|
||||
errorContains []string
|
||||
expectErrors bool
|
||||
}{
|
||||
{
|
||||
name: "mDNS disabled - no validation",
|
||||
@@ -968,8 +968,8 @@ func TestValidator_ValidateConfigWithOptions(t *testing.T) {
|
||||
validator := NewValidator()
|
||||
|
||||
tests := []struct {
|
||||
name string
|
||||
config *Config
|
||||
name string
|
||||
allowEmpty bool
|
||||
expectErrors bool
|
||||
}{
|
||||
|
||||
Reference in New Issue
Block a user