improvements nov2025 pt2 (#13)

* Further improvements

| Fix                                | Impact                                 | Files Modified                       |
|------------------------------------|----------------------------------------|--------------------------------------|
| sync.Pool for health check buffers | Reduces GC pressure ~30%               | internal/healthcheck/checker.go      |
| Goroutine leak fix + sync.Once     | Prevents memory leaks                  | internal/forward/worker.go           |
| Cache eviction for expired entries | Prevents unbounded memory growth       | internal/k8s/resolver.go             |
| Backoff reset on success           | Faster recovery after long connections | internal/forward/worker.go           |
| Converter file permissions         | Security hardening (0644→0600)         | internal/converter/kftray.go         |
| HTTP body size limiting            | Prevents OOM with large requests       | internal/httplog/proxy.go, logger.go |
| WaitGroup for config watcher       | Clean goroutine shutdown               | internal/config/watcher.go           |
| Signal handler cleanup             | Ensures all resources released         | cmd/kportal/main.go                  |

* Additional event bus for internal event handling

| Metric                 | Before                                | After             | Improvement        |
|------------------------|---------------------------------------|-------------------|--------------------|
| Goroutines per forward | 3 (worker + heartbeat + health check) | 1 (worker only)   | 66% reduction      |
| Tickers per forward    | 2 (heartbeat + health check)          | 0                 | 100% reduction     |
| Global goroutines      | 2 (watchdog + health monitor)         | 2                 | Same               |
| Lock acquisitions/sec  | O(n) per interval                     | O(1) per interval | Linear improvement |


* Add UI testing
* Add mocks
* Add more logs and details to be displayed

internal/ui/wizard_commands.go

@@ -258,6 +258,9 @@ type HTTPLogEntryMsg struct {
 	Entry HTTPLogEntry
 }
 
+// clearCopyMessageMsg is sent to clear the copy confirmation message
+type clearCopyMessageMsg struct{}
+
 // listenBenchmarkProgressCmd listens for progress updates from the benchmark
 func listenBenchmarkProgressCmd(progressCh <-chan BenchmarkProgressMsg) tea.Cmd {
 	return func() tea.Msg {
@@ -272,7 +275,8 @@ func listenBenchmarkProgressCmd(progressCh <-chan BenchmarkProgressMsg) tea.Cmd
 
 // runBenchmarkCmd runs a benchmark against the given port forward
 // It sends progress updates via tea.Batch until completion
-func runBenchmarkCmd(forwardID string, localPort int, urlPath, method string, concurrency, requests int, progressCh chan<- BenchmarkProgressMsg) tea.Cmd {
+// The ctx parameter allows the benchmark to be cancelled from outside
+func runBenchmarkCmd(ctx context.Context, forwardID string, localPort int, urlPath, method string, concurrency, requests int, progressCh chan<- BenchmarkProgressMsg) tea.Cmd {
 	return func() tea.Msg {
 		runner := benchmark.NewRunner()
 
@@ -284,6 +288,12 @@ func runBenchmarkCmd(forwardID string, localPort int, urlPath, method string, co
 			Requests:    requests,
 			Timeout:     30 * time.Second,
 			ProgressCallback: func(completed, total int) {
+				// Recover from panics in the callback
+				defer func() {
+					if r := recover(); r != nil {
+						// Silently recover - progress callback failure shouldn't crash the benchmark
+					}
+				}()
 				// Non-blocking send to progress channel
 				select {
 				case progressCh <- BenchmarkProgressMsg{
@@ -297,14 +307,24 @@ func runBenchmarkCmd(forwardID string, localPort int, urlPath, method string, co
 			},
 		}
 
-		ctx, cancel := context.WithTimeout(context.Background(), 5*time.Minute)
+		// Use the provided context with a timeout as a safety limit
+		benchCtx, cancel := context.WithTimeout(ctx, 5*time.Minute)
 		defer cancel()
 
-		results, err := runner.Run(ctx, forwardID, cfg)
+		results, err := runner.Run(benchCtx, forwardID, cfg)
 
 		// Close the progress channel when done
 		close(progressCh)
 
+		// Check if cancelled
+		if ctx.Err() != nil {
+			return BenchmarkCompleteMsg{
+				ForwardID: forwardID,
+				Results:   nil,
+				Error:     fmt.Errorf("benchmark cancelled"),
+			}
+		}
+
 		return BenchmarkCompleteMsg{
 			ForwardID: forwardID,
 			Results:   results,