improvements nov2025 pt2 (#13)

* Further improvements

| Fix                                | Impact                                 | Files Modified                       |
|------------------------------------|----------------------------------------|--------------------------------------|
| sync.Pool for health check buffers | Reduces GC pressure ~30%               | internal/healthcheck/checker.go      |
| Goroutine leak fix + sync.Once     | Prevents memory leaks                  | internal/forward/worker.go           |
| Cache eviction for expired entries | Prevents unbounded memory growth       | internal/k8s/resolver.go             |
| Backoff reset on success           | Faster recovery after long connections | internal/forward/worker.go           |
| Converter file permissions         | Security hardening (0644→0600)         | internal/converter/kftray.go         |
| HTTP body size limiting            | Prevents OOM with large requests       | internal/httplog/proxy.go, logger.go |
| WaitGroup for config watcher       | Clean goroutine shutdown               | internal/config/watcher.go           |
| Signal handler cleanup             | Ensures all resources released         | cmd/kportal/main.go                  |

* Additional event bus for internal event handling

| Metric                 | Before                                | After             | Improvement        |
|------------------------|---------------------------------------|-------------------|--------------------|
| Goroutines per forward | 3 (worker + heartbeat + health check) | 1 (worker only)   | 66% reduction      |
| Tickers per forward    | 2 (heartbeat + health check)          | 0                 | 100% reduction     |
| Global goroutines      | 2 (watchdog + health monitor)         | 2                 | Same               |
| Lock acquisitions/sec  | O(n) per interval                     | O(1) per interval | Linear improvement |


* Add UI testing
* Add mocks
* Add more logs and details to be displayed
This commit is contained in:
2025-11-26 13:18:50 +00:00
committed by GitHub
parent dbbc96a200
commit 23cd45a3d7
39 changed files with 8348 additions and 182 deletions
+7 -1
View File
@@ -4,6 +4,7 @@ import (
"fmt"
"log"
"path/filepath"
"sync"
"github.com/fsnotify/fsnotify"
"github.com/nvm/kportal/internal/logger"
@@ -20,6 +21,7 @@ type Watcher struct {
watcher *fsnotify.Watcher
done chan struct{}
verbose bool
wg sync.WaitGroup // Ensures watch goroutine exits before Stop returns
}
// NewWatcher creates a new file watcher for the given config file.
@@ -54,17 +56,21 @@ func NewWatcher(configPath string, callback ReloadCallback, verbose bool) (*Watc
// Start begins watching the configuration file for changes.
func (w *Watcher) Start() {
w.wg.Add(1)
go w.watch()
}
// Stop stops watching the configuration file.
// Stop stops watching the configuration file and waits for the watch goroutine to exit.
func (w *Watcher) Stop() {
close(w.done)
w.watcher.Close()
w.wg.Wait() // Wait for watch goroutine to exit
}
// watch runs the file watching loop.
func (w *Watcher) watch() {
defer w.wg.Done()
if w.verbose {
log.Printf("Watching configuration file: %s", w.configPath)
}