mirror of
https://github.com/lukaszraczylo/jobs-manager-operator.git
synced 2026-07-12 07:41:00 +00:00
new year update (#30)
* Multiple fixes - add goreleaser to the build / release process - add kubectl plugin for job graphs visualization - add installation scripts - update dependencies * Update the release & CRD content. * Next set of improvements. Code Quality - Label constants: Added LabelWorkflowName, LabelGroupName, LabelJobName, LabelJobID in controllers/definitions.go - Removed commented debug code: Cleaned up dead code from multiple files - Removed unused dependencyTree field: Cleaned connPackage struct - Fixed snake_case variables: Changed to camelCase (runGroup, groupDep, runJob, jobDep, k8sJob) Kubernetes Best Practices - Finalizers: Implemented handleDeletion() and deleteChildJobs() for proper cleanup - Status enum validation: Added +kubebuilder:validation:Enum=pending;running;succeeded;failed;aborted - ImagePullPolicy default: Created getImagePullPolicy() helper that defaults to IfNotPresent - Resource limits support: Added Resources *corev1.ResourceRequirements to ManagedJobParameters Observability - Prometheus metrics: Created controllers/metrics.go with counters (jobs created/succeeded/failed), histogram (reconciliation duration), and gauge (active jobs) - Structured logging: Added logger field to connPackage, used context-based logging throughout Configuration - Leader election ID: Made configurable via --leader-election-id flag - Development mode: Made configurable via --dev-mode flag and LOG_LEVEL env var Performance - Dependency lookup optimization: Changed from O(n*m) to O(1) using lookup maps (jobDepMap, groupDepMap) - Reconciliation backoff: Added RequeueAfter: 30*time.Second when workflow is running Documentation & Testing - Godoc documentation: Added comprehensive comments to API types and controller - Unit tests: Added helpers_test.go with tests for all helper functions - Integration tests: Added managedjob_controller_test.go with Ginkgo/Gomega tests * Add the helm chart release. * Add reasonable test coverage. * fixup! Add reasonable test coverage. * fixup! fixup! Add reasonable test coverage. * fixup! fixup! fixup! Add reasonable test coverage.
This commit is contained in:
@@ -12,6 +12,7 @@ on:
|
|||||||
permissions:
|
permissions:
|
||||||
contents: read
|
contents: read
|
||||||
pull-requests: write
|
pull-requests: write
|
||||||
|
security-events: write
|
||||||
|
|
||||||
jobs:
|
jobs:
|
||||||
pr-checks:
|
pr-checks:
|
||||||
|
|||||||
@@ -51,7 +51,7 @@ jobs:
|
|||||||
repository: lukaszraczylo/helm-charts
|
repository: lukaszraczylo/helm-charts
|
||||||
ref: gh-pages
|
ref: gh-pages
|
||||||
path: helm-charts
|
path: helm-charts
|
||||||
token: ${{ secrets.HELM_CHARTS_TOKEN }}
|
token: ${{ secrets.HOMEBREW_TAP_TOKEN }}
|
||||||
|
|
||||||
- name: Update and package Helm chart
|
- name: Update and package Helm chart
|
||||||
run: |
|
run: |
|
||||||
|
|||||||
@@ -74,15 +74,10 @@ archives:
|
|||||||
- goos: windows
|
- goos: windows
|
||||||
formats:
|
formats:
|
||||||
- zip
|
- zip
|
||||||
hooks:
|
|
||||||
after:
|
|
||||||
- helm package charts/jobs-manager-operator -d dist/
|
|
||||||
|
|
||||||
checksum:
|
checksum:
|
||||||
name_template: 'checksums.txt'
|
name_template: 'checksums.txt'
|
||||||
algorithm: sha256
|
algorithm: sha256
|
||||||
extra_files:
|
|
||||||
- glob: dist/jobs-manager-*.tgz
|
|
||||||
|
|
||||||
changelog:
|
changelog:
|
||||||
sort: asc
|
sort: asc
|
||||||
@@ -101,8 +96,6 @@ release:
|
|||||||
draft: false
|
draft: false
|
||||||
prerelease: auto
|
prerelease: auto
|
||||||
name_template: "v{{.Version}}"
|
name_template: "v{{.Version}}"
|
||||||
extra_files:
|
|
||||||
- glob: dist/jobs-manager-*.tgz
|
|
||||||
header: |
|
header: |
|
||||||
## Jobs Manager Operator v{{.Version}}
|
## Jobs Manager Operator v{{.Version}}
|
||||||
|
|
||||||
|
|||||||
+1
-6
@@ -1,11 +1,6 @@
|
|||||||
version: 1
|
version: 1
|
||||||
force:
|
|
||||||
major: 0
|
|
||||||
minor: 0
|
|
||||||
patch: 0
|
|
||||||
wording:
|
wording:
|
||||||
patch:
|
|
||||||
minor:
|
minor:
|
||||||
- release-minor
|
- release-minor
|
||||||
major:
|
major:
|
||||||
- release-major
|
- release-major
|
||||||
|
|||||||
Reference in New Issue
Block a user