lukaszraczylo/jobs-manager-operator
1
0
Fork 0
mirror of https://github.com/lukaszraczylo/jobs-manager-operator.git synced 2026-10-12 05:32:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(controller): report Failed when a group fails

Browse Source 
checkOverallStatus overwrote the Failed status with Running. A failed workflow
stayed Running and kept requeueing. It now stays Failed and the failure event
fires once. Also remove err shadowing in the visualization client.
This commit is contained in:
lukaszraczylo
2026-10-02 03:59:44 +01:00
parent 5ebe8d8c72
commit bdfc781044
3 changed files with 15 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/visualization/client.go
+2 -2
View File
@@ -25,10 +25,10 @@ func NewClient() (*Client, error) {
}
scheme := runtime.NewScheme()
if err := clientgoscheme.AddToScheme(scheme); err != nil {
if err = clientgoscheme.AddToScheme(scheme); err != nil {
return nil, fmt.Errorf("failed to add client-go scheme: %w", err)
}
if err := jobsmanagerv1beta1.AddToScheme(scheme); err != nil {
if err = jobsmanagerv1beta1.AddToScheme(scheme); err != nil {
return nil, fmt.Errorf("failed to add jobsmanager scheme: %w", err)
}