lukaszraczylo/jobs-manager-operator
1
0
Fork 0
mirror of https://github.com/lukaszraczylo/jobs-manager-operator.git synced 2026-10-14 05:47:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(controller): report Failed when a group fails

Browse Source 
checkOverallStatus overwrote the Failed status with Running. A failed workflow
stayed Running and kept requeueing. It now stays Failed and the failure event
fires once. Also remove err shadowing in the visualization client.
This commit is contained in:
lukaszraczylo
2026-10-02 03:59:44 +01:00
parent 5ebe8d8c72
commit bdfc781044
3 changed files with 15 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
controllers/crd_scrapper_test.go
+1 -4
View File
@@ -315,10 +315,7 @@ func (s *ScrapperTestSuite) TestCheckOverallStatus_GroupFailed() {
cp := s.newConnPackage(mj)
cp.checkOverallStatus()
// Note: Current implementation sets running status after checking failed
// This is the actual behavior - the status goes through the failed branch
// but then gets overwritten by the final else block
s.Equal(ExecutionStatusRunning, mj.Status)
s.Equal(ExecutionStatusFailed, mj.Status)
}
func (s *ScrapperTestSuite) TestCheckOverallStatus_GroupRunning() {