refactor(adapters): extract common helpers + fix kilo native schema

internal/adapters/claudecode/claudecode.go

@@ -6,6 +6,7 @@ import (
 	"path/filepath"
 
 	"github.com/lukaszraczylo/harness-sync/internal/adapter"
+	"github.com/lukaszraczylo/harness-sync/internal/adapter/common"
 	"github.com/lukaszraczylo/harness-sync/internal/canonical"
 	"github.com/lukaszraczylo/harness-sync/internal/render"
 )
@@ -89,28 +90,8 @@ func (a *Adapter) Render(b *canonical.Bundle) (*adapter.FileSet, error) {
 }
 
 func renderSettings(b *canonical.Bundle) ([]byte, error) {
-	mcp := map[string]any{}
-	for _, s := range b.MCP.Servers {
-		entry := map[string]any{}
-		if s.Command != "" {
-			entry["command"] = s.Command
-		}
-		if len(s.Args) > 0 {
-			entry["args"] = s.Args
-		}
-		if s.URL != "" {
-			entry["url"] = s.URL
-		}
-		if s.Transport != "" {
-			entry["transport"] = s.Transport
-		}
-		if len(s.Env) > 0 {
-			entry["env"] = s.Env
-		}
-		mcp[s.Name] = entry
-	}
 	return render.JSON(map[string]any{
-		"mcpServers": mcp,
+		"mcpServers": common.BuildMCPMap(&b.MCP),
 	})
 }
 

internal/adapters/claudecode/import.go

@@ -1,14 +1,10 @@
 package claudecode
 
 import (
-	"encoding/json"
-	"os"
 	"path/filepath"
-	"strings"
-
-	"gopkg.in/yaml.v3"
 
 	"github.com/lukaszraczylo/harness-sync/internal/adapter"
+	"github.com/lukaszraczylo/harness-sync/internal/adapter/common"
 	"github.com/lukaszraczylo/harness-sync/internal/canonical"
 )
 
@@ -16,158 +12,36 @@ func importFrom(home string) (*adapter.ImportResult, error) {
 	base := filepath.Join(home, ".claude")
 	res := &adapter.ImportResult{}
 
-	skills, err := importMarkdownTree(filepath.Join(base, "skills"), "SKILL.md")
+	skills, err := common.ImportMarkdownTree(filepath.Join(base, "skills"), "SKILL.md")
 	if err != nil {
 		return nil, err
 	}
 	for _, s := range skills {
 		res.Skills = append(res.Skills, canonical.Skill{
-			Name:        s.name,
-			Description: s.description,
-			Body:        s.body,
-			Path:        s.path,
+			Name: s.Name, Description: s.Description, Body: s.Body, Path: s.Path,
 		})
 	}
 
-	agents, err := importMarkdownTree(filepath.Join(base, "agents"), "")
+	agents, err := common.ImportMarkdownTree(filepath.Join(base, "agents"), "")
 	if err != nil {
 		return nil, err
 	}
 	for _, a := range agents {
 		res.Agents = append(res.Agents, canonical.Agent{
-			Name:        a.name,
-			Description: a.description,
-			Body:        a.body,
-			Path:        a.path,
+			Name: a.Name, Description: a.Description, Body: a.Body, Path: a.Path,
 		})
 	}
 
-	body, err := readIfExists(filepath.Join(base, "CLAUDE.md"))
+	body, err := common.ReadIfExists(filepath.Join(base, "CLAUDE.md"))
 	if err != nil {
 		return nil, err
 	}
 	res.Instructions = body
 
-	servers, err := importMCPFromSettings(filepath.Join(base, "settings.json"))
+	servers, err := common.ImportMCPFromJSONFile(filepath.Join(base, "settings.json"), "mcpServers")
 	if err != nil {
 		return nil, err
 	}
 	res.MCP = servers
 	return res, nil
 }
-
-type mdDoc struct {
-	name        string
-	description string
-	body        string
-	path        string
-}
-
-func importMarkdownTree(dir, requiredFilename string) ([]mdDoc, error) {
-	var docs []mdDoc
-	if !dirExists(dir) {
-		return docs, nil
-	}
-	err := filepath.Walk(dir, func(p string, info os.FileInfo, err error) error {
-		if err != nil {
-			return err
-		}
-		if info.IsDir() {
-			return nil
-		}
-		if requiredFilename != "" && filepath.Base(p) != requiredFilename {
-			return nil
-		}
-		if requiredFilename == "" && !strings.HasSuffix(p, ".md") {
-			return nil
-		}
-		body, err := os.ReadFile(p)
-		if err != nil {
-			return err
-		}
-		n, desc := parseFrontmatter(body)
-		if n == "" {
-			n = strings.TrimSuffix(filepath.Base(p), ".md")
-		}
-		rel, _ := filepath.Rel(dir, p)
-		docs = append(docs, mdDoc{
-			name:        n,
-			description: desc,
-			body:        string(body),
-			path:        rel,
-		})
-		return nil
-	})
-	return docs, err
-}
-
-type settingsServer struct { //nolint:govet // fieldalignment not achievable: map+slice+3 strings = 80 bytes regardless of order
-	Env       map[string]string `json:"env"`
-	Args      []string          `json:"args"`
-	Command   string            `json:"command"`
-	URL       string            `json:"url"`
-	Transport string            `json:"transport"`
-}
-
-type settingsFile struct {
-	MCPServers map[string]settingsServer `json:"mcpServers"`
-}
-
-func importMCPFromSettings(path string) ([]canonical.MCPServer, error) {
-	body, err := os.ReadFile(path)
-	if os.IsNotExist(err) {
-		return nil, nil
-	}
-	if err != nil {
-		return nil, err
-	}
-	var d settingsFile
-	if err := json.Unmarshal(body, &d); err != nil {
-		return nil, err
-	}
-	out := make([]canonical.MCPServer, 0, len(d.MCPServers))
-	for nm, v := range d.MCPServers {
-		out = append(out, canonical.MCPServer{
-			Name:      nm,
-			Command:   v.Command,
-			Args:      v.Args,
-			URL:       v.URL,
-			Transport: v.Transport,
-			Env:       v.Env,
-		})
-	}
-	return out, nil
-}
-
-func parseFrontmatter(b []byte) (n, description string) {
-	s := string(b)
-	if !strings.HasPrefix(s, "---\n") {
-		return "", ""
-	}
-	end := strings.Index(s[4:], "\n---")
-	if end == -1 {
-		return "", ""
-	}
-	var meta struct {
-		Name        string `yaml:"name"`
-		Description string `yaml:"description"`
-	}
-	_ = yaml.Unmarshal([]byte(s[4:4+end]), &meta)
-	return meta.Name, meta.Description
-}
-
-func readIfExists(path string) (string, error) {
-	b, err := os.ReadFile(path)
-	if os.IsNotExist(err) {
-		return "", nil
-	}
-	if err != nil {
-		return "", err
-	}
-	return string(b), nil
-}
-
-func dirExists(path string) bool {
-	info, err := os.Stat(path)
-	return err == nil && info.IsDir()
-}

internal/adapters/crush/crush.go

@@ -6,6 +6,7 @@ import (
 	"path/filepath"
 
 	"github.com/lukaszraczylo/harness-sync/internal/adapter"
+	"github.com/lukaszraczylo/harness-sync/internal/adapter/common"
 	"github.com/lukaszraczylo/harness-sync/internal/canonical"
 	"github.com/lukaszraczylo/harness-sync/internal/render"
 )
@@ -72,67 +73,11 @@ func (a *Adapter) Render(b *canonical.Bundle) (*adapter.FileSet, error) {
 }
 
 func renderConfig(b *canonical.Bundle) ([]byte, error) {
-	providers := make([]map[string]any, 0, len(b.Profile.Upstreams)+1)
-
-	// Gateway as primary provider.
-	if b.Profile.Gateway.URL != "" {
-		gw := map[string]any{
-			"id":       "harness-sync-gateway",
-			"name":     "harness-sync gateway",
-			"base_url": b.Profile.Gateway.URL,
-			"api_key":  b.Profile.Gateway.Token,
-		}
-		models := make([]map[string]any, 0, len(b.Profile.Models))
-		for _, m := range b.Profile.Models {
-			entry := map[string]any{"id": m.ID}
-			if m.Alias != "" {
-				entry["alias"] = m.Alias
-			}
-			models = append(models, entry)
-		}
-		if len(models) > 0 {
-			gw["models"] = models
-		}
-		providers = append(providers, gw)
-	}
-
-	for _, up := range b.Profile.Upstreams {
-		p := map[string]any{"id": up.Name, "name": up.Name}
-		if up.BaseURL != "" {
-			p["base_url"] = up.BaseURL
-		}
-		if up.APIKey != "" {
-			p["api_key"] = up.APIKey
-		}
-		providers = append(providers, p)
-	}
-
-	mcp := map[string]any{}
-	for _, s := range b.MCP.Servers {
-		entry := map[string]any{}
-		if s.Command != "" {
-			entry["command"] = s.Command
-		}
-		if len(s.Args) > 0 {
-			entry["args"] = s.Args
-		}
-		if s.URL != "" {
-			entry["url"] = s.URL
-		}
-		if s.Transport != "" {
-			entry["transport"] = s.Transport
-		}
-		if len(s.Env) > 0 {
-			entry["env"] = s.Env
-		}
-		mcp[s.Name] = entry
-	}
-
 	out := map[string]any{
-		"providers":     providers,
+		"providers":     common.BuildProviders(&b.Profile),
 		"default_model": b.Profile.Gateway.DefaultModel,
 	}
-	if len(mcp) > 0 {
+	if mcp := common.BuildMCPMap(&b.MCP); len(mcp) > 0 {
 		out["mcpServers"] = mcp
 	}
 	return render.JSON(out)

internal/adapters/crush/import.go

@@ -1,49 +1,17 @@
 package crush
 
 import (
-	"encoding/json"
-	"os"
 	"path/filepath"
 
 	"github.com/lukaszraczylo/harness-sync/internal/adapter"
-	"github.com/lukaszraczylo/harness-sync/internal/canonical"
+	"github.com/lukaszraczylo/harness-sync/internal/adapter/common"
 )
 
-type crushMCPEntry struct { //nolint:govet // fieldalignment: map+slice+3 strings irreducible
-	Env       map[string]string `json:"env"`
-	Args      []string          `json:"args"`
-	Command   string            `json:"command"`
-	URL       string            `json:"url"`
-	Transport string            `json:"transport"`
-}
-
-type crushConfig struct {
-	MCPServers map[string]crushMCPEntry `json:"mcpServers"`
-}
-
 func importFrom(home string) (*adapter.ImportResult, error) {
 	cfgPath := filepath.Join(home, ".config", "crush", "crush.json")
-	body, err := os.ReadFile(cfgPath)
-	if os.IsNotExist(err) {
-		return &adapter.ImportResult{}, nil
-	}
+	servers, err := common.ImportMCPFromJSONFile(cfgPath, "mcpServers")
 	if err != nil {
 		return nil, err
 	}
-
-	var doc crushConfig
-	_ = json.Unmarshal(body, &doc)
-
-	res := &adapter.ImportResult{}
-	for nm, v := range doc.MCPServers {
-		res.MCP = append(res.MCP, canonical.MCPServer{
-			Name:      nm,
-			Command:   v.Command,
-			Args:      v.Args,
-			URL:       v.URL,
-			Transport: v.Transport,
-			Env:       v.Env,
-		})
-	}
-	return res, nil
+	return &adapter.ImportResult{MCP: servers}, nil
 }

internal/adapters/kilo/import.go

@@ -1,46 +1,17 @@
 package kilo
 
 import (
-	"encoding/json"
-	"os"
 	"path/filepath"
 
 	"github.com/lukaszraczylo/harness-sync/internal/adapter"
-	"github.com/lukaszraczylo/harness-sync/internal/canonical"
+	"github.com/lukaszraczylo/harness-sync/internal/adapter/common"
 )
 
 func importFrom(home string) (*adapter.ImportResult, error) {
 	cfgPath := filepath.Join(home, ".config", "kilo", "kilo.json")
-	body, err := os.ReadFile(cfgPath)
-	if os.IsNotExist(err) {
-		return &adapter.ImportResult{}, nil
-	}
+	servers, err := common.ImportMCPFromJSONFile(cfgPath, "mcp")
 	if err != nil {
 		return nil, err
 	}
-
-	type mcpEntry struct { //nolint:govet // fieldalignment not achievable: map+slice+3 strings = 80 bytes regardless of order
-		Env       map[string]string `json:"env"`
-		Args      []string          `json:"args"`
-		Command   string            `json:"command"`
-		URL       string            `json:"url"`
-		Transport string            `json:"transport"`
-	}
-	var doc struct {
-		MCPServers map[string]mcpEntry `json:"mcpServers"`
-	}
-	_ = json.Unmarshal(body, &doc)
-
-	res := &adapter.ImportResult{}
-	for nm, v := range doc.MCPServers {
-		res.MCP = append(res.MCP, canonical.MCPServer{
-			Name:      nm,
-			Command:   v.Command,
-			Args:      v.Args,
-			URL:       v.URL,
-			Transport: v.Transport,
-			Env:       v.Env,
-		})
-	}
-	return res, nil
+	return &adapter.ImportResult{MCP: servers}, nil
 }

internal/adapters/kilo/kilo.go

@@ -6,6 +6,7 @@ import (
 	"path/filepath"
 
 	"github.com/lukaszraczylo/harness-sync/internal/adapter"
+	"github.com/lukaszraczylo/harness-sync/internal/adapter/common"
 	"github.com/lukaszraczylo/harness-sync/internal/canonical"
 	"github.com/lukaszraczylo/harness-sync/internal/render"
 )
@@ -74,65 +75,12 @@ func (a *Adapter) Render(b *canonical.Bundle) (*adapter.FileSet, error) {
 }
 
 func renderConfig(b *canonical.Bundle) ([]byte, error) {
-	providers := make([]map[string]any, 0)
-	if b.Profile.Gateway.URL != "" {
-		gw := map[string]any{
-			"id":       "harness-sync-gateway",
-			"name":     "harness-sync gateway",
-			"base_url": b.Profile.Gateway.URL,
-			"api_key":  b.Profile.Gateway.Token,
-		}
-		models := make([]map[string]any, 0, len(b.Profile.Models))
-		for _, m := range b.Profile.Models {
-			entry := map[string]any{"id": m.ID}
-			if m.Alias != "" {
-				entry["alias"] = m.Alias
-			}
-			models = append(models, entry)
-		}
-		if len(models) > 0 {
-			gw["models"] = models
-		}
-		providers = append(providers, gw)
-	}
-	for _, up := range b.Profile.Upstreams {
-		p := map[string]any{"id": up.Name, "name": up.Name}
-		if up.BaseURL != "" {
-			p["base_url"] = up.BaseURL
-		}
-		if up.APIKey != "" {
-			p["api_key"] = up.APIKey
-		}
-		providers = append(providers, p)
-	}
-
-	mcp := map[string]any{}
-	for _, s := range b.MCP.Servers {
-		entry := map[string]any{}
-		if s.Command != "" {
-			entry["command"] = s.Command
-		}
-		if len(s.Args) > 0 {
-			entry["args"] = s.Args
-		}
-		if s.URL != "" {
-			entry["url"] = s.URL
-		}
-		if s.Transport != "" {
-			entry["transport"] = s.Transport
-		}
-		if len(s.Env) > 0 {
-			entry["env"] = s.Env
-		}
-		mcp[s.Name] = entry
-	}
-
 	out := map[string]any{
-		"providers":     providers,
-		"default_model": b.Profile.Gateway.DefaultModel,
+		"model":     b.Profile.Gateway.DefaultModel,
+		"providers": common.BuildProviders(&b.Profile),
 	}
-	if len(mcp) > 0 {
-		out["mcpServers"] = mcp
+	if mcp := common.BuildMCPMap(&b.MCP); len(mcp) > 0 {
+		out["mcp"] = mcp
 	}
 	return render.JSON(out)
 }

internal/adapters/kilo/kilo_test.go

@@ -23,6 +23,9 @@ func TestKiloRender(t *testing.T) {
 			Gateway: canonical.Gateway{URL: "https://gw", Token: "dummy", DefaultModel: "sonnet"},
 			Models:  []canonical.Model{{ID: "claude-sonnet-4-6", Alias: "sonnet"}},
 		},
+		MCP: canonical.MCPRegistry{Servers: []canonical.MCPServer{
+			{Name: "filepuff", Command: "/bin/filepuff"},
+		}},
 	}
 	fs, err := ad.Render(b)
 	require.NoError(t, err)
@@ -39,6 +42,10 @@ func TestKiloRender(t *testing.T) {
 
 	var parsed map[string]any
 	require.NoError(t, json.Unmarshal(seen[cfgDest].Content, &parsed))
+	assert.Equal(t, "sonnet", parsed["model"])
+	assert.Contains(t, parsed, "mcp")
+	assert.NotContains(t, parsed, "default_model")
+	assert.NotContains(t, parsed, "mcpServers")
 }
 
 func TestKiloImport(t *testing.T) {

internal/adapters/opencode/import.go

@@ -1,75 +1,32 @@
 package opencode
 
 import (
-	"encoding/json"
-	"os"
 	"path/filepath"
-	"regexp"
-	"strings"
 
 	"github.com/lukaszraczylo/harness-sync/internal/adapter"
-	"github.com/lukaszraczylo/harness-sync/internal/canonical"
+	"github.com/lukaszraczylo/harness-sync/internal/adapter/common"
 )
 
 func importFrom(home string) (*adapter.ImportResult, error) {
 	base := filepath.Join(home, ".config", "opencode")
 	res := &adapter.ImportResult{}
 
-	cfgBody, err := readIfExists(filepath.Join(base, "opencode.jsonc"))
+	cfgBody, err := common.ReadIfExists(filepath.Join(base, "opencode.jsonc"))
 	if err != nil {
 		return nil, err
 	}
 	if cfgBody != "" {
-		clean := stripJSONComments(cfgBody)
-		var doc struct {
-			MCPServers map[string]struct { //nolint:govet // fieldalignment: map+slice+3 strings irreducible
-				Env       map[string]string `json:"env"`
-				Args      []string          `json:"args"`
-				Command   string            `json:"command"`
-				URL       string            `json:"url"`
-				Transport string            `json:"transport"`
-			} `json:"mcpServers"`
-		}
-		_ = json.Unmarshal([]byte(clean), &doc)
-		for nm, v := range doc.MCPServers {
-			res.MCP = append(res.MCP, canonical.MCPServer{
-				Name:      nm,
-				Command:   v.Command,
-				Args:      v.Args,
-				URL:       v.URL,
-				Transport: v.Transport,
-				Env:       v.Env,
-			})
+		mcpServers, mcpErr := common.ParseMCPFromJSON([]byte(cfgBody), "mcpServers")
+		if mcpErr != nil {
+			return nil, mcpErr
 		}
+		res.MCP = mcpServers
 	}
 
-	body, err := readIfExists(filepath.Join(base, "AGENTS.md"))
+	instructions, err := common.ReadIfExists(filepath.Join(base, "AGENTS.md"))
 	if err != nil {
 		return nil, err
 	}
-	res.Instructions = body
-
+	res.Instructions = instructions
 	return res, nil
 }
-
-var (
-	blockComment = regexp.MustCompile(`(?s)/\*.*?\*/`)
-	lineComment  = regexp.MustCompile(`(?m)//[^\n]*`)
-)
-
-func stripJSONComments(s string) string {
-	s = blockComment.ReplaceAllString(s, "")
-	s = lineComment.ReplaceAllString(s, "")
-	return strings.TrimSpace(s)
-}
-
-func readIfExists(path string) (string, error) {
-	b, err := os.ReadFile(path)
-	if os.IsNotExist(err) {
-		return "", nil
-	}
-	if err != nil {
-		return "", err
-	}
-	return string(b), nil
-}

internal/adapters/opencode/opencode.go

@@ -6,6 +6,7 @@ import (
 	"path/filepath"
 
 	"github.com/lukaszraczylo/harness-sync/internal/adapter"
+	"github.com/lukaszraczylo/harness-sync/internal/adapter/common"
 	"github.com/lukaszraczylo/harness-sync/internal/canonical"
 	"github.com/lukaszraczylo/harness-sync/internal/render"
 )
@@ -76,64 +77,11 @@ func (a *Adapter) Render(b *canonical.Bundle) (*adapter.FileSet, error) {
 }
 
 func renderConfig(b *canonical.Bundle) ([]byte, error) {
-	providers := make([]map[string]any, 0)
-	if b.Profile.Gateway.URL != "" {
-		gw := map[string]any{
-			"id":       "harness-sync-gateway",
-			"name":     "harness-sync gateway",
-			"base_url": b.Profile.Gateway.URL,
-			"api_key":  b.Profile.Gateway.Token,
-		}
-		models := make([]map[string]any, 0, len(b.Profile.Models))
-		for _, m := range b.Profile.Models {
-			entry := map[string]any{"id": m.ID}
-			if m.Alias != "" {
-				entry["alias"] = m.Alias
-			}
-			models = append(models, entry)
-		}
-		if len(models) > 0 {
-			gw["models"] = models
-		}
-		providers = append(providers, gw)
-	}
-	for _, up := range b.Profile.Upstreams {
-		p := map[string]any{"id": up.Name, "name": up.Name}
-		if up.BaseURL != "" {
-			p["base_url"] = up.BaseURL
-		}
-		if up.APIKey != "" {
-			p["api_key"] = up.APIKey
-		}
-		providers = append(providers, p)
-	}
-
-	mcp := map[string]any{}
-	for _, s := range b.MCP.Servers {
-		entry := map[string]any{}
-		if s.Command != "" {
-			entry["command"] = s.Command
-		}
-		if len(s.Args) > 0 {
-			entry["args"] = s.Args
-		}
-		if s.URL != "" {
-			entry["url"] = s.URL
-		}
-		if s.Transport != "" {
-			entry["transport"] = s.Transport
-		}
-		if len(s.Env) > 0 {
-			entry["env"] = s.Env
-		}
-		mcp[s.Name] = entry
-	}
-
 	out := map[string]any{
-		"providers":     providers,
+		"providers":     common.BuildProviders(&b.Profile),
 		"default_model": b.Profile.Gateway.DefaultModel,
 	}
-	if len(mcp) > 0 {
+	if mcp := common.BuildMCPMap(&b.MCP); len(mcp) > 0 {
 		out["mcpServers"] = mcp
 	}
 	return render.JSON(out)