From d4dd3636f3ebedf70cf9cb803e16b5b6529d039a Mon Sep 17 00:00:00 2001 From: Lukasz Raczylo Date: Thu, 30 Jan 2025 11:25:10 +0000 Subject: [PATCH] fixup! Staticheck fixes --- graphql_test.go | 22 +++++++--------------- proxy_test.go | 26 ++++++++++---------------- 2 files changed, 17 insertions(+), 31 deletions(-) diff --git a/graphql_test.go b/graphql_test.go index 8c50693..b78dd9a 100644 --- a/graphql_test.go +++ b/graphql_test.go @@ -282,23 +282,15 @@ func (suite *Tests) Test_parseGraphQLQuery() { suite.Run(tt.name, func() { cfg = &config{} parseConfig() - ctx_headers := func() *fasthttp.RequestHeader { - h := fasthttp.RequestHeader{} - for k, v := range tt.suppliedQuery.headers { - h.Add(k, v) - } - return &h - }() - - ctx_request := fasthttp.Request{ - Header: *ctx_headers, + ctx := suite.app.AcquireCtx(&fasthttp.RequestCtx{}) + + // Set headers + for k, v := range tt.suppliedQuery.headers { + ctx.Request().Header.Add(k, v) } - ctx_request.AppendBody([]byte(tt.suppliedQuery.body)) - - ctx := suite.app.AcquireCtx(&fasthttp.RequestCtx{ - Request: ctx_request, - }) + // Set body + ctx.Request().AppendBody([]byte(tt.suppliedQuery.body)) // defer func() { // cfg = &config{} diff --git a/proxy_test.go b/proxy_test.go index 53b5aed..aa2104e 100644 --- a/proxy_test.go +++ b/proxy_test.go @@ -87,23 +87,17 @@ func (suite *Tests) Test_proxyTheRequest() { cfg.Server.HostGraphQLReadOnly = tt.hostRO } - ctx_headers := func() *fasthttp.RequestHeader { - h := fasthttp.RequestHeader{} - for k, v := range tt.headers { - h.Add(k, v) - } - return &h - }() - - ctx_request := fasthttp.Request{ - Header: *ctx_headers, + ctx := suite.app.AcquireCtx(&fasthttp.RequestCtx{}) + + // Set headers + for k, v := range tt.headers { + ctx.Request().Header.Add(k, v) } - ctx_request.SetBody([]byte(tt.body)) - ctx_request.SetRequestURI(tt.path) - ctx_request.Header.SetMethod("POST") - ctx := suite.app.AcquireCtx(&fasthttp.RequestCtx{ - Request: ctx_request, - }) + + // Set body and other request properties + ctx.Request().SetBody([]byte(tt.body)) + ctx.Request().SetRequestURI(tt.path) + ctx.Request().Header.SetMethod("POST") res := parseGraphQLQuery(ctx) assert.NotNil(ctx, "Fiber context is nil", tt.name) err := proxyTheRequest(ctx, res.activeEndpoint)