lukaszraczylo/graphql-monitoring-proxy
1
0
Fork 0
mirror of https://github.com/lukaszraczylo/graphql-monitoring-proxy.git synced 2026-10-21 06:37:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(security,refactor): extract sanitization and improve code quality (#41)

Browse Source 
* chore(security,refactor): extract sanitization and improve code quality

- [x] Extract sanitization functions to dedicated sanitization.go module
- [x] Add comprehensive golangci-lint v2 configuration with security rules
- [x] Replace interface{} with any type throughout codebase
- [x] Add admin API authentication security warning
- [x] Extract WebSocket and stats streaming constants
- [x] Add best-effort error handling comments for resource cleanup
- [x] Expand sensitive field patterns for improved PII redaction
- [x] Simplify safety checks and remove redundant nil validations
- [x] Improve test coverage for password field redaction patterns

* refactor: replace interface{} with any type alias

- [x] Replace all `map[string]interface{}` with `map[string]any`
- [x] Replace all `interface{}` with `any` in function signatures and type definitions
- [x] Update sync.Pool New function returns from `interface{}` to `any`
- [x] Add package documentation comments to 8 package files
- [x] Update type assertions and casts to work with `any` type
This commit is contained in:
lukaszraczylo
2026-01-17 00:04:12 +00:00
committed by GitHub
parent caeae62236
commit 3aa83d4480
42 changed files with 815 additions and 618 deletions
Download Patch File Download Diff File Expand all files Collapse all files
admin_dashboard_test.go
+15 -15
View File
@@ -103,7 +103,7 @@ func TestAdminDashboard_GetStats(t *testing.T) {
assert.Equal(t, 200, resp.StatusCode)
// Parse response
var stats map[string]interface{}
var stats map[string]any
body, _ := io.ReadAll(resp.Body)
err = json.Unmarshal(body, &stats)
assert.NoError(t, err)
@@ -116,7 +116,7 @@ func TestAdminDashboard_GetStats(t *testing.T) {
assert.NotNil(t, stats["requests"])
// Verify request stats structure
requests := stats["requests"].(map[string]interface{})
requests := stats["requests"].(map[string]any)
assert.NotNil(t, requests["total"])
assert.NotNil(t, requests["succeeded"])
assert.NotNil(t, requests["failed"])
@@ -139,7 +139,7 @@ func TestAdminDashboard_GetHealth(t *testing.T) {
assert.Equal(t, 200, resp.StatusCode)
// Parse response
var health map[string]interface{}
var health map[string]any
body, _ := io.ReadAll(resp.Body)
err = json.Unmarshal(body, &health)
assert.NoError(t, err)
@@ -188,7 +188,7 @@ func TestAdminDashboard_GetCircuitBreakerStatus(t *testing.T) {
assert.Equal(t, 200, resp.StatusCode)
// Parse response
var status map[string]interface{}
var status map[string]any
body, _ := io.ReadAll(resp.Body)
err = json.Unmarshal(body, &status)
assert.NoError(t, err)
@@ -236,7 +236,7 @@ func TestAdminDashboard_GetCacheStats(t *testing.T) {
assert.Equal(t, 200, resp.StatusCode)
// Parse response
var stats map[string]interface{}
var stats map[string]any
body, _ := io.ReadAll(resp.Body)
err = json.Unmarshal(body, &stats)
assert.NoError(t, err)
@@ -260,7 +260,7 @@ func TestAdminDashboard_GetConnectionStats(t *testing.T) {
assert.Equal(t, 200, resp.StatusCode)
// Parse response
var stats map[string]interface{}
var stats map[string]any
body, _ := io.ReadAll(resp.Body)
err = json.Unmarshal(body, &stats)
assert.NoError(t, err)
@@ -283,7 +283,7 @@ func TestAdminDashboard_GetRetryBudgetStats(t *testing.T) {
assert.Equal(t, 200, resp.StatusCode)
// Parse response
var stats map[string]interface{}
var stats map[string]any
body, _ := io.ReadAll(resp.Body)
err = json.Unmarshal(body, &stats)
assert.NoError(t, err)
@@ -306,7 +306,7 @@ func TestAdminDashboard_GetCoalescingStats(t *testing.T) {
assert.Equal(t, 200, resp.StatusCode)
// Parse response
var stats map[string]interface{}
var stats map[string]any
body, _ := io.ReadAll(resp.Body)
err = json.Unmarshal(body, &stats)
assert.NoError(t, err)
@@ -329,7 +329,7 @@ func TestAdminDashboard_GetWebSocketStats(t *testing.T) {
assert.Equal(t, 200, resp.StatusCode)
// Parse response
var stats map[string]interface{}
var stats map[string]any
body, _ := io.ReadAll(resp.Body)
err = json.Unmarshal(body, &stats)
assert.NoError(t, err)
@@ -352,7 +352,7 @@ func TestAdminDashboard_ClearCache(t *testing.T) {
assert.Equal(t, 200, resp.StatusCode)
// Parse response
var result map[string]interface{}
var result map[string]any
body, _ := io.ReadAll(resp.Body)
err = json.Unmarshal(body, &result)
assert.NoError(t, err)
@@ -383,7 +383,7 @@ func TestAdminDashboard_ResetRetryBudget(t *testing.T) {
assert.Equal(t, 200, resp.StatusCode)
// Parse response
var result map[string]interface{}
var result map[string]any
body, _ := io.ReadAll(resp.Body)
err = json.Unmarshal(body, &result)
assert.NoError(t, err)
@@ -410,7 +410,7 @@ func TestAdminDashboard_ResetCoalescing(t *testing.T) {
assert.Equal(t, 200, resp.StatusCode)
// Parse response
var result map[string]interface{}
var result map[string]any
body, _ := io.ReadAll(resp.Body)
err = json.Unmarshal(body, &result)
assert.NoError(t, err)
@@ -475,7 +475,7 @@ func TestAdminDashboard_IntegrationWithFeatures(t *testing.T) {
assert.NoError(t, err)
assert.Equal(t, 200, resp.StatusCode)
var rbStats map[string]interface{}
var rbStats map[string]any
body, _ := io.ReadAll(resp.Body)
json.Unmarshal(body, &rbStats)
assert.Equal(t, true, rbStats["enabled"])
@@ -486,7 +486,7 @@ func TestAdminDashboard_IntegrationWithFeatures(t *testing.T) {
assert.NoError(t, err)
assert.Equal(t, 200, resp.StatusCode)
var coalStats map[string]interface{}
var coalStats map[string]any
body, _ = io.ReadAll(resp.Body)
json.Unmarshal(body, &coalStats)
assert.Equal(t, true, coalStats["enabled"])
@@ -497,7 +497,7 @@ func TestAdminDashboard_IntegrationWithFeatures(t *testing.T) {
assert.NoError(t, err)
assert.Equal(t, 200, resp.StatusCode)
var wsStats map[string]interface{}
var wsStats map[string]any
body, _ = io.ReadAll(resp.Body)
json.Unmarshal(body, &wsStats)
assert.Equal(t, true, wsStats["enabled"])