Gofmt the codebase.

This commit is contained in:
2025-02-26 00:47:41 +00:00
parent 66c8fef24d
commit 1b7890f322
20 changed files with 349 additions and 348 deletions
+12 -12
View File
@@ -30,10 +30,10 @@ func (suite *MonitoringAdditionalTestSuite) TestListActiveMetrics() {
// Register metrics directly to the set to ensure they're there
suite.ms.metrics_set_custom.GetOrCreateCounter("test_counter{label=\"value\"}")
suite.ms.metrics_set_custom.GetOrCreateGauge("test_gauge{label=\"value\"}", func() float64 { return 42.0 })
// Get list of metrics
metricsList := suite.ms.ListActiveMetrics()
// Verify metrics were registered - the metrics_set_custom doesn't get listed by ListActiveMetrics,
// so we'll just check that the function runs without error
assert.NotNil(suite.T(), metricsList, "Metrics list should not be nil")
@@ -46,10 +46,10 @@ func (suite *MonitoringAdditionalTestSuite) TestRegisterFloatCounter() {
"label1": "value1",
})
assert.NotNil(suite.T(), counter)
// Test using the counter
counter.Add(42.5)
// We don't need to test invalid metric names since they log a critical message
// which can cause the test to exit, and that's the expected behavior
}
@@ -61,7 +61,7 @@ func (suite *MonitoringAdditionalTestSuite) TestRegisterMetricsSummary() {
"label1": "value1",
})
assert.NotNil(suite.T(), summary)
// Test using the summary
summary.Update(42.5)
}
@@ -73,7 +73,7 @@ func (suite *MonitoringAdditionalTestSuite) TestRegisterMetricsHistogram() {
"label1": "value1",
})
assert.NotNil(suite.T(), histogram)
// Test using the histogram
histogram.Update(42.5)
}
@@ -85,11 +85,11 @@ func (suite *MonitoringAdditionalTestSuite) TestUpdateDuration() {
labels := map[string]string{
"label1": "value1",
}
// Use UpdateDuration
startTime := time.Now().Add(-time.Second) // 1 second ago
suite.ms.UpdateDuration(metricName, labels, startTime)
// Since we can't easily verify the duration was recorded correctly in a test,
// we'll just verify the method doesn't crash
}
@@ -99,15 +99,15 @@ func (suite *MonitoringAdditionalTestSuite) TestUpdateDuration() {
func (suite *MonitoringAdditionalTestSuite) TestPurgeMetrics() {
// Register a custom metric
suite.ms.RegisterMetricsCounter("test_purge_counter", nil)
// Purge the metrics
suite.ms.PurgeMetrics()
// Verify the custom metrics were purged
// We need to check the actual customSet instead of calling ListActiveMetrics
customMetrics := suite.ms.metrics_set_custom.ListMetricNames()
// The metrics might not be immediately cleared due to internal implementation details,
// so this test might be flaky. We'll check that it doesn't panic instead.
assert.NotNil(suite.T(), customMetrics, "Custom metrics list shouldn't be nil")
}
}
+31 -31
View File
@@ -23,11 +23,11 @@ func TestNewMonitoring(t *testing.T) {
func TestAddMetricsPrefix(t *testing.T) {
mon := NewMonitoring(&InitConfig{})
// Test adding prefix to a name
mon.AddMetricsPrefix("test")
assert.Equal(t, "test", mon.metrics_prefix)
// Test with empty prefix
mon.AddMetricsPrefix("")
assert.Equal(t, "", mon.metrics_prefix)
@@ -35,11 +35,11 @@ func TestAddMetricsPrefix(t *testing.T) {
func TestRegisterMetricsGauge(t *testing.T) {
mon := NewMonitoring(&InitConfig{})
// Test registering a gauge
gauge := mon.RegisterMetricsGauge("valid_gauge", map[string]string{"label1": "value1"}, 42.0)
assert.NotNil(t, gauge)
// Test with invalid metric name - we'll skip this test since it causes fatal errors
// gauge = mon.RegisterMetricsGauge("invalid metric name", map[string]string{"label1": "value1"}, 42.0)
// assert.Nil(t, gauge)
@@ -47,11 +47,11 @@ func TestRegisterMetricsGauge(t *testing.T) {
func TestRegisterMetricsCounter(t *testing.T) {
mon := NewMonitoring(&InitConfig{})
// Test registering a counter
counter := mon.RegisterMetricsCounter("valid_counter", map[string]string{"label1": "value1"})
assert.NotNil(t, counter)
// Test with default metrics
counter = mon.RegisterMetricsCounter(MetricsSucceeded, map[string]string{"label1": "value1"})
assert.NotNil(t, counter)
@@ -59,7 +59,7 @@ func TestRegisterMetricsCounter(t *testing.T) {
func TestRegisterFloatCounter(t *testing.T) {
mon := NewMonitoring(&InitConfig{})
// Test registering a float counter
counter := mon.RegisterFloatCounter("valid_float_counter", map[string]string{"label1": "value1"})
assert.NotNil(t, counter)
@@ -67,7 +67,7 @@ func TestRegisterFloatCounter(t *testing.T) {
func TestRegisterMetricsSummary(t *testing.T) {
mon := NewMonitoring(&InitConfig{})
// Test registering a summary
summary := mon.RegisterMetricsSummary("valid_summary", map[string]string{"label1": "value1"})
assert.NotNil(t, summary)
@@ -75,7 +75,7 @@ func TestRegisterMetricsSummary(t *testing.T) {
func TestRegisterMetricsHistogram(t *testing.T) {
mon := NewMonitoring(&InitConfig{})
// Test registering a histogram
histogram := mon.RegisterMetricsHistogram("valid_histogram", map[string]string{"label1": "value1"})
assert.NotNil(t, histogram)
@@ -83,59 +83,59 @@ func TestRegisterMetricsHistogram(t *testing.T) {
func TestIncrement(t *testing.T) {
mon := NewMonitoring(&InitConfig{})
// Test incrementing a counter
mon.Increment("increment_counter", map[string]string{"label1": "value1"})
// We can't easily verify the value was incremented in a test,
// but we can verify the function doesn't panic
}
func TestIncrementFloat(t *testing.T) {
mon := NewMonitoring(&InitConfig{})
// Test incrementing a float counter
mon.IncrementFloat("float_counter", map[string]string{"label1": "value1"}, 1.5)
}
func TestSet(t *testing.T) {
mon := NewMonitoring(&InitConfig{})
// Test setting a gauge
mon.Set("set_gauge", map[string]string{"label1": "value1"}, 42)
}
func TestUpdate(t *testing.T) {
mon := NewMonitoring(&InitConfig{})
// Test updating a histogram
mon.Update("update_histogram", map[string]string{"label1": "value1"}, 42.0)
}
func TestUpdateSummary(t *testing.T) {
mon := NewMonitoring(&InitConfig{})
// Test updating a summary
mon.UpdateSummary("update_summary", map[string]string{"label1": "value1"}, 42.0)
}
func TestRemoveMetrics(t *testing.T) {
mon := NewMonitoring(&InitConfig{})
// Register a metric first
mon.RegisterMetricsGauge("remove_gauge", map[string]string{"label1": "value1"}, 42.0)
// Test removing a metric
mon.RemoveMetrics("remove_gauge", map[string]string{"label1": "value1"})
}
func TestPurgeMetrics(t *testing.T) {
mon := NewMonitoring(&InitConfig{})
// Register some metrics first
mon.RegisterMetricsGauge("purge_gauge1", map[string]string{"label1": "value1"}, 42.0)
mon.RegisterMetricsGauge("purge_gauge2", map[string]string{"label1": "value1"}, 42.0)
// Test purging all metrics
mon.PurgeMetrics()
}
@@ -143,15 +143,15 @@ func TestPurgeMetrics(t *testing.T) {
func TestListActiveMetrics(t *testing.T) {
// Skip this test as it's causing issues with the metrics registry
t.Skip("Skipping test due to issues with metrics registry")
mon := NewMonitoring(&InitConfig{})
// Register some metrics first - use the default metrics set
mon.RegisterDefaultMetrics()
// Give some time for metrics to register
time.Sleep(100 * time.Millisecond)
// Test listing active metrics
metrics := mon.ListActiveMetrics()
assert.NotEmpty(t, metrics)
@@ -159,18 +159,18 @@ func TestListActiveMetrics(t *testing.T) {
func TestMetricsEndpoint(t *testing.T) {
mon := NewMonitoring(&InitConfig{})
// Register a metric
mon.RegisterMetricsGauge("endpoint_gauge", map[string]string{}, 42.0)
// Create a test Fiber app
app := fiber.New()
app.Get("/metrics", mon.metricsEndpoint)
// Create a test request
req := httptest.NewRequest(http.MethodGet, "/metrics", nil)
resp, err := app.Test(req)
// Verify the response
assert.NoError(t, err)
assert.Equal(t, http.StatusOK, resp.StatusCode)
@@ -178,10 +178,10 @@ func TestMetricsEndpoint(t *testing.T) {
func TestRegisterDefaultMetricsFunc(t *testing.T) {
mon := NewMonitoring(&InitConfig{})
// Test registering default metrics
mon.RegisterDefaultMetrics()
// We can't easily verify the metrics were registered in a test,
// but we can verify the function doesn't panic
assert.NotPanics(t, func() {
@@ -198,7 +198,7 @@ func TestHelperFunctions(t *testing.T) {
assert.True(t, is_allowed_rune(' '))
assert.False(t, is_allowed_rune('-'))
})
// Test is_special_rune
t.Run("is_special_rune", func(t *testing.T) {
assert.True(t, is_special_rune('_'))
@@ -211,4 +211,4 @@ func TestGetPodNameFunc(t *testing.T) {
// Test getting pod name
podName := getPodName()
assert.NotEmpty(t, podName)
}
}