feat(circuit): progressive backoff and configurable trip conditions

The circuit breaker ignored the trip-on-timeout, trip-on-4xx, and
trip-on-5xx flags and never cleared its counts, so the failure ratio
became lifetime-cumulative. The backoff-multiplier and max-backoff
settings did nothing. Circuit-open surfaced as HTTP 500.

Failure classification now honours the trip flags, the breaker uses a
rolling count window, and repeated trips extend the open state up to the
configured maximum. A helper maps circuit-open to HTTP 503. The request
body is copied once per request instead of once per retry. Defaults
reproduce the prior behaviour: the breaker is off by default and a
backoff multiplier of one keeps a constant open window.
This commit is contained in:
2026-08-14 11:10:37 +01:00
parent 6751346796
commit 10e51daab3
5 changed files with 1070 additions and 44 deletions
+60
View File
@@ -6,6 +6,7 @@ import (
"net/http"
"testing"
"github.com/sony/gobreaker"
"github.com/stretchr/testify/assert"
)
@@ -260,3 +261,62 @@ func Test_IsRetryable_GetStatusCode_Wrapped(t *testing.T) {
assert.False(t, IsRetryable(nil))
assert.Equal(t, 200, GetStatusCode(nil))
}
// Test_StatusCodeForError covers the C4 fix: circuit-open errors must map to
// 503 (previously fell through to a generic 500 because nothing mapped
// them), a wrapped *ProxyError's own status code must survive, and any
// other error defaults to 500. nil maps to 200.
func Test_StatusCodeForError(t *testing.T) {
tests := []struct {
name string
err error
wantStatus int
}{
{
name: "nil error maps to 200",
err: nil,
wantStatus: 200,
},
{
name: "circuit breaker open (proxy sentinel) maps to 503",
err: ErrCircuitOpen,
wantStatus: 503,
},
{
name: "circuit breaker open (gobreaker sentinel) maps to 503",
err: gobreaker.ErrOpenState,
wantStatus: 503,
},
{
name: "wrapped circuit breaker open still maps to 503",
err: fmt.Errorf("request failed: %w", ErrCircuitOpen),
wantStatus: 503,
},
{
name: "wrapped gobreaker open state still maps to 503",
err: fmt.Errorf("request failed: %w", gobreaker.ErrOpenState),
wantStatus: 503,
},
{
name: "generic error defaults to 500",
err: errors.New("boom"),
wantStatus: 500,
},
{
name: "ProxyError with explicit status code is honoured",
err: NewProxyError(ErrCodeRateLimited, "too many requests", http.StatusTooManyRequests, false),
wantStatus: http.StatusTooManyRequests,
},
{
name: "wrapped ProxyError status code survives wrapping",
err: fmt.Errorf("wrapped: %w", NewProxyError(ErrCodeBackendError, "boom", http.StatusBadGateway, true)),
wantStatus: http.StatusBadGateway,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
assert.Equal(t, tt.wantStatus, StatusCodeForError(tt.err))
})
}
}