Files
gohoarder/pkg/websocket/server.go
T
lukaszraczylo e39d6a0f0d feat: comprehensive audit + Tier 3 wiring (security/correctness/features)
Multi-agent audit + fix pass covering bugs, security, dead config wiring,
and missing features. All quality gates green: build/vet/test -race/govulncheck/
golangci-lint. Frontend tests 47/47.

SECURITY & CORRECTNESS

- Scanner pipeline fail-closed: cache.go scan timeout now 503 (was goto servePkg);
  scanner.go all-scanners-fail saves ScanStatusError; CheckVulnerabilities blocks
  on missing/error result instead of allowing.
- Scanner argv corrections: govulncheck source-mode + go.mod discovery;
  npm-audit generates lockfile via npm install --package-lock-only --ignore-scripts;
  pip-audit per-extension dispatch (wheel direct / sdist extract+pyproject).
- GHSA version-range filtering implemented (was always-include); url.QueryEscape
  on package name.
- pypi SSRF closed via host allowlist on original_url; url.QueryEscape on
  rewriteURL output.
- Path traversal: cache temp file uses os.CreateTemp; smb keyToPath sanitized;
  filesystem keyToPath returns error + filepath.Abs prefix-verify.
- Goroutine leaks plugged: cache.cleanupWorker stop channel; auth.ValidationCache
  Stop() with sync.Once; ws.unregister buffered with non-blocking send.
- WebSocket double-close panic fixed via sync.Once Client.closeSend().
- Race conditions: gormstore.registryCache sync.RWMutex (was concurrent map
  panic); auth.LastUsedAt no longer mutated under RLock; analytics strict
  lock-ordering invariant (statsMu before downloadsMu).
- Auth validator fails CLOSED on transport/unknown-status errors (was returning
  true,err 'allow cache fallback').
- Credential cache hash full SHA256 (was 8-byte truncate; eliminates 2^32
  collision risk).
- filesystem.fs.used incremented after successful rename (no quota inflation
  race).
- gormstore aggregation events deleted in same tx as insert (no double-counting).
- gormstore.SavePackage uses Updates(map) so zero-value security flags
  (RequiresAuth=false) can be cleared.
- partition_manager validates partition name regex before DROP TABLE.
- vcs/git: version regex validation rejects --option-injection; checkout uses
  --detach -- separator; removed TrimPrefix(repo,'v') that corrupted vault/
  vitess/vim-go.
- WebSocket CheckOrigin allowlist (was return true; CSWSH closed); same-origin
  default + ServerConfig.AllowedOrigins.
- fiber CVE GO-2026-4543 patched (v2.52.10 -> v2.52.12).

FUNCTIONAL FEATURES

- API key DB persistence: APIKeyModel + migration 202604280002, full CRUD,
  async LastUsedAt updates with WaitGroup-tracked goroutines drained on Close.
- Admin bootstrap via GOHOARDER_BOOTSTRAP_ADMIN_KEY env var; idempotent
  (skipped when non-revoked admin already exists).
- Auth middleware factory in pkg/app: RequireAuth, RequireRole, RequirePermission,
  OptionalAuth. Mounted on proxy + read APIs when Auth.Enabled=true.
  DELETE /api/packages/* requires admin role. /health public for k8s probes.
- NFS storage backend: pkg/storage/nfs wraps filesystem with /proc/mounts
  detection (Linux), post-write fsync, read-after-write health probe.
- WebSocket real-time pipeline: pkg/events Broadcaster interface; cache + scanner
  managers emit EventPackageCached / EventPackageDownloaded / EventScanComplete;
  app.go runs 30s EventStatsUpdate ticker. Frontend has full WS client (reconnect
  with exponential backoff 1s->30s, 25s heartbeat, subscriber pattern), Pinia
  realtime store, Dashboard live indicator + activity feed + reactive stats
  override.
- TLS termination: fiber.ListenTLS when Server.TLS.Enabled.
- Pre-warming: Prewarming.Enabled flag wired (was hardcoded false); Interval,
  MaxConcurrent, TopPackages plumbed.
- NetworkConfig wired (timeouts, retry, rate-limit, circuit-breaker).
- AuthConfig.BcryptCost wired.
- Security.Scanners.Static.MaxPackageSize plumbed to cache.io.LimitReader.
- Handlers.{Go,NPM,PyPI}.Enabled gates route mounting.
- Graceful shutdown: authManager.Close drains async writes.

LINT/HYGIENE

- 80 golangci-lint issues resolved: errcheck (Close/Write/RemoveAll wrapped),
  gofmt, gosec G104/G306, govet shadow renames + fieldalignment reorders,
  staticcheck ST1000 pkg comments + QF1003 tagged switches + QF1008 embedded
  field selectors + QF1001 De Morgan's law.

BEHAVIOR CHANGES

- Scanner now fail-closed: deployments without scanner binaries
  (trivy/govulncheck/npm-audit/pip-audit/grype) BLOCK packages instead of
  serving unscanned. Add binaries or plan a future allow-on-scan-error flag.
- WS origin defaults to same-origin; cross-origin dashboards must set
  server.allowed_origins.
- Validator no longer fails open; private packages won't serve from cache when
  validation can't be performed.
- download_events retention dropped from 24h to ~5min (deleted in agg tx).
  Migration 202604280001 purges pre-upgrade events.
- DELETE /api/packages/* requires admin role when auth enabled.

NEW PACKAGES

- pkg/events  - Broadcaster interface
- pkg/storage/nfs  - NFS-aware filesystem wrapper

DEFERRED (out of scope this pass)

- Static scanner implementation (config defines AllowedLicenses/MaxPackageSize/
  BlockSuspicious but pkg/scanner/static/ does not exist).
- AuthConfig.AuditLog wiring (no audit log infra yet).
- CacheConfig.TTLOverrides passthrough (would touch cache.Config beyond
  integrator scope).
2026-07-10 09:37:55 +01:00

428 lines
11 KiB
Go

// Package websocket implements the realtime event broadcasting server used
// by the dashboard frontend.
package websocket
import (
"context"
"encoding/json"
"net/http"
"sync"
"time"
"github.com/gorilla/websocket"
"github.com/rs/zerolog/log"
)
// EventType represents the type of event being broadcast
type EventType string
const (
EventPackageCached EventType = "package_cached"
EventPackageDeleted EventType = "package_deleted"
EventPackageDownloaded EventType = "package_downloaded"
EventScanComplete EventType = "scan_complete"
EventStatsUpdate EventType = "stats_update"
EventSystemAlert EventType = "system_alert"
)
// Event represents a WebSocket event message
type Event struct {
Timestamp time.Time `json:"timestamp"`
Data map[string]interface{} `json:"data"`
Type EventType `json:"type"`
}
// Client represents a WebSocket client connection
type Client struct {
conn *websocket.Conn
send chan []byte
server *Server
subscriptions map[EventType]bool
mu sync.RWMutex
closeOnce sync.Once
}
// closeSend safely closes the client's send channel exactly once.
// Safe to call concurrently from multiple goroutines (e.g. run loop
// unregister and shutdown closeAllClients).
func (c *Client) closeSend() {
c.closeOnce.Do(func() {
close(c.send)
})
}
// Server manages WebSocket connections and event broadcasting
type Server struct {
clients map[*Client]bool
broadcast chan Event
register chan *Client
unregister chan *Client
upgrader websocket.Upgrader
mu sync.RWMutex
}
// Config holds WebSocket server configuration
type Config struct {
CheckOrigin func(r *http.Request) bool
ReadBufferSize int
WriteBufferSize int
}
// NewServer creates a new WebSocket server
func NewServer(cfg Config) *Server {
if cfg.CheckOrigin == nil {
cfg.CheckOrigin = func(r *http.Request) bool {
return true // Allow all origins by default
}
}
server := &Server{
clients: make(map[*Client]bool),
broadcast: make(chan Event, 256),
register: make(chan *Client),
unregister: make(chan *Client, 256),
upgrader: websocket.Upgrader{
ReadBufferSize: cfg.ReadBufferSize,
WriteBufferSize: cfg.WriteBufferSize,
CheckOrigin: cfg.CheckOrigin,
},
}
return server
}
// Start starts the WebSocket server event loop
func (s *Server) Start(ctx context.Context) {
go s.run(ctx)
log.Info().Msg("WebSocket server started")
}
// run handles client registration/unregistration and broadcasting
func (s *Server) run(ctx context.Context) {
ticker := time.NewTicker(30 * time.Second)
defer ticker.Stop()
for {
select {
case <-ctx.Done():
log.Info().Msg("WebSocket server shutting down")
s.closeAllClients()
return
case client := <-s.register:
s.mu.Lock()
s.clients[client] = true
s.mu.Unlock()
log.Debug().
Int("total_clients", len(s.clients)).
Msg("Client registered")
case client := <-s.unregister:
s.mu.Lock()
if _, ok := s.clients[client]; ok {
delete(s.clients, client)
client.closeSend()
}
s.mu.Unlock()
log.Debug().
Int("total_clients", len(s.clients)).
Msg("Client unregistered")
case event := <-s.broadcast:
s.broadcastEvent(event)
case <-ticker.C:
// Ping all clients to keep connections alive
s.pingClients()
}
}
}
// broadcastEvent sends an event to all subscribed clients
func (s *Server) broadcastEvent(event Event) {
message, err := json.Marshal(event)
if err != nil {
log.Error().Err(err).Msg("Failed to marshal event")
return
}
s.mu.RLock()
defer s.mu.RUnlock()
for client := range s.clients {
// Check if client is subscribed to this event type
client.mu.RLock()
subscribed := len(client.subscriptions) == 0 || client.subscriptions[event.Type]
client.mu.RUnlock()
if subscribed {
select {
case client.send <- message:
default:
// Client send buffer full - schedule unregister.
// Non-blocking send; unregister chan is buffered, so we
// avoid spawning goroutines that pile up under a stuck
// run() consumer. If the buffer is full the client will
// be cleaned up on its next failed write/ping.
select {
case s.unregister <- client:
default:
}
}
}
}
log.Debug().
Str("event_type", string(event.Type)).
Int("clients_notified", len(s.clients)).
Msg("Event broadcast")
}
// pingClients sends ping messages to all connected clients
func (s *Server) pingClients() {
s.mu.RLock()
defer s.mu.RUnlock()
for client := range s.clients {
if err := client.conn.WriteControl(
websocket.PingMessage,
[]byte{},
time.Now().Add(10*time.Second),
); err != nil {
log.Debug().Err(err).Msg("Failed to ping client")
// Non-blocking send; see broadcastEvent for rationale.
select {
case s.unregister <- client:
default:
}
}
}
}
// closeAllClients closes all client connections
func (s *Server) closeAllClients() {
s.mu.Lock()
defer s.mu.Unlock()
for client := range s.clients {
_ = client.conn.Close() // #nosec G104 -- Cleanup, error not critical
client.closeSend()
}
s.clients = make(map[*Client]bool)
}
// Broadcast sends an event to all connected clients
func (s *Server) Broadcast(eventType EventType, data map[string]interface{}) {
event := Event{
Type: eventType,
Timestamp: time.Now(),
Data: data,
}
select {
case s.broadcast <- event:
default:
log.Warn().Msg("Broadcast channel full - dropping event")
}
}
// BroadcastEvent satisfies the events.Broadcaster contract used by
// cache/scanner sub-systems. It accepts a string event type and an
// arbitrary payload (typically map[string]any) and forwards to the
// typed Broadcast path.
//
// Non-blocking: enqueues onto the broadcast channel and drops the
// event if the channel is full. Safe for concurrent use.
func (s *Server) BroadcastEvent(eventType string, payload any) {
var data map[string]interface{}
switch p := payload.(type) {
case map[string]interface{}:
data = p
case nil:
data = map[string]interface{}{}
default:
// Wrap unknown payloads so the wire format stays consistent.
// Sub-systems are expected to pass map[string]any; this branch
// is defensive only.
log.Warn().
Str("event_type", eventType).
Msg("BroadcastEvent received non-map payload; wrapping under 'payload' key")
data = map[string]interface{}{"payload": payload}
}
s.Broadcast(EventType(eventType), data)
}
// HandleWebSocket upgrades HTTP connection to WebSocket
func (s *Server) HandleWebSocket(w http.ResponseWriter, r *http.Request) {
conn, err := s.upgrader.Upgrade(w, r, nil)
if err != nil {
log.Error().Err(err).Msg("Failed to upgrade connection")
return
}
client := &Client{
conn: conn,
send: make(chan []byte, 256),
server: s,
subscriptions: make(map[EventType]bool),
}
s.register <- client
// Start goroutines for reading and writing
go client.readPump()
go client.writePump()
log.Info().
Str("remote_addr", r.RemoteAddr).
Msg("WebSocket connection established")
}
// readPump handles incoming messages from the client
func (c *Client) readPump() {
defer func() {
c.server.unregister <- c
_ = c.conn.Close() // #nosec G104 -- Cleanup, error not critical
}()
_ = c.conn.SetReadDeadline(time.Now().Add(60 * time.Second)) // #nosec G104 -- Websocket deadline
c.conn.SetPongHandler(func(string) error { // #nosec G104 -- Websocket handler
_ = c.conn.SetReadDeadline(time.Now().Add(60 * time.Second)) // #nosec G104 -- Websocket deadline
return nil
})
for {
_, message, err := c.conn.ReadMessage()
if err != nil {
if websocket.IsUnexpectedCloseError(err, websocket.CloseGoingAway, websocket.CloseAbnormalClosure) {
log.Error().Err(err).Msg("WebSocket read error")
}
break
}
// Handle client messages (subscriptions, etc.)
c.handleMessage(message)
}
}
// writePump handles outgoing messages to the client
func (c *Client) writePump() {
ticker := time.NewTicker(54 * time.Second)
defer func() {
ticker.Stop()
_ = c.conn.Close() // #nosec G104 -- Cleanup, error not critical
}()
for {
select {
case message, ok := <-c.send:
_ = c.conn.SetWriteDeadline(time.Now().Add(10 * time.Second)) // #nosec G104 -- Websocket deadline, error not critical
if !ok {
// Channel closed
_ = c.conn.WriteMessage(websocket.CloseMessage, []byte{}) // #nosec G104 -- Websocket write
return
}
w, err := c.conn.NextWriter(websocket.TextMessage)
if err != nil {
return
}
_, _ = w.Write(message) // #nosec G104 -- Websocket buffer write
// Write any additional queued messages
n := len(c.send)
for i := 0; i < n; i++ {
_, _ = w.Write([]byte{'\n'}) // #nosec G104 -- Websocket buffer write
_, _ = w.Write(<-c.send) // #nosec G104 -- Websocket buffer write
}
if err := w.Close(); err != nil {
return
}
case <-ticker.C:
_ = c.conn.SetWriteDeadline(time.Now().Add(10 * time.Second)) // #nosec G104 -- Websocket deadline, error not critical
if err := c.conn.WriteMessage(websocket.PingMessage, nil); err != nil {
return
}
}
}
}
// handleMessage processes incoming client messages
func (c *Client) handleMessage(message []byte) {
var msg struct {
Data interface{} `json:"data"`
Action string `json:"action"`
}
if err := json.Unmarshal(message, &msg); err != nil {
log.Error().Err(err).Msg("Failed to unmarshal client message")
return
}
switch msg.Action {
case "subscribe":
c.handleSubscribe(msg.Data)
case "unsubscribe":
c.handleUnsubscribe(msg.Data)
case "ping":
c.sendPong()
default:
log.Warn().Str("action", msg.Action).Msg("Unknown client action")
}
}
// handleSubscribe subscribes the client to specific event types
func (c *Client) handleSubscribe(data interface{}) {
eventTypes, ok := data.([]interface{})
if !ok {
log.Error().Msg("Invalid subscribe data format")
return
}
c.mu.Lock()
defer c.mu.Unlock()
for _, et := range eventTypes {
if eventType, ok := et.(string); ok {
c.subscriptions[EventType(eventType)] = true
log.Debug().
Str("event_type", eventType).
Msg("Client subscribed to event type")
}
}
}
// handleUnsubscribe unsubscribes the client from specific event types
func (c *Client) handleUnsubscribe(data interface{}) {
eventTypes, ok := data.([]interface{})
if !ok {
log.Error().Msg("Invalid unsubscribe data format")
return
}
c.mu.Lock()
defer c.mu.Unlock()
for _, et := range eventTypes {
if eventType, ok := et.(string); ok {
delete(c.subscriptions, EventType(eventType))
log.Debug().
Str("event_type", eventType).
Msg("Client unsubscribed from event type")
}
}
}
// sendPong sends a pong response to the client
func (c *Client) sendPong() {
response := map[string]string{"type": "pong"}
message, _ := json.Marshal(response)
select {
case c.send <- message:
default:
}
}