mirror of
https://github.com/lukaszraczylo/gohoarder.git
synced 2026-07-14 05:06:14 +00:00
e39d6a0f0d
Multi-agent audit + fix pass covering bugs, security, dead config wiring,
and missing features. All quality gates green: build/vet/test -race/govulncheck/
golangci-lint. Frontend tests 47/47.
SECURITY & CORRECTNESS
- Scanner pipeline fail-closed: cache.go scan timeout now 503 (was goto servePkg);
scanner.go all-scanners-fail saves ScanStatusError; CheckVulnerabilities blocks
on missing/error result instead of allowing.
- Scanner argv corrections: govulncheck source-mode + go.mod discovery;
npm-audit generates lockfile via npm install --package-lock-only --ignore-scripts;
pip-audit per-extension dispatch (wheel direct / sdist extract+pyproject).
- GHSA version-range filtering implemented (was always-include); url.QueryEscape
on package name.
- pypi SSRF closed via host allowlist on original_url; url.QueryEscape on
rewriteURL output.
- Path traversal: cache temp file uses os.CreateTemp; smb keyToPath sanitized;
filesystem keyToPath returns error + filepath.Abs prefix-verify.
- Goroutine leaks plugged: cache.cleanupWorker stop channel; auth.ValidationCache
Stop() with sync.Once; ws.unregister buffered with non-blocking send.
- WebSocket double-close panic fixed via sync.Once Client.closeSend().
- Race conditions: gormstore.registryCache sync.RWMutex (was concurrent map
panic); auth.LastUsedAt no longer mutated under RLock; analytics strict
lock-ordering invariant (statsMu before downloadsMu).
- Auth validator fails CLOSED on transport/unknown-status errors (was returning
true,err 'allow cache fallback').
- Credential cache hash full SHA256 (was 8-byte truncate; eliminates 2^32
collision risk).
- filesystem.fs.used incremented after successful rename (no quota inflation
race).
- gormstore aggregation events deleted in same tx as insert (no double-counting).
- gormstore.SavePackage uses Updates(map) so zero-value security flags
(RequiresAuth=false) can be cleared.
- partition_manager validates partition name regex before DROP TABLE.
- vcs/git: version regex validation rejects --option-injection; checkout uses
--detach -- separator; removed TrimPrefix(repo,'v') that corrupted vault/
vitess/vim-go.
- WebSocket CheckOrigin allowlist (was return true; CSWSH closed); same-origin
default + ServerConfig.AllowedOrigins.
- fiber CVE GO-2026-4543 patched (v2.52.10 -> v2.52.12).
FUNCTIONAL FEATURES
- API key DB persistence: APIKeyModel + migration 202604280002, full CRUD,
async LastUsedAt updates with WaitGroup-tracked goroutines drained on Close.
- Admin bootstrap via GOHOARDER_BOOTSTRAP_ADMIN_KEY env var; idempotent
(skipped when non-revoked admin already exists).
- Auth middleware factory in pkg/app: RequireAuth, RequireRole, RequirePermission,
OptionalAuth. Mounted on proxy + read APIs when Auth.Enabled=true.
DELETE /api/packages/* requires admin role. /health public for k8s probes.
- NFS storage backend: pkg/storage/nfs wraps filesystem with /proc/mounts
detection (Linux), post-write fsync, read-after-write health probe.
- WebSocket real-time pipeline: pkg/events Broadcaster interface; cache + scanner
managers emit EventPackageCached / EventPackageDownloaded / EventScanComplete;
app.go runs 30s EventStatsUpdate ticker. Frontend has full WS client (reconnect
with exponential backoff 1s->30s, 25s heartbeat, subscriber pattern), Pinia
realtime store, Dashboard live indicator + activity feed + reactive stats
override.
- TLS termination: fiber.ListenTLS when Server.TLS.Enabled.
- Pre-warming: Prewarming.Enabled flag wired (was hardcoded false); Interval,
MaxConcurrent, TopPackages plumbed.
- NetworkConfig wired (timeouts, retry, rate-limit, circuit-breaker).
- AuthConfig.BcryptCost wired.
- Security.Scanners.Static.MaxPackageSize plumbed to cache.io.LimitReader.
- Handlers.{Go,NPM,PyPI}.Enabled gates route mounting.
- Graceful shutdown: authManager.Close drains async writes.
LINT/HYGIENE
- 80 golangci-lint issues resolved: errcheck (Close/Write/RemoveAll wrapped),
gofmt, gosec G104/G306, govet shadow renames + fieldalignment reorders,
staticcheck ST1000 pkg comments + QF1003 tagged switches + QF1008 embedded
field selectors + QF1001 De Morgan's law.
BEHAVIOR CHANGES
- Scanner now fail-closed: deployments without scanner binaries
(trivy/govulncheck/npm-audit/pip-audit/grype) BLOCK packages instead of
serving unscanned. Add binaries or plan a future allow-on-scan-error flag.
- WS origin defaults to same-origin; cross-origin dashboards must set
server.allowed_origins.
- Validator no longer fails open; private packages won't serve from cache when
validation can't be performed.
- download_events retention dropped from 24h to ~5min (deleted in agg tx).
Migration 202604280001 purges pre-upgrade events.
- DELETE /api/packages/* requires admin role when auth enabled.
NEW PACKAGES
- pkg/events - Broadcaster interface
- pkg/storage/nfs - NFS-aware filesystem wrapper
DEFERRED (out of scope this pass)
- Static scanner implementation (config defines AllowedLicenses/MaxPackageSize/
BlockSuspicious but pkg/scanner/static/ does not exist).
- AuthConfig.AuditLog wiring (no audit log infra yet).
- CacheConfig.TTLOverrides passthrough (would touch cache.Config beyond
integrator scope).
246 lines
7.2 KiB
Go
246 lines
7.2 KiB
Go
// Package trivy wraps the Aqua Security `trivy` CLI to scan packages for
|
|
// known vulnerabilities and license issues.
|
|
package trivy
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"os"
|
|
"os/exec"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/lukaszraczylo/gohoarder/pkg/config"
|
|
"github.com/lukaszraczylo/gohoarder/pkg/metadata"
|
|
"github.com/lukaszraczylo/gohoarder/pkg/uuid"
|
|
"github.com/rs/zerolog/log"
|
|
)
|
|
|
|
// ScannerName is the name of this scanner
|
|
const ScannerName = "trivy"
|
|
|
|
// Scanner implements the Scanner interface using Trivy
|
|
type Scanner struct {
|
|
config config.TrivyConfig
|
|
}
|
|
|
|
// TrivyResult represents Trivy JSON output structure
|
|
type TrivyResult struct {
|
|
Metadata TrivyMetadata `json:"Metadata"`
|
|
ArtifactName string `json:"ArtifactName"`
|
|
ArtifactType string `json:"ArtifactType"`
|
|
Results []TrivyVulnResult `json:"Results"`
|
|
SchemaVersion int `json:"SchemaVersion"`
|
|
}
|
|
|
|
type TrivyMetadata struct {
|
|
OS *TrivyOS `json:"OS,omitempty"`
|
|
ImageConfig *TrivyImageConfig `json:"ImageConfig,omitempty"`
|
|
RepoTags []string `json:"RepoTags,omitempty"`
|
|
RepoDigests []string `json:"RepoDigests,omitempty"`
|
|
}
|
|
|
|
type TrivyOS struct {
|
|
Family string `json:"Family"`
|
|
Name string `json:"Name"`
|
|
}
|
|
|
|
type TrivyImageConfig struct {
|
|
Architecture string `json:"architecture"`
|
|
Created string `json:"created"`
|
|
}
|
|
|
|
type TrivyVulnResult struct {
|
|
Target string `json:"Target"`
|
|
Class string `json:"Class"`
|
|
Type string `json:"Type"`
|
|
Vulnerabilities []TrivyVulnerability `json:"Vulnerabilities"`
|
|
}
|
|
|
|
type TrivyVulnerability struct {
|
|
VulnerabilityID string `json:"VulnerabilityID"`
|
|
PkgName string `json:"PkgName"`
|
|
InstalledVersion string `json:"InstalledVersion"`
|
|
FixedVersion string `json:"FixedVersion"`
|
|
Severity string `json:"Severity"`
|
|
Title string `json:"Title"`
|
|
Description string `json:"Description"`
|
|
PrimaryURL string `json:"PrimaryURL"`
|
|
References []string `json:"References"`
|
|
}
|
|
|
|
// New creates a new Trivy scanner
|
|
func New(cfg config.TrivyConfig) *Scanner {
|
|
return &Scanner{
|
|
config: cfg,
|
|
}
|
|
}
|
|
|
|
// Name returns the scanner name
|
|
func (s *Scanner) Name() string {
|
|
return ScannerName
|
|
}
|
|
|
|
// UpdateDatabase updates Trivy's vulnerability database
|
|
func (s *Scanner) UpdateDatabase(ctx context.Context) error {
|
|
log.Info().Msg("Updating Trivy vulnerability database")
|
|
|
|
cmd := exec.CommandContext(ctx, "trivy", "image", "--download-db-only")
|
|
if s.config.CacheDB != "" {
|
|
cmd.Env = append(os.Environ(), fmt.Sprintf("TRIVY_CACHE_DIR=%s", s.config.CacheDB))
|
|
}
|
|
|
|
output, err := cmd.CombinedOutput()
|
|
if err != nil {
|
|
return fmt.Errorf("failed to update Trivy database: %w (output: %s)", err, string(output))
|
|
}
|
|
|
|
log.Info().Msg("Trivy vulnerability database updated successfully")
|
|
return nil
|
|
}
|
|
|
|
// Scan scans a package for vulnerabilities using Trivy
|
|
func (s *Scanner) Scan(ctx context.Context, registry, packageName, version string, filePath string) (*metadata.ScanResult, error) {
|
|
// Set timeout
|
|
if s.config.Timeout > 0 {
|
|
var cancel context.CancelFunc
|
|
ctx, cancel = context.WithTimeout(ctx, s.config.Timeout)
|
|
defer cancel()
|
|
}
|
|
|
|
// Determine scan type based on registry
|
|
scanType := s.determineScanType(registry, filePath)
|
|
|
|
// Build Trivy command
|
|
args := []string{
|
|
scanType,
|
|
"--format", "json",
|
|
"--quiet",
|
|
filePath,
|
|
}
|
|
|
|
cmd := exec.CommandContext(ctx, "trivy", args...) // #nosec G204 -- trivy command with controlled arguments
|
|
|
|
// Set cache directory if configured
|
|
if s.config.CacheDB != "" {
|
|
cmd.Env = append(os.Environ(), fmt.Sprintf("TRIVY_CACHE_DIR=%s", s.config.CacheDB))
|
|
}
|
|
|
|
// Execute scan
|
|
output, err := cmd.Output()
|
|
if err != nil {
|
|
// Check if it's a timeout
|
|
if ctx.Err() == context.DeadlineExceeded {
|
|
return &metadata.ScanResult{
|
|
ID: uuid.New().String(),
|
|
Registry: registry,
|
|
PackageName: packageName,
|
|
PackageVersion: version,
|
|
Scanner: s.Name(),
|
|
ScannedAt: time.Now(),
|
|
Status: metadata.ScanStatusError,
|
|
Details: map[string]interface{}{
|
|
"error": "scan timeout",
|
|
},
|
|
}, nil
|
|
}
|
|
|
|
return nil, fmt.Errorf("trivy scan failed: %w", err)
|
|
}
|
|
|
|
// Parse Trivy output
|
|
var trivyResult TrivyResult
|
|
if err := json.Unmarshal(output, &trivyResult); err != nil {
|
|
return nil, fmt.Errorf("failed to parse Trivy output: %w", err)
|
|
}
|
|
|
|
// Convert to metadata.ScanResult
|
|
return s.convertTrivyResult(&trivyResult, registry, packageName, version), nil
|
|
}
|
|
|
|
// determineScanType determines the appropriate Trivy scan type
|
|
func (s *Scanner) determineScanType(registry, filePath string) string {
|
|
// For now, use filesystem scan for packages
|
|
// Container image scanning would need different handling
|
|
ext := strings.ToLower(filePath[strings.LastIndex(filePath, ".")+1:])
|
|
|
|
switch registry {
|
|
case "npm":
|
|
return "fs" // Filesystem scan for npm packages
|
|
case "pypi":
|
|
return "fs" // Filesystem scan for Python packages
|
|
case "go":
|
|
return "fs" // Filesystem scan for Go modules
|
|
default:
|
|
// Check file extension
|
|
if ext == "tar" || ext == "tgz" || ext == "gz" {
|
|
return "fs"
|
|
}
|
|
return "fs"
|
|
}
|
|
}
|
|
|
|
// convertTrivyResult converts Trivy result to metadata.ScanResult
|
|
func (s *Scanner) convertTrivyResult(trivyResult *TrivyResult, registry, packageName, version string) *metadata.ScanResult {
|
|
vulnerabilities := make([]metadata.Vulnerability, 0)
|
|
severityCounts := make(map[string]int)
|
|
|
|
// Aggregate all vulnerabilities from all results
|
|
for _, result := range trivyResult.Results {
|
|
for _, vuln := range result.Vulnerabilities {
|
|
// Normalize severity to standard values (CRITICAL, HIGH, MODERATE, LOW)
|
|
normalizedSeverity := metadata.NormalizeSeverity(vuln.Severity)
|
|
|
|
// Count by severity
|
|
severityCounts[normalizedSeverity]++
|
|
|
|
// Add to vulnerabilities list
|
|
vulnerabilities = append(vulnerabilities, metadata.Vulnerability{
|
|
ID: vuln.VulnerabilityID,
|
|
Severity: normalizedSeverity,
|
|
Title: vuln.Title,
|
|
Description: vuln.Description,
|
|
References: vuln.References,
|
|
FixedIn: vuln.FixedVersion,
|
|
})
|
|
}
|
|
}
|
|
|
|
// Determine overall status
|
|
status := metadata.ScanStatusClean
|
|
if len(vulnerabilities) > 0 {
|
|
status = metadata.ScanStatusVulnerable
|
|
}
|
|
|
|
return &metadata.ScanResult{
|
|
ID: uuid.New().String(),
|
|
Registry: registry,
|
|
PackageName: packageName,
|
|
PackageVersion: version,
|
|
Scanner: s.Name(),
|
|
ScannedAt: time.Now(),
|
|
Status: status,
|
|
VulnerabilityCount: len(vulnerabilities),
|
|
Vulnerabilities: vulnerabilities,
|
|
Details: map[string]interface{}{
|
|
"artifact_name": trivyResult.ArtifactName,
|
|
"artifact_type": trivyResult.ArtifactType,
|
|
"severity_counts": severityCounts,
|
|
},
|
|
}
|
|
}
|
|
|
|
// Health checks if Trivy is available and working
|
|
func (s *Scanner) Health(ctx context.Context) error {
|
|
// Check if trivy command exists
|
|
cmd := exec.CommandContext(ctx, "trivy", "--version")
|
|
output, err := cmd.CombinedOutput()
|
|
if err != nil {
|
|
return fmt.Errorf("trivy not available: %w (output: %s)", err, string(output))
|
|
}
|
|
|
|
log.Debug().Str("version", strings.TrimSpace(string(output))).Msg("Trivy health check passed")
|
|
return nil
|
|
}
|