mirror of
https://github.com/lukaszraczylo/gohoarder.git
synced 2026-07-12 04:50:45 +00:00
e39d6a0f0d
Multi-agent audit + fix pass covering bugs, security, dead config wiring,
and missing features. All quality gates green: build/vet/test -race/govulncheck/
golangci-lint. Frontend tests 47/47.
SECURITY & CORRECTNESS
- Scanner pipeline fail-closed: cache.go scan timeout now 503 (was goto servePkg);
scanner.go all-scanners-fail saves ScanStatusError; CheckVulnerabilities blocks
on missing/error result instead of allowing.
- Scanner argv corrections: govulncheck source-mode + go.mod discovery;
npm-audit generates lockfile via npm install --package-lock-only --ignore-scripts;
pip-audit per-extension dispatch (wheel direct / sdist extract+pyproject).
- GHSA version-range filtering implemented (was always-include); url.QueryEscape
on package name.
- pypi SSRF closed via host allowlist on original_url; url.QueryEscape on
rewriteURL output.
- Path traversal: cache temp file uses os.CreateTemp; smb keyToPath sanitized;
filesystem keyToPath returns error + filepath.Abs prefix-verify.
- Goroutine leaks plugged: cache.cleanupWorker stop channel; auth.ValidationCache
Stop() with sync.Once; ws.unregister buffered with non-blocking send.
- WebSocket double-close panic fixed via sync.Once Client.closeSend().
- Race conditions: gormstore.registryCache sync.RWMutex (was concurrent map
panic); auth.LastUsedAt no longer mutated under RLock; analytics strict
lock-ordering invariant (statsMu before downloadsMu).
- Auth validator fails CLOSED on transport/unknown-status errors (was returning
true,err 'allow cache fallback').
- Credential cache hash full SHA256 (was 8-byte truncate; eliminates 2^32
collision risk).
- filesystem.fs.used incremented after successful rename (no quota inflation
race).
- gormstore aggregation events deleted in same tx as insert (no double-counting).
- gormstore.SavePackage uses Updates(map) so zero-value security flags
(RequiresAuth=false) can be cleared.
- partition_manager validates partition name regex before DROP TABLE.
- vcs/git: version regex validation rejects --option-injection; checkout uses
--detach -- separator; removed TrimPrefix(repo,'v') that corrupted vault/
vitess/vim-go.
- WebSocket CheckOrigin allowlist (was return true; CSWSH closed); same-origin
default + ServerConfig.AllowedOrigins.
- fiber CVE GO-2026-4543 patched (v2.52.10 -> v2.52.12).
FUNCTIONAL FEATURES
- API key DB persistence: APIKeyModel + migration 202604280002, full CRUD,
async LastUsedAt updates with WaitGroup-tracked goroutines drained on Close.
- Admin bootstrap via GOHOARDER_BOOTSTRAP_ADMIN_KEY env var; idempotent
(skipped when non-revoked admin already exists).
- Auth middleware factory in pkg/app: RequireAuth, RequireRole, RequirePermission,
OptionalAuth. Mounted on proxy + read APIs when Auth.Enabled=true.
DELETE /api/packages/* requires admin role. /health public for k8s probes.
- NFS storage backend: pkg/storage/nfs wraps filesystem with /proc/mounts
detection (Linux), post-write fsync, read-after-write health probe.
- WebSocket real-time pipeline: pkg/events Broadcaster interface; cache + scanner
managers emit EventPackageCached / EventPackageDownloaded / EventScanComplete;
app.go runs 30s EventStatsUpdate ticker. Frontend has full WS client (reconnect
with exponential backoff 1s->30s, 25s heartbeat, subscriber pattern), Pinia
realtime store, Dashboard live indicator + activity feed + reactive stats
override.
- TLS termination: fiber.ListenTLS when Server.TLS.Enabled.
- Pre-warming: Prewarming.Enabled flag wired (was hardcoded false); Interval,
MaxConcurrent, TopPackages plumbed.
- NetworkConfig wired (timeouts, retry, rate-limit, circuit-breaker).
- AuthConfig.BcryptCost wired.
- Security.Scanners.Static.MaxPackageSize plumbed to cache.io.LimitReader.
- Handlers.{Go,NPM,PyPI}.Enabled gates route mounting.
- Graceful shutdown: authManager.Close drains async writes.
LINT/HYGIENE
- 80 golangci-lint issues resolved: errcheck (Close/Write/RemoveAll wrapped),
gofmt, gosec G104/G306, govet shadow renames + fieldalignment reorders,
staticcheck ST1000 pkg comments + QF1003 tagged switches + QF1008 embedded
field selectors + QF1001 De Morgan's law.
BEHAVIOR CHANGES
- Scanner now fail-closed: deployments without scanner binaries
(trivy/govulncheck/npm-audit/pip-audit/grype) BLOCK packages instead of
serving unscanned. Add binaries or plan a future allow-on-scan-error flag.
- WS origin defaults to same-origin; cross-origin dashboards must set
server.allowed_origins.
- Validator no longer fails open; private packages won't serve from cache when
validation can't be performed.
- download_events retention dropped from 24h to ~5min (deleted in agg tx).
Migration 202604280001 purges pre-upgrade events.
- DELETE /api/packages/* requires admin role when auth enabled.
NEW PACKAGES
- pkg/events - Broadcaster interface
- pkg/storage/nfs - NFS-aware filesystem wrapper
DEFERRED (out of scope this pass)
- Static scanner implementation (config defines AllowedLicenses/MaxPackageSize/
BlockSuspicious but pkg/scanner/static/ does not exist).
- AuthConfig.AuditLog wiring (no audit log infra yet).
- CacheConfig.TTLOverrides passthrough (would touch cache.Config beyond
integrator scope).
224 lines
5.8 KiB
Go
224 lines
5.8 KiB
Go
package scanner
|
|
|
|
import (
|
|
"context"
|
|
"sync"
|
|
"time"
|
|
|
|
"github.com/lukaszraczylo/gohoarder/pkg/metadata"
|
|
"github.com/lukaszraczylo/gohoarder/pkg/storage"
|
|
"github.com/rs/zerolog/log"
|
|
)
|
|
|
|
// RescanWorker handles periodic re-scanning of cached packages
|
|
type RescanWorker struct {
|
|
metadataStore metadata.MetadataStore
|
|
storage storage.StorageBackend
|
|
manager *Manager
|
|
stopCh chan struct{}
|
|
stopOnce sync.Once
|
|
interval time.Duration
|
|
}
|
|
|
|
// NewRescanWorker creates a new rescan worker
|
|
func NewRescanWorker(manager *Manager, metadataStore metadata.MetadataStore, storageBackend storage.StorageBackend, interval time.Duration) *RescanWorker {
|
|
return &RescanWorker{
|
|
manager: manager,
|
|
metadataStore: metadataStore,
|
|
storage: storageBackend,
|
|
interval: interval,
|
|
stopCh: make(chan struct{}),
|
|
}
|
|
}
|
|
|
|
// Start begins the periodic re-scanning process
|
|
func (w *RescanWorker) Start(ctx context.Context) {
|
|
if !w.manager.enabled || w.interval == 0 {
|
|
log.Info().Msg("Rescan worker disabled")
|
|
return
|
|
}
|
|
|
|
log.Info().
|
|
Dur("interval", w.interval).
|
|
Msg("Starting package rescan worker")
|
|
|
|
ticker := time.NewTicker(w.interval)
|
|
defer ticker.Stop()
|
|
|
|
// Run initial scan immediately on startup
|
|
log.Info().Msg("Running initial package scan on startup")
|
|
w.rescanPackages(ctx)
|
|
log.Info().
|
|
Dur("next_scan", w.interval).
|
|
Msg("Initial scan complete, next scan scheduled")
|
|
|
|
for {
|
|
select {
|
|
case <-ticker.C:
|
|
w.rescanPackages(ctx)
|
|
case <-w.stopCh:
|
|
log.Info().Msg("Rescan worker stopped")
|
|
return
|
|
case <-ctx.Done():
|
|
log.Info().Msg("Rescan worker stopped (context cancelled)")
|
|
return
|
|
}
|
|
}
|
|
}
|
|
|
|
// Stop stops the rescan worker. Safe to call multiple times.
|
|
func (w *RescanWorker) Stop() {
|
|
w.stopOnce.Do(func() {
|
|
close(w.stopCh)
|
|
})
|
|
}
|
|
|
|
// rescanPackages re-scans packages that need updating
|
|
func (w *RescanWorker) rescanPackages(ctx context.Context) {
|
|
log.Info().Msg("Starting package rescan cycle - checking all packages for scan status")
|
|
|
|
// Get all packages
|
|
packages, err := w.metadataStore.ListPackages(ctx, &metadata.ListOptions{})
|
|
if err != nil {
|
|
log.Error().Err(err).Msg("Failed to list packages for rescan")
|
|
return
|
|
}
|
|
|
|
scanned := 0
|
|
skipped := 0
|
|
failed := 0
|
|
|
|
for _, pkg := range packages {
|
|
// Skip metadata entries (npm metadata pages, pypi pages, etc.)
|
|
if pkg.Version == "list" || pkg.Version == "latest" || pkg.Version == "metadata" || pkg.Version == "page" {
|
|
skipped++
|
|
continue
|
|
}
|
|
|
|
// Check if package needs rescanning
|
|
needsRescan, err := w.needsRescan(ctx, pkg)
|
|
if err != nil {
|
|
log.Error().
|
|
Err(err).
|
|
Str("package", pkg.Name).
|
|
Str("version", pkg.Version).
|
|
Msg("Failed to check rescan status")
|
|
failed++
|
|
continue
|
|
}
|
|
|
|
if !needsRescan {
|
|
log.Debug().
|
|
Str("package", pkg.Name).
|
|
Str("version", pkg.Version).
|
|
Bool("security_scanned", pkg.SecurityScanned).
|
|
Msg("Package does not need rescanning, skipping")
|
|
skipped++
|
|
continue
|
|
}
|
|
|
|
log.Info().
|
|
Str("registry", pkg.Registry).
|
|
Str("package", pkg.Name).
|
|
Str("version", pkg.Version).
|
|
Msg("Package needs rescanning")
|
|
|
|
// Get file path from storage using the storage key from the package metadata
|
|
if pkg.StorageKey == "" {
|
|
log.Warn().
|
|
Str("registry", pkg.Registry).
|
|
Str("package", pkg.Name).
|
|
Str("version", pkg.Version).
|
|
Msg("Package has no storage key, skipping rescan")
|
|
failed++
|
|
continue
|
|
}
|
|
|
|
filePath, err := w.getPackageFilePath(ctx, pkg.StorageKey)
|
|
if err != nil {
|
|
log.Warn().
|
|
Err(err).
|
|
Str("registry", pkg.Registry).
|
|
Str("package", pkg.Name).
|
|
Str("version", pkg.Version).
|
|
Str("storage_key", pkg.StorageKey).
|
|
Msg("Failed to get package file path, skipping rescan")
|
|
failed++
|
|
continue
|
|
}
|
|
|
|
if filePath == "" {
|
|
log.Debug().
|
|
Str("registry", pkg.Registry).
|
|
Str("package", pkg.Name).
|
|
Str("version", pkg.Version).
|
|
Msg("No local file path available, skipping rescan")
|
|
skipped++
|
|
continue
|
|
}
|
|
|
|
// Perform the actual scan
|
|
if err := w.manager.ScanPackage(ctx, pkg.Registry, pkg.Name, pkg.Version, filePath); err != nil {
|
|
log.Error().
|
|
Err(err).
|
|
Str("registry", pkg.Registry).
|
|
Str("package", pkg.Name).
|
|
Str("version", pkg.Version).
|
|
Msg("Failed to rescan package")
|
|
failed++
|
|
continue
|
|
}
|
|
|
|
scanned++
|
|
}
|
|
|
|
log.Info().
|
|
Int("total", len(packages)).
|
|
Int("scanned", scanned).
|
|
Int("skipped", skipped).
|
|
Int("failed", failed).
|
|
Msg("Rescan cycle completed")
|
|
}
|
|
|
|
// needsRescan checks if a package needs to be rescanned
|
|
func (w *RescanWorker) needsRescan(ctx context.Context, pkg *metadata.Package) (bool, error) {
|
|
// Get latest scan result
|
|
scanResult, err := w.metadataStore.GetScanResult(ctx, pkg.Registry, pkg.Name, pkg.Version)
|
|
if err != nil {
|
|
// No scan result - needs scanning
|
|
log.Debug().
|
|
Str("package", pkg.Name).
|
|
Str("version", pkg.Version).
|
|
Msg("Package has no scan result, needs scanning")
|
|
return true, nil
|
|
}
|
|
|
|
// If package is not marked as scanned but has scan result, it's a stale state - rescan
|
|
if !pkg.SecurityScanned {
|
|
log.Info().
|
|
Str("package", pkg.Name).
|
|
Str("version", pkg.Version).
|
|
Msg("Package has scan result but security_scanned flag is false, needs update")
|
|
return true, nil
|
|
}
|
|
|
|
// Check if scan is older than rescan interval
|
|
timeSinceLastScan := time.Since(scanResult.ScannedAt)
|
|
if timeSinceLastScan >= w.interval {
|
|
return true, nil
|
|
}
|
|
|
|
return false, nil
|
|
}
|
|
|
|
// getPackageFilePath retrieves the local file path for a package from storage
|
|
func (w *RescanWorker) getPackageFilePath(ctx context.Context, storageKey string) (string, error) {
|
|
// Check if storage backend supports local paths
|
|
if localProvider, ok := w.storage.(storage.LocalPathProvider); ok {
|
|
return localProvider.GetLocalPath(ctx, storageKey)
|
|
}
|
|
|
|
// If storage doesn't support local paths (S3, SMB), we can't rescan
|
|
return "", nil
|
|
}
|