mirror of
https://github.com/lukaszraczylo/gohoarder.git
synced 2026-07-12 04:50:45 +00:00
e39d6a0f0d
Multi-agent audit + fix pass covering bugs, security, dead config wiring,
and missing features. All quality gates green: build/vet/test -race/govulncheck/
golangci-lint. Frontend tests 47/47.
SECURITY & CORRECTNESS
- Scanner pipeline fail-closed: cache.go scan timeout now 503 (was goto servePkg);
scanner.go all-scanners-fail saves ScanStatusError; CheckVulnerabilities blocks
on missing/error result instead of allowing.
- Scanner argv corrections: govulncheck source-mode + go.mod discovery;
npm-audit generates lockfile via npm install --package-lock-only --ignore-scripts;
pip-audit per-extension dispatch (wheel direct / sdist extract+pyproject).
- GHSA version-range filtering implemented (was always-include); url.QueryEscape
on package name.
- pypi SSRF closed via host allowlist on original_url; url.QueryEscape on
rewriteURL output.
- Path traversal: cache temp file uses os.CreateTemp; smb keyToPath sanitized;
filesystem keyToPath returns error + filepath.Abs prefix-verify.
- Goroutine leaks plugged: cache.cleanupWorker stop channel; auth.ValidationCache
Stop() with sync.Once; ws.unregister buffered with non-blocking send.
- WebSocket double-close panic fixed via sync.Once Client.closeSend().
- Race conditions: gormstore.registryCache sync.RWMutex (was concurrent map
panic); auth.LastUsedAt no longer mutated under RLock; analytics strict
lock-ordering invariant (statsMu before downloadsMu).
- Auth validator fails CLOSED on transport/unknown-status errors (was returning
true,err 'allow cache fallback').
- Credential cache hash full SHA256 (was 8-byte truncate; eliminates 2^32
collision risk).
- filesystem.fs.used incremented after successful rename (no quota inflation
race).
- gormstore aggregation events deleted in same tx as insert (no double-counting).
- gormstore.SavePackage uses Updates(map) so zero-value security flags
(RequiresAuth=false) can be cleared.
- partition_manager validates partition name regex before DROP TABLE.
- vcs/git: version regex validation rejects --option-injection; checkout uses
--detach -- separator; removed TrimPrefix(repo,'v') that corrupted vault/
vitess/vim-go.
- WebSocket CheckOrigin allowlist (was return true; CSWSH closed); same-origin
default + ServerConfig.AllowedOrigins.
- fiber CVE GO-2026-4543 patched (v2.52.10 -> v2.52.12).
FUNCTIONAL FEATURES
- API key DB persistence: APIKeyModel + migration 202604280002, full CRUD,
async LastUsedAt updates with WaitGroup-tracked goroutines drained on Close.
- Admin bootstrap via GOHOARDER_BOOTSTRAP_ADMIN_KEY env var; idempotent
(skipped when non-revoked admin already exists).
- Auth middleware factory in pkg/app: RequireAuth, RequireRole, RequirePermission,
OptionalAuth. Mounted on proxy + read APIs when Auth.Enabled=true.
DELETE /api/packages/* requires admin role. /health public for k8s probes.
- NFS storage backend: pkg/storage/nfs wraps filesystem with /proc/mounts
detection (Linux), post-write fsync, read-after-write health probe.
- WebSocket real-time pipeline: pkg/events Broadcaster interface; cache + scanner
managers emit EventPackageCached / EventPackageDownloaded / EventScanComplete;
app.go runs 30s EventStatsUpdate ticker. Frontend has full WS client (reconnect
with exponential backoff 1s->30s, 25s heartbeat, subscriber pattern), Pinia
realtime store, Dashboard live indicator + activity feed + reactive stats
override.
- TLS termination: fiber.ListenTLS when Server.TLS.Enabled.
- Pre-warming: Prewarming.Enabled flag wired (was hardcoded false); Interval,
MaxConcurrent, TopPackages plumbed.
- NetworkConfig wired (timeouts, retry, rate-limit, circuit-breaker).
- AuthConfig.BcryptCost wired.
- Security.Scanners.Static.MaxPackageSize plumbed to cache.io.LimitReader.
- Handlers.{Go,NPM,PyPI}.Enabled gates route mounting.
- Graceful shutdown: authManager.Close drains async writes.
LINT/HYGIENE
- 80 golangci-lint issues resolved: errcheck (Close/Write/RemoveAll wrapped),
gofmt, gosec G104/G306, govet shadow renames + fieldalignment reorders,
staticcheck ST1000 pkg comments + QF1003 tagged switches + QF1008 embedded
field selectors + QF1001 De Morgan's law.
BEHAVIOR CHANGES
- Scanner now fail-closed: deployments without scanner binaries
(trivy/govulncheck/npm-audit/pip-audit/grype) BLOCK packages instead of
serving unscanned. Add binaries or plan a future allow-on-scan-error flag.
- WS origin defaults to same-origin; cross-origin dashboards must set
server.allowed_origins.
- Validator no longer fails open; private packages won't serve from cache when
validation can't be performed.
- download_events retention dropped from 24h to ~5min (deleted in agg tx).
Migration 202604280001 purges pre-upgrade events.
- DELETE /api/packages/* requires admin role when auth enabled.
NEW PACKAGES
- pkg/events - Broadcaster interface
- pkg/storage/nfs - NFS-aware filesystem wrapper
DEFERRED (out of scope this pass)
- Static scanner implementation (config defines AllowedLicenses/MaxPackageSize/
BlockSuspicious but pkg/scanner/static/ does not exist).
- AuthConfig.AuditLog wiring (no audit log infra yet).
- CacheConfig.TTLOverrides passthrough (would touch cache.Config beyond
integrator scope).
406 lines
12 KiB
Go
406 lines
12 KiB
Go
// Package npm implements the HTTP handler that proxies npm registry
|
|
// requests through the GoHoarder cache.
|
|
package npm
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"io"
|
|
"net/http"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/lukaszraczylo/gohoarder/pkg/auth"
|
|
"github.com/lukaszraczylo/gohoarder/pkg/cache"
|
|
"github.com/lukaszraczylo/gohoarder/pkg/errors"
|
|
"github.com/lukaszraczylo/gohoarder/pkg/network"
|
|
"github.com/rs/zerolog/log"
|
|
)
|
|
|
|
// Handler implements the NPM registry protocol
|
|
type Handler struct {
|
|
cache *cache.Manager
|
|
client *network.Client
|
|
credExtractor *auth.CredentialExtractor
|
|
credHasher *auth.CredentialHasher
|
|
credValidator *auth.NPMValidator
|
|
validationCache *auth.ValidationCache
|
|
upstream string
|
|
}
|
|
|
|
// Config holds NPM proxy configuration
|
|
type Config struct {
|
|
Upstream string // Upstream NPM registry (e.g., registry.npmjs.org)
|
|
}
|
|
|
|
// New creates a new NPM proxy handler
|
|
func New(cacheManager *cache.Manager, client *network.Client, config Config) *Handler {
|
|
if config.Upstream == "" {
|
|
config.Upstream = "https://registry.npmjs.org"
|
|
}
|
|
|
|
return &Handler{
|
|
cache: cacheManager,
|
|
client: client,
|
|
upstream: config.Upstream,
|
|
credExtractor: auth.NewCredentialExtractor(),
|
|
credHasher: auth.NewCredentialHasher(),
|
|
credValidator: auth.NewNPMValidator(),
|
|
validationCache: auth.NewValidationCache(5 * time.Minute),
|
|
}
|
|
}
|
|
|
|
// ServeHTTP handles NPM registry requests
|
|
func (h *Handler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
|
|
ctx := r.Context()
|
|
path := strings.TrimPrefix(r.URL.Path, "/npm")
|
|
|
|
log.Debug().Str("path", path).Str("method", r.Method).Msg("NPM proxy request")
|
|
|
|
// Handle different NPM request types
|
|
// Check for tarballs FIRST before special endpoints (tarballs also contain "/-/")
|
|
if isTarballRequest(path) {
|
|
// Package tarball: /@scope/package/-/package-version.tgz
|
|
h.handleTarball(ctx, w, r, path)
|
|
} else if strings.Contains(path, "/-/") {
|
|
// Special NPM endpoints (e.g., /-/ping, /-/user/token)
|
|
h.handleSpecial(ctx, w, r, path)
|
|
} else if isPackageMetadata(path) {
|
|
// Package metadata: /@scope/package or /package
|
|
h.handleMetadata(ctx, w, r, path)
|
|
} else {
|
|
http.Error(w, "Invalid NPM request", http.StatusBadRequest)
|
|
}
|
|
}
|
|
|
|
// handleMetadata handles package metadata requests
|
|
func (h *Handler) handleMetadata(ctx context.Context, w http.ResponseWriter, r *http.Request, path string) {
|
|
url := h.upstream + path
|
|
packageName := extractPackageName(path)
|
|
|
|
entry, err := h.cache.Get(ctx, "npm", packageName, "metadata", func(ctx context.Context) (io.ReadCloser, string, error) {
|
|
body, statusCode, fetchErr := h.client.Get(ctx, url, nil)
|
|
if fetchErr != nil {
|
|
return nil, "", fetchErr
|
|
}
|
|
if statusCode != http.StatusOK {
|
|
_ = body.Close()
|
|
return nil, "", fmt.Errorf("upstream returned status %d", statusCode)
|
|
}
|
|
return body, url, nil
|
|
})
|
|
|
|
if err != nil {
|
|
log.Error().Err(err).Str("url", url).Msg("Failed to fetch package metadata")
|
|
http.Error(w, "Failed to fetch package metadata", http.StatusBadGateway)
|
|
return
|
|
}
|
|
defer func() {
|
|
if cerr := entry.Data.Close(); cerr != nil {
|
|
log.Warn().Err(cerr).Msg("Failed to close NPM metadata body")
|
|
}
|
|
}()
|
|
|
|
// Read metadata into memory for URL rewriting
|
|
var buf bytes.Buffer
|
|
if _, copyErr := io.Copy(&buf, entry.Data); copyErr != nil {
|
|
log.Error().Err(copyErr).Msg("Failed to read metadata")
|
|
http.Error(w, "Failed to read metadata", http.StatusInternalServerError)
|
|
return
|
|
}
|
|
|
|
// Parse JSON metadata
|
|
var metadata map[string]interface{}
|
|
if jsonErr := json.Unmarshal(buf.Bytes(), &metadata); jsonErr != nil {
|
|
log.Error().Err(jsonErr).Msg("Failed to parse metadata JSON")
|
|
http.Error(w, "Failed to parse metadata", http.StatusInternalServerError)
|
|
return
|
|
}
|
|
|
|
// Rewrite tarball URLs to point to our proxy
|
|
proxyBaseURL := getProxyBaseURL(r)
|
|
rewriteMetadataURLs(metadata, h.upstream, proxyBaseURL)
|
|
|
|
// Serialize modified metadata
|
|
modifiedJSON, err := json.Marshal(metadata)
|
|
if err != nil {
|
|
log.Error().Err(err).Msg("Failed to serialize modified metadata")
|
|
http.Error(w, "Failed to serialize metadata", http.StatusInternalServerError)
|
|
return
|
|
}
|
|
|
|
w.Header().Set("Content-Type", "application/json; charset=UTF-8")
|
|
_, _ = w.Write(modifiedJSON) // #nosec G104 -- Websocket buffer write
|
|
}
|
|
|
|
// handleTarball handles package tarball requests
|
|
func (h *Handler) handleTarball(ctx context.Context, w http.ResponseWriter, r *http.Request, path string) {
|
|
packageName, version := extractTarballInfo(path)
|
|
|
|
// Extract credentials from request
|
|
credentials := h.credExtractor.Extract(r)
|
|
credHash := h.credHasher.Hash(credentials)
|
|
|
|
// Construct proper upstream URL with /-/ format
|
|
// Format: https://registry.npmjs.org/<package>/-/<filename>
|
|
// For unscoped: filename is "<package>-<version>.tgz"
|
|
// For scoped @scope/pkg: filename is "<pkg>-<version>.tgz" (no scope, no leading @)
|
|
tarballFilename := tarballPrefix(packageName) + version + ".tgz"
|
|
url := fmt.Sprintf("%s/%s/-/%s", h.upstream, packageName, tarballFilename)
|
|
|
|
log.Debug().
|
|
Str("path", path).
|
|
Str("package", packageName).
|
|
Str("version", version).
|
|
Str("upstream_url", url).
|
|
Str("cred_hash", credHash).
|
|
Bool("has_credentials", credentials != "").
|
|
Msg("Handling tarball request")
|
|
|
|
// Try to get from cache first (with credential-aware key)
|
|
entry, err := h.cache.Get(ctx, "npm", packageName, version, func(ctx context.Context) (io.ReadCloser, string, error) {
|
|
// Prepare headers for upstream request
|
|
headers := make(map[string]string)
|
|
if credentials != "" {
|
|
headers["Authorization"] = credentials
|
|
}
|
|
|
|
body, statusCode, fetchErr := h.client.Get(ctx, url, headers)
|
|
if fetchErr != nil {
|
|
return nil, "", fetchErr
|
|
}
|
|
if statusCode != http.StatusOK {
|
|
_ = body.Close()
|
|
return nil, "", fmt.Errorf("upstream returned status %d", statusCode)
|
|
}
|
|
return body, url, nil
|
|
})
|
|
|
|
if err != nil {
|
|
log.Error().Err(err).Str("url", url).Msg("Failed to fetch package tarball")
|
|
|
|
// Check if error is a security violation - return 403 Forbidden
|
|
if ghErr, ok := err.(*errors.Error); ok && ghErr.Code == errors.ErrCodeSecurityViolation {
|
|
http.Error(w, fmt.Sprintf("Package blocked: %s", ghErr.Message), http.StatusForbidden)
|
|
return
|
|
}
|
|
|
|
// All other errors return 502 Bad Gateway (upstream issues)
|
|
http.Error(w, "Failed to fetch package tarball", http.StatusBadGateway)
|
|
return
|
|
}
|
|
defer func() {
|
|
if cerr := entry.Data.Close(); cerr != nil {
|
|
log.Warn().Err(cerr).Msg("Failed to close NPM tarball body")
|
|
}
|
|
}()
|
|
|
|
// CRITICAL SECURITY CHECK: If package requires auth, validate credentials
|
|
if entry.Package != nil && entry.Package.RequiresAuth {
|
|
// Check validation cache first
|
|
allowed, cached, reason := h.validationCache.Get(credHash, url)
|
|
if cached {
|
|
if !allowed {
|
|
log.Warn().
|
|
Str("package", packageName).
|
|
Str("version", version).
|
|
Str("reason", reason).
|
|
Msg("Access denied (cached validation)")
|
|
http.Error(w, "Access denied", http.StatusForbidden)
|
|
return
|
|
}
|
|
log.Debug().
|
|
Str("package", packageName).
|
|
Str("version", version).
|
|
Msg("Access granted (cached validation)")
|
|
} else {
|
|
// Validate with upstream
|
|
log.Debug().
|
|
Str("package", packageName).
|
|
Str("version", version).
|
|
Str("provider", entry.Package.AuthProvider).
|
|
Msg("Validating credentials with upstream")
|
|
|
|
allowed, err := h.credValidator.ValidateAccess(ctx, url, credentials)
|
|
if err != nil {
|
|
reason = err.Error()
|
|
}
|
|
|
|
// Cache validation result
|
|
h.validationCache.Set(credHash, url, allowed, reason)
|
|
|
|
if !allowed {
|
|
log.Warn().
|
|
Str("package", packageName).
|
|
Str("version", version).
|
|
Err(err).
|
|
Msg("Access denied by upstream")
|
|
http.Error(w, "Access denied", http.StatusForbidden)
|
|
return
|
|
}
|
|
|
|
log.Debug().
|
|
Str("package", packageName).
|
|
Str("version", version).
|
|
Msg("Access granted by upstream")
|
|
}
|
|
}
|
|
|
|
w.Header().Set("Content-Type", "application/octet-stream")
|
|
_, _ = io.Copy(w, entry.Data) // #nosec G104 -- HTTP response write
|
|
}
|
|
|
|
// handleSpecial handles special NPM endpoints
|
|
func (h *Handler) handleSpecial(ctx context.Context, w http.ResponseWriter, r *http.Request, path string) {
|
|
url := h.upstream + path
|
|
|
|
// Don't cache special endpoints, proxy directly
|
|
body, statusCode, err := h.client.Get(ctx, url, nil)
|
|
if err != nil {
|
|
log.Error().Err(err).Str("url", url).Msg("Failed to fetch special endpoint")
|
|
http.Error(w, "Failed to fetch from upstream", http.StatusBadGateway)
|
|
return
|
|
}
|
|
defer func() {
|
|
if cerr := body.Close(); cerr != nil {
|
|
log.Warn().Err(cerr).Msg("Failed to close NPM special endpoint body")
|
|
}
|
|
}()
|
|
|
|
w.WriteHeader(statusCode)
|
|
_, _ = io.Copy(w, body) // #nosec G104 -- HTTP response write
|
|
}
|
|
|
|
// isTarballRequest checks if the request is for a tarball
|
|
func isTarballRequest(path string) bool {
|
|
return strings.HasSuffix(path, ".tgz") || strings.HasSuffix(path, ".tar.gz")
|
|
}
|
|
|
|
// isPackageMetadata checks if the request is for package metadata
|
|
func isPackageMetadata(path string) bool {
|
|
// Package metadata doesn't have file extensions
|
|
return !isTarballRequest(path) && !strings.Contains(path, "/-/")
|
|
}
|
|
|
|
// extractPackageName extracts package name from path
|
|
func extractPackageName(path string) string {
|
|
// Remove leading slash
|
|
path = strings.TrimPrefix(path, "/")
|
|
|
|
// Handle scoped packages (@scope/package)
|
|
if strings.HasPrefix(path, "@") {
|
|
parts := strings.Split(path, "/")
|
|
if len(parts) >= 2 {
|
|
return parts[0] + "/" + parts[1]
|
|
}
|
|
}
|
|
|
|
// Regular package
|
|
parts := strings.Split(path, "/")
|
|
if len(parts) > 0 {
|
|
return parts[0]
|
|
}
|
|
|
|
return path
|
|
}
|
|
|
|
// tarballPrefix returns the filename prefix used by npm tarballs for a given
|
|
// package. For scoped packages (@scope/pkg) only the bare name is used as a
|
|
// prefix — the @scope segment is not part of the filename.
|
|
func tarballPrefix(packageName string) string {
|
|
bare := packageName
|
|
if strings.HasPrefix(bare, "@") {
|
|
if idx := strings.Index(bare, "/"); idx >= 0 {
|
|
bare = bare[idx+1:]
|
|
}
|
|
}
|
|
return bare + "-"
|
|
}
|
|
|
|
// extractTarballInfo extracts package name and version from tarball path
|
|
func extractTarballInfo(path string) (string, string) {
|
|
// Format: /@scope/package/-/package-version.tgz
|
|
// or: /package/-/package-version.tgz
|
|
// Also handle: /package/package-version.tgz (fallback)
|
|
|
|
// Try standard format with /-/
|
|
parts := strings.Split(path, "/-/")
|
|
if len(parts) == 2 {
|
|
packageName := extractPackageName(parts[0])
|
|
tarballName := parts[1]
|
|
tarballName = strings.TrimSuffix(tarballName, ".tgz")
|
|
tarballName = strings.TrimSuffix(tarballName, ".tar.gz")
|
|
|
|
// Remove package name prefix to get version. For scoped packages the
|
|
// tarball filename uses only the bare package name (no @scope/ prefix).
|
|
version := strings.TrimPrefix(tarballName, tarballPrefix(packageName))
|
|
|
|
return packageName, version
|
|
}
|
|
|
|
// Fallback: parse path without /-/
|
|
// Format: /package/package-version.tgz or /@scope/package/package-version.tgz
|
|
path = strings.TrimPrefix(path, "/")
|
|
pathParts := strings.Split(path, "/")
|
|
|
|
if len(pathParts) < 2 {
|
|
return "", ""
|
|
}
|
|
|
|
var packageName, tarballName string
|
|
|
|
// Handle scoped packages
|
|
if strings.HasPrefix(pathParts[0], "@") && len(pathParts) >= 3 {
|
|
packageName = pathParts[0] + "/" + pathParts[1]
|
|
tarballName = pathParts[len(pathParts)-1]
|
|
} else {
|
|
packageName = pathParts[0]
|
|
tarballName = pathParts[len(pathParts)-1]
|
|
}
|
|
|
|
tarballName = strings.TrimSuffix(tarballName, ".tgz")
|
|
tarballName = strings.TrimSuffix(tarballName, ".tar.gz")
|
|
|
|
// Remove package name prefix to get version (scope-aware).
|
|
version := strings.TrimPrefix(tarballName, tarballPrefix(packageName))
|
|
|
|
return packageName, version
|
|
}
|
|
|
|
// getProxyBaseURL constructs the proxy base URL from the request
|
|
func getProxyBaseURL(r *http.Request) string {
|
|
scheme := "http"
|
|
if r.TLS != nil {
|
|
scheme = "https"
|
|
}
|
|
host := r.Host
|
|
return fmt.Sprintf("%s://%s/npm", scheme, host)
|
|
}
|
|
|
|
// rewriteMetadataURLs recursively rewrites upstream URLs to proxy URLs in metadata
|
|
func rewriteMetadataURLs(data interface{}, upstream, proxyBaseURL string) {
|
|
switch v := data.(type) {
|
|
case map[string]interface{}:
|
|
for key, value := range v {
|
|
if key == "tarball" || key == "dist" {
|
|
// Rewrite tarball URL
|
|
if strVal, ok := value.(string); ok {
|
|
v[key] = strings.Replace(strVal, upstream, proxyBaseURL, 1)
|
|
} else if distMap, ok := value.(map[string]interface{}); ok {
|
|
// Handle dist object with tarball field
|
|
rewriteMetadataURLs(distMap, upstream, proxyBaseURL)
|
|
}
|
|
} else {
|
|
// Recursively process nested objects
|
|
rewriteMetadataURLs(value, upstream, proxyBaseURL)
|
|
}
|
|
}
|
|
case []interface{}:
|
|
for _, item := range v {
|
|
rewriteMetadataURLs(item, upstream, proxyBaseURL)
|
|
}
|
|
}
|
|
}
|