mirror of
https://github.com/lukaszraczylo/gohoarder.git
synced 2026-07-13 04:57:11 +00:00
e39d6a0f0d
Multi-agent audit + fix pass covering bugs, security, dead config wiring,
and missing features. All quality gates green: build/vet/test -race/govulncheck/
golangci-lint. Frontend tests 47/47.
SECURITY & CORRECTNESS
- Scanner pipeline fail-closed: cache.go scan timeout now 503 (was goto servePkg);
scanner.go all-scanners-fail saves ScanStatusError; CheckVulnerabilities blocks
on missing/error result instead of allowing.
- Scanner argv corrections: govulncheck source-mode + go.mod discovery;
npm-audit generates lockfile via npm install --package-lock-only --ignore-scripts;
pip-audit per-extension dispatch (wheel direct / sdist extract+pyproject).
- GHSA version-range filtering implemented (was always-include); url.QueryEscape
on package name.
- pypi SSRF closed via host allowlist on original_url; url.QueryEscape on
rewriteURL output.
- Path traversal: cache temp file uses os.CreateTemp; smb keyToPath sanitized;
filesystem keyToPath returns error + filepath.Abs prefix-verify.
- Goroutine leaks plugged: cache.cleanupWorker stop channel; auth.ValidationCache
Stop() with sync.Once; ws.unregister buffered with non-blocking send.
- WebSocket double-close panic fixed via sync.Once Client.closeSend().
- Race conditions: gormstore.registryCache sync.RWMutex (was concurrent map
panic); auth.LastUsedAt no longer mutated under RLock; analytics strict
lock-ordering invariant (statsMu before downloadsMu).
- Auth validator fails CLOSED on transport/unknown-status errors (was returning
true,err 'allow cache fallback').
- Credential cache hash full SHA256 (was 8-byte truncate; eliminates 2^32
collision risk).
- filesystem.fs.used incremented after successful rename (no quota inflation
race).
- gormstore aggregation events deleted in same tx as insert (no double-counting).
- gormstore.SavePackage uses Updates(map) so zero-value security flags
(RequiresAuth=false) can be cleared.
- partition_manager validates partition name regex before DROP TABLE.
- vcs/git: version regex validation rejects --option-injection; checkout uses
--detach -- separator; removed TrimPrefix(repo,'v') that corrupted vault/
vitess/vim-go.
- WebSocket CheckOrigin allowlist (was return true; CSWSH closed); same-origin
default + ServerConfig.AllowedOrigins.
- fiber CVE GO-2026-4543 patched (v2.52.10 -> v2.52.12).
FUNCTIONAL FEATURES
- API key DB persistence: APIKeyModel + migration 202604280002, full CRUD,
async LastUsedAt updates with WaitGroup-tracked goroutines drained on Close.
- Admin bootstrap via GOHOARDER_BOOTSTRAP_ADMIN_KEY env var; idempotent
(skipped when non-revoked admin already exists).
- Auth middleware factory in pkg/app: RequireAuth, RequireRole, RequirePermission,
OptionalAuth. Mounted on proxy + read APIs when Auth.Enabled=true.
DELETE /api/packages/* requires admin role. /health public for k8s probes.
- NFS storage backend: pkg/storage/nfs wraps filesystem with /proc/mounts
detection (Linux), post-write fsync, read-after-write health probe.
- WebSocket real-time pipeline: pkg/events Broadcaster interface; cache + scanner
managers emit EventPackageCached / EventPackageDownloaded / EventScanComplete;
app.go runs 30s EventStatsUpdate ticker. Frontend has full WS client (reconnect
with exponential backoff 1s->30s, 25s heartbeat, subscriber pattern), Pinia
realtime store, Dashboard live indicator + activity feed + reactive stats
override.
- TLS termination: fiber.ListenTLS when Server.TLS.Enabled.
- Pre-warming: Prewarming.Enabled flag wired (was hardcoded false); Interval,
MaxConcurrent, TopPackages plumbed.
- NetworkConfig wired (timeouts, retry, rate-limit, circuit-breaker).
- AuthConfig.BcryptCost wired.
- Security.Scanners.Static.MaxPackageSize plumbed to cache.io.LimitReader.
- Handlers.{Go,NPM,PyPI}.Enabled gates route mounting.
- Graceful shutdown: authManager.Close drains async writes.
LINT/HYGIENE
- 80 golangci-lint issues resolved: errcheck (Close/Write/RemoveAll wrapped),
gofmt, gosec G104/G306, govet shadow renames + fieldalignment reorders,
staticcheck ST1000 pkg comments + QF1003 tagged switches + QF1008 embedded
field selectors + QF1001 De Morgan's law.
BEHAVIOR CHANGES
- Scanner now fail-closed: deployments without scanner binaries
(trivy/govulncheck/npm-audit/pip-audit/grype) BLOCK packages instead of
serving unscanned. Add binaries or plan a future allow-on-scan-error flag.
- WS origin defaults to same-origin; cross-origin dashboards must set
server.allowed_origins.
- Validator no longer fails open; private packages won't serve from cache when
validation can't be performed.
- download_events retention dropped from 24h to ~5min (deleted in agg tx).
Migration 202604280001 purges pre-upgrade events.
- DELETE /api/packages/* requires admin role when auth enabled.
NEW PACKAGES
- pkg/events - Broadcaster interface
- pkg/storage/nfs - NFS-aware filesystem wrapper
DEFERRED (out of scope this pass)
- Static scanner implementation (config defines AllowedLicenses/MaxPackageSize/
BlockSuspicious but pkg/scanner/static/ does not exist).
- AuthConfig.AuditLog wiring (no audit log infra yet).
- CacheConfig.TTLOverrides passthrough (would touch cache.Config beyond
integrator scope).
488 lines
16 KiB
Go
488 lines
16 KiB
Go
// Package goproxy implements the HTTP handler that proxies Go module
|
|
// requests through the GoHoarder cache.
|
|
package goproxy
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"io"
|
|
"net/http"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/lukaszraczylo/gohoarder/pkg/auth"
|
|
"github.com/lukaszraczylo/gohoarder/pkg/cache"
|
|
"github.com/lukaszraczylo/gohoarder/pkg/errors"
|
|
"github.com/lukaszraczylo/gohoarder/pkg/network"
|
|
"github.com/lukaszraczylo/gohoarder/pkg/vcs"
|
|
"github.com/rs/zerolog/log"
|
|
)
|
|
|
|
// Handler implements the GOPROXY protocol
|
|
type Handler struct {
|
|
cache *cache.Manager
|
|
client *network.Client
|
|
credExtractor *auth.CredentialExtractor
|
|
credHasher *auth.CredentialHasher
|
|
credValidator *auth.GoValidator
|
|
validationCache *auth.ValidationCache
|
|
gitFetcher *vcs.GitFetcher
|
|
moduleBuilder *vcs.ModuleBuilder
|
|
upstream string
|
|
sumDBURL string
|
|
}
|
|
|
|
// Config holds Go proxy configuration
|
|
type Config struct {
|
|
CredStore *vcs.CredentialStore
|
|
Upstream string
|
|
SumDBURL string
|
|
}
|
|
|
|
// New creates a new Go proxy handler
|
|
func New(cacheManager *cache.Manager, client *network.Client, config Config) *Handler {
|
|
if config.Upstream == "" {
|
|
config.Upstream = "https://proxy.golang.org"
|
|
}
|
|
|
|
if config.SumDBURL == "" {
|
|
config.SumDBURL = "https://sum.golang.org"
|
|
}
|
|
|
|
// Use provided credential store or create empty one
|
|
credStore := config.CredStore
|
|
if credStore == nil {
|
|
credStore = vcs.NewCredentialStore()
|
|
}
|
|
|
|
return &Handler{
|
|
cache: cacheManager,
|
|
client: client,
|
|
upstream: config.Upstream,
|
|
sumDBURL: config.SumDBURL,
|
|
credExtractor: auth.NewCredentialExtractor(),
|
|
credHasher: auth.NewCredentialHasher(),
|
|
credValidator: auth.NewGoValidator(),
|
|
validationCache: auth.NewValidationCache(5 * time.Minute),
|
|
gitFetcher: vcs.NewGitFetcher("", credStore),
|
|
moduleBuilder: vcs.NewModuleBuilder(),
|
|
}
|
|
}
|
|
|
|
// ServeHTTP handles GOPROXY protocol requests
|
|
func (h *Handler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
|
|
ctx := r.Context()
|
|
// Path is already stripped by http.StripPrefix in app.go
|
|
path := r.URL.Path
|
|
|
|
log.Debug().
|
|
Str("path", path).
|
|
Msg("Processing Go proxy request")
|
|
|
|
// Parse GOPROXY request
|
|
// Formats:
|
|
// /@v/list - list versions
|
|
// /@v/$version.info - version info
|
|
// /@v/$version.mod - go.mod file
|
|
// /@v/$version.zip - module zip
|
|
// /@latest - latest version
|
|
|
|
log.Debug().Str("path", path).Msg("Go proxy request")
|
|
|
|
// Route request based on path
|
|
if strings.HasPrefix(path, "/sumdb/") {
|
|
h.handleSumDB(ctx, w, r, path)
|
|
} else if strings.HasSuffix(path, "/@v/list") {
|
|
h.handleList(ctx, w, r, path)
|
|
} else if strings.Contains(path, "/@v/") && strings.HasSuffix(path, ".info") {
|
|
h.handleInfo(ctx, w, r, path)
|
|
} else if strings.Contains(path, "/@v/") && strings.HasSuffix(path, ".mod") {
|
|
h.handleMod(ctx, w, r, path)
|
|
} else if strings.Contains(path, "/@v/") && strings.HasSuffix(path, ".zip") {
|
|
h.handleZip(ctx, w, r, path)
|
|
} else if strings.HasSuffix(path, "/@latest") {
|
|
h.handleLatest(ctx, w, r, path)
|
|
} else {
|
|
http.Error(w, "Invalid Go proxy request", http.StatusBadRequest)
|
|
}
|
|
}
|
|
|
|
// handleList handles /@v/list requests
|
|
func (h *Handler) handleList(ctx context.Context, w http.ResponseWriter, r *http.Request, path string) {
|
|
url := h.upstream + path
|
|
modulePath := h.extractModulePath(path)
|
|
|
|
// Extract credentials from request
|
|
credentials := h.credExtractor.Extract(r)
|
|
|
|
entry, err := h.cache.Get(ctx, "go", modulePath, "list", func(ctx context.Context) (io.ReadCloser, string, error) {
|
|
// Prepare headers for upstream request
|
|
headers := make(map[string]string)
|
|
if credentials != "" {
|
|
headers["Authorization"] = credentials
|
|
}
|
|
|
|
body, statusCode, err := h.client.Get(ctx, url, headers)
|
|
if err != nil {
|
|
return nil, "", err
|
|
}
|
|
if statusCode != http.StatusOK {
|
|
_ = body.Close() // #nosec G104 -- Cleanup, error not critical
|
|
return nil, "", fmt.Errorf("upstream returned status %d", statusCode)
|
|
}
|
|
return body, url, nil
|
|
})
|
|
|
|
if err != nil {
|
|
log.Error().Err(err).Str("url", url).Msg("Failed to fetch version list")
|
|
http.Error(w, "Failed to fetch version list", http.StatusBadGateway)
|
|
return
|
|
}
|
|
defer func() { _ = entry.Data.Close() }() // #nosec G104 -- Cleanup, error not critical
|
|
|
|
w.Header().Set("Content-Type", "text/plain; charset=UTF-8")
|
|
_, _ = io.Copy(w, entry.Data) // #nosec G104 -- HTTP response write
|
|
}
|
|
|
|
// handleInfo handles /@v/$version.info requests
|
|
func (h *Handler) handleInfo(ctx context.Context, w http.ResponseWriter, r *http.Request, path string) {
|
|
url := h.upstream + path
|
|
modulePath := h.extractModulePath(path)
|
|
version := h.extractVersion(path, ".info")
|
|
// Use .info suffix to distinguish from .mod and .zip in cache
|
|
cacheKey := modulePath + "/@v/" + version + ".info"
|
|
|
|
// Extract credentials from request
|
|
credentials := h.credExtractor.Extract(r)
|
|
|
|
entry, err := h.cache.Get(ctx, "go", cacheKey, version, func(ctx context.Context) (io.ReadCloser, string, error) {
|
|
// Prepare headers for upstream request
|
|
headers := make(map[string]string)
|
|
if credentials != "" {
|
|
headers["Authorization"] = credentials
|
|
}
|
|
|
|
body, statusCode, err := h.client.Get(ctx, url, headers)
|
|
if err != nil {
|
|
return nil, "", err
|
|
}
|
|
if statusCode != http.StatusOK {
|
|
_ = body.Close() // #nosec G104 -- Cleanup, error not critical
|
|
return nil, "", fmt.Errorf("upstream returned status %d", statusCode)
|
|
}
|
|
return body, url, nil
|
|
})
|
|
|
|
if err != nil {
|
|
log.Error().Err(err).Str("url", url).Msg("Failed to fetch version info")
|
|
http.Error(w, "Failed to fetch version info", http.StatusBadGateway)
|
|
return
|
|
}
|
|
defer func() { _ = entry.Data.Close() }() // #nosec G104 -- Cleanup, error not critical
|
|
|
|
w.Header().Set("Content-Type", "application/json; charset=UTF-8")
|
|
_, _ = io.Copy(w, entry.Data) // #nosec G104 -- HTTP response write
|
|
}
|
|
|
|
// handleMod handles /@v/$version.mod requests
|
|
func (h *Handler) handleMod(ctx context.Context, w http.ResponseWriter, r *http.Request, path string) {
|
|
url := h.upstream + path
|
|
modulePath := h.extractModulePath(path)
|
|
version := h.extractVersion(path, ".mod")
|
|
// Use .mod suffix to distinguish from .info and .zip in cache
|
|
cacheKey := modulePath + "/@v/" + version + ".mod"
|
|
|
|
// Extract credentials from request
|
|
credentials := h.credExtractor.Extract(r)
|
|
|
|
entry, err := h.cache.Get(ctx, "go", cacheKey, version, func(ctx context.Context) (io.ReadCloser, string, error) {
|
|
// Prepare headers for upstream request
|
|
headers := make(map[string]string)
|
|
if credentials != "" {
|
|
headers["Authorization"] = credentials
|
|
}
|
|
|
|
body, statusCode, err := h.client.Get(ctx, url, headers)
|
|
if err != nil {
|
|
return nil, "", err
|
|
}
|
|
if statusCode != http.StatusOK {
|
|
_ = body.Close() // #nosec G104 -- Cleanup, error not critical
|
|
return nil, "", fmt.Errorf("upstream returned status %d", statusCode)
|
|
}
|
|
return body, url, nil
|
|
})
|
|
|
|
if err != nil {
|
|
log.Error().Err(err).Str("url", url).Msg("Failed to fetch go.mod")
|
|
http.Error(w, "Failed to fetch go.mod", http.StatusBadGateway)
|
|
return
|
|
}
|
|
defer func() { _ = entry.Data.Close() }() // #nosec G104 -- Cleanup, error not critical
|
|
|
|
w.Header().Set("Content-Type", "text/plain; charset=UTF-8")
|
|
_, _ = io.Copy(w, entry.Data) // #nosec G104 -- HTTP response write
|
|
}
|
|
|
|
// handleZip handles /@v/$version.zip requests
|
|
func (h *Handler) handleZip(ctx context.Context, w http.ResponseWriter, r *http.Request, path string) {
|
|
url := h.upstream + path
|
|
modulePath := h.extractModulePath(path)
|
|
version := h.extractVersion(path, ".zip")
|
|
// Use .zip suffix to distinguish from .info and .mod in cache
|
|
cacheKey := modulePath + "/@v/" + version + ".zip"
|
|
|
|
// Extract credentials from request
|
|
credentials := h.credExtractor.Extract(r)
|
|
credHash := h.credHasher.Hash(credentials)
|
|
|
|
log.Debug().
|
|
Str("path", path).
|
|
Str("module", modulePath).
|
|
Str("version", version).
|
|
Str("url", url).
|
|
Str("cred_hash", credHash).
|
|
Bool("has_credentials", credentials != "").
|
|
Msg("Handling Go module zip request")
|
|
|
|
entry, err := h.cache.Get(ctx, "go", cacheKey, version, func(ctx context.Context) (io.ReadCloser, string, error) {
|
|
// Prepare headers for upstream request
|
|
headers := make(map[string]string)
|
|
if credentials != "" {
|
|
headers["Authorization"] = credentials
|
|
}
|
|
|
|
// Try upstream proxy first (fast path for public modules)
|
|
body, statusCode, err := h.client.Get(ctx, url, headers)
|
|
if err == nil && statusCode == http.StatusOK {
|
|
return body, url, nil
|
|
}
|
|
|
|
// If upstream failed with 404 or 403, try git fallback (private modules)
|
|
if statusCode == http.StatusNotFound || statusCode == http.StatusForbidden {
|
|
if body != nil {
|
|
_ = body.Close() // #nosec G104 -- Cleanup, error not critical
|
|
}
|
|
|
|
log.Debug().
|
|
Str("module", modulePath).
|
|
Str("version", version).
|
|
Int("upstream_status", statusCode).
|
|
Msg("Upstream proxy returned not found, trying git fallback")
|
|
|
|
return h.fetchModuleFromGit(ctx, modulePath, version, credentials)
|
|
}
|
|
|
|
// Other errors
|
|
if body != nil {
|
|
_ = body.Close() // #nosec G104 -- Cleanup, error not critical
|
|
}
|
|
if err != nil {
|
|
return nil, "", err
|
|
}
|
|
return nil, "", fmt.Errorf("upstream returned status %d", statusCode)
|
|
})
|
|
|
|
if err != nil {
|
|
log.Error().Err(err).Str("url", url).Msg("Failed to fetch module zip")
|
|
|
|
// Check if error is a security violation - return 403 Forbidden
|
|
if ghErr, ok := err.(*errors.Error); ok && ghErr.Code == errors.ErrCodeSecurityViolation {
|
|
http.Error(w, fmt.Sprintf("Package blocked: %s", ghErr.Message), http.StatusForbidden)
|
|
return
|
|
}
|
|
|
|
// All other errors return 502 Bad Gateway (upstream issues)
|
|
http.Error(w, "Failed to fetch module zip", http.StatusBadGateway)
|
|
return
|
|
}
|
|
defer func() { _ = entry.Data.Close() }() // #nosec G104 -- Cleanup, error not critical
|
|
|
|
// CRITICAL SECURITY CHECK: If module requires auth, validate credentials
|
|
if entry.Package != nil && entry.Package.RequiresAuth {
|
|
// Check validation cache first
|
|
allowed, cached, reason := h.validationCache.Get(credHash, modulePath)
|
|
if cached {
|
|
if !allowed {
|
|
log.Warn().
|
|
Str("module", modulePath).
|
|
Str("version", version).
|
|
Str("reason", reason).
|
|
Msg("Access denied (cached validation)")
|
|
http.Error(w, "Module not found", http.StatusNotFound)
|
|
return
|
|
}
|
|
log.Debug().
|
|
Str("module", modulePath).
|
|
Str("version", version).
|
|
Msg("Access granted (cached validation)")
|
|
} else {
|
|
// Validate with upstream using git ls-remote
|
|
log.Debug().
|
|
Str("module", modulePath).
|
|
Str("version", version).
|
|
Str("provider", entry.Package.AuthProvider).
|
|
Msg("Validating credentials with upstream")
|
|
|
|
allowed, err := h.credValidator.ValidateAccess(ctx, modulePath, credentials)
|
|
if err != nil {
|
|
reason = err.Error()
|
|
}
|
|
|
|
// Cache validation result
|
|
h.validationCache.Set(credHash, modulePath, allowed, reason)
|
|
|
|
if !allowed {
|
|
log.Warn().
|
|
Str("module", modulePath).
|
|
Str("version", version).
|
|
Err(err).
|
|
Msg("Access denied by upstream")
|
|
// Return 404 (same as GitHub does for private repos)
|
|
http.Error(w, "Module not found", http.StatusNotFound)
|
|
return
|
|
}
|
|
|
|
log.Debug().
|
|
Str("module", modulePath).
|
|
Str("version", version).
|
|
Msg("Access granted by upstream")
|
|
}
|
|
}
|
|
|
|
w.Header().Set("Content-Type", "application/zip")
|
|
_, _ = io.Copy(w, entry.Data) // #nosec G104 -- HTTP response write
|
|
}
|
|
|
|
// handleLatest handles /@latest requests
|
|
func (h *Handler) handleLatest(ctx context.Context, w http.ResponseWriter, r *http.Request, path string) {
|
|
url := h.upstream + path
|
|
modulePath := h.extractModulePath(path)
|
|
|
|
// Extract credentials from request
|
|
credentials := h.credExtractor.Extract(r)
|
|
|
|
entry, err := h.cache.Get(ctx, "go", modulePath, "latest", func(ctx context.Context) (io.ReadCloser, string, error) {
|
|
// Prepare headers for upstream request
|
|
headers := make(map[string]string)
|
|
if credentials != "" {
|
|
headers["Authorization"] = credentials
|
|
}
|
|
|
|
body, statusCode, err := h.client.Get(ctx, url, headers)
|
|
if err != nil {
|
|
return nil, "", err
|
|
}
|
|
if statusCode != http.StatusOK {
|
|
_ = body.Close() // #nosec G104 -- Cleanup, error not critical
|
|
return nil, "", fmt.Errorf("upstream returned status %d", statusCode)
|
|
}
|
|
return body, url, nil
|
|
})
|
|
|
|
if err != nil {
|
|
log.Error().Err(err).Str("url", url).Msg("Failed to fetch latest version")
|
|
http.Error(w, "Failed to fetch latest version", http.StatusBadGateway)
|
|
return
|
|
}
|
|
defer func() { _ = entry.Data.Close() }() // #nosec G104 -- Cleanup, error not critical
|
|
|
|
w.Header().Set("Content-Type", "application/json; charset=UTF-8")
|
|
_, _ = io.Copy(w, entry.Data) // #nosec G104 -- HTTP response write
|
|
}
|
|
|
|
// handleSumDB handles sumdb requests (checksum database)
|
|
func (h *Handler) handleSumDB(ctx context.Context, w http.ResponseWriter, r *http.Request, path string) {
|
|
// path format: /sumdb/sum.golang.org/...
|
|
// Remove /sumdb/ prefix and proxy to sumdb URL
|
|
sumdbPath := strings.TrimPrefix(path, "/sumdb/sum.golang.org")
|
|
url := h.sumDBURL + sumdbPath
|
|
|
|
log.Debug().Str("url", url).Msg("Proxying sumdb request")
|
|
|
|
// Sumdb requests should not be cached, proxy directly
|
|
body, statusCode, err := h.client.Get(ctx, url, nil)
|
|
if err != nil {
|
|
log.Error().Err(err).Str("url", url).Msg("Failed to fetch from sumdb")
|
|
http.Error(w, "Failed to fetch from sumdb", http.StatusBadGateway)
|
|
return
|
|
}
|
|
defer func() { _ = body.Close() }() // #nosec G104 -- Cleanup, error not critical
|
|
|
|
if statusCode != http.StatusOK {
|
|
log.Error().Int("status", statusCode).Str("url", url).Msg("Sumdb returned non-OK status")
|
|
http.Error(w, "Sumdb error", statusCode)
|
|
return
|
|
}
|
|
|
|
w.Header().Set("Content-Type", "text/plain; charset=UTF-8")
|
|
_, _ = io.Copy(w, body) // #nosec G104 -- HTTP response write
|
|
}
|
|
|
|
// extractVersion extracts version from path
|
|
func (h *Handler) extractVersion(path, suffix string) string {
|
|
// path format: /module/path/@v/v1.2.3.suffix
|
|
parts := strings.Split(path, "/@v/")
|
|
if len(parts) != 2 {
|
|
return ""
|
|
}
|
|
return strings.TrimSuffix(parts[1], suffix)
|
|
}
|
|
|
|
// extractModulePath extracts the clean module path from a GOPROXY path
|
|
// Examples:
|
|
//
|
|
// /github.com/avast/retry-go/v4/@v/v4.6.1.zip -> github.com/avast/retry-go/v4
|
|
// /golang.org/x/net/@v/v0.40.0.mod -> golang.org/x/net
|
|
// /github.com/user/repo/@v/list -> github.com/user/repo
|
|
func (h *Handler) extractModulePath(path string) string {
|
|
// Remove leading slash
|
|
path = strings.TrimPrefix(path, "/")
|
|
|
|
// Split on /@v/ to get the module path
|
|
parts := strings.Split(path, "/@v/")
|
|
if len(parts) > 0 {
|
|
return parts[0]
|
|
}
|
|
|
|
// Fallback: remove /@latest suffix if present
|
|
return strings.TrimSuffix(path, "/@latest")
|
|
}
|
|
|
|
// fetchModuleFromGit fetches a Go module directly from git repository
|
|
func (h *Handler) fetchModuleFromGit(ctx context.Context, modulePath, version, credentials string) (io.ReadCloser, string, error) {
|
|
log.Info().
|
|
Str("module", modulePath).
|
|
Str("version", version).
|
|
Msg("Fetching module from git repository")
|
|
|
|
// 1. Fetch module source from git
|
|
srcPath, err := h.gitFetcher.FetchModule(ctx, modulePath, version, credentials)
|
|
if err != nil {
|
|
return nil, "", fmt.Errorf("git fetch failed: %w", err)
|
|
}
|
|
defer h.gitFetcher.Cleanup(srcPath)
|
|
|
|
// 2. Validate module
|
|
if validateErr := h.moduleBuilder.ValidateModule(ctx, srcPath, modulePath); validateErr != nil {
|
|
return nil, "", fmt.Errorf("module validation failed: %w", validateErr)
|
|
}
|
|
|
|
// 3. Build module zip
|
|
zipReader, err := h.moduleBuilder.BuildModuleZip(ctx, srcPath, modulePath, version)
|
|
if err != nil {
|
|
return nil, "", fmt.Errorf("module zip build failed: %w", err)
|
|
}
|
|
|
|
// Create source URL for logging
|
|
sourceURL := fmt.Sprintf("git+https://%s@%s", modulePath, version)
|
|
|
|
log.Info().
|
|
Str("module", modulePath).
|
|
Str("version", version).
|
|
Str("source", sourceURL).
|
|
Msg("Successfully built module from git")
|
|
|
|
return zipReader, sourceURL, nil
|
|
}
|