mirror of
https://github.com/lukaszraczylo/gohoarder.git
synced 2026-07-16 05:33:59 +00:00
e39d6a0f0d
Multi-agent audit + fix pass covering bugs, security, dead config wiring,
and missing features. All quality gates green: build/vet/test -race/govulncheck/
golangci-lint. Frontend tests 47/47.
SECURITY & CORRECTNESS
- Scanner pipeline fail-closed: cache.go scan timeout now 503 (was goto servePkg);
scanner.go all-scanners-fail saves ScanStatusError; CheckVulnerabilities blocks
on missing/error result instead of allowing.
- Scanner argv corrections: govulncheck source-mode + go.mod discovery;
npm-audit generates lockfile via npm install --package-lock-only --ignore-scripts;
pip-audit per-extension dispatch (wheel direct / sdist extract+pyproject).
- GHSA version-range filtering implemented (was always-include); url.QueryEscape
on package name.
- pypi SSRF closed via host allowlist on original_url; url.QueryEscape on
rewriteURL output.
- Path traversal: cache temp file uses os.CreateTemp; smb keyToPath sanitized;
filesystem keyToPath returns error + filepath.Abs prefix-verify.
- Goroutine leaks plugged: cache.cleanupWorker stop channel; auth.ValidationCache
Stop() with sync.Once; ws.unregister buffered with non-blocking send.
- WebSocket double-close panic fixed via sync.Once Client.closeSend().
- Race conditions: gormstore.registryCache sync.RWMutex (was concurrent map
panic); auth.LastUsedAt no longer mutated under RLock; analytics strict
lock-ordering invariant (statsMu before downloadsMu).
- Auth validator fails CLOSED on transport/unknown-status errors (was returning
true,err 'allow cache fallback').
- Credential cache hash full SHA256 (was 8-byte truncate; eliminates 2^32
collision risk).
- filesystem.fs.used incremented after successful rename (no quota inflation
race).
- gormstore aggregation events deleted in same tx as insert (no double-counting).
- gormstore.SavePackage uses Updates(map) so zero-value security flags
(RequiresAuth=false) can be cleared.
- partition_manager validates partition name regex before DROP TABLE.
- vcs/git: version regex validation rejects --option-injection; checkout uses
--detach -- separator; removed TrimPrefix(repo,'v') that corrupted vault/
vitess/vim-go.
- WebSocket CheckOrigin allowlist (was return true; CSWSH closed); same-origin
default + ServerConfig.AllowedOrigins.
- fiber CVE GO-2026-4543 patched (v2.52.10 -> v2.52.12).
FUNCTIONAL FEATURES
- API key DB persistence: APIKeyModel + migration 202604280002, full CRUD,
async LastUsedAt updates with WaitGroup-tracked goroutines drained on Close.
- Admin bootstrap via GOHOARDER_BOOTSTRAP_ADMIN_KEY env var; idempotent
(skipped when non-revoked admin already exists).
- Auth middleware factory in pkg/app: RequireAuth, RequireRole, RequirePermission,
OptionalAuth. Mounted on proxy + read APIs when Auth.Enabled=true.
DELETE /api/packages/* requires admin role. /health public for k8s probes.
- NFS storage backend: pkg/storage/nfs wraps filesystem with /proc/mounts
detection (Linux), post-write fsync, read-after-write health probe.
- WebSocket real-time pipeline: pkg/events Broadcaster interface; cache + scanner
managers emit EventPackageCached / EventPackageDownloaded / EventScanComplete;
app.go runs 30s EventStatsUpdate ticker. Frontend has full WS client (reconnect
with exponential backoff 1s->30s, 25s heartbeat, subscriber pattern), Pinia
realtime store, Dashboard live indicator + activity feed + reactive stats
override.
- TLS termination: fiber.ListenTLS when Server.TLS.Enabled.
- Pre-warming: Prewarming.Enabled flag wired (was hardcoded false); Interval,
MaxConcurrent, TopPackages plumbed.
- NetworkConfig wired (timeouts, retry, rate-limit, circuit-breaker).
- AuthConfig.BcryptCost wired.
- Security.Scanners.Static.MaxPackageSize plumbed to cache.io.LimitReader.
- Handlers.{Go,NPM,PyPI}.Enabled gates route mounting.
- Graceful shutdown: authManager.Close drains async writes.
LINT/HYGIENE
- 80 golangci-lint issues resolved: errcheck (Close/Write/RemoveAll wrapped),
gofmt, gosec G104/G306, govet shadow renames + fieldalignment reorders,
staticcheck ST1000 pkg comments + QF1003 tagged switches + QF1008 embedded
field selectors + QF1001 De Morgan's law.
BEHAVIOR CHANGES
- Scanner now fail-closed: deployments without scanner binaries
(trivy/govulncheck/npm-audit/pip-audit/grype) BLOCK packages instead of
serving unscanned. Add binaries or plan a future allow-on-scan-error flag.
- WS origin defaults to same-origin; cross-origin dashboards must set
server.allowed_origins.
- Validator no longer fails open; private packages won't serve from cache when
validation can't be performed.
- download_events retention dropped from 24h to ~5min (deleted in agg tx).
Migration 202604280001 purges pre-upgrade events.
- DELETE /api/packages/* requires admin role when auth enabled.
NEW PACKAGES
- pkg/events - Broadcaster interface
- pkg/storage/nfs - NFS-aware filesystem wrapper
DEFERRED (out of scope this pass)
- Static scanner implementation (config defines AllowedLicenses/MaxPackageSize/
BlockSuspicious but pkg/scanner/static/ does not exist).
- AuthConfig.AuditLog wiring (no audit log infra yet).
- CacheConfig.TTLOverrides passthrough (would touch cache.Config beyond
integrator scope).
358 lines
15 KiB
Go
358 lines
15 KiB
Go
package gormstore
|
|
|
|
import (
|
|
"database/sql/driver"
|
|
"encoding/json"
|
|
"time"
|
|
|
|
"gorm.io/gorm"
|
|
)
|
|
|
|
// BaseModel provides common fields for all models with audit trail
|
|
type BaseModel struct {
|
|
CreatedAt time.Time `gorm:"not null"`
|
|
UpdatedAt time.Time `gorm:"not null"`
|
|
DeletedAt gorm.DeletedAt `gorm:"index"` // Soft delete support (auto-generated index name per table)
|
|
}
|
|
|
|
// RegistryModel represents package registries (normalized)
|
|
// This eliminates repetition of "npm", "pypi", "go" across millions of rows
|
|
type RegistryModel struct {
|
|
BaseModel
|
|
Name string `gorm:"uniqueIndex:idx_registry_name;not null;size:50"` // npm, pypi, go
|
|
DisplayName string `gorm:"not null;size:100"` // NPM Registry, PyPI, Go Modules
|
|
UpstreamURL string `gorm:"not null;size:512"` // https://registry.npmjs.org
|
|
ID int32 `gorm:"primaryKey;autoIncrement"`
|
|
Enabled bool `gorm:"not null;default:true;index:idx_registry_enabled"`
|
|
ScanByDefault bool `gorm:"not null;default:true"`
|
|
}
|
|
|
|
func (RegistryModel) TableName() string {
|
|
return "registries"
|
|
}
|
|
|
|
// PackageModel represents the core package data (optimized)
|
|
type PackageModel struct {
|
|
|
|
// Cache management
|
|
CachedAt time.Time `gorm:"not null;index:idx_package_cached_at"`
|
|
LastAccessed time.Time `gorm:"not null;index:idx_package_last_accessed"` // For LRU eviction
|
|
ExpiresAt *time.Time `gorm:"index:idx_package_expires_at"` // For cache invalidation
|
|
LastScannedAt *time.Time `gorm:"index:idx_package_last_scanned"`
|
|
Metadata *PackageMetadataModel `gorm:"foreignKey:PackageID;constraint:OnUpdate:CASCADE,OnDelete:CASCADE"`
|
|
|
|
// Relationships
|
|
Registry RegistryModel `gorm:"foreignKey:RegistryID;constraint:OnUpdate:CASCADE,OnDelete:RESTRICT"`
|
|
|
|
BaseModel
|
|
|
|
Name string `gorm:"not null;size:255;index:idx_package_name;index:idx_package_registry_name_version,priority:2"`
|
|
Version string `gorm:"not null;size:100;index:idx_package_registry_name_version,priority:3"`
|
|
|
|
// Storage information
|
|
StorageKey string `gorm:"not null;uniqueIndex:idx_package_storage_key;size:512"`
|
|
ChecksumMD5 string `gorm:"size:32;index:idx_package_md5"`
|
|
ChecksumSHA256 string `gorm:"size:64;index:idx_package_sha256"`
|
|
UpstreamURL string `gorm:"size:1024"`
|
|
|
|
HighestSeverity string `gorm:"size:20;index:idx_package_severity"` // critical, high, medium, low, none
|
|
AuthProvider string `gorm:"size:50;index:idx_package_auth_provider"` // github, gitlab, custom
|
|
|
|
ScanResults []ScanResultModel `gorm:"foreignKey:PackageID;constraint:OnUpdate:CASCADE,OnDelete:CASCADE"`
|
|
Vulnerabilities []PackageVulnerabilityModel `gorm:"foreignKey:PackageID;constraint:OnUpdate:CASCADE,OnDelete:CASCADE"`
|
|
ID int64 `gorm:"primaryKey;autoIncrement"`
|
|
Size int64 `gorm:"not null;index:idx_package_size"` // For storage quota queries
|
|
AccessCount int64 `gorm:"not null;default:0;index:idx_package_access_count"` // Total access count (denormalized for performance)
|
|
|
|
VulnerabilityCount int `gorm:"not null;default:0;index:idx_package_vuln_count"` // Denormalized for fast filtering
|
|
CriticalCount int `gorm:"not null;default:0"` // Count of critical vulnerabilities
|
|
HighCount int `gorm:"not null;default:0"` // Count of high vulnerabilities
|
|
ModerateCount int `gorm:"not null;default:0"` // Count of moderate vulnerabilities
|
|
LowCount int `gorm:"not null;default:0"` // Count of low vulnerabilities
|
|
|
|
RegistryID int32 `gorm:"not null;index:idx_package_registry_name_version,priority:1"` // Foreign key to registries
|
|
|
|
// Security
|
|
SecurityScanned bool `gorm:"not null;default:false;index:idx_package_security_scanned"`
|
|
|
|
// Authentication
|
|
RequiresAuth bool `gorm:"not null;default:false;index:idx_package_requires_auth"`
|
|
}
|
|
|
|
func (PackageModel) TableName() string {
|
|
return "packages"
|
|
}
|
|
|
|
// BeforeCreate hook to set access count
|
|
func (p *PackageModel) BeforeCreate(tx *gorm.DB) error {
|
|
if p.AccessCount == 0 {
|
|
p.AccessCount = 0
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// PackageMetadataModel stores structured package metadata (1:1 with packages)
|
|
// Separated from main table to reduce row size and improve query performance
|
|
type PackageMetadataModel struct {
|
|
RawMetadata JSONBField `gorm:"type:jsonb"` // Full metadata as JSONB (PostgreSQL) or JSON
|
|
BaseModel
|
|
Author string `gorm:"size:255;index:idx_metadata_author"`
|
|
License string `gorm:"size:100;index:idx_metadata_license"`
|
|
Homepage string `gorm:"size:512"`
|
|
Repository string `gorm:"size:512"`
|
|
Description string `gorm:"type:text"`
|
|
Keywords PostgresArray `gorm:"type:text"` // JSONB array for PostgreSQL, JSON for MySQL/SQLite
|
|
PackageID int64 `gorm:"primaryKey;not null"` // 1:1 relationship
|
|
}
|
|
|
|
func (PackageMetadataModel) TableName() string {
|
|
return "package_metadata"
|
|
}
|
|
|
|
// ScanResultModel represents security scan results (optimized)
|
|
type ScanResultModel struct {
|
|
ScannedAt time.Time `gorm:"not null;index:idx_scan_scanned_at"`
|
|
Details JSONBField `gorm:"type:jsonb"` // Scanner-specific details
|
|
BaseModel
|
|
|
|
Scanner string `gorm:"not null;size:50;index:idx_scan_scanner;index:idx_scan_package_scanner,priority:2"`
|
|
Status string `gorm:"not null;size:20;index:idx_scan_status"` // success, failed, pending
|
|
|
|
Package PackageModel `gorm:"foreignKey:PackageID;constraint:OnUpdate:CASCADE,OnDelete:CASCADE"`
|
|
ID int64 `gorm:"primaryKey;autoIncrement"`
|
|
PackageID int64 `gorm:"not null;index:idx_scan_package_scanner,priority:1"` // Foreign key
|
|
VulnCount int `gorm:"not null;default:0;index:idx_scan_vuln_count"`
|
|
CriticalCount int `gorm:"not null;default:0"`
|
|
HighCount int `gorm:"not null;default:0"`
|
|
MediumCount int `gorm:"not null;default:0"`
|
|
LowCount int `gorm:"not null;default:0"`
|
|
ScanDuration int `gorm:"not null;default:0"` // milliseconds
|
|
}
|
|
|
|
func (ScanResultModel) TableName() string {
|
|
return "scan_results"
|
|
}
|
|
|
|
// VulnerabilityModel represents unique vulnerabilities (normalized)
|
|
type VulnerabilityModel struct {
|
|
PublishedAt time.Time `gorm:"not null;index:idx_vuln_published"`
|
|
BaseModel
|
|
CVEID string `gorm:"uniqueIndex:idx_vuln_cve_id;not null;size:50"` // CVE-2021-12345
|
|
Title string `gorm:"not null;size:512"`
|
|
Description string `gorm:"type:text"`
|
|
Severity string `gorm:"not null;size:20;index:idx_vuln_severity"` // critical, high, medium, low
|
|
FixedVersion string `gorm:"size:100"` // First version where it's fixed
|
|
References PostgresArray `gorm:"type:text"` // URLs to advisories
|
|
ID int64 `gorm:"primaryKey;autoIncrement"`
|
|
CVSS float32 `gorm:"index:idx_vuln_cvss"` // CVSS score for sorting
|
|
}
|
|
|
|
func (VulnerabilityModel) TableName() string {
|
|
return "vulnerabilities"
|
|
}
|
|
|
|
// PackageVulnerabilityModel is a many-to-many relationship between packages and vulnerabilities
|
|
type PackageVulnerabilityModel struct {
|
|
DetectedAt time.Time `gorm:"not null;index:idx_pkg_vuln_detected"`
|
|
BypassID *int64 `gorm:"index:idx_pkg_vuln_bypass_id"` // Reference to bypass if applicable
|
|
Vulnerability VulnerabilityModel `gorm:"foreignKey:VulnerabilityID;constraint:OnUpdate:CASCADE,OnDelete:CASCADE"`
|
|
BaseModel
|
|
|
|
Scanner string `gorm:"not null;size:50;index:idx_pkg_vuln_scanner"`
|
|
|
|
Package PackageModel `gorm:"foreignKey:PackageID;constraint:OnUpdate:CASCADE,OnDelete:CASCADE"`
|
|
ID int64 `gorm:"primaryKey;autoIncrement"`
|
|
PackageID int64 `gorm:"not null;index:idx_pkg_vuln_package,priority:1;index:idx_pkg_vuln_composite,priority:1"`
|
|
VulnerabilityID int64 `gorm:"not null;index:idx_pkg_vuln_vuln,priority:1;index:idx_pkg_vuln_composite,priority:2"`
|
|
Bypassed bool `gorm:"not null;default:false;index:idx_pkg_vuln_bypassed"`
|
|
}
|
|
|
|
func (PackageVulnerabilityModel) TableName() string {
|
|
return "package_vulnerabilities"
|
|
}
|
|
|
|
// CVEBypassModel represents CVE bypass rules (improved)
|
|
type CVEBypassModel struct {
|
|
ExpiresAt time.Time `gorm:"not null;index:idx_bypass_expires_at"`
|
|
LastUsedAt *time.Time `gorm:"index:idx_bypass_last_used"`
|
|
|
|
// Scope limiting (optional)
|
|
RegistryID *int32 `gorm:"index:idx_bypass_registry"` // NULL = all registries
|
|
PackageID *int64 `gorm:"index:idx_bypass_package"` // NULL = all packages
|
|
|
|
BaseModel
|
|
Type string `gorm:"not null;size:20;index:idx_bypass_type"` // cve, package, registry
|
|
Target string `gorm:"not null;size:512;index:idx_bypass_target"` // CVE-ID, package name, etc.
|
|
Reason string `gorm:"not null;type:text"`
|
|
CreatedBy string `gorm:"not null;size:255;index:idx_bypass_created_by"`
|
|
ID int64 `gorm:"primaryKey;autoIncrement"`
|
|
UsageCount int64 `gorm:"not null;default:0"` // How many times this bypass has been used
|
|
NotifyOnExpiry bool `gorm:"not null;default:false"`
|
|
Active bool `gorm:"not null;default:true;index:idx_bypass_active"`
|
|
}
|
|
|
|
func (CVEBypassModel) TableName() string {
|
|
return "cve_bypasses"
|
|
}
|
|
|
|
// DownloadEventModel represents raw download events (partitioned by month)
|
|
// This table should use PostgreSQL partitioning or time-series DB features
|
|
type DownloadEventModel struct {
|
|
DownloadedAt time.Time `gorm:"not null;index:idx_download_time;index:idx_download_package,priority:2"` // Partition key
|
|
UserAgent string `gorm:"size:512"` // For analytics
|
|
IPAddress string `gorm:"size:45;index:idx_download_ip"` // IPv6 support
|
|
Username string `gorm:"size:255;index:idx_download_user"`
|
|
|
|
// No BaseModel - this is append-only, no updates/deletes on individual rows
|
|
// Partitioned tables handle cleanup via DROP PARTITION
|
|
ID int64 `gorm:"primaryKey;autoIncrement"`
|
|
PackageID int64 `gorm:"not null;index:idx_download_package,priority:1"`
|
|
RegistryID int32 `gorm:"not null;index:idx_download_registry"`
|
|
Authenticated bool `gorm:"not null;default:false"`
|
|
}
|
|
|
|
func (DownloadEventModel) TableName() string {
|
|
return "download_events"
|
|
}
|
|
|
|
// DownloadStatsHourlyModel represents pre-aggregated hourly statistics (partitioned)
|
|
type DownloadStatsHourlyModel struct {
|
|
TimeBucket time.Time `gorm:"not null;index:idx_stats_hourly_composite,priority:2"` // Truncated to hour
|
|
PackageID *int64 `gorm:"index:idx_stats_hourly_package"` // NULL = all packages in registry
|
|
|
|
BaseModel
|
|
ID int64 `gorm:"primaryKey;autoIncrement"`
|
|
DownloadCount int64 `gorm:"not null;default:0"`
|
|
UniqueIPs int64 `gorm:"not null;default:0"` // Unique downloaders
|
|
AuthDownloads int64 `gorm:"not null;default:0"` // Authenticated downloads
|
|
|
|
RegistryID int32 `gorm:"not null;index:idx_stats_hourly_composite,priority:1"`
|
|
}
|
|
|
|
func (DownloadStatsHourlyModel) TableName() string {
|
|
return "download_stats_hourly"
|
|
}
|
|
|
|
// DownloadStatsDailyModel represents pre-aggregated daily statistics
|
|
type DownloadStatsDailyModel struct {
|
|
TimeBucket time.Time `gorm:"not null;index:idx_stats_daily_composite,priority:2"` // Truncated to day
|
|
PackageID *int64 `gorm:"index:idx_stats_daily_package"` // NULL = all packages in registry
|
|
TopUserAgents JSONBField `gorm:"type:jsonb"` // Top 10 user agents
|
|
|
|
BaseModel
|
|
ID int64 `gorm:"primaryKey;autoIncrement"`
|
|
DownloadCount int64 `gorm:"not null;default:0"`
|
|
UniqueIPs int64 `gorm:"not null;default:0"`
|
|
AuthDownloads int64 `gorm:"not null;default:0"`
|
|
RegistryID int32 `gorm:"not null;index:idx_stats_daily_composite,priority:1"`
|
|
}
|
|
|
|
func (DownloadStatsDailyModel) TableName() string {
|
|
return "download_stats_daily"
|
|
}
|
|
|
|
// AuditLogModel tracks all important changes (optional, for compliance)
|
|
type AuditLogModel struct {
|
|
Timestamp time.Time `gorm:"not null;index:idx_audit_timestamp"`
|
|
Changes JSONBField `gorm:"type:jsonb"` // Before/after values
|
|
EntityType string `gorm:"not null;size:50;index:idx_audit_entity_type"` // package, bypass, registry
|
|
Action string `gorm:"not null;size:20;index:idx_audit_action"` // create, update, delete
|
|
Username string `gorm:"not null;size:255;index:idx_audit_username"`
|
|
IPAddress string `gorm:"size:45"`
|
|
UserAgent string `gorm:"size:512"`
|
|
|
|
// No BaseModel - append-only audit log
|
|
ID int64 `gorm:"primaryKey;autoIncrement"`
|
|
EntityID int64 `gorm:"not null;index:idx_audit_entity_id"`
|
|
}
|
|
|
|
func (AuditLogModel) TableName() string {
|
|
return "audit_log"
|
|
}
|
|
|
|
// APIKeyModel represents a persisted authentication API key.
|
|
// Index on (id, project, revoked) is provided via composite index
|
|
// idx_api_key_lookup so the auth manager can quickly enumerate
|
|
// non-revoked keys per project at startup.
|
|
type APIKeyModel struct {
|
|
CreatedAt time.Time `gorm:"not null"`
|
|
ExpiresAt *time.Time `gorm:"index:idx_api_key_expires"`
|
|
LastUsedAt *time.Time `gorm:"index:idx_api_key_last_used"`
|
|
ID string `gorm:"primaryKey;size:64;index:idx_api_key_lookup,priority:1"`
|
|
KeyHash string `gorm:"not null;size:255"` // bcrypt hash
|
|
Project string `gorm:"not null;size:255;index:idx_api_key_project;index:idx_api_key_lookup,priority:2"`
|
|
Role string `gorm:"not null;size:32;index:idx_api_key_role"` // read_only, read_write, admin
|
|
Permissions string `gorm:"type:text"` // JSON-encoded list (optional)
|
|
Revoked bool `gorm:"not null;default:false;index:idx_api_key_revoked;index:idx_api_key_lookup,priority:3"`
|
|
}
|
|
|
|
func (APIKeyModel) TableName() string {
|
|
return "api_keys"
|
|
}
|
|
|
|
// JSONBField is a custom type for JSONB (PostgreSQL) / JSON (MySQL/SQLite)
|
|
type JSONBField map[string]interface{}
|
|
|
|
func (j JSONBField) Value() (driver.Value, error) {
|
|
if j == nil {
|
|
return nil, nil
|
|
}
|
|
return json.Marshal(j)
|
|
}
|
|
|
|
func (j *JSONBField) Scan(value interface{}) error {
|
|
if value == nil {
|
|
*j = nil
|
|
return nil
|
|
}
|
|
|
|
bytes, ok := value.([]byte)
|
|
if !ok {
|
|
return nil
|
|
}
|
|
|
|
return json.Unmarshal(bytes, j)
|
|
}
|
|
|
|
// PostgresArray is a custom type for PostgreSQL arrays stored as JSON
|
|
type PostgresArray []string
|
|
|
|
func (a PostgresArray) Value() (driver.Value, error) {
|
|
if a == nil {
|
|
return nil, nil
|
|
}
|
|
return json.Marshal(a)
|
|
}
|
|
|
|
func (a *PostgresArray) Scan(value interface{}) error {
|
|
if value == nil {
|
|
*a = nil
|
|
return nil
|
|
}
|
|
|
|
bytes, ok := value.([]byte)
|
|
if !ok {
|
|
return nil
|
|
}
|
|
|
|
return json.Unmarshal(bytes, a)
|
|
}
|
|
|
|
// GetAllModels returns all models for GORM auto-migration
|
|
func GetAllModels() []interface{} {
|
|
return []interface{}{
|
|
&RegistryModel{},
|
|
&PackageModel{},
|
|
&PackageMetadataModel{},
|
|
&ScanResultModel{},
|
|
&VulnerabilityModel{},
|
|
&PackageVulnerabilityModel{},
|
|
&CVEBypassModel{},
|
|
&DownloadEventModel{},
|
|
&DownloadStatsHourlyModel{},
|
|
&DownloadStatsDailyModel{},
|
|
&AuditLogModel{},
|
|
&APIKeyModel{},
|
|
}
|
|
}
|