mirror of
https://github.com/lukaszraczylo/gohoarder.git
synced 2026-07-12 04:50:45 +00:00
e39d6a0f0d
Multi-agent audit + fix pass covering bugs, security, dead config wiring,
and missing features. All quality gates green: build/vet/test -race/govulncheck/
golangci-lint. Frontend tests 47/47.
SECURITY & CORRECTNESS
- Scanner pipeline fail-closed: cache.go scan timeout now 503 (was goto servePkg);
scanner.go all-scanners-fail saves ScanStatusError; CheckVulnerabilities blocks
on missing/error result instead of allowing.
- Scanner argv corrections: govulncheck source-mode + go.mod discovery;
npm-audit generates lockfile via npm install --package-lock-only --ignore-scripts;
pip-audit per-extension dispatch (wheel direct / sdist extract+pyproject).
- GHSA version-range filtering implemented (was always-include); url.QueryEscape
on package name.
- pypi SSRF closed via host allowlist on original_url; url.QueryEscape on
rewriteURL output.
- Path traversal: cache temp file uses os.CreateTemp; smb keyToPath sanitized;
filesystem keyToPath returns error + filepath.Abs prefix-verify.
- Goroutine leaks plugged: cache.cleanupWorker stop channel; auth.ValidationCache
Stop() with sync.Once; ws.unregister buffered with non-blocking send.
- WebSocket double-close panic fixed via sync.Once Client.closeSend().
- Race conditions: gormstore.registryCache sync.RWMutex (was concurrent map
panic); auth.LastUsedAt no longer mutated under RLock; analytics strict
lock-ordering invariant (statsMu before downloadsMu).
- Auth validator fails CLOSED on transport/unknown-status errors (was returning
true,err 'allow cache fallback').
- Credential cache hash full SHA256 (was 8-byte truncate; eliminates 2^32
collision risk).
- filesystem.fs.used incremented after successful rename (no quota inflation
race).
- gormstore aggregation events deleted in same tx as insert (no double-counting).
- gormstore.SavePackage uses Updates(map) so zero-value security flags
(RequiresAuth=false) can be cleared.
- partition_manager validates partition name regex before DROP TABLE.
- vcs/git: version regex validation rejects --option-injection; checkout uses
--detach -- separator; removed TrimPrefix(repo,'v') that corrupted vault/
vitess/vim-go.
- WebSocket CheckOrigin allowlist (was return true; CSWSH closed); same-origin
default + ServerConfig.AllowedOrigins.
- fiber CVE GO-2026-4543 patched (v2.52.10 -> v2.52.12).
FUNCTIONAL FEATURES
- API key DB persistence: APIKeyModel + migration 202604280002, full CRUD,
async LastUsedAt updates with WaitGroup-tracked goroutines drained on Close.
- Admin bootstrap via GOHOARDER_BOOTSTRAP_ADMIN_KEY env var; idempotent
(skipped when non-revoked admin already exists).
- Auth middleware factory in pkg/app: RequireAuth, RequireRole, RequirePermission,
OptionalAuth. Mounted on proxy + read APIs when Auth.Enabled=true.
DELETE /api/packages/* requires admin role. /health public for k8s probes.
- NFS storage backend: pkg/storage/nfs wraps filesystem with /proc/mounts
detection (Linux), post-write fsync, read-after-write health probe.
- WebSocket real-time pipeline: pkg/events Broadcaster interface; cache + scanner
managers emit EventPackageCached / EventPackageDownloaded / EventScanComplete;
app.go runs 30s EventStatsUpdate ticker. Frontend has full WS client (reconnect
with exponential backoff 1s->30s, 25s heartbeat, subscriber pattern), Pinia
realtime store, Dashboard live indicator + activity feed + reactive stats
override.
- TLS termination: fiber.ListenTLS when Server.TLS.Enabled.
- Pre-warming: Prewarming.Enabled flag wired (was hardcoded false); Interval,
MaxConcurrent, TopPackages plumbed.
- NetworkConfig wired (timeouts, retry, rate-limit, circuit-breaker).
- AuthConfig.BcryptCost wired.
- Security.Scanners.Static.MaxPackageSize plumbed to cache.io.LimitReader.
- Handlers.{Go,NPM,PyPI}.Enabled gates route mounting.
- Graceful shutdown: authManager.Close drains async writes.
LINT/HYGIENE
- 80 golangci-lint issues resolved: errcheck (Close/Write/RemoveAll wrapped),
gofmt, gosec G104/G306, govet shadow renames + fieldalignment reorders,
staticcheck ST1000 pkg comments + QF1003 tagged switches + QF1008 embedded
field selectors + QF1001 De Morgan's law.
BEHAVIOR CHANGES
- Scanner now fail-closed: deployments without scanner binaries
(trivy/govulncheck/npm-audit/pip-audit/grype) BLOCK packages instead of
serving unscanned. Add binaries or plan a future allow-on-scan-error flag.
- WS origin defaults to same-origin; cross-origin dashboards must set
server.allowed_origins.
- Validator no longer fails open; private packages won't serve from cache when
validation can't be performed.
- download_events retention dropped from 24h to ~5min (deleted in agg tx).
Migration 202604280001 purges pre-upgrade events.
- DELETE /api/packages/* requires admin role when auth enabled.
NEW PACKAGES
- pkg/events - Broadcaster interface
- pkg/storage/nfs - NFS-aware filesystem wrapper
DEFERRED (out of scope this pass)
- Static scanner implementation (config defines AllowedLicenses/MaxPackageSize/
BlockSuspicious but pkg/scanner/static/ does not exist).
- AuthConfig.AuditLog wiring (no audit log infra yet).
- CacheConfig.TTLOverrides passthrough (would touch cache.Config beyond
integrator scope).
116 lines
3.7 KiB
Go
116 lines
3.7 KiB
Go
package gormstore
|
|
|
|
import (
|
|
"context"
|
|
"time"
|
|
|
|
"github.com/lukaszraczylo/gohoarder/pkg/errors"
|
|
"github.com/lukaszraczylo/gohoarder/pkg/metadata"
|
|
"gorm.io/gorm"
|
|
"gorm.io/gorm/clause"
|
|
)
|
|
|
|
// SaveAPIKey persists an API key. Insert-or-update by primary key.
|
|
func (s *GORMStoreV2) SaveAPIKey(ctx context.Context, key *metadata.APIKey) error {
|
|
if key == nil || key.ID == "" {
|
|
return errors.New(errors.ErrCodeBadRequest, "api key id required")
|
|
}
|
|
|
|
model := &APIKeyModel{
|
|
ID: key.ID,
|
|
KeyHash: key.KeyHash,
|
|
Project: key.Project,
|
|
Role: key.Role,
|
|
Permissions: key.Permissions,
|
|
CreatedAt: key.CreatedAt,
|
|
ExpiresAt: key.ExpiresAt,
|
|
LastUsedAt: key.LastUsedAt,
|
|
Revoked: key.Revoked,
|
|
}
|
|
if model.CreatedAt.IsZero() {
|
|
model.CreatedAt = time.Now()
|
|
}
|
|
|
|
// Upsert on primary key. Updates all columns on conflict — keeps the call
|
|
// site simple (Generate then Revoke both flow through here).
|
|
err := s.db.WithContext(ctx).
|
|
Clauses(clause.OnConflict{
|
|
Columns: []clause.Column{{Name: "id"}},
|
|
UpdateAll: true,
|
|
}).
|
|
Create(model).Error
|
|
if err != nil {
|
|
return errors.Wrap(err, errors.ErrCodeStorageFailure, "failed to save api key")
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// GetAPIKey retrieves an API key by ID. Returns a not-found error if missing.
|
|
func (s *GORMStoreV2) GetAPIKey(ctx context.Context, id string) (*metadata.APIKey, error) {
|
|
var model APIKeyModel
|
|
err := s.db.WithContext(ctx).Where("id = ?", id).First(&model).Error
|
|
if err != nil {
|
|
if err == gorm.ErrRecordNotFound {
|
|
return nil, errors.New(errors.ErrCodeNotFound, "api key not found")
|
|
}
|
|
return nil, errors.Wrap(err, errors.ErrCodeStorageFailure, "failed to get api key")
|
|
}
|
|
return apiKeyModelToMetadata(&model), nil
|
|
}
|
|
|
|
// ListAPIKeys returns all API keys (revoked included). Caller filters as needed.
|
|
func (s *GORMStoreV2) ListAPIKeys(ctx context.Context) ([]*metadata.APIKey, error) {
|
|
var models []APIKeyModel
|
|
if err := s.db.WithContext(ctx).Order("created_at DESC").Find(&models).Error; err != nil {
|
|
return nil, errors.Wrap(err, errors.ErrCodeStorageFailure, "failed to list api keys")
|
|
}
|
|
out := make([]*metadata.APIKey, len(models))
|
|
for i := range models {
|
|
out[i] = apiKeyModelToMetadata(&models[i])
|
|
}
|
|
return out, nil
|
|
}
|
|
|
|
// DeleteAPIKey hard-deletes an API key by ID. Use SaveAPIKey with Revoked=true
|
|
// for audit-friendly revocation; this method is for explicit purges.
|
|
func (s *GORMStoreV2) DeleteAPIKey(ctx context.Context, id string) error {
|
|
result := s.db.WithContext(ctx).Where("id = ?", id).Delete(&APIKeyModel{})
|
|
if result.Error != nil {
|
|
return errors.Wrap(result.Error, errors.ErrCodeStorageFailure, "failed to delete api key")
|
|
}
|
|
if result.RowsAffected == 0 {
|
|
return errors.New(errors.ErrCodeNotFound, "api key not found")
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// UpdateAPIKeyLastUsed updates only last_used_at. Cheap (single column UPDATE).
|
|
// Auth manager calls this asynchronously per-request; do not perform extra
|
|
// work here without measuring impact.
|
|
func (s *GORMStoreV2) UpdateAPIKeyLastUsed(ctx context.Context, id string, t time.Time) error {
|
|
result := s.db.WithContext(ctx).
|
|
Model(&APIKeyModel{}).
|
|
Where("id = ?", id).
|
|
Update("last_used_at", t)
|
|
if result.Error != nil {
|
|
return errors.Wrap(result.Error, errors.ErrCodeStorageFailure, "failed to update api key last used")
|
|
}
|
|
// Missing rows are not fatal: caller validated the key against an
|
|
// in-memory snapshot that may have lagged a concurrent revoke.
|
|
return nil
|
|
}
|
|
|
|
func apiKeyModelToMetadata(m *APIKeyModel) *metadata.APIKey {
|
|
return &metadata.APIKey{
|
|
ID: m.ID,
|
|
KeyHash: m.KeyHash,
|
|
Project: m.Project,
|
|
Role: m.Role,
|
|
Permissions: m.Permissions,
|
|
CreatedAt: m.CreatedAt,
|
|
ExpiresAt: m.ExpiresAt,
|
|
LastUsedAt: m.LastUsedAt,
|
|
Revoked: m.Revoked,
|
|
}
|
|
}
|