mirror of
https://github.com/lukaszraczylo/gohoarder.git
synced 2026-07-12 04:50:45 +00:00
e39d6a0f0d
Multi-agent audit + fix pass covering bugs, security, dead config wiring,
and missing features. All quality gates green: build/vet/test -race/govulncheck/
golangci-lint. Frontend tests 47/47.
SECURITY & CORRECTNESS
- Scanner pipeline fail-closed: cache.go scan timeout now 503 (was goto servePkg);
scanner.go all-scanners-fail saves ScanStatusError; CheckVulnerabilities blocks
on missing/error result instead of allowing.
- Scanner argv corrections: govulncheck source-mode + go.mod discovery;
npm-audit generates lockfile via npm install --package-lock-only --ignore-scripts;
pip-audit per-extension dispatch (wheel direct / sdist extract+pyproject).
- GHSA version-range filtering implemented (was always-include); url.QueryEscape
on package name.
- pypi SSRF closed via host allowlist on original_url; url.QueryEscape on
rewriteURL output.
- Path traversal: cache temp file uses os.CreateTemp; smb keyToPath sanitized;
filesystem keyToPath returns error + filepath.Abs prefix-verify.
- Goroutine leaks plugged: cache.cleanupWorker stop channel; auth.ValidationCache
Stop() with sync.Once; ws.unregister buffered with non-blocking send.
- WebSocket double-close panic fixed via sync.Once Client.closeSend().
- Race conditions: gormstore.registryCache sync.RWMutex (was concurrent map
panic); auth.LastUsedAt no longer mutated under RLock; analytics strict
lock-ordering invariant (statsMu before downloadsMu).
- Auth validator fails CLOSED on transport/unknown-status errors (was returning
true,err 'allow cache fallback').
- Credential cache hash full SHA256 (was 8-byte truncate; eliminates 2^32
collision risk).
- filesystem.fs.used incremented after successful rename (no quota inflation
race).
- gormstore aggregation events deleted in same tx as insert (no double-counting).
- gormstore.SavePackage uses Updates(map) so zero-value security flags
(RequiresAuth=false) can be cleared.
- partition_manager validates partition name regex before DROP TABLE.
- vcs/git: version regex validation rejects --option-injection; checkout uses
--detach -- separator; removed TrimPrefix(repo,'v') that corrupted vault/
vitess/vim-go.
- WebSocket CheckOrigin allowlist (was return true; CSWSH closed); same-origin
default + ServerConfig.AllowedOrigins.
- fiber CVE GO-2026-4543 patched (v2.52.10 -> v2.52.12).
FUNCTIONAL FEATURES
- API key DB persistence: APIKeyModel + migration 202604280002, full CRUD,
async LastUsedAt updates with WaitGroup-tracked goroutines drained on Close.
- Admin bootstrap via GOHOARDER_BOOTSTRAP_ADMIN_KEY env var; idempotent
(skipped when non-revoked admin already exists).
- Auth middleware factory in pkg/app: RequireAuth, RequireRole, RequirePermission,
OptionalAuth. Mounted on proxy + read APIs when Auth.Enabled=true.
DELETE /api/packages/* requires admin role. /health public for k8s probes.
- NFS storage backend: pkg/storage/nfs wraps filesystem with /proc/mounts
detection (Linux), post-write fsync, read-after-write health probe.
- WebSocket real-time pipeline: pkg/events Broadcaster interface; cache + scanner
managers emit EventPackageCached / EventPackageDownloaded / EventScanComplete;
app.go runs 30s EventStatsUpdate ticker. Frontend has full WS client (reconnect
with exponential backoff 1s->30s, 25s heartbeat, subscriber pattern), Pinia
realtime store, Dashboard live indicator + activity feed + reactive stats
override.
- TLS termination: fiber.ListenTLS when Server.TLS.Enabled.
- Pre-warming: Prewarming.Enabled flag wired (was hardcoded false); Interval,
MaxConcurrent, TopPackages plumbed.
- NetworkConfig wired (timeouts, retry, rate-limit, circuit-breaker).
- AuthConfig.BcryptCost wired.
- Security.Scanners.Static.MaxPackageSize plumbed to cache.io.LimitReader.
- Handlers.{Go,NPM,PyPI}.Enabled gates route mounting.
- Graceful shutdown: authManager.Close drains async writes.
LINT/HYGIENE
- 80 golangci-lint issues resolved: errcheck (Close/Write/RemoveAll wrapped),
gofmt, gosec G104/G306, govet shadow renames + fieldalignment reorders,
staticcheck ST1000 pkg comments + QF1003 tagged switches + QF1008 embedded
field selectors + QF1001 De Morgan's law.
BEHAVIOR CHANGES
- Scanner now fail-closed: deployments without scanner binaries
(trivy/govulncheck/npm-audit/pip-audit/grype) BLOCK packages instead of
serving unscanned. Add binaries or plan a future allow-on-scan-error flag.
- WS origin defaults to same-origin; cross-origin dashboards must set
server.allowed_origins.
- Validator no longer fails open; private packages won't serve from cache when
validation can't be performed.
- download_events retention dropped from 24h to ~5min (deleted in agg tx).
Migration 202604280001 purges pre-upgrade events.
- DELETE /api/packages/* requires admin role when auth enabled.
NEW PACKAGES
- pkg/events - Broadcaster interface
- pkg/storage/nfs - NFS-aware filesystem wrapper
DEFERRED (out of scope this pass)
- Static scanner implementation (config defines AllowedLicenses/MaxPackageSize/
BlockSuspicious but pkg/scanner/static/ does not exist).
- AuthConfig.AuditLog wiring (no audit log infra yet).
- CacheConfig.TTLOverrides passthrough (would touch cache.Config beyond
integrator scope).
364 lines
12 KiB
Go
364 lines
12 KiB
Go
package gormstore
|
|
|
|
import (
|
|
"time"
|
|
|
|
"github.com/rs/zerolog/log"
|
|
"gorm.io/gorm"
|
|
)
|
|
|
|
// AggregationWorker handles background aggregation of download statistics
|
|
type AggregationWorker struct {
|
|
db *gorm.DB
|
|
stopChan chan struct{}
|
|
ticker *time.Ticker
|
|
}
|
|
|
|
// NewAggregationWorker creates a new aggregation worker
|
|
func NewAggregationWorker(db *gorm.DB) *AggregationWorker {
|
|
return &AggregationWorker{
|
|
db: db,
|
|
stopChan: make(chan struct{}),
|
|
ticker: time.NewTicker(1 * time.Hour), // Run every hour
|
|
}
|
|
}
|
|
|
|
// Start begins the aggregation worker
|
|
func (w *AggregationWorker) Start() {
|
|
log.Info().Msg("Starting aggregation worker")
|
|
|
|
// Run immediately on start
|
|
if err := w.AggregateHourly(); err != nil {
|
|
log.Error().Err(err).Msg("Failed to run initial hourly aggregation")
|
|
}
|
|
|
|
for {
|
|
select {
|
|
case <-w.ticker.C:
|
|
if err := w.AggregateHourly(); err != nil {
|
|
log.Error().Err(err).Msg("Failed to aggregate hourly stats")
|
|
}
|
|
|
|
// Check if it's time for daily aggregation (run at midnight)
|
|
now := time.Now()
|
|
if now.Hour() == 0 {
|
|
if err := w.AggregateDaily(); err != nil {
|
|
log.Error().Err(err).Msg("Failed to aggregate daily stats")
|
|
}
|
|
}
|
|
|
|
case <-w.stopChan:
|
|
log.Info().Msg("Stopping aggregation worker")
|
|
w.ticker.Stop()
|
|
return
|
|
}
|
|
}
|
|
}
|
|
|
|
// Stop stops the aggregation worker
|
|
func (w *AggregationWorker) Stop() {
|
|
close(w.stopChan)
|
|
}
|
|
|
|
// AggregateHourly aggregates download events into hourly stats
|
|
func (w *AggregationWorker) AggregateHourly() error {
|
|
startTime := time.Now()
|
|
log.Debug().Msg("Starting hourly aggregation")
|
|
|
|
// Get dialect name
|
|
dialectName := w.db.Name()
|
|
|
|
// Calculate cutoff time (aggregate events older than 5 minutes to avoid partial data)
|
|
cutoff := time.Now().Add(-5 * time.Minute).Truncate(time.Hour)
|
|
|
|
return w.db.Transaction(func(tx *gorm.DB) error {
|
|
var aggregateSQL string
|
|
|
|
switch dialectName {
|
|
case "postgres":
|
|
// PostgreSQL: Use date_trunc for time bucketing
|
|
aggregateSQL = `
|
|
INSERT INTO download_stats_hourly (registry_id, package_id, time_bucket, download_count, unique_ips, auth_downloads, created_at, updated_at)
|
|
SELECT
|
|
de.registry_id,
|
|
de.package_id,
|
|
date_trunc('hour', de.downloaded_at) AS time_bucket,
|
|
COUNT(*) AS download_count,
|
|
COUNT(DISTINCT de.ip_address) AS unique_ips,
|
|
COUNT(*) FILTER (WHERE de.authenticated = true) AS auth_downloads,
|
|
NOW() AS created_at,
|
|
NOW() AS updated_at
|
|
FROM download_events de
|
|
WHERE de.downloaded_at < ?
|
|
GROUP BY de.registry_id, de.package_id, time_bucket
|
|
ON CONFLICT (registry_id, COALESCE(package_id, 0), time_bucket)
|
|
DO UPDATE SET
|
|
download_count = download_stats_hourly.download_count + EXCLUDED.download_count,
|
|
unique_ips = GREATEST(download_stats_hourly.unique_ips, EXCLUDED.unique_ips),
|
|
auth_downloads = download_stats_hourly.auth_downloads + EXCLUDED.auth_downloads,
|
|
updated_at = NOW()
|
|
`
|
|
|
|
case "mysql":
|
|
// MySQL: Use DATE_FORMAT for time bucketing
|
|
aggregateSQL = `
|
|
INSERT INTO download_stats_hourly (registry_id, package_id, time_bucket, download_count, unique_ips, auth_downloads, created_at, updated_at)
|
|
SELECT
|
|
de.registry_id,
|
|
de.package_id,
|
|
DATE_FORMAT(de.downloaded_at, '%Y-%m-%d %H:00:00') AS time_bucket,
|
|
COUNT(*) AS download_count,
|
|
COUNT(DISTINCT de.ip_address) AS unique_ips,
|
|
SUM(CASE WHEN de.authenticated = true THEN 1 ELSE 0 END) AS auth_downloads,
|
|
NOW() AS created_at,
|
|
NOW() AS updated_at
|
|
FROM download_events de
|
|
WHERE de.downloaded_at < ?
|
|
GROUP BY de.registry_id, de.package_id, time_bucket
|
|
ON DUPLICATE KEY UPDATE
|
|
download_count = download_stats_hourly.download_count + VALUES(download_count),
|
|
unique_ips = GREATEST(download_stats_hourly.unique_ips, VALUES(unique_ips)),
|
|
auth_downloads = download_stats_hourly.auth_downloads + VALUES(auth_downloads),
|
|
updated_at = NOW()
|
|
`
|
|
|
|
default: // SQLite
|
|
// SQLite: Use strftime for time bucketing
|
|
// Note: SQLite doesn't support UPSERT as elegantly, need to handle separately
|
|
aggregateSQL = `
|
|
INSERT OR REPLACE INTO download_stats_hourly (registry_id, package_id, time_bucket, download_count, unique_ips, auth_downloads, created_at, updated_at)
|
|
SELECT
|
|
de.registry_id,
|
|
de.package_id,
|
|
strftime('%Y-%m-%d %H:00:00', de.downloaded_at) AS time_bucket,
|
|
COUNT(*) AS download_count,
|
|
COUNT(DISTINCT de.ip_address) AS unique_ips,
|
|
SUM(CASE WHEN de.authenticated = 1 THEN 1 ELSE 0 END) AS auth_downloads,
|
|
datetime('now') AS created_at,
|
|
datetime('now') AS updated_at
|
|
FROM download_events de
|
|
WHERE de.downloaded_at < ?
|
|
GROUP BY de.registry_id, de.package_id, time_bucket
|
|
`
|
|
}
|
|
|
|
// Execute aggregation
|
|
if err := tx.Exec(aggregateSQL, cutoff).Error; err != nil {
|
|
return err
|
|
}
|
|
|
|
// Delete aggregated events in the SAME transaction using the SAME cutoff
|
|
// that drove the aggregation. This guarantees an event is counted exactly
|
|
// once: prior to this commit it lives in download_events; after this commit
|
|
// it's reflected only in download_stats_hourly. Any later run sees only
|
|
// fresh events (downloaded_at >= cutoff at write time) and cannot
|
|
// double-count rows that were already aggregated.
|
|
// Trade-off: raw events older than `cutoff` are not retained for debugging.
|
|
deleteResult := tx.Exec("DELETE FROM download_events WHERE downloaded_at < ?", cutoff)
|
|
if deleteResult.Error != nil {
|
|
return deleteResult.Error
|
|
}
|
|
|
|
// Also update package-level stats (NULL package_id = registry totals)
|
|
var registryAggSQL string
|
|
switch dialectName {
|
|
case "postgres":
|
|
registryAggSQL = `
|
|
INSERT INTO download_stats_hourly (registry_id, package_id, time_bucket, download_count, unique_ips, auth_downloads, created_at, updated_at)
|
|
SELECT
|
|
registry_id,
|
|
NULL as package_id,
|
|
time_bucket,
|
|
SUM(download_count) as download_count,
|
|
SUM(unique_ips) as unique_ips,
|
|
SUM(auth_downloads) as auth_downloads,
|
|
NOW() as created_at,
|
|
NOW() as updated_at
|
|
FROM download_stats_hourly
|
|
WHERE package_id IS NOT NULL
|
|
GROUP BY registry_id, time_bucket
|
|
ON CONFLICT (registry_id, COALESCE(package_id, 0), time_bucket)
|
|
DO UPDATE SET
|
|
download_count = EXCLUDED.download_count,
|
|
unique_ips = EXCLUDED.unique_ips,
|
|
auth_downloads = EXCLUDED.auth_downloads,
|
|
updated_at = NOW()
|
|
`
|
|
case "mysql":
|
|
registryAggSQL = `
|
|
INSERT INTO download_stats_hourly (registry_id, package_id, time_bucket, download_count, unique_ips, auth_downloads, created_at, updated_at)
|
|
SELECT
|
|
registry_id,
|
|
NULL as package_id,
|
|
time_bucket,
|
|
SUM(download_count) as download_count,
|
|
SUM(unique_ips) as unique_ips,
|
|
SUM(auth_downloads) as auth_downloads,
|
|
NOW() as created_at,
|
|
NOW() as updated_at
|
|
FROM download_stats_hourly
|
|
WHERE package_id IS NOT NULL
|
|
GROUP BY registry_id, time_bucket
|
|
ON DUPLICATE KEY UPDATE
|
|
download_count = VALUES(download_count),
|
|
unique_ips = VALUES(unique_ips),
|
|
auth_downloads = VALUES(auth_downloads),
|
|
updated_at = NOW()
|
|
`
|
|
default:
|
|
// SQLite
|
|
registryAggSQL = `
|
|
INSERT OR REPLACE INTO download_stats_hourly (registry_id, package_id, time_bucket, download_count, unique_ips, auth_downloads, created_at, updated_at)
|
|
SELECT
|
|
registry_id,
|
|
NULL as package_id,
|
|
time_bucket,
|
|
SUM(download_count) as download_count,
|
|
SUM(unique_ips) as unique_ips,
|
|
SUM(auth_downloads) as auth_downloads,
|
|
datetime('now') as created_at,
|
|
datetime('now') as updated_at
|
|
FROM download_stats_hourly
|
|
WHERE package_id IS NOT NULL
|
|
GROUP BY registry_id, time_bucket
|
|
`
|
|
}
|
|
|
|
if err := tx.Exec(registryAggSQL).Error; err != nil {
|
|
log.Warn().Err(err).Msg("Failed to aggregate registry totals (continuing anyway)")
|
|
}
|
|
|
|
elapsed := time.Since(startTime)
|
|
log.Info().
|
|
Int64("deleted_events", deleteResult.RowsAffected).
|
|
Dur("duration", elapsed).
|
|
Msg("Completed hourly aggregation")
|
|
|
|
return nil
|
|
})
|
|
}
|
|
|
|
// AggregateDaily aggregates hourly stats into daily stats
|
|
func (w *AggregationWorker) AggregateDaily() error {
|
|
startTime := time.Now()
|
|
log.Debug().Msg("Starting daily aggregation")
|
|
|
|
dialectName := w.db.Name()
|
|
|
|
// Aggregate yesterday's data
|
|
yesterday := time.Now().AddDate(0, 0, -1).Truncate(24 * time.Hour)
|
|
dayEnd := yesterday.Add(24 * time.Hour)
|
|
|
|
return w.db.Transaction(func(tx *gorm.DB) error {
|
|
var aggregateSQL string
|
|
|
|
switch dialectName {
|
|
case "postgres":
|
|
aggregateSQL = `
|
|
INSERT INTO download_stats_daily (registry_id, package_id, time_bucket, download_count, unique_ips, auth_downloads, top_user_agents, created_at, updated_at)
|
|
SELECT
|
|
registry_id,
|
|
package_id,
|
|
date_trunc('day', time_bucket) AS time_bucket,
|
|
SUM(download_count) AS download_count,
|
|
MAX(unique_ips) AS unique_ips,
|
|
SUM(auth_downloads) AS auth_downloads,
|
|
'{}' AS top_user_agents,
|
|
NOW() AS created_at,
|
|
NOW() AS updated_at
|
|
FROM download_stats_hourly
|
|
WHERE time_bucket >= ? AND time_bucket < ?
|
|
GROUP BY registry_id, package_id, date_trunc('day', time_bucket)
|
|
ON CONFLICT (registry_id, COALESCE(package_id, 0), time_bucket)
|
|
DO UPDATE SET
|
|
download_count = EXCLUDED.download_count,
|
|
unique_ips = EXCLUDED.unique_ips,
|
|
auth_downloads = EXCLUDED.auth_downloads,
|
|
updated_at = NOW()
|
|
`
|
|
|
|
case "mysql":
|
|
aggregateSQL = `
|
|
INSERT INTO download_stats_daily (registry_id, package_id, time_bucket, download_count, unique_ips, auth_downloads, top_user_agents, created_at, updated_at)
|
|
SELECT
|
|
registry_id,
|
|
package_id,
|
|
DATE_FORMAT(time_bucket, '%Y-%m-%d 00:00:00') AS time_bucket,
|
|
SUM(download_count) AS download_count,
|
|
MAX(unique_ips) AS unique_ips,
|
|
SUM(auth_downloads) AS auth_downloads,
|
|
'{}' AS top_user_agents,
|
|
NOW() AS created_at,
|
|
NOW() AS updated_at
|
|
FROM download_stats_hourly
|
|
WHERE time_bucket >= ? AND time_bucket < ?
|
|
GROUP BY registry_id, package_id, DATE_FORMAT(time_bucket, '%Y-%m-%d 00:00:00')
|
|
ON DUPLICATE KEY UPDATE
|
|
download_count = VALUES(download_count),
|
|
unique_ips = VALUES(unique_ips),
|
|
auth_downloads = VALUES(auth_downloads),
|
|
updated_at = NOW()
|
|
`
|
|
|
|
default: // SQLite
|
|
aggregateSQL = `
|
|
INSERT OR REPLACE INTO download_stats_daily (registry_id, package_id, time_bucket, download_count, unique_ips, auth_downloads, top_user_agents, created_at, updated_at)
|
|
SELECT
|
|
registry_id,
|
|
package_id,
|
|
date(time_bucket) AS time_bucket,
|
|
SUM(download_count) AS download_count,
|
|
MAX(unique_ips) AS unique_ips,
|
|
SUM(auth_downloads) AS auth_downloads,
|
|
'{}' AS top_user_agents,
|
|
datetime('now') AS created_at,
|
|
datetime('now') AS updated_at
|
|
FROM download_stats_hourly
|
|
WHERE time_bucket >= ? AND time_bucket < ?
|
|
GROUP BY registry_id, package_id, date(time_bucket)
|
|
`
|
|
}
|
|
|
|
if err := tx.Exec(aggregateSQL, yesterday, dayEnd).Error; err != nil {
|
|
return err
|
|
}
|
|
|
|
// Delete old hourly stats (keep last 7 days)
|
|
deleteOlder := time.Now().AddDate(0, 0, -7)
|
|
deleteResult := tx.Exec("DELETE FROM download_stats_hourly WHERE time_bucket < ?", deleteOlder)
|
|
if deleteResult.Error != nil {
|
|
return deleteResult.Error
|
|
}
|
|
|
|
elapsed := time.Since(startTime)
|
|
log.Info().
|
|
Int64("deleted_hourly_stats", deleteResult.RowsAffected).
|
|
Dur("duration", elapsed).
|
|
Msg("Completed daily aggregation")
|
|
|
|
return nil
|
|
})
|
|
}
|
|
|
|
// UpdatePackageAccessCounts synchronizes package access_count from download stats
|
|
func (w *AggregationWorker) UpdatePackageAccessCounts() error {
|
|
log.Debug().Msg("Updating package access counts")
|
|
|
|
// Update from download_stats_hourly (sum all-time downloads per package)
|
|
updateSQL := `
|
|
UPDATE packages p
|
|
SET access_count = COALESCE((
|
|
SELECT SUM(download_count)
|
|
FROM download_stats_hourly dsh
|
|
WHERE dsh.package_id = p.id
|
|
), 0)
|
|
`
|
|
|
|
if err := w.db.Exec(updateSQL).Error; err != nil {
|
|
return err
|
|
}
|
|
|
|
log.Info().Msg("Updated package access counts")
|
|
return nil
|
|
}
|