mirror of
https://github.com/lukaszraczylo/gohoarder.git
synced 2026-07-13 04:57:11 +00:00
e39d6a0f0d
Multi-agent audit + fix pass covering bugs, security, dead config wiring,
and missing features. All quality gates green: build/vet/test -race/govulncheck/
golangci-lint. Frontend tests 47/47.
SECURITY & CORRECTNESS
- Scanner pipeline fail-closed: cache.go scan timeout now 503 (was goto servePkg);
scanner.go all-scanners-fail saves ScanStatusError; CheckVulnerabilities blocks
on missing/error result instead of allowing.
- Scanner argv corrections: govulncheck source-mode + go.mod discovery;
npm-audit generates lockfile via npm install --package-lock-only --ignore-scripts;
pip-audit per-extension dispatch (wheel direct / sdist extract+pyproject).
- GHSA version-range filtering implemented (was always-include); url.QueryEscape
on package name.
- pypi SSRF closed via host allowlist on original_url; url.QueryEscape on
rewriteURL output.
- Path traversal: cache temp file uses os.CreateTemp; smb keyToPath sanitized;
filesystem keyToPath returns error + filepath.Abs prefix-verify.
- Goroutine leaks plugged: cache.cleanupWorker stop channel; auth.ValidationCache
Stop() with sync.Once; ws.unregister buffered with non-blocking send.
- WebSocket double-close panic fixed via sync.Once Client.closeSend().
- Race conditions: gormstore.registryCache sync.RWMutex (was concurrent map
panic); auth.LastUsedAt no longer mutated under RLock; analytics strict
lock-ordering invariant (statsMu before downloadsMu).
- Auth validator fails CLOSED on transport/unknown-status errors (was returning
true,err 'allow cache fallback').
- Credential cache hash full SHA256 (was 8-byte truncate; eliminates 2^32
collision risk).
- filesystem.fs.used incremented after successful rename (no quota inflation
race).
- gormstore aggregation events deleted in same tx as insert (no double-counting).
- gormstore.SavePackage uses Updates(map) so zero-value security flags
(RequiresAuth=false) can be cleared.
- partition_manager validates partition name regex before DROP TABLE.
- vcs/git: version regex validation rejects --option-injection; checkout uses
--detach -- separator; removed TrimPrefix(repo,'v') that corrupted vault/
vitess/vim-go.
- WebSocket CheckOrigin allowlist (was return true; CSWSH closed); same-origin
default + ServerConfig.AllowedOrigins.
- fiber CVE GO-2026-4543 patched (v2.52.10 -> v2.52.12).
FUNCTIONAL FEATURES
- API key DB persistence: APIKeyModel + migration 202604280002, full CRUD,
async LastUsedAt updates with WaitGroup-tracked goroutines drained on Close.
- Admin bootstrap via GOHOARDER_BOOTSTRAP_ADMIN_KEY env var; idempotent
(skipped when non-revoked admin already exists).
- Auth middleware factory in pkg/app: RequireAuth, RequireRole, RequirePermission,
OptionalAuth. Mounted on proxy + read APIs when Auth.Enabled=true.
DELETE /api/packages/* requires admin role. /health public for k8s probes.
- NFS storage backend: pkg/storage/nfs wraps filesystem with /proc/mounts
detection (Linux), post-write fsync, read-after-write health probe.
- WebSocket real-time pipeline: pkg/events Broadcaster interface; cache + scanner
managers emit EventPackageCached / EventPackageDownloaded / EventScanComplete;
app.go runs 30s EventStatsUpdate ticker. Frontend has full WS client (reconnect
with exponential backoff 1s->30s, 25s heartbeat, subscriber pattern), Pinia
realtime store, Dashboard live indicator + activity feed + reactive stats
override.
- TLS termination: fiber.ListenTLS when Server.TLS.Enabled.
- Pre-warming: Prewarming.Enabled flag wired (was hardcoded false); Interval,
MaxConcurrent, TopPackages plumbed.
- NetworkConfig wired (timeouts, retry, rate-limit, circuit-breaker).
- AuthConfig.BcryptCost wired.
- Security.Scanners.Static.MaxPackageSize plumbed to cache.io.LimitReader.
- Handlers.{Go,NPM,PyPI}.Enabled gates route mounting.
- Graceful shutdown: authManager.Close drains async writes.
LINT/HYGIENE
- 80 golangci-lint issues resolved: errcheck (Close/Write/RemoveAll wrapped),
gofmt, gosec G104/G306, govet shadow renames + fieldalignment reorders,
staticcheck ST1000 pkg comments + QF1003 tagged switches + QF1008 embedded
field selectors + QF1001 De Morgan's law.
BEHAVIOR CHANGES
- Scanner now fail-closed: deployments without scanner binaries
(trivy/govulncheck/npm-audit/pip-audit/grype) BLOCK packages instead of
serving unscanned. Add binaries or plan a future allow-on-scan-error flag.
- WS origin defaults to same-origin; cross-origin dashboards must set
server.allowed_origins.
- Validator no longer fails open; private packages won't serve from cache when
validation can't be performed.
- download_events retention dropped from 24h to ~5min (deleted in agg tx).
Migration 202604280001 purges pre-upgrade events.
- DELETE /api/packages/* requires admin role when auth enabled.
NEW PACKAGES
- pkg/events - Broadcaster interface
- pkg/storage/nfs - NFS-aware filesystem wrapper
DEFERRED (out of scope this pass)
- Static scanner implementation (config defines AllowedLicenses/MaxPackageSize/
BlockSuspicious but pkg/scanner/static/ does not exist).
- AuthConfig.AuditLog wiring (no audit log infra yet).
- CacheConfig.TTLOverrides passthrough (would touch cache.Config beyond
integrator scope).
182 lines
4.5 KiB
Go
182 lines
4.5 KiB
Go
// Package health exposes liveness and readiness checks consumed by HTTP
|
|
// probes and orchestrators.
|
|
package health
|
|
|
|
import (
|
|
"context"
|
|
"net/http"
|
|
"sync"
|
|
"time"
|
|
|
|
json "github.com/goccy/go-json"
|
|
"github.com/lukaszraczylo/gohoarder/internal/version"
|
|
)
|
|
|
|
// Status represents component health status
|
|
type Status string
|
|
|
|
const (
|
|
StatusHealthy Status = "healthy"
|
|
StatusUnhealthy Status = "unhealthy"
|
|
StatusDegraded Status = "degraded"
|
|
)
|
|
|
|
// Check represents a single health check
|
|
type Check struct {
|
|
Fn func(context.Context) (Status, string) `json:"-"`
|
|
Name string `json:"name"`
|
|
Status Status `json:"status"`
|
|
Error string `json:"error,omitempty"`
|
|
}
|
|
|
|
// Response is the health check response
|
|
type Response struct {
|
|
Data *HealthData `json:"data,omitempty"`
|
|
Metadata *Metadata `json:"metadata,omitempty"`
|
|
Success bool `json:"success"`
|
|
}
|
|
|
|
// HealthData contains health check data
|
|
type HealthData struct {
|
|
Components map[string]*Component `json:"components"`
|
|
Status Status `json:"status"`
|
|
Version string `json:"version"`
|
|
Uptime string `json:"uptime"`
|
|
}
|
|
|
|
// Component represents a system component
|
|
type Component struct {
|
|
Status Status `json:"status"`
|
|
Details map[string]interface{} `json:"details,omitempty"`
|
|
Error string `json:"error,omitempty"`
|
|
}
|
|
|
|
// Metadata contains response metadata
|
|
type Metadata struct {
|
|
RequestID string `json:"request_id"`
|
|
Timestamp string `json:"timestamp"`
|
|
}
|
|
|
|
// Checker manages health checks
|
|
type Checker struct {
|
|
startTime time.Time
|
|
checks []*Check
|
|
mu sync.RWMutex
|
|
}
|
|
|
|
// New creates a new health checker
|
|
func New() *Checker {
|
|
return &Checker{
|
|
checks: make([]*Check, 0),
|
|
startTime: time.Now(),
|
|
}
|
|
}
|
|
|
|
// AddCheck adds a health check
|
|
func (c *Checker) AddCheck(name string, fn func(context.Context) (Status, string)) {
|
|
c.mu.Lock()
|
|
defer c.mu.Unlock()
|
|
|
|
c.checks = append(c.checks, &Check{
|
|
Name: name,
|
|
Fn: fn,
|
|
})
|
|
}
|
|
|
|
// RunChecks runs all health checks
|
|
func (c *Checker) RunChecks(ctx context.Context) *HealthData {
|
|
c.mu.RLock()
|
|
checks := make([]*Check, len(c.checks))
|
|
copy(checks, c.checks)
|
|
c.mu.RUnlock()
|
|
|
|
components := make(map[string]*Component)
|
|
overallStatus := StatusHealthy
|
|
|
|
for _, check := range checks {
|
|
status, errMsg := check.Fn(ctx)
|
|
components[check.Name] = &Component{
|
|
Status: status,
|
|
Error: errMsg,
|
|
}
|
|
|
|
// Determine overall status
|
|
if status == StatusUnhealthy {
|
|
overallStatus = StatusUnhealthy
|
|
} else if status == StatusDegraded && overallStatus == StatusHealthy {
|
|
overallStatus = StatusDegraded
|
|
}
|
|
}
|
|
|
|
return &HealthData{
|
|
Status: overallStatus,
|
|
Version: version.Version,
|
|
Uptime: time.Since(c.startTime).String(),
|
|
Components: components,
|
|
}
|
|
}
|
|
|
|
// HealthHandler returns an HTTP handler for health checks
|
|
func (c *Checker) HealthHandler() http.HandlerFunc {
|
|
return func(w http.ResponseWriter, r *http.Request) {
|
|
ctx, cancel := context.WithTimeout(r.Context(), 5*time.Second)
|
|
defer cancel()
|
|
|
|
healthData := c.RunChecks(ctx)
|
|
|
|
response := Response{
|
|
Success: healthData.Status == StatusHealthy,
|
|
Data: healthData,
|
|
Metadata: &Metadata{
|
|
RequestID: r.Header.Get("X-Request-ID"),
|
|
Timestamp: time.Now().UTC().Format(time.RFC3339),
|
|
},
|
|
}
|
|
|
|
statusCode := http.StatusOK
|
|
switch healthData.Status {
|
|
case StatusUnhealthy:
|
|
statusCode = http.StatusServiceUnavailable
|
|
case StatusDegraded:
|
|
statusCode = http.StatusOK // 200 but degraded
|
|
}
|
|
|
|
w.Header().Set("Content-Type", "application/json")
|
|
w.WriteHeader(statusCode)
|
|
_ = json.NewEncoder(w).Encode(response) // #nosec G104 -- JSON response write
|
|
}
|
|
}
|
|
|
|
// ReadyHandler returns an HTTP handler for readiness checks
|
|
func (c *Checker) ReadyHandler() http.HandlerFunc {
|
|
return func(w http.ResponseWriter, r *http.Request) {
|
|
ctx, cancel := context.WithTimeout(r.Context(), 5*time.Second)
|
|
defer cancel()
|
|
|
|
healthData := c.RunChecks(ctx)
|
|
|
|
ready := healthData.Status != StatusUnhealthy
|
|
|
|
response := Response{
|
|
Success: ready,
|
|
Data: &HealthData{
|
|
Status: healthData.Status,
|
|
Components: healthData.Components,
|
|
},
|
|
Metadata: &Metadata{
|
|
RequestID: r.Header.Get("X-Request-ID"),
|
|
Timestamp: time.Now().UTC().Format(time.RFC3339),
|
|
},
|
|
}
|
|
|
|
statusCode := http.StatusOK
|
|
if !ready {
|
|
statusCode = http.StatusServiceUnavailable
|
|
}
|
|
|
|
w.Header().Set("Content-Type", "application/json")
|
|
w.WriteHeader(statusCode)
|
|
_ = json.NewEncoder(w).Encode(response) // #nosec G104 -- JSON response write
|
|
}
|
|
}
|