mirror of
https://github.com/lukaszraczylo/gohoarder.git
synced 2026-10-13 00:48:26 +00:00
Multi-agent audit + fix pass covering bugs, security, dead config wiring,
and missing features. All quality gates green: build/vet/test -race/govulncheck/
golangci-lint. Frontend tests 47/47.
SECURITY & CORRECTNESS
- Scanner pipeline fail-closed: cache.go scan timeout now 503 (was goto servePkg);
scanner.go all-scanners-fail saves ScanStatusError; CheckVulnerabilities blocks
on missing/error result instead of allowing.
- Scanner argv corrections: govulncheck source-mode + go.mod discovery;
npm-audit generates lockfile via npm install --package-lock-only --ignore-scripts;
pip-audit per-extension dispatch (wheel direct / sdist extract+pyproject).
- GHSA version-range filtering implemented (was always-include); url.QueryEscape
on package name.
- pypi SSRF closed via host allowlist on original_url; url.QueryEscape on
rewriteURL output.
- Path traversal: cache temp file uses os.CreateTemp; smb keyToPath sanitized;
filesystem keyToPath returns error + filepath.Abs prefix-verify.
- Goroutine leaks plugged: cache.cleanupWorker stop channel; auth.ValidationCache
Stop() with sync.Once; ws.unregister buffered with non-blocking send.
- WebSocket double-close panic fixed via sync.Once Client.closeSend().
- Race conditions: gormstore.registryCache sync.RWMutex (was concurrent map
panic); auth.LastUsedAt no longer mutated under RLock; analytics strict
lock-ordering invariant (statsMu before downloadsMu).
- Auth validator fails CLOSED on transport/unknown-status errors (was returning
true,err 'allow cache fallback').
- Credential cache hash full SHA256 (was 8-byte truncate; eliminates 2^32
collision risk).
- filesystem.fs.used incremented after successful rename (no quota inflation
race).
- gormstore aggregation events deleted in same tx as insert (no double-counting).
- gormstore.SavePackage uses Updates(map) so zero-value security flags
(RequiresAuth=false) can be cleared.
- partition_manager validates partition name regex before DROP TABLE.
- vcs/git: version regex validation rejects --option-injection; checkout uses
--detach -- separator; removed TrimPrefix(repo,'v') that corrupted vault/
vitess/vim-go.
- WebSocket CheckOrigin allowlist (was return true; CSWSH closed); same-origin
default + ServerConfig.AllowedOrigins.
- fiber CVE GO-2026-4543 patched (v2.52.10 -> v2.52.12).
FUNCTIONAL FEATURES
- API key DB persistence: APIKeyModel + migration 202604280002, full CRUD,
async LastUsedAt updates with WaitGroup-tracked goroutines drained on Close.
- Admin bootstrap via GOHOARDER_BOOTSTRAP_ADMIN_KEY env var; idempotent
(skipped when non-revoked admin already exists).
- Auth middleware factory in pkg/app: RequireAuth, RequireRole, RequirePermission,
OptionalAuth. Mounted on proxy + read APIs when Auth.Enabled=true.
DELETE /api/packages/* requires admin role. /health public for k8s probes.
- NFS storage backend: pkg/storage/nfs wraps filesystem with /proc/mounts
detection (Linux), post-write fsync, read-after-write health probe.
- WebSocket real-time pipeline: pkg/events Broadcaster interface; cache + scanner
managers emit EventPackageCached / EventPackageDownloaded / EventScanComplete;
app.go runs 30s EventStatsUpdate ticker. Frontend has full WS client (reconnect
with exponential backoff 1s->30s, 25s heartbeat, subscriber pattern), Pinia
realtime store, Dashboard live indicator + activity feed + reactive stats
override.
- TLS termination: fiber.ListenTLS when Server.TLS.Enabled.
- Pre-warming: Prewarming.Enabled flag wired (was hardcoded false); Interval,
MaxConcurrent, TopPackages plumbed.
- NetworkConfig wired (timeouts, retry, rate-limit, circuit-breaker).
- AuthConfig.BcryptCost wired.
- Security.Scanners.Static.MaxPackageSize plumbed to cache.io.LimitReader.
- Handlers.{Go,NPM,PyPI}.Enabled gates route mounting.
- Graceful shutdown: authManager.Close drains async writes.
LINT/HYGIENE
- 80 golangci-lint issues resolved: errcheck (Close/Write/RemoveAll wrapped),
gofmt, gosec G104/G306, govet shadow renames + fieldalignment reorders,
staticcheck ST1000 pkg comments + QF1003 tagged switches + QF1008 embedded
field selectors + QF1001 De Morgan's law.
BEHAVIOR CHANGES
- Scanner now fail-closed: deployments without scanner binaries
(trivy/govulncheck/npm-audit/pip-audit/grype) BLOCK packages instead of
serving unscanned. Add binaries or plan a future allow-on-scan-error flag.
- WS origin defaults to same-origin; cross-origin dashboards must set
server.allowed_origins.
- Validator no longer fails open; private packages won't serve from cache when
validation can't be performed.
- download_events retention dropped from 24h to ~5min (deleted in agg tx).
Migration 202604280001 purges pre-upgrade events.
- DELETE /api/packages/* requires admin role when auth enabled.
NEW PACKAGES
- pkg/events - Broadcaster interface
- pkg/storage/nfs - NFS-aware filesystem wrapper
DEFERRED (out of scope this pass)
- Static scanner implementation (config defines AllowedLicenses/MaxPackageSize/
BlockSuspicious but pkg/scanner/static/ does not exist).
- AuthConfig.AuditLog wiring (no audit log infra yet).
- CacheConfig.TTLOverrides passthrough (would touch cache.Config beyond
integrator scope).
248 lines
6.7 KiB
TypeScript
248 lines
6.7 KiB
TypeScript
import { describe, it, expect, beforeEach, vi } from 'vitest'
|
|
import { mount } from '@vue/test-utils'
|
|
import { createPinia, setActivePinia } from 'pinia'
|
|
import Dashboard from './Dashboard.vue'
|
|
import { usePackageStore } from '../stores/packages'
|
|
import { useRealtimeStore, __resetRealtimeSingleton } from '../stores/realtime'
|
|
|
|
describe('Dashboard.vue', () => {
|
|
beforeEach(() => {
|
|
setActivePinia(createPinia())
|
|
__resetRealtimeSingleton()
|
|
// Mock the fetch functions to prevent actual API calls
|
|
const store = usePackageStore()
|
|
vi.spyOn(store, 'fetchStats').mockResolvedValue()
|
|
vi.spyOn(store, 'fetchPackages').mockResolvedValue()
|
|
})
|
|
|
|
it('renders dashboard component', () => {
|
|
const wrapper = mount(Dashboard)
|
|
expect(wrapper.find('h2').text()).toBe('Dashboard')
|
|
})
|
|
|
|
it('displays error message when error occurs', async () => {
|
|
const wrapper = mount(Dashboard)
|
|
const store = usePackageStore()
|
|
|
|
store.error = 'Failed to load dashboard'
|
|
await wrapper.vm.$nextTick()
|
|
|
|
expect(wrapper.text()).toContain('Failed to load dashboard')
|
|
})
|
|
|
|
it('displays loading state when loading', async () => {
|
|
const wrapper = mount(Dashboard)
|
|
const store = usePackageStore()
|
|
|
|
store.loading = true
|
|
await wrapper.vm.$nextTick()
|
|
|
|
expect(wrapper.text()).toContain('Loading statistics...')
|
|
})
|
|
|
|
it('displays overview stats cards', async () => {
|
|
const wrapper = mount(Dashboard)
|
|
const store = usePackageStore()
|
|
|
|
store.loading = false
|
|
store.stats = {
|
|
registry: '',
|
|
total_packages: 2,
|
|
total_size: 3072,
|
|
max_cache_size: 10737418240,
|
|
total_downloads: 30,
|
|
scanned_packages: 2,
|
|
vulnerable_packages: 0,
|
|
blocked_packages: 0,
|
|
}
|
|
await wrapper.vm.$nextTick()
|
|
|
|
expect(wrapper.text()).toContain('Total Packages')
|
|
expect(wrapper.text()).toContain('Total Size')
|
|
expect(wrapper.text()).toContain('Total Downloads')
|
|
})
|
|
|
|
it('displays total packages from stats', async () => {
|
|
const wrapper = mount(Dashboard)
|
|
const store = usePackageStore()
|
|
|
|
store.loading = false
|
|
store.stats = {
|
|
registry: '',
|
|
total_packages: 100,
|
|
total_size: 0,
|
|
max_cache_size: 10737418240,
|
|
total_downloads: 0,
|
|
scanned_packages: 0,
|
|
vulnerable_packages: 0,
|
|
blocked_packages: 0,
|
|
}
|
|
await wrapper.vm.$nextTick()
|
|
|
|
expect(wrapper.text()).toContain('100')
|
|
})
|
|
|
|
it('displays total downloads from stats', async () => {
|
|
const wrapper = mount(Dashboard)
|
|
const store = usePackageStore()
|
|
|
|
store.loading = false
|
|
store.stats = {
|
|
registry: '',
|
|
total_packages: 0,
|
|
total_size: 0,
|
|
max_cache_size: 10737418240,
|
|
total_downloads: 500,
|
|
scanned_packages: 0,
|
|
vulnerable_packages: 0,
|
|
blocked_packages: 0,
|
|
}
|
|
await wrapper.vm.$nextTick()
|
|
|
|
expect(wrapper.text()).toContain('500')
|
|
})
|
|
|
|
it('displays total size from stats', async () => {
|
|
const wrapper = mount(Dashboard)
|
|
const store = usePackageStore()
|
|
|
|
store.loading = false
|
|
store.stats = {
|
|
registry: '',
|
|
total_packages: 0,
|
|
total_size: 1048576, // 1 MB
|
|
max_cache_size: 10737418240,
|
|
total_downloads: 0,
|
|
scanned_packages: 0,
|
|
vulnerable_packages: 0,
|
|
blocked_packages: 0,
|
|
}
|
|
await wrapper.vm.$nextTick()
|
|
|
|
expect(wrapper.text()).toContain('1 MB')
|
|
})
|
|
|
|
it('displays recent packages section', async () => {
|
|
const wrapper = mount(Dashboard)
|
|
const store = usePackageStore()
|
|
|
|
store.loading = false
|
|
store.packages = [
|
|
{
|
|
id: '1',
|
|
registry: 'npm',
|
|
name: 'test-package',
|
|
version: '1.0.0',
|
|
size: 1024,
|
|
cached_at: '2025-01-01T00:00:00Z',
|
|
last_accessed: '2025-01-01T00:00:00Z',
|
|
download_count: 10,
|
|
},
|
|
]
|
|
await wrapper.vm.$nextTick()
|
|
|
|
expect(wrapper.text()).toContain('Recent Packages')
|
|
})
|
|
|
|
it('shows recent packages sorted by cached_at', async () => {
|
|
const wrapper = mount(Dashboard)
|
|
const store = usePackageStore()
|
|
|
|
store.loading = false
|
|
store.packages = [
|
|
{
|
|
id: '1',
|
|
registry: 'npm',
|
|
name: 'old-package',
|
|
version: '1.0.0',
|
|
size: 1024,
|
|
cached_at: '2025-01-01T00:00:00Z',
|
|
last_accessed: '2025-01-01T00:00:00Z',
|
|
download_count: 10,
|
|
},
|
|
{
|
|
id: '2',
|
|
registry: 'npm',
|
|
name: 'new-package',
|
|
version: '1.0.0',
|
|
size: 1024,
|
|
cached_at: '2025-01-02T00:00:00Z',
|
|
last_accessed: '2025-01-02T00:00:00Z',
|
|
download_count: 5,
|
|
},
|
|
]
|
|
await wrapper.vm.$nextTick()
|
|
|
|
const recentPackagesSection = wrapper.text().split('Recent Packages')[1]
|
|
|
|
// new-package should appear before old-package since it's more recent
|
|
expect(recentPackagesSection.indexOf('new-package')).toBeLessThan(
|
|
recentPackagesSection.indexOf('old-package')
|
|
)
|
|
})
|
|
|
|
it('limits recent packages to 10 items', async () => {
|
|
const wrapper = mount(Dashboard)
|
|
const store = usePackageStore()
|
|
|
|
store.loading = false
|
|
store.packages = Array.from({ length: 15 }, (_, i) => ({
|
|
id: `${i}`,
|
|
registry: 'npm',
|
|
name: `package${i}`,
|
|
version: '1.0.0',
|
|
size: 1024,
|
|
cached_at: `2025-01-${String(i + 1).padStart(2, '0')}T00:00:00Z`,
|
|
last_accessed: `2025-01-${String(i + 1).padStart(2, '0')}T00:00:00Z`,
|
|
download_count: i,
|
|
}))
|
|
await wrapper.vm.$nextTick()
|
|
|
|
const recentSection = wrapper.text().split('Recent Packages')[1]
|
|
// Count how many "package" strings appear (each package has the word "package" in its name)
|
|
const packageCount = (recentSection.match(/package\d+/g) || []).length
|
|
expect(packageCount).toBeLessThanOrEqual(10)
|
|
})
|
|
|
|
it('handles empty packages array', async () => {
|
|
const wrapper = mount(Dashboard)
|
|
const store = usePackageStore()
|
|
|
|
store.loading = false
|
|
store.packages = []
|
|
await wrapper.vm.$nextTick()
|
|
|
|
expect(wrapper.text()).toContain('0')
|
|
expect(wrapper.text()).toContain('0 B')
|
|
})
|
|
|
|
it('renders realtime lastStats over polled stats when present', async () => {
|
|
const wrapper = mount(Dashboard)
|
|
const store = usePackageStore()
|
|
const rt = useRealtimeStore()
|
|
|
|
store.loading = false
|
|
store.stats = {
|
|
registry: '',
|
|
total_packages: 10,
|
|
total_size: 1024,
|
|
max_cache_size: 10737418240,
|
|
total_downloads: 5,
|
|
scanned_packages: 0,
|
|
vulnerable_packages: 0,
|
|
blocked_packages: 0,
|
|
}
|
|
rt.lastStats = {
|
|
total_packages: 999,
|
|
total_size: 2048,
|
|
total_downloads: 777,
|
|
scanned_packages: 0,
|
|
}
|
|
await wrapper.vm.$nextTick()
|
|
|
|
// Realtime values should be visible (override polled values).
|
|
expect(wrapper.text()).toContain('999')
|
|
expect(wrapper.text()).toContain('777')
|
|
})
|
|
})
|