mirror of
https://github.com/lukaszraczylo/gohoarder.git
synced 2026-10-13 00:48:26 +00:00
Multi-agent audit + fix pass covering bugs, security, dead config wiring,
and missing features. All quality gates green: build/vet/test -race/govulncheck/
golangci-lint. Frontend tests 47/47.
SECURITY & CORRECTNESS
- Scanner pipeline fail-closed: cache.go scan timeout now 503 (was goto servePkg);
scanner.go all-scanners-fail saves ScanStatusError; CheckVulnerabilities blocks
on missing/error result instead of allowing.
- Scanner argv corrections: govulncheck source-mode + go.mod discovery;
npm-audit generates lockfile via npm install --package-lock-only --ignore-scripts;
pip-audit per-extension dispatch (wheel direct / sdist extract+pyproject).
- GHSA version-range filtering implemented (was always-include); url.QueryEscape
on package name.
- pypi SSRF closed via host allowlist on original_url; url.QueryEscape on
rewriteURL output.
- Path traversal: cache temp file uses os.CreateTemp; smb keyToPath sanitized;
filesystem keyToPath returns error + filepath.Abs prefix-verify.
- Goroutine leaks plugged: cache.cleanupWorker stop channel; auth.ValidationCache
Stop() with sync.Once; ws.unregister buffered with non-blocking send.
- WebSocket double-close panic fixed via sync.Once Client.closeSend().
- Race conditions: gormstore.registryCache sync.RWMutex (was concurrent map
panic); auth.LastUsedAt no longer mutated under RLock; analytics strict
lock-ordering invariant (statsMu before downloadsMu).
- Auth validator fails CLOSED on transport/unknown-status errors (was returning
true,err 'allow cache fallback').
- Credential cache hash full SHA256 (was 8-byte truncate; eliminates 2^32
collision risk).
- filesystem.fs.used incremented after successful rename (no quota inflation
race).
- gormstore aggregation events deleted in same tx as insert (no double-counting).
- gormstore.SavePackage uses Updates(map) so zero-value security flags
(RequiresAuth=false) can be cleared.
- partition_manager validates partition name regex before DROP TABLE.
- vcs/git: version regex validation rejects --option-injection; checkout uses
--detach -- separator; removed TrimPrefix(repo,'v') that corrupted vault/
vitess/vim-go.
- WebSocket CheckOrigin allowlist (was return true; CSWSH closed); same-origin
default + ServerConfig.AllowedOrigins.
- fiber CVE GO-2026-4543 patched (v2.52.10 -> v2.52.12).
FUNCTIONAL FEATURES
- API key DB persistence: APIKeyModel + migration 202604280002, full CRUD,
async LastUsedAt updates with WaitGroup-tracked goroutines drained on Close.
- Admin bootstrap via GOHOARDER_BOOTSTRAP_ADMIN_KEY env var; idempotent
(skipped when non-revoked admin already exists).
- Auth middleware factory in pkg/app: RequireAuth, RequireRole, RequirePermission,
OptionalAuth. Mounted on proxy + read APIs when Auth.Enabled=true.
DELETE /api/packages/* requires admin role. /health public for k8s probes.
- NFS storage backend: pkg/storage/nfs wraps filesystem with /proc/mounts
detection (Linux), post-write fsync, read-after-write health probe.
- WebSocket real-time pipeline: pkg/events Broadcaster interface; cache + scanner
managers emit EventPackageCached / EventPackageDownloaded / EventScanComplete;
app.go runs 30s EventStatsUpdate ticker. Frontend has full WS client (reconnect
with exponential backoff 1s->30s, 25s heartbeat, subscriber pattern), Pinia
realtime store, Dashboard live indicator + activity feed + reactive stats
override.
- TLS termination: fiber.ListenTLS when Server.TLS.Enabled.
- Pre-warming: Prewarming.Enabled flag wired (was hardcoded false); Interval,
MaxConcurrent, TopPackages plumbed.
- NetworkConfig wired (timeouts, retry, rate-limit, circuit-breaker).
- AuthConfig.BcryptCost wired.
- Security.Scanners.Static.MaxPackageSize plumbed to cache.io.LimitReader.
- Handlers.{Go,NPM,PyPI}.Enabled gates route mounting.
- Graceful shutdown: authManager.Close drains async writes.
LINT/HYGIENE
- 80 golangci-lint issues resolved: errcheck (Close/Write/RemoveAll wrapped),
gofmt, gosec G104/G306, govet shadow renames + fieldalignment reorders,
staticcheck ST1000 pkg comments + QF1003 tagged switches + QF1008 embedded
field selectors + QF1001 De Morgan's law.
BEHAVIOR CHANGES
- Scanner now fail-closed: deployments without scanner binaries
(trivy/govulncheck/npm-audit/pip-audit/grype) BLOCK packages instead of
serving unscanned. Add binaries or plan a future allow-on-scan-error flag.
- WS origin defaults to same-origin; cross-origin dashboards must set
server.allowed_origins.
- Validator no longer fails open; private packages won't serve from cache when
validation can't be performed.
- download_events retention dropped from 24h to ~5min (deleted in agg tx).
Migration 202604280001 purges pre-upgrade events.
- DELETE /api/packages/* requires admin role when auth enabled.
NEW PACKAGES
- pkg/events - Broadcaster interface
- pkg/storage/nfs - NFS-aware filesystem wrapper
DEFERRED (out of scope this pass)
- Static scanner implementation (config defines AllowedLicenses/MaxPackageSize/
BlockSuspicious but pkg/scanner/static/ does not exist).
- AuthConfig.AuditLog wiring (no audit log infra yet).
- CacheConfig.TTLOverrides passthrough (would touch cache.Config beyond
integrator scope).
119 lines
3.2 KiB
TypeScript
119 lines
3.2 KiB
TypeScript
import { defineStore } from 'pinia'
|
|
import { computed, ref } from 'vue'
|
|
import { WSClient, type EventType, type RealtimeEvent } from '@/lib/ws'
|
|
|
|
const EVENTS_CAP = 100
|
|
|
|
export interface RealtimeStats {
|
|
registry?: string
|
|
total_packages?: number
|
|
total_size?: number
|
|
max_cache_size?: number
|
|
total_downloads?: number
|
|
scanned_packages?: number
|
|
vulnerable_packages?: number
|
|
blocked_packages?: number
|
|
[key: string]: unknown
|
|
}
|
|
|
|
let singletonClient: WSClient | null = null
|
|
|
|
function getClient(url?: string): WSClient {
|
|
if (!singletonClient) {
|
|
singletonClient = new WSClient(url)
|
|
}
|
|
return singletonClient
|
|
}
|
|
|
|
// Test-only reset hook. Avoids leaking a singleton across tests.
|
|
export function __resetRealtimeSingleton(): void {
|
|
if (singletonClient) {
|
|
singletonClient.close()
|
|
}
|
|
singletonClient = null
|
|
}
|
|
|
|
export const useRealtimeStore = defineStore('realtime', () => {
|
|
const connected = ref(false)
|
|
const events = ref<RealtimeEvent[]>([])
|
|
const lastStats = ref<RealtimeStats | null>(null)
|
|
const unsubscribers = ref<Array<() => void>>([])
|
|
|
|
const recentCacheActivity = computed(() =>
|
|
events.value.filter(
|
|
(e) => e.type === 'package_cached' || e.type === 'package_downloaded',
|
|
),
|
|
)
|
|
|
|
const recentScans = computed(() =>
|
|
events.value.filter((e) => e.type === 'scan_complete'),
|
|
)
|
|
|
|
function appendEvent(event: RealtimeEvent): void {
|
|
events.value.push(event)
|
|
if (events.value.length > EVENTS_CAP) {
|
|
events.value.splice(0, events.value.length - EVENTS_CAP)
|
|
}
|
|
if (event.type === 'stats_update') {
|
|
lastStats.value = event.payload as RealtimeStats
|
|
}
|
|
}
|
|
|
|
function ingest(event: RealtimeEvent): void {
|
|
appendEvent(event)
|
|
}
|
|
|
|
function connect(url?: string): void {
|
|
// Bail in SSR / non-browser test environments where there is no
|
|
// WebSocket constructor. Keeps Dashboard.spec.ts (which mounts the
|
|
// component without a WS stub) from leaking timers.
|
|
const hasWS =
|
|
typeof globalThis !== 'undefined' &&
|
|
typeof (globalThis as { WebSocket?: unknown }).WebSocket !== 'undefined'
|
|
if (!hasWS) return
|
|
|
|
const client = getClient(url)
|
|
if (unsubscribers.value.length === 0) {
|
|
const types: EventType[] = [
|
|
'package_cached',
|
|
'package_deleted',
|
|
'package_downloaded',
|
|
'scan_complete',
|
|
'stats_update',
|
|
]
|
|
for (const t of types) {
|
|
unsubscribers.value.push(client.on(t, ingest))
|
|
}
|
|
// Poll connected status — WSClient does not yet emit connection events;
|
|
// a 1s tick is acceptable here and avoids tight coupling.
|
|
const tick = setInterval(() => {
|
|
connected.value = client.connected
|
|
}, 1_000)
|
|
unsubscribers.value.push(() => clearInterval(tick))
|
|
}
|
|
client.connect()
|
|
// Reflect the current state immediately so tests/UX don't wait a tick.
|
|
connected.value = client.connected
|
|
}
|
|
|
|
function disconnect(): void {
|
|
for (const off of unsubscribers.value) off()
|
|
unsubscribers.value = []
|
|
if (singletonClient) {
|
|
singletonClient.close()
|
|
}
|
|
connected.value = false
|
|
}
|
|
|
|
return {
|
|
connected,
|
|
events,
|
|
lastStats,
|
|
recentCacheActivity,
|
|
recentScans,
|
|
connect,
|
|
disconnect,
|
|
ingest,
|
|
}
|
|
})
|