mirror of
https://github.com/lukaszraczylo/gohoarder.git
synced 2026-10-13 00:48:26 +00:00
Multi-agent audit + fix pass covering bugs, security, dead config wiring,
and missing features. All quality gates green: build/vet/test -race/govulncheck/
golangci-lint. Frontend tests 47/47.
SECURITY & CORRECTNESS
- Scanner pipeline fail-closed: cache.go scan timeout now 503 (was goto servePkg);
scanner.go all-scanners-fail saves ScanStatusError; CheckVulnerabilities blocks
on missing/error result instead of allowing.
- Scanner argv corrections: govulncheck source-mode + go.mod discovery;
npm-audit generates lockfile via npm install --package-lock-only --ignore-scripts;
pip-audit per-extension dispatch (wheel direct / sdist extract+pyproject).
- GHSA version-range filtering implemented (was always-include); url.QueryEscape
on package name.
- pypi SSRF closed via host allowlist on original_url; url.QueryEscape on
rewriteURL output.
- Path traversal: cache temp file uses os.CreateTemp; smb keyToPath sanitized;
filesystem keyToPath returns error + filepath.Abs prefix-verify.
- Goroutine leaks plugged: cache.cleanupWorker stop channel; auth.ValidationCache
Stop() with sync.Once; ws.unregister buffered with non-blocking send.
- WebSocket double-close panic fixed via sync.Once Client.closeSend().
- Race conditions: gormstore.registryCache sync.RWMutex (was concurrent map
panic); auth.LastUsedAt no longer mutated under RLock; analytics strict
lock-ordering invariant (statsMu before downloadsMu).
- Auth validator fails CLOSED on transport/unknown-status errors (was returning
true,err 'allow cache fallback').
- Credential cache hash full SHA256 (was 8-byte truncate; eliminates 2^32
collision risk).
- filesystem.fs.used incremented after successful rename (no quota inflation
race).
- gormstore aggregation events deleted in same tx as insert (no double-counting).
- gormstore.SavePackage uses Updates(map) so zero-value security flags
(RequiresAuth=false) can be cleared.
- partition_manager validates partition name regex before DROP TABLE.
- vcs/git: version regex validation rejects --option-injection; checkout uses
--detach -- separator; removed TrimPrefix(repo,'v') that corrupted vault/
vitess/vim-go.
- WebSocket CheckOrigin allowlist (was return true; CSWSH closed); same-origin
default + ServerConfig.AllowedOrigins.
- fiber CVE GO-2026-4543 patched (v2.52.10 -> v2.52.12).
FUNCTIONAL FEATURES
- API key DB persistence: APIKeyModel + migration 202604280002, full CRUD,
async LastUsedAt updates with WaitGroup-tracked goroutines drained on Close.
- Admin bootstrap via GOHOARDER_BOOTSTRAP_ADMIN_KEY env var; idempotent
(skipped when non-revoked admin already exists).
- Auth middleware factory in pkg/app: RequireAuth, RequireRole, RequirePermission,
OptionalAuth. Mounted on proxy + read APIs when Auth.Enabled=true.
DELETE /api/packages/* requires admin role. /health public for k8s probes.
- NFS storage backend: pkg/storage/nfs wraps filesystem with /proc/mounts
detection (Linux), post-write fsync, read-after-write health probe.
- WebSocket real-time pipeline: pkg/events Broadcaster interface; cache + scanner
managers emit EventPackageCached / EventPackageDownloaded / EventScanComplete;
app.go runs 30s EventStatsUpdate ticker. Frontend has full WS client (reconnect
with exponential backoff 1s->30s, 25s heartbeat, subscriber pattern), Pinia
realtime store, Dashboard live indicator + activity feed + reactive stats
override.
- TLS termination: fiber.ListenTLS when Server.TLS.Enabled.
- Pre-warming: Prewarming.Enabled flag wired (was hardcoded false); Interval,
MaxConcurrent, TopPackages plumbed.
- NetworkConfig wired (timeouts, retry, rate-limit, circuit-breaker).
- AuthConfig.BcryptCost wired.
- Security.Scanners.Static.MaxPackageSize plumbed to cache.io.LimitReader.
- Handlers.{Go,NPM,PyPI}.Enabled gates route mounting.
- Graceful shutdown: authManager.Close drains async writes.
LINT/HYGIENE
- 80 golangci-lint issues resolved: errcheck (Close/Write/RemoveAll wrapped),
gofmt, gosec G104/G306, govet shadow renames + fieldalignment reorders,
staticcheck ST1000 pkg comments + QF1003 tagged switches + QF1008 embedded
field selectors + QF1001 De Morgan's law.
BEHAVIOR CHANGES
- Scanner now fail-closed: deployments without scanner binaries
(trivy/govulncheck/npm-audit/pip-audit/grype) BLOCK packages instead of
serving unscanned. Add binaries or plan a future allow-on-scan-error flag.
- WS origin defaults to same-origin; cross-origin dashboards must set
server.allowed_origins.
- Validator no longer fails open; private packages won't serve from cache when
validation can't be performed.
- download_events retention dropped from 24h to ~5min (deleted in agg tx).
Migration 202604280001 purges pre-upgrade events.
- DELETE /api/packages/* requires admin role when auth enabled.
NEW PACKAGES
- pkg/events - Broadcaster interface
- pkg/storage/nfs - NFS-aware filesystem wrapper
DEFERRED (out of scope this pass)
- Static scanner implementation (config defines AllowedLicenses/MaxPackageSize/
BlockSuspicious but pkg/scanner/static/ does not exist).
- AuthConfig.AuditLog wiring (no audit log infra yet).
- CacheConfig.TTLOverrides passthrough (would touch cache.Config beyond
integrator scope).
208 lines
5.7 KiB
TypeScript
208 lines
5.7 KiB
TypeScript
import { describe, it, expect, beforeEach, vi } from 'vitest'
|
|
import { mount } from '@vue/test-utils'
|
|
import { createPinia, setActivePinia } from 'pinia'
|
|
import Stats from './Stats.vue'
|
|
import { usePackageStore } from '../stores/packages'
|
|
|
|
describe('Stats.vue', () => {
|
|
beforeEach(() => {
|
|
setActivePinia(createPinia())
|
|
})
|
|
|
|
it('renders stats component', () => {
|
|
const wrapper = mount(Stats)
|
|
expect(wrapper.find('h2').text()).toBe('Statistics')
|
|
})
|
|
|
|
it('displays loading state when loading', async () => {
|
|
const wrapper = mount(Stats)
|
|
const store = usePackageStore()
|
|
|
|
store.loading = true
|
|
await wrapper.vm.$nextTick()
|
|
|
|
expect(wrapper.text()).toContain('Loading statistics...')
|
|
})
|
|
|
|
it('displays error message when error occurs', async () => {
|
|
const wrapper = mount(Stats)
|
|
const store = usePackageStore()
|
|
|
|
store.error = 'Failed to fetch statistics'
|
|
await wrapper.vm.$nextTick()
|
|
|
|
expect(wrapper.text()).toContain('Failed to fetch statistics')
|
|
})
|
|
|
|
it('displays overall statistics', async () => {
|
|
const wrapper = mount(Stats)
|
|
const store = usePackageStore()
|
|
|
|
store.loading = false
|
|
store.stats = {
|
|
registry: '',
|
|
total_packages: 100,
|
|
total_size: 1073741824, // 1 GB
|
|
max_cache_size: 10737418240,
|
|
total_downloads: 500,
|
|
scanned_packages: 90,
|
|
vulnerable_packages: 5,
|
|
blocked_packages: 0,
|
|
}
|
|
await wrapper.vm.$nextTick()
|
|
|
|
expect(wrapper.text()).toContain('Overall Statistics')
|
|
expect(wrapper.text()).toContain('100')
|
|
expect(wrapper.text()).toContain('500')
|
|
})
|
|
|
|
it('displays security scanning statistics', async () => {
|
|
const wrapper = mount(Stats)
|
|
const store = usePackageStore()
|
|
|
|
store.loading = false
|
|
store.stats = {
|
|
registry: '',
|
|
total_packages: 100,
|
|
total_size: 1073741824,
|
|
max_cache_size: 10737418240,
|
|
total_downloads: 500,
|
|
scanned_packages: 90,
|
|
vulnerable_packages: 5,
|
|
blocked_packages: 0,
|
|
}
|
|
await wrapper.vm.$nextTick()
|
|
|
|
expect(wrapper.text()).toContain('Security Scanning')
|
|
expect(wrapper.text()).toContain('Scanned Packages')
|
|
expect(wrapper.text()).toContain('Vulnerable Packages')
|
|
})
|
|
|
|
it('displays registry breakdown', async () => {
|
|
const wrapper = mount(Stats)
|
|
const store = usePackageStore()
|
|
|
|
store.loading = false
|
|
store.stats = {
|
|
registry: '',
|
|
total_packages: 100,
|
|
total_size: 1073741824,
|
|
max_cache_size: 10737418240,
|
|
total_downloads: 500,
|
|
scanned_packages: 90,
|
|
vulnerable_packages: 5,
|
|
blocked_packages: 0,
|
|
}
|
|
store.registries = {
|
|
npm: {
|
|
count: 50,
|
|
size: 536870912, // 512 MB
|
|
downloads: 300,
|
|
},
|
|
pypi: {
|
|
count: 30,
|
|
size: 322122547, // ~307 MB
|
|
downloads: 150,
|
|
},
|
|
go: {
|
|
count: 20,
|
|
size: 214748365, // ~205 MB
|
|
downloads: 50,
|
|
},
|
|
}
|
|
await wrapper.vm.$nextTick()
|
|
|
|
expect(wrapper.text()).toContain('Registry Breakdown')
|
|
expect(wrapper.text()).toContain('NPM Registry')
|
|
expect(wrapper.text()).toContain('PyPI Registry')
|
|
expect(wrapper.text()).toContain('Go Modules')
|
|
expect(wrapper.text()).toContain('50 packages')
|
|
expect(wrapper.text()).toContain('30 packages')
|
|
expect(wrapper.text()).toContain('20 packages')
|
|
})
|
|
|
|
it('formats bytes correctly in overall stats', async () => {
|
|
const wrapper = mount(Stats)
|
|
const store = usePackageStore()
|
|
|
|
store.loading = false
|
|
store.stats = {
|
|
registry: '',
|
|
total_packages: 100,
|
|
total_size: 1073741824, // 1 GB
|
|
max_cache_size: 10737418240,
|
|
total_downloads: 500,
|
|
scanned_packages: 90,
|
|
vulnerable_packages: 5,
|
|
blocked_packages: 0,
|
|
}
|
|
await wrapper.vm.$nextTick()
|
|
|
|
expect(wrapper.text()).toContain('1 GB')
|
|
})
|
|
|
|
it('calls fetchStats on mount', () => {
|
|
const store = usePackageStore()
|
|
const fetchSpy = vi.spyOn(store, 'fetchStats')
|
|
|
|
mount(Stats)
|
|
|
|
expect(fetchSpy).toHaveBeenCalled()
|
|
})
|
|
|
|
it('displays correct icon colors for different registries', async () => {
|
|
const wrapper = mount(Stats)
|
|
const store = usePackageStore()
|
|
|
|
store.loading = false
|
|
store.stats = {
|
|
registry: '',
|
|
total_packages: 3,
|
|
total_size: 0,
|
|
max_cache_size: 10737418240,
|
|
total_downloads: 0,
|
|
scanned_packages: 0,
|
|
vulnerable_packages: 0,
|
|
blocked_packages: 0,
|
|
}
|
|
store.registries = {
|
|
npm: { count: 1, size: 0, downloads: 0 },
|
|
pypi: { count: 1, size: 0, downloads: 0 },
|
|
go: { count: 1, size: 0, downloads: 0 },
|
|
}
|
|
await wrapper.vm.$nextTick()
|
|
|
|
// Scope to the registry icon containers (w-12 h-12 rounded-full),
|
|
// excluding the storage progress bar which also uses rounded-full.
|
|
const containers = wrapper.findAll('.w-12.h-12.rounded-full')
|
|
expect(containers).toHaveLength(3)
|
|
expect(containers[0].classes()).toContain('bg-red-100') // npm
|
|
expect(containers[1].classes()).toContain('bg-blue-100') // pypi
|
|
expect(containers[2].classes()).toContain('bg-cyan-100') // go
|
|
})
|
|
|
|
it('handles empty registries data', async () => {
|
|
const wrapper = mount(Stats)
|
|
const store = usePackageStore()
|
|
|
|
store.loading = false
|
|
store.stats = {
|
|
registry: '',
|
|
total_packages: 0,
|
|
total_size: 0,
|
|
max_cache_size: 10737418240,
|
|
total_downloads: 0,
|
|
scanned_packages: 0,
|
|
vulnerable_packages: 0,
|
|
blocked_packages: 0,
|
|
}
|
|
store.registries = {}
|
|
await wrapper.vm.$nextTick()
|
|
|
|
expect(wrapper.text()).toContain('Registry Breakdown')
|
|
// Should have no registry items
|
|
const registryItems = wrapper.findAll('.bg-gray-50')
|
|
expect(registryItems.length).toBe(3) // Only the overall stats cards
|
|
})
|
|
})
|