feat: comprehensive audit + Tier 3 wiring (security/correctness/features)

Multi-agent audit + fix pass covering bugs, security, dead config wiring,
and missing features. All quality gates green: build/vet/test -race/govulncheck/
golangci-lint. Frontend tests 47/47.

SECURITY & CORRECTNESS

- Scanner pipeline fail-closed: cache.go scan timeout now 503 (was goto servePkg);
  scanner.go all-scanners-fail saves ScanStatusError; CheckVulnerabilities blocks
  on missing/error result instead of allowing.
- Scanner argv corrections: govulncheck source-mode + go.mod discovery;
  npm-audit generates lockfile via npm install --package-lock-only --ignore-scripts;
  pip-audit per-extension dispatch (wheel direct / sdist extract+pyproject).
- GHSA version-range filtering implemented (was always-include); url.QueryEscape
  on package name.
- pypi SSRF closed via host allowlist on original_url; url.QueryEscape on
  rewriteURL output.
- Path traversal: cache temp file uses os.CreateTemp; smb keyToPath sanitized;
  filesystem keyToPath returns error + filepath.Abs prefix-verify.
- Goroutine leaks plugged: cache.cleanupWorker stop channel; auth.ValidationCache
  Stop() with sync.Once; ws.unregister buffered with non-blocking send.
- WebSocket double-close panic fixed via sync.Once Client.closeSend().
- Race conditions: gormstore.registryCache sync.RWMutex (was concurrent map
  panic); auth.LastUsedAt no longer mutated under RLock; analytics strict
  lock-ordering invariant (statsMu before downloadsMu).
- Auth validator fails CLOSED on transport/unknown-status errors (was returning
  true,err 'allow cache fallback').
- Credential cache hash full SHA256 (was 8-byte truncate; eliminates 2^32
  collision risk).
- filesystem.fs.used incremented after successful rename (no quota inflation
  race).
- gormstore aggregation events deleted in same tx as insert (no double-counting).
- gormstore.SavePackage uses Updates(map) so zero-value security flags
  (RequiresAuth=false) can be cleared.
- partition_manager validates partition name regex before DROP TABLE.
- vcs/git: version regex validation rejects --option-injection; checkout uses
  --detach -- separator; removed TrimPrefix(repo,'v') that corrupted vault/
  vitess/vim-go.
- WebSocket CheckOrigin allowlist (was return true; CSWSH closed); same-origin
  default + ServerConfig.AllowedOrigins.
- fiber CVE GO-2026-4543 patched (v2.52.10 -> v2.52.12).

FUNCTIONAL FEATURES

- API key DB persistence: APIKeyModel + migration 202604280002, full CRUD,
  async LastUsedAt updates with WaitGroup-tracked goroutines drained on Close.
- Admin bootstrap via GOHOARDER_BOOTSTRAP_ADMIN_KEY env var; idempotent
  (skipped when non-revoked admin already exists).
- Auth middleware factory in pkg/app: RequireAuth, RequireRole, RequirePermission,
  OptionalAuth. Mounted on proxy + read APIs when Auth.Enabled=true.
  DELETE /api/packages/* requires admin role. /health public for k8s probes.
- NFS storage backend: pkg/storage/nfs wraps filesystem with /proc/mounts
  detection (Linux), post-write fsync, read-after-write health probe.
- WebSocket real-time pipeline: pkg/events Broadcaster interface; cache + scanner
  managers emit EventPackageCached / EventPackageDownloaded / EventScanComplete;
  app.go runs 30s EventStatsUpdate ticker. Frontend has full WS client (reconnect
  with exponential backoff 1s->30s, 25s heartbeat, subscriber pattern), Pinia
  realtime store, Dashboard live indicator + activity feed + reactive stats
  override.
- TLS termination: fiber.ListenTLS when Server.TLS.Enabled.
- Pre-warming: Prewarming.Enabled flag wired (was hardcoded false); Interval,
  MaxConcurrent, TopPackages plumbed.
- NetworkConfig wired (timeouts, retry, rate-limit, circuit-breaker).
- AuthConfig.BcryptCost wired.
- Security.Scanners.Static.MaxPackageSize plumbed to cache.io.LimitReader.
- Handlers.{Go,NPM,PyPI}.Enabled gates route mounting.
- Graceful shutdown: authManager.Close drains async writes.

LINT/HYGIENE

- 80 golangci-lint issues resolved: errcheck (Close/Write/RemoveAll wrapped),
  gofmt, gosec G104/G306, govet shadow renames + fieldalignment reorders,
  staticcheck ST1000 pkg comments + QF1003 tagged switches + QF1008 embedded
  field selectors + QF1001 De Morgan's law.

BEHAVIOR CHANGES

- Scanner now fail-closed: deployments without scanner binaries
  (trivy/govulncheck/npm-audit/pip-audit/grype) BLOCK packages instead of
  serving unscanned. Add binaries or plan a future allow-on-scan-error flag.
- WS origin defaults to same-origin; cross-origin dashboards must set
  server.allowed_origins.
- Validator no longer fails open; private packages won't serve from cache when
  validation can't be performed.
- download_events retention dropped from 24h to ~5min (deleted in agg tx).
  Migration 202604280001 purges pre-upgrade events.
- DELETE /api/packages/* requires admin role when auth enabled.

NEW PACKAGES

- pkg/events  - Broadcaster interface
- pkg/storage/nfs  - NFS-aware filesystem wrapper

DEFERRED (out of scope this pass)

- Static scanner implementation (config defines AllowedLicenses/MaxPackageSize/
  BlockSuspicious but pkg/scanner/static/ does not exist).
- AuthConfig.AuditLog wiring (no audit log infra yet).
- CacheConfig.TTLOverrides passthrough (would touch cache.Config beyond
  integrator scope).

pkg/metadata/gormstore/gormstore_v2.go

@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"strconv"
 	"strings"
+	"sync"
 	"time"
 
 	"github.com/lukaszraczylo/gohoarder/pkg/errors"
@@ -23,6 +24,7 @@ type GORMStoreV2 struct {
 	registryCache     map[string]int32 // Cache registry name -> ID mapping
 	aggregationWorker *AggregationWorker
 	partitionManager  *PartitionManager
+	registryCacheMu   sync.RWMutex // Protects registryCache for concurrent access
 }
 
 // NewV2 creates a new GORM-based metadata store with V2 schema
@@ -102,7 +104,7 @@ func NewV2(cfg Config) (*GORMStoreV2, error) {
 	}
 
 	// Seed default registries if empty
-	if len(store.registryCache) == 0 {
+	if store.registryCacheLen() == 0 {
 		if err := store.seedDefaultRegistries(); err != nil {
 			return nil, err
 		}
@@ -133,12 +135,21 @@ func (s *GORMStoreV2) loadRegistryCache() error {
 		return errors.Wrap(err, errors.ErrCodeStorageFailure, "failed to load registries")
 	}
 
+	s.registryCacheMu.Lock()
 	for _, r := range registries {
 		s.registryCache[r.Name] = r.ID
 	}
+	s.registryCacheMu.Unlock()
 	return nil
 }
 
+// registryCacheLen returns current cache size (used after loading default seed data)
+func (s *GORMStoreV2) registryCacheLen() int {
+	s.registryCacheMu.RLock()
+	defer s.registryCacheMu.RUnlock()
+	return len(s.registryCache)
+}
+
 // seedDefaultRegistries creates default registry entries
 func (s *GORMStoreV2) seedDefaultRegistries() error {
 	defaultRegistries := []RegistryModel{
@@ -151,7 +162,9 @@ func (s *GORMStoreV2) seedDefaultRegistries() error {
 		if err := s.db.Create(&reg).Error; err != nil {
 			return errors.Wrap(err, errors.ErrCodeStorageFailure, "failed to seed registry: "+reg.Name)
 		}
+		s.registryCacheMu.Lock()
 		s.registryCache[reg.Name] = reg.ID
+		s.registryCacheMu.Unlock()
 	}
 
 	log.Info().Msg("Seeded default registries: npm, pypi, go")
@@ -160,9 +173,13 @@ func (s *GORMStoreV2) seedDefaultRegistries() error {
 
 // getRegistryID returns the registry ID from cache or database
 func (s *GORMStoreV2) getRegistryID(name string) (int32, error) {
+	// Fast path: read lock for cache hit
+	s.registryCacheMu.RLock()
 	if id, ok := s.registryCache[name]; ok {
+		s.registryCacheMu.RUnlock()
 		return id, nil
 	}
+	s.registryCacheMu.RUnlock()
 
 	// Not in cache, try to load from database
 	var reg RegistryModel
@@ -173,7 +190,15 @@ func (s *GORMStoreV2) getRegistryID(name string) (int32, error) {
 		return 0, errors.Wrap(err, errors.ErrCodeStorageFailure, "failed to query registry")
 	}
 
+	// Promote to write lock to populate cache
+	s.registryCacheMu.Lock()
+	// Re-check: another goroutine may have populated between RUnlock and Lock
+	if existing, ok := s.registryCache[name]; ok {
+		s.registryCacheMu.Unlock()
+		return existing, nil
+	}
 	s.registryCache[name] = reg.ID
+	s.registryCacheMu.Unlock()
 	return reg.ID, nil
 }
 
@@ -212,10 +237,29 @@ func (s *GORMStoreV2) SavePackage(ctx context.Context, pkg *metadata.Package) er
 			AuthProvider:   pkg.AuthProvider,
 		}
 
-		// Upsert package: first try to update, if no rows affected then create
+		// Upsert package: first try to update, if no rows affected then create.
+		// IMPORTANT: use map[string]interface{} so that zero values
+		// (e.g. RequiresAuth=false, Size=0) are written explicitly. With Updates(struct)
+		// GORM silently skips zero fields, which leaves stale security-relevant flags.
+		updateFields := map[string]interface{}{
+			"registry_id":     registryID,
+			"name":            pkg.Name,
+			"version":         pkg.Version,
+			"storage_key":     pkg.StorageKey,
+			"size":            pkg.Size,
+			"checksum_md5":    pkg.ChecksumMD5,
+			"checksum_sha256": pkg.ChecksumSHA256,
+			"upstream_url":    pkg.UpstreamURL,
+			"cached_at":       pkg.CachedAt,
+			"last_accessed":   pkg.LastAccessed,
+			"expires_at":      pkg.ExpiresAt,
+			"requires_auth":   pkg.RequiresAuth,
+			"auth_provider":   pkg.AuthProvider,
+		}
+
 		result := tx.Model(&PackageModel{}).
 			Where("registry_id = ? AND name = ? AND version = ?", registryID, pkg.Name, pkg.Version).
-			Updates(model)
+			Updates(updateFields)
 
 		if result.Error != nil {
 			return errors.Wrap(result.Error, errors.ErrCodeStorageFailure, "failed to update package")
@@ -226,6 +270,14 @@ func (s *GORMStoreV2) SavePackage(ctx context.Context, pkg *metadata.Package) er
 			if err := tx.Create(model).Error; err != nil {
 				return errors.Wrap(err, errors.ErrCodeStorageFailure, "failed to create package")
 			}
+		} else {
+			// On update, fetch the row's primary key for downstream metadata save
+			if err := tx.Model(&PackageModel{}).
+				Select("id").
+				Where("registry_id = ? AND name = ? AND version = ?", registryID, pkg.Name, pkg.Version).
+				First(model).Error; err != nil {
+				return errors.Wrap(err, errors.ErrCodeStorageFailure, "failed to reload package id after update")
+			}
 		}
 
 		// Save metadata if present
@@ -415,16 +467,15 @@ func (s *GORMStoreV2) ListPackages(ctx context.Context, opts *metadata.ListOptio
 
 	// Convert to metadata.Package
 	packages := make([]*metadata.Package, len(models))
+	// Snapshot id->name mapping under read lock once to avoid repeated locking
+	s.registryCacheMu.RLock()
+	idToName := make(map[int32]string, len(s.registryCache))
+	for name, id := range s.registryCache {
+		idToName[id] = name
+	}
+	s.registryCacheMu.RUnlock()
 	for i, model := range models {
-		// Get registry name from cache
-		var regName string
-		for name, id := range s.registryCache {
-			if id == model.RegistryID {
-				regName = name
-				break
-			}
-		}
-		packages[i] = s.modelToPackage(&model, regName)
+		packages[i] = s.modelToPackage(&model, idToName[model.RegistryID])
 	}
 
 	return packages, nil