lukaszraczylo/gohoarder
1
0
Fork 0
mirror of https://github.com/lukaszraczylo/gohoarder.git synced 2026-06-10 23:29:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: accept GitHub API rate limits in GHSA health check

Browse Source 
- Rate limits (403) are now accepted as healthy
- Rate limiting is expected without a GitHub token
- Only real errors (network failures, 500s) fail the health check
- Prevents health check failures due to unauthenticated API usage

Related: GHSA scanner health checks
This commit is contained in:
Lukasz Raczylo
2026-01-04 13:33:49 +00:00
parent bf0925a4fc
commit c207aa72e9
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/scanner/ghsa/ghsa.go
+9 -3
View File
@@ -107,11 +107,17 @@ func (s *Scanner) Health(ctx context.Context) error {
} }
defer resp.Body.Close() // #nosec G104 -- Cleanup, error not critical defer resp.Body.Close() // #nosec G104 -- Cleanup, error not critical
if resp.StatusCode != http.StatusOK { // Accept any 2xx or 403 (rate limit) as healthy
return fmt.Errorf("github api returned status: %d", resp.StatusCode) // Rate limits are expected without a GitHub token and shouldn't fail health checks
if resp.StatusCode >= 200 && resp.StatusCode < 300 {
return nil
}
if resp.StatusCode == http.StatusForbidden {
log.Debug().Msg("GitHub API rate limited (expected without token)")
return nil
} }
return nil return fmt.Errorf("github api returned status: %d", resp.StatusCode)
} }
// mapRegistryToEcosystem maps our registry names to GitHub ecosystem names // mapRegistryToEcosystem maps our registry names to GitHub ecosystem names