Add dummy change for PR #2

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

cache/cache.go

@@ -3,6 +3,7 @@ package libpack_cache
 import (
 	"bytes"
 	"compress/gzip"
+	"hash/fnv"
 	"io"
 	"sync"
 	"time"
@@ -13,12 +14,25 @@ type CacheEntry struct {
 	Value     []byte
 }
 
+const shardCount = 256 // Must be power of 2
+
+type shard struct {
+	entries    map[string]CacheEntry
+	sync.RWMutex
+}
+
 type Cache struct {
 	compressPool   sync.Pool
 	decompressPool sync.Pool
-	entries        sync.Map
+	shards        [shardCount]*shard
-	globalTTL      time.Duration
+	globalTTL     time.Duration
-	sync.RWMutex
+}
+
+// getShard returns the appropriate shard for a given key
+func (c *Cache) getShard(key string) *shard {
+	hash := fnv.New32a()
+	hash.Write([]byte(key))
+	return c.shards[hash.Sum32()%shardCount]
 }
 
 func New(globalTTL time.Duration) *Cache {
@@ -32,13 +46,19 @@ func New(globalTTL time.Duration) *Cache {
 		},
 		decompressPool: sync.Pool{
 			New: func() interface{} {
-				// Ensure that new is returning a new reader initialized with an empty byte buffer
 				r, _ := gzip.NewReader(bytes.NewReader([]byte{}))
 				return r
 			},
 		},
 	}
 
+	// Initialize shards
+	for i := 0; i < shardCount; i++ {
+		cache.shards[i] = &shard{
+			entries: make(map[string]CacheEntry),
+		}
+	}
+
 	go cache.cleanupRoutine(globalTTL)
 	return cache
 }
@@ -52,33 +72,43 @@ func (c *Cache) cleanupRoutine(globalTTL time.Duration) {
 	}
 }
 func (c *Cache) Set(key string, value []byte, ttl time.Duration) {
-	c.Lock() // use the lock
+	shard := c.getShard(key)
-	defer c.Unlock()
+	shard.Lock()
-
+	defer shard.Unlock()
-	expiresAt := time.Now().Add(ttl)
 
 	compressedValue, err := c.compress(value)
 	if err != nil {
 		return
 	}
 
-	entry := CacheEntry{
+	shard.entries[key] = CacheEntry{
 		Value:     compressedValue,
-		ExpiresAt: expiresAt,
+		ExpiresAt: time.Now().Add(ttl),
 	}
-	c.entries.Store(key, entry)
 }
 
 func (c *Cache) Get(key string) ([]byte, bool) {
-	c.RLock() // use the read lock
+	shard := c.getShard(key)
-	defer c.RUnlock()
+	shard.RLock()
-
+	entry, ok := shard.entries[key]
-	entry, ok := c.entries.Load(key)
+	if !ok {
-	if !ok || entry.(CacheEntry).ExpiresAt.Before(time.Now()) {
+		shard.RUnlock()
 		return nil, false
 	}
-	compressedValue := entry.(CacheEntry).Value
+
-	value, err := c.decompress(compressedValue)
+	if entry.ExpiresAt.Before(time.Now()) {
+		shard.RUnlock()
+		// Clean up expired entry in background
+		go func() {
+			shard.Lock()
+			delete(shard.entries, key)
+			shard.Unlock()
+		}()
+		return nil, false
+	}
+	shard.RUnlock()
+
+	value, err := c.decompress(entry.Value)
 	if err != nil {
 		return nil, false
 	}
@@ -87,26 +117,23 @@ func (c *Cache) Get(key string) ([]byte, bool) {
 }
 
 func (c *Cache) Delete(key string) {
-	c.Lock()
+	shard := c.getShard(key)
-	defer c.Unlock()
+	shard.Lock()
-
+	delete(shard.entries, key)
-	_, ok := c.entries.Load(key)
+	shard.Unlock()
-	if !ok {
-		return
-	}
-
-	c.entries.Delete(key)
 }
 
 func (c *Cache) CleanExpiredEntries() {
 	now := time.Now()
-	c.entries.Range(func(key, value interface{}) bool {
+	for _, shard := range c.shards {
-		entry := value.(CacheEntry)
+		shard.Lock()
-		if entry.ExpiresAt.Before(now) {
+		for key, entry := range shard.entries {
-			c.entries.Delete(key)
+			if entry.ExpiresAt.Before(now) {
+				delete(shard.entries, key)
+			}
 		}
-		return true
+		shard.Unlock()
-	})
+	}
 }
 
 func (c *Cache) compress(data []byte) ([]byte, error) {

dummy-file-1.txt

@@ -0,0 +1 @@
+This is a dummy change for PR #1

dummy-file-2.txt

@@ -0,0 +1 @@
+This is a dummy change for PR #2

execute_query.go

@@ -7,7 +7,6 @@ import (
 	"fmt"
 	"io"
 	"net/http"
-	"sync"
 	"time"
 
 	"github.com/avast/retry-go/v4"
@@ -15,11 +14,22 @@ import (
 	libpack_logger "github.com/lukaszraczylo/go-simple-graphql/logging"
 )
 
-var bufferPool = sync.Pool{
+var (
-	New: func() interface{} {
+	// Shared HTTP transport with optimized settings
-		return new(bytes.Buffer)
+	defaultTransport = &http.Transport{
-	},
+		MaxIdleConns:        100,
-}
+		MaxIdleConnsPerHost: 100,
+		IdleConnTimeout:     90 * time.Second,
+		DisableCompression:  false, // Enable compression for responses
+		ForceAttemptHTTP2:   true,
+	}
+
+	// Shared HTTP client with timeouts
+	defaultClient = &http.Client{
+		Transport: defaultTransport,
+		Timeout:   30 * time.Second,
+	}
+)
 
 func (qe *QueryExecutor) executeQuery() ([]byte, error) {
 	// Reuse buffer from pool to avoid allocations
@@ -62,7 +72,12 @@ func (qe *QueryExecutor) executeQuery() ([]byte, error) {
 			httpRequest.Body = io.NopCloser(bytes.NewReader(buf.Bytes()))
 			httpRequest.ContentLength = int64(buf.Len())
 
-			httpResponse, err := qe.client.Do(httpRequest)
+			// Use default client if custom client is not set
+			client := qe.client
+			if client == nil {
+				client = defaultClient
+			}
+			httpResponse, err := client.Do(httpRequest)
 			if err != nil {
 				return err
 			}
@@ -88,14 +103,18 @@ func (qe *QueryExecutor) executeQuery() ([]byte, error) {
 				reader = httpResponse.Body
 			}
 
-			// Read all response body
+			// Use buffer pool for reading response
-			body, err := io.ReadAll(reader)
+			respBuf := bufferPool.Get().(*bytes.Buffer)
+			respBuf.Reset()
+			defer bufferPool.Put(respBuf)
+
+			_, err = io.Copy(respBuf, reader)
 			if err != nil {
 				return fmt.Errorf("error reading HTTP response: %w", err)
 			}
 
-			// Unmarshal response
+			// Unmarshal response directly from buffer
-			err = json.Unmarshal(body, &queryResult)
+			err = json.Unmarshal(respBuf.Bytes(), &queryResult)
 			if err != nil {
 				return fmt.Errorf("error unmarshalling HTTP response: %w", err)
 			}
@@ -111,6 +130,7 @@ func (qe *QueryExecutor) executeQuery() ([]byte, error) {
 		retry.Attempts(uint(retriesMax)),
 		retry.DelayType(retry.BackOffDelay),
 		retry.Delay(time.Duration(qe.retries_delay)),
+		retry.MaxDelay(10 * time.Second),
 		retry.LastErrorOnly(true),
 	)
 	if err != nil {

go.mod

@@ -4,11 +4,11 @@ go 1.21
 
 require (
 	github.com/avast/retry-go/v4 v4.6.0
-	github.com/goccy/go-json v0.10.3
+	github.com/goccy/go-json v0.10.5
 	github.com/goccy/go-reflect v1.2.0
 	github.com/gookit/goutil v0.6.18
 	github.com/stretchr/testify v1.9.0
-	golang.org/x/net v0.32.0
+	golang.org/x/net v0.34.0
 )
 
 require (
@@ -16,9 +16,9 @@ require (
 	github.com/gookit/color v1.5.4 // indirect
 	github.com/pmezard/go-difflib v1.0.0 // indirect
 	github.com/xo/terminfo v0.0.0-20220910002029-abceb7e1c41e // indirect
-	golang.org/x/sync v0.10.0 // indirect
+	golang.org/x/sync v0.11.0 // indirect
-	golang.org/x/sys v0.28.0 // indirect
+	golang.org/x/sys v0.30.0 // indirect
-	golang.org/x/term v0.27.0 // indirect
+	golang.org/x/term v0.29.0 // indirect
-	golang.org/x/text v0.21.0 // indirect
+	golang.org/x/text v0.22.0 // indirect
 	gopkg.in/yaml.v3 v3.0.1 // indirect
 )

go.sum

@@ -2,8 +2,8 @@ github.com/avast/retry-go/v4 v4.6.0 h1:K9xNA+KeB8HHc2aWFuLb25Offp+0iVRXEvFx8IinR
 github.com/avast/retry-go/v4 v4.6.0/go.mod h1:gvWlPhBVsvBbLkVGDg/KwvBv0bEkCOLRRSHKIr2PyOE=
 github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
 github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
-github.com/goccy/go-json v0.10.3 h1:KZ5WoDbxAIgm2HNbYckL0se1fHD6rz5j4ywS6ebzDqA=
+github.com/goccy/go-json v0.10.5 h1:Fq85nIqj+gXn/S5ahsiTlK3TmC85qgirsdTP/+DeaC4=
-github.com/goccy/go-json v0.10.3/go.mod h1:oq7eo15ShAhp70Anwd5lgX2pLfOS3QCiwU/PULtXL6M=
+github.com/goccy/go-json v0.10.5/go.mod h1:oq7eo15ShAhp70Anwd5lgX2pLfOS3QCiwU/PULtXL6M=
 github.com/goccy/go-reflect v1.2.0 h1:O0T8rZCuNmGXewnATuKYnkL0xm6o8UNOJZd/gOkb9ms=
 github.com/goccy/go-reflect v1.2.0/go.mod h1:n0oYZn8VcV2CkWTxi8B9QjkCoq6GTtCEdfmR66YhFtE=
 github.com/gookit/color v1.5.4 h1:FZmqs7XOyGgCAxmWyPslpiok1k05wmY3SJTytgvYFs0=
@@ -18,16 +18,16 @@ github.com/xo/terminfo v0.0.0-20220910002029-abceb7e1c41e h1:JVG44RsyaB9T2KIHavM
 github.com/xo/terminfo v0.0.0-20220910002029-abceb7e1c41e/go.mod h1:RbqR21r5mrJuqunuUZ/Dhy/avygyECGrLceyNeo4LiM=
 golang.org/x/exp v0.0.0-20220909182711-5c715a9e8561 h1:MDc5xs78ZrZr3HMQugiXOAkSZtfTpbJLDr/lwfgO53E=
 golang.org/x/exp v0.0.0-20220909182711-5c715a9e8561/go.mod h1:cyybsKvd6eL0RnXn6p/Grxp8F5bW7iYuBgsNCOHpMYE=
-golang.org/x/net v0.32.0 h1:ZqPmj8Kzc+Y6e0+skZsuACbx+wzMgo5MQsJh9Qd6aYI=
+golang.org/x/net v0.34.0 h1:Mb7Mrk043xzHgnRM88suvJFwzVrRfHEHJEl5/71CKw0=
-golang.org/x/net v0.32.0/go.mod h1:CwU0IoeOlnQQWJ6ioyFrfRuomB8GKF6KbYXZVyeXNfs=
+golang.org/x/net v0.34.0/go.mod h1:di0qlW3YNM5oh6GqDGQr92MyTozJPmybPK4Ev/Gm31k=
-golang.org/x/sync v0.10.0 h1:3NQrjDixjgGwUOCaF8w2+VYHv0Ve/vGYSbdkTa98gmQ=
+golang.org/x/sync v0.11.0 h1:GGz8+XQP4FvTTrjZPzNKTMFtSXH80RAzG+5ghFPgK9w=
-golang.org/x/sync v0.10.0/go.mod h1:Czt+wKu1gCyEFDUtn0jG5QVvpJ6rzVqr5aXyt9drQfk=
+golang.org/x/sync v0.11.0/go.mod h1:Czt+wKu1gCyEFDUtn0jG5QVvpJ6rzVqr5aXyt9drQfk=
-golang.org/x/sys v0.28.0 h1:Fksou7UEQUWlKvIdsqzJmUmCX3cZuD2+P3XyyzwMhlA=
+golang.org/x/sys v0.30.0 h1:QjkSwP/36a20jFYWkSue1YwXzLmsV5Gfq7Eiy72C1uc=
-golang.org/x/sys v0.28.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
+golang.org/x/sys v0.30.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
-golang.org/x/term v0.27.0 h1:WP60Sv1nlK1T6SupCHbXzSaN0b9wUmsPoRS9b61A23Q=
+golang.org/x/term v0.29.0 h1:L6pJp37ocefwRRtYPKSWOWzOtWSxVajvz2ldH/xi3iU=
-golang.org/x/term v0.27.0/go.mod h1:iMsnZpn0cago0GOrHO2+Y7u7JPn5AylBrcoWkElMTSM=
+golang.org/x/term v0.29.0/go.mod h1:6bl4lRlvVuDgSf3179VpIxBF0o10JUpXWOnI7nErv7s=
-golang.org/x/text v0.21.0 h1:zyQAAkrwaneQ066sspRyJaG9VNi/YJ1NfzcGB3hZ/qo=
+golang.org/x/text v0.22.0 h1:bofq7m3/HAFvbF51jz3Q9wLg3jkvSPuiZu/pD1XwgtM=
-golang.org/x/text v0.21.0/go.mod h1:4IBbMaMmOPCJ8SecivzSH54+73PCFmPWxNTLm+vZkEQ=
+golang.org/x/text v0.22.0/go.mod h1:YRoo4H8PVmsu+E3Ou7cqLVH8oXWIHVoX0jqUWALQhfY=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405 h1:yhCVgyC4o1eVCa2tZl7eS0r+SDo693bJlVdllGtEeKM=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
 gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA=

helpers.go

@@ -48,6 +48,6 @@ func (b *BaseClient) decodeResponse(response []byte) (any, error) {
 			Message: "Can't decode response",
 			Pairs:   map[string]interface{}{"error": "unknown response type"},
 		})
-		return nil, fmt.Errorf("Can't decode response - unknown response type specified")
+		return nil, fmt.Errorf("can't decode response - unknown response type specified")
 	}
 }

logging/logger_bench_test.go

@@ -58,11 +58,11 @@ func Benchmark_NewLogger(b *testing.B) {
 				got := New()
 
 				if tt.triggers.ModFormat.Format != "" {
-					got = got.SetFormat(tt.triggers.ModFormat.Format)
+					got.SetFormat(tt.triggers.ModFormat.Format)
 				}
 
 				if tt.triggers.ModLevel.Level != 0 {
-					got = got.SetMinLogLevel(tt.triggers.ModLevel.Level)
+					got.SetMinLogLevel(tt.triggers.ModLevel.Level)
 				}
 			}
 		})

logging/logger_test.go

@@ -3,7 +3,6 @@ package libpack_logger
 import (
 	"bytes"
 	"fmt"
-	"os"
 	"testing"
 	"time"
 
@@ -11,30 +10,6 @@ import (
 	"github.com/goccy/go-reflect"
 )
 
-func captureStderr(f func()) string {
-	originalStderr := os.Stderr
-	r, w, _ := os.Pipe()
-	os.Stderr = w
-	f()
-	w.Close()
-	var buf bytes.Buffer
-	buf.ReadFrom(r)
-	os.Stderr = originalStderr
-	return buf.String()
-}
-
-func captureStdOut(f func()) string {
-	originalStdout := os.Stdout
-	r, w, _ := os.Pipe()
-	os.Stdout = w
-	f()
-	w.Close()
-	var buf bytes.Buffer
-	buf.ReadFrom(r)
-	os.Stdout = originalStdout
-	return buf.String()
-}
-
 func (suite *LoggerTestSuite) Test_LogMessageString() {
 	msg := &LogMessage{
 		Message: "test message",

mock_server.go

@@ -3,7 +3,7 @@ package gql
 
 import (
 	"encoding/json"
-	"io/ioutil"
+	"io"
 	"net/http"
 	"net/http/httptest"
 	"strings"
@@ -15,7 +15,7 @@ func StartMockServer() *httptest.Server {
 	// Create your handler
 	handler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		// Your existing handler code
-		bodyBytes, err := ioutil.ReadAll(r.Body)
+		bodyBytes, err := io.ReadAll(r.Body)
 		if err != nil {
 			w.WriteHeader(http.StatusInternalServerError)
 			return

pools.go

@@ -0,0 +1,24 @@
+package gql
+
+import (
+	"bytes"
+	"sync"
+)
+
+var (
+	// Pre-sized buffer pool for better performance
+	bufferPool = sync.Pool{
+		New: func() interface{} {
+			// Pre-allocate buffer with 4KB capacity
+			b := bytes.NewBuffer(make([]byte, 0, 4096))
+			return b
+		},
+	}
+
+	// Pre-allocate error maps to reduce allocations
+	errPairsPool = sync.Pool{
+		New: func() interface{} {
+			return make(map[string]interface{}, 1)
+		},
+	}
+)

query.go

@@ -11,56 +11,73 @@ import (
 )
 
 func (b *BaseClient) convertToJSON(v any) []byte {
-	// Reuse buffer to reduce allocations
 	buf := bufferPool.Get().(*bytes.Buffer)
 	defer bufferPool.Put(buf)
 	buf.Reset()
 
-	// Use json.Marshal to avoid adding extra newline
+	// Use json.NewEncoder for better performance with buffers
-	jsonData, err := json.Marshal(v)
+	enc := json.NewEncoder(buf)
-	if err != nil {
+	enc.SetEscapeHTML(false) // Reduce unnecessary escaping
+
+	if err := enc.Encode(v); err != nil {
+		errPairs := errPairsPool.Get().(map[string]interface{})
+		errPairs["error"] = err.Error()
 		b.Logger.Error(&libpack_logger.LogMessage{
 			Message: "Can't convert to JSON",
-			Pairs:   map[string]interface{}{"error": err.Error()},
+			Pairs:   errPairs,
 		})
+		errPairsPool.Put(errPairs)
 		return nil
 	}
 
-	// Copy the bytes to the buffer
+	// Get the buffer bytes directly, trimming the trailing newline
-	buf.Write(jsonData)
+	bytes := buf.Bytes()
+	if len(bytes) > 0 && bytes[len(bytes)-1] == '\n' {
+		bytes = bytes[:len(bytes)-1]
+	}
 
-	// Copy the bytes to a new slice before returning
+	// Make a copy of the bytes since the buffer will be reused
-	result := make([]byte, buf.Len())
+	result := make([]byte, len(bytes))
-	copy(result, buf.Bytes())
+	copy(result, bytes)
 	return result
 }
 
 func (b *BaseClient) compileQuery(queryPartials ...any) *Query {
 	var query string
 	var variables map[string]interface{}
-	for _, partial := range queryPartials {
+
-		switch val := partial.(type) {
+	// Pre-allocate the query with an estimated size
-		case string:
+	if len(queryPartials) > 0 {
-			query = val
+		if str, ok := queryPartials[0].(string); ok {
-		case map[string]interface{}:
+			query = str
-			variables = val
+		}
+	}
+
+	// Only allocate variables map if we have more than one partial
+	if len(queryPartials) > 1 {
+		if vars, ok := queryPartials[1].(map[string]interface{}); ok {
+			variables = vars
 		}
 	}
 
 	if query == "" {
+		errPairs := errPairsPool.Get().(map[string]interface{})
+		errPairs["error"] = "query is empty"
 		b.Logger.Error(&libpack_logger.LogMessage{
 			Message: "Can't compile query",
-			Pairs:   map[string]interface{}{"error": "query is empty"},
+			Pairs:   errPairs,
 		})
+		errPairsPool.Put(errPairs)
 		return nil
 	}
 
-	jsonQuery := b.convertToJSON(&Query{Query: query, Variables: variables})
+	// Construct query object once
-	return &Query{
+	q := &Query{
 		Query:     query,
 		Variables: variables,
-		JsonQuery: jsonQuery,
 	}
+	q.JsonQuery = b.convertToJSON(q)
+	return q
 }
 
 func (b *BaseClient) Query(query string, variables map[string]interface{}, headers map[string]interface{}) (any, error) {