Library improvements.

http_test.go

@@ -0,0 +1,161 @@
+package gql
+
+import (
+	"net/http"
+	"testing"
+	"time"
+
+	"golang.org/x/net/http2"
+)
+
+func (suite *Tests) TestBaseClient_createHttpClient() {
+	suite.T().Run("should create HTTP/1.1 client for http endpoints", func(t *testing.T) {
+		client := NewConnection()
+		client.SetEndpoint("http://example.com/graphql")
+
+		httpClient := client.createHttpClient()
+		assert.NotNil(httpClient)
+		assert.Equal(30*time.Second, httpClient.Timeout)
+		assert.NotNil(httpClient.Transport)
+
+		// Check that it's using regular HTTP transport
+		transport, ok := httpClient.Transport.(*http.Transport)
+		assert.True(ok)
+		assert.Equal(100, transport.MaxIdleConns)
+		assert.Equal(50, transport.MaxConnsPerHost)
+		assert.Equal(10, transport.MaxIdleConnsPerHost)
+		assert.Equal(30*time.Second, transport.IdleConnTimeout)
+		assert.Equal(10*time.Second, transport.ResponseHeaderTimeout)
+		assert.False(transport.DisableKeepAlives)
+		assert.False(transport.DisableCompression)
+		assert.Equal(4096, transport.WriteBufferSize)
+		assert.Equal(4096, transport.ReadBufferSize)
+	})
+
+	suite.T().Run("should create HTTP/2 client for https endpoints", func(t *testing.T) {
+		client := NewConnection()
+		client.SetEndpoint("https://example.com/graphql")
+
+		httpClient := client.createHttpClient()
+		assert.NotNil(httpClient)
+		assert.Equal(30*time.Second, httpClient.Timeout)
+		assert.NotNil(httpClient.Transport)
+
+		// Check that it's using HTTP/2 transport
+		transport, ok := httpClient.Transport.(*http2.Transport)
+		assert.True(ok)
+		assert.True(transport.AllowHTTP)
+		assert.NotNil(transport.TLSClientConfig)
+		assert.True(transport.TLSClientConfig.InsecureSkipVerify)
+		assert.Equal(30*time.Second, transport.ReadIdleTimeout)
+		assert.Equal(10*time.Second, transport.PingTimeout)
+		assert.Equal(10*time.Second, transport.WriteByteTimeout)
+	})
+
+	suite.T().Run("should handle invalid endpoints", func(t *testing.T) {
+		client := NewConnection()
+		client.SetEndpoint("ftp://example.com/graphql")
+
+		httpClient := client.createHttpClient()
+		assert.Nil(httpClient)
+	})
+
+	suite.T().Run("should set redirect policy", func(t *testing.T) {
+		client := NewConnection()
+		client.SetEndpoint("http://example.com/graphql")
+
+		httpClient := client.createHttpClient()
+		assert.NotNil(httpClient)
+		assert.NotNil(httpClient.CheckRedirect)
+
+		// Test redirect policy
+		req, _ := http.NewRequest("GET", "http://example.com", nil)
+		err := httpClient.CheckRedirect(req, []*http.Request{})
+		assert.Equal(http.ErrUseLastResponse, err)
+	})
+
+	suite.T().Run("should handle empty endpoint", func(t *testing.T) {
+		client := NewConnection()
+		client.SetEndpoint("")
+
+		httpClient := client.createHttpClient()
+		assert.Nil(httpClient)
+	})
+
+	suite.T().Run("should handle endpoint without protocol", func(t *testing.T) {
+		client := NewConnection()
+		client.SetEndpoint("example.com/graphql")
+
+		httpClient := client.createHttpClient()
+		assert.Nil(httpClient)
+	})
+}
+
+func (suite *Tests) TestBaseClient_createHttpClient_transportSettings() {
+	suite.T().Run("should configure HTTP transport correctly", func(t *testing.T) {
+		client := NewConnection()
+		client.SetEndpoint("http://example.com/graphql")
+
+		httpClient := client.createHttpClient()
+		transport := httpClient.Transport.(*http.Transport)
+
+		// Verify all transport settings
+		assert.Equal(100, transport.MaxIdleConns)
+		assert.Equal(50, transport.MaxConnsPerHost)
+		assert.Equal(10, transport.MaxIdleConnsPerHost)
+		assert.Equal(30*time.Second, transport.IdleConnTimeout)
+		assert.Equal(10*time.Second, transport.ResponseHeaderTimeout)
+		assert.False(transport.DisableKeepAlives)
+		assert.False(transport.DisableCompression)
+		assert.Equal(4096, transport.WriteBufferSize)
+		assert.Equal(4096, transport.ReadBufferSize)
+	})
+
+	suite.T().Run("should configure HTTP/2 transport correctly", func(t *testing.T) {
+		client := NewConnection()
+		client.SetEndpoint("https://example.com/graphql")
+
+		httpClient := client.createHttpClient()
+		transport := httpClient.Transport.(*http2.Transport)
+
+		// Verify all HTTP/2 transport settings
+		assert.True(transport.AllowHTTP)
+		assert.NotNil(transport.TLSClientConfig)
+		assert.True(transport.TLSClientConfig.InsecureSkipVerify)
+		assert.Equal(30*time.Second, transport.ReadIdleTimeout)
+		assert.Equal(10*time.Second, transport.PingTimeout)
+		assert.Equal(10*time.Second, transport.WriteByteTimeout)
+	})
+}
+
+func (suite *Tests) TestBaseClient_createHttpClient_logging() {
+	suite.T().Run("should log HTTP/1.1 usage", func(t *testing.T) {
+		client := NewConnection()
+		client.SetEndpoint("http://example.com/graphql")
+
+		// This test verifies that the function runs without error
+		// The actual logging is tested indirectly through the logger tests
+		httpClient := client.createHttpClient()
+		assert.NotNil(httpClient)
+	})
+
+	suite.T().Run("should log HTTP/2 usage", func(t *testing.T) {
+		client := NewConnection()
+		client.SetEndpoint("https://example.com/graphql")
+
+		// This test verifies that the function runs without error
+		// The actual logging is tested indirectly through the logger tests
+		httpClient := client.createHttpClient()
+		assert.NotNil(httpClient)
+	})
+
+	suite.T().Run("should log critical error for invalid endpoint", func(t *testing.T) {
+		client := NewConnection()
+		client.SetEndpoint("invalid://example.com/graphql")
+
+		// This test verifies that the function runs without error
+		// and returns nil for invalid endpoints (Critical() won't exit in tests)
+		httpClient := client.createHttpClient()
+		assert.Nil(httpClient)
+	})
+}