mirror of
https://github.com/lukaszraczylo/git-velocity.git
synced 2026-06-09 23:04:00 +00:00
Update tests.
This commit is contained in:
+34
-16
@@ -24,26 +24,13 @@ func New(directory, port string) *Server {
|
||||
|
||||
// Start starts the HTTP server
|
||||
func (s *Server) Start() error {
|
||||
// Check if directory exists
|
||||
if _, err := os.Stat(s.directory); os.IsNotExist(err) {
|
||||
return fmt.Errorf("directory does not exist: %s", s.directory)
|
||||
}
|
||||
|
||||
// Get absolute path
|
||||
absPath, err := filepath.Abs(s.directory)
|
||||
handler, err := s.CreateHandler()
|
||||
if err != nil {
|
||||
return fmt.Errorf("failed to get absolute path: %w", err)
|
||||
return err
|
||||
}
|
||||
|
||||
// Create file server with directory listing disabled for security
|
||||
fs := http.FileServer(http.Dir(absPath))
|
||||
|
||||
// Wrap with middleware
|
||||
handler := s.loggingMiddleware(s.cacheMiddleware(fs))
|
||||
|
||||
addr := fmt.Sprintf(":%s", s.port)
|
||||
srv := &http.Server{
|
||||
Addr: addr,
|
||||
Addr: s.GetAddress(),
|
||||
Handler: handler,
|
||||
ReadTimeout: 15 * time.Second,
|
||||
ReadHeaderTimeout: 15 * time.Second,
|
||||
@@ -75,3 +62,34 @@ func (s *Server) cacheMiddleware(next http.Handler) http.Handler {
|
||||
next.ServeHTTP(w, r)
|
||||
})
|
||||
}
|
||||
|
||||
// CreateHandler creates and returns the HTTP handler without starting the server.
|
||||
// This is useful for testing and for embedding the server in other applications.
|
||||
func (s *Server) CreateHandler() (http.Handler, error) {
|
||||
// Check if directory exists
|
||||
if _, err := os.Stat(s.directory); os.IsNotExist(err) {
|
||||
return nil, fmt.Errorf("directory does not exist: %s", s.directory)
|
||||
}
|
||||
|
||||
// Get absolute path
|
||||
absPath, err := filepath.Abs(s.directory)
|
||||
if err != nil {
|
||||
return nil, fmt.Errorf("failed to get absolute path: %w", err)
|
||||
}
|
||||
|
||||
// Create file server with directory listing disabled for security
|
||||
fs := http.FileServer(http.Dir(absPath))
|
||||
|
||||
// Wrap with middleware
|
||||
return s.loggingMiddleware(s.cacheMiddleware(fs)), nil
|
||||
}
|
||||
|
||||
// GetAddress returns the server address in the format :port
|
||||
func (s *Server) GetAddress() string {
|
||||
return fmt.Sprintf(":%s", s.port)
|
||||
}
|
||||
|
||||
// GetDirectory returns the directory being served
|
||||
func (s *Server) GetDirectory() string {
|
||||
return s.directory
|
||||
}
|
||||
|
||||
@@ -207,3 +207,231 @@ func TestServer_ServesIndexHtml(t *testing.T) {
|
||||
body, _ := io.ReadAll(resp.Body)
|
||||
assert.Contains(t, string(body), "Test Page")
|
||||
}
|
||||
|
||||
func TestServer_CreateHandler(t *testing.T) {
|
||||
tempDir := t.TempDir()
|
||||
|
||||
// Create an index.html
|
||||
indexFile := filepath.Join(tempDir, "index.html")
|
||||
err := os.WriteFile(indexFile, []byte("<html><body>Handler Test</body></html>"), 0644)
|
||||
require.NoError(t, err)
|
||||
|
||||
s := New(tempDir, "8080")
|
||||
|
||||
handler, err := s.CreateHandler()
|
||||
require.NoError(t, err)
|
||||
|
||||
ts := httptest.NewServer(handler)
|
||||
defer ts.Close()
|
||||
|
||||
resp, err := http.Get(ts.URL + "/")
|
||||
require.NoError(t, err)
|
||||
defer resp.Body.Close()
|
||||
|
||||
assert.Equal(t, http.StatusOK, resp.StatusCode)
|
||||
body, _ := io.ReadAll(resp.Body)
|
||||
assert.Contains(t, string(body), "Handler Test")
|
||||
|
||||
// Check middleware headers are applied
|
||||
assert.Equal(t, "no-cache, no-store, must-revalidate", resp.Header.Get("Cache-Control"))
|
||||
assert.Equal(t, "*", resp.Header.Get("Access-Control-Allow-Origin"))
|
||||
}
|
||||
|
||||
func TestServer_CreateHandlerWithNonExistentDirectory(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
s := New("/this/directory/does/not/exist", "8080")
|
||||
|
||||
handler, err := s.CreateHandler()
|
||||
assert.Error(t, err)
|
||||
assert.Nil(t, handler)
|
||||
assert.Contains(t, err.Error(), "directory does not exist")
|
||||
}
|
||||
|
||||
func TestServer_GetAddress(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
tests := []struct {
|
||||
name string
|
||||
port string
|
||||
expected string
|
||||
}{
|
||||
{"standard port", "8080", ":8080"},
|
||||
{"different port", "3000", ":3000"},
|
||||
{"port 0 for random", "0", ":0"},
|
||||
}
|
||||
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
s := New(".", tt.port)
|
||||
assert.Equal(t, tt.expected, s.GetAddress())
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestServer_GetDirectory(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
s := New("/some/path", "8080")
|
||||
assert.Equal(t, "/some/path", s.GetDirectory())
|
||||
}
|
||||
|
||||
func TestServer_ServesJSONWithCorrectContentType(t *testing.T) {
|
||||
tempDir := t.TempDir()
|
||||
|
||||
// Create a JSON file
|
||||
jsonFile := filepath.Join(tempDir, "data.json")
|
||||
err := os.WriteFile(jsonFile, []byte(`{"status": "ok"}`), 0644)
|
||||
require.NoError(t, err)
|
||||
|
||||
s := New(tempDir, "0")
|
||||
handler, err := s.CreateHandler()
|
||||
require.NoError(t, err)
|
||||
|
||||
ts := httptest.NewServer(handler)
|
||||
defer ts.Close()
|
||||
|
||||
resp, err := http.Get(ts.URL + "/data.json")
|
||||
require.NoError(t, err)
|
||||
defer resp.Body.Close()
|
||||
|
||||
assert.Equal(t, http.StatusOK, resp.StatusCode)
|
||||
// Check content type is JSON
|
||||
contentType := resp.Header.Get("Content-Type")
|
||||
assert.Contains(t, contentType, "application/json")
|
||||
}
|
||||
|
||||
func TestServer_ServesHTMLWithCorrectContentType(t *testing.T) {
|
||||
tempDir := t.TempDir()
|
||||
|
||||
// Create an HTML file
|
||||
htmlFile := filepath.Join(tempDir, "page.html")
|
||||
err := os.WriteFile(htmlFile, []byte("<html><body>HTML Page</body></html>"), 0644)
|
||||
require.NoError(t, err)
|
||||
|
||||
s := New(tempDir, "0")
|
||||
handler, err := s.CreateHandler()
|
||||
require.NoError(t, err)
|
||||
|
||||
ts := httptest.NewServer(handler)
|
||||
defer ts.Close()
|
||||
|
||||
resp, err := http.Get(ts.URL + "/page.html")
|
||||
require.NoError(t, err)
|
||||
defer resp.Body.Close()
|
||||
|
||||
assert.Equal(t, http.StatusOK, resp.StatusCode)
|
||||
// Check content type is HTML
|
||||
contentType := resp.Header.Get("Content-Type")
|
||||
assert.Contains(t, contentType, "text/html")
|
||||
}
|
||||
|
||||
func TestServer_CORSHeaders(t *testing.T) {
|
||||
tempDir := t.TempDir()
|
||||
|
||||
// Create a test file
|
||||
testFile := filepath.Join(tempDir, "test.txt")
|
||||
err := os.WriteFile(testFile, []byte("test content"), 0644)
|
||||
require.NoError(t, err)
|
||||
|
||||
s := New(tempDir, "0")
|
||||
handler, err := s.CreateHandler()
|
||||
require.NoError(t, err)
|
||||
|
||||
ts := httptest.NewServer(handler)
|
||||
defer ts.Close()
|
||||
|
||||
resp, err := http.Get(ts.URL + "/test.txt")
|
||||
require.NoError(t, err)
|
||||
defer resp.Body.Close()
|
||||
|
||||
// Check CORS header
|
||||
assert.Equal(t, "*", resp.Header.Get("Access-Control-Allow-Origin"))
|
||||
}
|
||||
|
||||
func TestServer_CacheDisabledHeaders(t *testing.T) {
|
||||
tempDir := t.TempDir()
|
||||
|
||||
// Create a test file
|
||||
testFile := filepath.Join(tempDir, "test.txt")
|
||||
err := os.WriteFile(testFile, []byte("test content"), 0644)
|
||||
require.NoError(t, err)
|
||||
|
||||
s := New(tempDir, "0")
|
||||
handler, err := s.CreateHandler()
|
||||
require.NoError(t, err)
|
||||
|
||||
ts := httptest.NewServer(handler)
|
||||
defer ts.Close()
|
||||
|
||||
resp, err := http.Get(ts.URL + "/test.txt")
|
||||
require.NoError(t, err)
|
||||
defer resp.Body.Close()
|
||||
|
||||
// Check cache headers are disabled for development
|
||||
assert.Equal(t, "no-cache, no-store, must-revalidate", resp.Header.Get("Cache-Control"))
|
||||
assert.Equal(t, "no-cache", resp.Header.Get("Pragma"))
|
||||
assert.Equal(t, "0", resp.Header.Get("Expires"))
|
||||
}
|
||||
|
||||
func TestServer_LoggingMiddlewareWithDifferentMethods(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
s := New(".", "8080")
|
||||
|
||||
handler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
w.WriteHeader(http.StatusOK)
|
||||
})
|
||||
|
||||
wrapped := s.loggingMiddleware(handler)
|
||||
|
||||
methods := []string{"GET", "POST", "PUT", "DELETE", "HEAD", "OPTIONS"}
|
||||
for _, method := range methods {
|
||||
t.Run(method, func(t *testing.T) {
|
||||
req := httptest.NewRequest(method, "/test-path", nil)
|
||||
rr := httptest.NewRecorder()
|
||||
|
||||
wrapped.ServeHTTP(rr, req)
|
||||
|
||||
assert.Equal(t, http.StatusOK, rr.Code)
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestServer_CacheMiddlewarePreservesResponseBody(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
s := New(".", "8080")
|
||||
|
||||
expectedBody := "This is the response body content"
|
||||
handler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
w.WriteHeader(http.StatusOK)
|
||||
w.Write([]byte(expectedBody))
|
||||
})
|
||||
|
||||
wrapped := s.cacheMiddleware(handler)
|
||||
|
||||
req := httptest.NewRequest("GET", "/test", nil)
|
||||
rr := httptest.NewRecorder()
|
||||
|
||||
wrapped.ServeHTTP(rr, req)
|
||||
|
||||
body, _ := io.ReadAll(rr.Body)
|
||||
assert.Equal(t, expectedBody, string(body))
|
||||
}
|
||||
|
||||
func TestNew_WithEmptyValues(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
s := New("", "")
|
||||
assert.Equal(t, "", s.directory)
|
||||
assert.Equal(t, "", s.port)
|
||||
}
|
||||
|
||||
func TestNew_WithSpecialCharactersInPath(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
path := "/path/with spaces/and-dashes/and_underscores"
|
||||
s := New(path, "8080")
|
||||
assert.Equal(t, path, s.directory)
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user