mirror of
https://github.com/lukaszraczylo/filepuff-mcp.git
synced 2026-06-05 22:23:50 +00:00
5ad975ee7a
* v2.0: token-optimization overhaul Additive (backward-compatible flags): - file_read: skeleton mode, strip (imports/license/block_comments), compact_line_numbers, 8-char etag with prefix-match compat - ast_query: format=verbose|compact|location, pagination cursor - file_search: cluster mode, pagination cursor - lsp_query (references): compact output Breaking (v2): - Preambles removed; opt-in verbose=true restores - edit_apply: response=count|diff|none, default count - ping tool removed - symbol_at/find_definition/find_references merged into lsp_query - Tool descriptions trimmed -83%, help moved to filepuff://help/<tool> - Batch file_read dedups by etag Protocol: - ResourceLink returned for file_read >64 KiB (force_inline override) - OnAfterInitialize hook reads capabilities.experimental.filepuff for session defaults (default_format, default_max_results, default_cluster, compact_refs, line_numbers, resource_link_threshold) * fix: drop --max-total-count from ripgrep args The flag does not exist in stable ripgrep (confirmed up to 15.1.0 -- "unrecognized flag --max-total-count, similar flags that are available: --max-count"). Every file_search call failed on hosts with stock rg. --max-count is per-file, not a drop-in replacement, so rely on the in-process truncation in parseOutput that was already the documented safety net.
345 lines
9.3 KiB
Go
345 lines
9.3 KiB
Go
package server
|
|
|
|
import (
|
|
"context"
|
|
"log/slog"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/lukaszraczylo/mcp-filepuff/internal/config"
|
|
"github.com/mark3labs/mcp-go/mcp"
|
|
)
|
|
|
|
// newTestServer creates a server with a temp workspace containing Go files.
|
|
func newFeaturesServer(t *testing.T) (*Server, string) {
|
|
t.Helper()
|
|
tmpDir := t.TempDir()
|
|
|
|
// Write a few Go files for AST queries
|
|
goFile1 := filepath.Join(tmpDir, "a.go")
|
|
if err := os.WriteFile(goFile1, []byte(`package main
|
|
|
|
func Alpha() string { return "alpha" }
|
|
func Beta() string { return "beta" }
|
|
func Gamma() string { return "gamma" }
|
|
`), 0o600); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
goFile2 := filepath.Join(tmpDir, "b.go")
|
|
if err := os.WriteFile(goFile2, []byte(`package main
|
|
|
|
func Delta() int { return 1 }
|
|
func Epsilon() int { return 2 }
|
|
`), 0o600); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
cfg := &config.Config{
|
|
WorkspaceRoot: tmpDir,
|
|
EnableLSP: false,
|
|
MaxFileSize: config.DefaultMaxFileSize,
|
|
MaxParseSize: config.DefaultMaxParseSize,
|
|
SearchTimeout: 30 * time.Second,
|
|
}
|
|
logger := slog.New(slog.NewTextHandler(os.Stderr, &slog.HandlerOptions{Level: slog.LevelError}))
|
|
srv, err := New(cfg, logger)
|
|
if err != nil {
|
|
t.Fatalf("New() error: %v", err)
|
|
}
|
|
return srv, tmpDir
|
|
}
|
|
|
|
// ---- Feature 1: ast_query format flag ----
|
|
|
|
func TestASTQueryFormatVerboseDefault(t *testing.T) {
|
|
srv, tmpDir := newFeaturesServer(t)
|
|
ctx := context.Background()
|
|
|
|
req := mcp.CallToolRequest{}
|
|
req.Params.Arguments = map[string]interface{}{
|
|
"pattern": "func $NAME() string",
|
|
"language": "go",
|
|
"paths": []interface{}{tmpDir},
|
|
}
|
|
res, err := srv.handleASTQuery(ctx, req)
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
if res == nil || len(res.Content) == 0 {
|
|
t.Fatal("nil/empty result")
|
|
}
|
|
text := res.Content[0].(mcp.TextContent).Text
|
|
// verbose mode has code blocks
|
|
if !strings.Contains(text, "```") {
|
|
t.Errorf("verbose mode should have code blocks, got:\n%s", text)
|
|
}
|
|
}
|
|
|
|
func TestASTQueryFormatCompact(t *testing.T) {
|
|
srv, tmpDir := newFeaturesServer(t)
|
|
ctx := context.Background()
|
|
|
|
req := mcp.CallToolRequest{}
|
|
req.Params.Arguments = map[string]interface{}{
|
|
"pattern": "func $NAME() string",
|
|
"language": "go",
|
|
"paths": []interface{}{tmpDir},
|
|
"format": "compact",
|
|
}
|
|
res, err := srv.handleASTQuery(ctx, req)
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
text := res.Content[0].(mcp.TextContent).Text
|
|
if strings.Contains(text, "```") {
|
|
t.Errorf("compact mode should NOT have code blocks, got:\n%s", text)
|
|
}
|
|
// Each line should contain file:line (kind) text
|
|
for _, line := range strings.Split(strings.TrimSpace(text), "\n") {
|
|
if line == "" || strings.HasPrefix(line, "Found") {
|
|
continue
|
|
}
|
|
if !strings.Contains(line, ":") {
|
|
t.Errorf("compact line missing ':' separator: %q", line)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestASTQueryFormatLocation(t *testing.T) {
|
|
srv, tmpDir := newFeaturesServer(t)
|
|
ctx := context.Background()
|
|
|
|
req := mcp.CallToolRequest{}
|
|
req.Params.Arguments = map[string]interface{}{
|
|
"pattern": "func $NAME() string",
|
|
"language": "go",
|
|
"paths": []interface{}{tmpDir},
|
|
"format": "location",
|
|
}
|
|
res, err := srv.handleASTQuery(ctx, req)
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
text := res.Content[0].(mcp.TextContent).Text
|
|
if strings.Contains(text, "```") {
|
|
t.Errorf("location mode should NOT have code blocks, got:\n%s", text)
|
|
}
|
|
// Lines should be file:linenum only (no parentheses with kind)
|
|
for _, line := range strings.Split(strings.TrimSpace(text), "\n") {
|
|
if line == "" || strings.HasPrefix(line, "Found") {
|
|
continue
|
|
}
|
|
if strings.Contains(line, "(") {
|
|
t.Errorf("location mode should not have node type in parens: %q", line)
|
|
}
|
|
}
|
|
}
|
|
|
|
// ---- Feature 3 (ast_query): pagination cursor ----
|
|
|
|
func TestASTQueryPaginationCursor(t *testing.T) {
|
|
srv, tmpDir := newFeaturesServer(t)
|
|
ctx := context.Background()
|
|
|
|
// Page 1: max_results=2
|
|
req1 := mcp.CallToolRequest{}
|
|
req1.Params.Arguments = map[string]interface{}{
|
|
"pattern": "func $NAME() $RET",
|
|
"language": "go",
|
|
"paths": []interface{}{tmpDir},
|
|
"max_results": float64(2),
|
|
}
|
|
res1, err := srv.handleASTQuery(ctx, req1)
|
|
if err != nil {
|
|
t.Fatalf("page1 error: %v", err)
|
|
}
|
|
text1 := res1.Content[0].(mcp.TextContent).Text
|
|
|
|
// Should contain cursor footer if there are more results
|
|
if !strings.Contains(text1, "[cursor:") {
|
|
// Might have fewer than 2 total results — skip cursor test
|
|
t.Logf("no cursor footer (fewer than 2 total matches), skipping pagination round-trip")
|
|
return
|
|
}
|
|
|
|
// Extract cursor token
|
|
var cursorToken string
|
|
for _, line := range strings.Split(text1, "\n") {
|
|
if strings.HasPrefix(line, "[cursor:") {
|
|
// [cursor: <token>, remaining: N]
|
|
parts := strings.Split(line, " ")
|
|
if len(parts) >= 2 {
|
|
cursorToken = strings.TrimSuffix(parts[1], ",")
|
|
}
|
|
break
|
|
}
|
|
}
|
|
if cursorToken == "" {
|
|
t.Fatal("could not extract cursor token from output")
|
|
}
|
|
|
|
// Page 2: pass cursor back
|
|
req2 := mcp.CallToolRequest{}
|
|
req2.Params.Arguments = map[string]interface{}{
|
|
"pattern": "func $NAME() $RET",
|
|
"language": "go",
|
|
"paths": []interface{}{tmpDir},
|
|
"max_results": float64(2),
|
|
"cursor": cursorToken,
|
|
}
|
|
res2, err := srv.handleASTQuery(ctx, req2)
|
|
if err != nil {
|
|
t.Fatalf("page2 error: %v", err)
|
|
}
|
|
text2 := res2.Content[0].(mcp.TextContent).Text
|
|
if strings.Contains(text2, "cursor is for a different query") {
|
|
t.Error("cursor was rejected as mismatched query")
|
|
}
|
|
// Page 2 should have results
|
|
if strings.Contains(text2, "No matches found.") {
|
|
t.Error("page2 should have some results")
|
|
}
|
|
}
|
|
|
|
func TestASTQueryCursorStaleMismatch(t *testing.T) {
|
|
srv, tmpDir := newFeaturesServer(t)
|
|
ctx := context.Background()
|
|
|
|
req := mcp.CallToolRequest{}
|
|
req.Params.Arguments = map[string]interface{}{
|
|
"pattern": "func $NAME() string",
|
|
"language": "go",
|
|
"paths": []interface{}{tmpDir},
|
|
"cursor": "eyJvZmZzZXQiOjIsInF1ZXJ5X2hhc2giOiJkZWFkYmVlZiJ9", // offset=2, hash=deadbeef
|
|
}
|
|
res, err := srv.handleASTQuery(ctx, req)
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
text := res.Content[0].(mcp.TextContent).Text
|
|
if !strings.Contains(text, "cursor is for a different query") {
|
|
t.Errorf("expected stale cursor error, got:\n%s", text)
|
|
}
|
|
}
|
|
|
|
// ---- Feature 2: file_search cluster ----
|
|
|
|
func TestFileSearchClusterFlag(t *testing.T) {
|
|
srv, tmpDir := newFeaturesServer(t)
|
|
if srv.searcher == nil {
|
|
t.Skip("rg not available")
|
|
}
|
|
ctx := context.Background()
|
|
|
|
req := mcp.CallToolRequest{}
|
|
req.Params.Arguments = map[string]interface{}{
|
|
"pattern": "func",
|
|
"paths": []interface{}{tmpDir},
|
|
"cluster": true,
|
|
}
|
|
res, err := srv.handleFileSearch(ctx, req)
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
if res == nil || len(res.Content) == 0 {
|
|
t.Fatal("nil/empty result")
|
|
}
|
|
text := res.Content[0].(mcp.TextContent).Text
|
|
if text == "No matches found." {
|
|
t.Skip("no matches found (unexpected)")
|
|
}
|
|
// In cluster mode, should NOT have " │" context decorations
|
|
if strings.Contains(text, " │") {
|
|
t.Errorf("cluster mode should not contain context-line decoration ' │', got:\n%s", text)
|
|
}
|
|
}
|
|
|
|
func TestFileSearchCursorStaleHash(t *testing.T) {
|
|
srv, tmpDir := newFeaturesServer(t)
|
|
if srv.searcher == nil {
|
|
t.Skip("rg not available")
|
|
}
|
|
ctx := context.Background()
|
|
|
|
req := mcp.CallToolRequest{}
|
|
req.Params.Arguments = map[string]interface{}{
|
|
"pattern": "func",
|
|
"paths": []interface{}{tmpDir},
|
|
"cursor": "eyJvZmZzZXQiOjEsInF1ZXJ5X2hhc2giOiJiYWRoYXNoIn0", // offset=1, hash=badhash
|
|
}
|
|
res, err := srv.handleFileSearch(ctx, req)
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
text := res.Content[0].(mcp.TextContent).Text
|
|
if !strings.Contains(text, "cursor is for a different query") {
|
|
t.Errorf("expected stale cursor error, got:\n%s", text)
|
|
}
|
|
}
|
|
|
|
func TestFileSearchPaginationCursor(t *testing.T) {
|
|
srv, tmpDir := newFeaturesServer(t)
|
|
if srv.searcher == nil {
|
|
t.Skip("rg not available")
|
|
}
|
|
ctx := context.Background()
|
|
|
|
// Page 1: get 1 result
|
|
req1 := mcp.CallToolRequest{}
|
|
req1.Params.Arguments = map[string]interface{}{
|
|
"pattern": "func",
|
|
"paths": []interface{}{tmpDir},
|
|
"max_results": float64(1),
|
|
"context_lines": float64(0),
|
|
}
|
|
res1, err := srv.handleFileSearch(ctx, req1)
|
|
if err != nil {
|
|
t.Fatalf("page1 error: %v", err)
|
|
}
|
|
text1 := res1.Content[0].(mcp.TextContent).Text
|
|
if !strings.Contains(text1, "[cursor:") {
|
|
t.Logf("no cursor in page1 (only 1 total result), skipping round-trip:\n%s", text1)
|
|
return
|
|
}
|
|
|
|
// Extract cursor
|
|
var cursorToken string
|
|
for _, line := range strings.Split(text1, "\n") {
|
|
if strings.HasPrefix(line, "[cursor:") {
|
|
parts := strings.Split(line, " ")
|
|
if len(parts) >= 2 {
|
|
cursorToken = strings.TrimSuffix(parts[1], ",")
|
|
}
|
|
break
|
|
}
|
|
}
|
|
if cursorToken == "" {
|
|
t.Fatal("could not extract cursor from page1")
|
|
}
|
|
|
|
// Page 2
|
|
req2 := mcp.CallToolRequest{}
|
|
req2.Params.Arguments = map[string]interface{}{
|
|
"pattern": "func",
|
|
"paths": []interface{}{tmpDir},
|
|
"max_results": float64(1),
|
|
"context_lines": float64(0),
|
|
"cursor": cursorToken,
|
|
}
|
|
res2, err := srv.handleFileSearch(ctx, req2)
|
|
if err != nil {
|
|
t.Fatalf("page2 error: %v", err)
|
|
}
|
|
text2 := res2.Content[0].(mcp.TextContent).Text
|
|
if strings.Contains(text2, "cursor is for a different query") {
|
|
t.Error("cursor was rejected as mismatched")
|
|
}
|
|
if strings.Contains(text2, "No matches found.") {
|
|
t.Error("page2 should have matches")
|
|
}
|
|
}
|