lukaszraczylo d0c07f0157 fix(edit): re-validate path immediately before write (TOCTOU hardening) ...

edit_apply validated the target with IsPathAllowed in the handler, then later
wrote it via os.WriteFile on the raw path after reading+parsing+diffing. A
symlink swapped in during that window could redirect the write outside the
workspace root. Inject the admission check into the edit Engine
(NewEngineWithValidator) and re-run it inside a new writeValidatedFile helper
immediately before the write — IsPathAllowed resolves symlinks at write time, so
a swapped-in link now resolving outside the root is rejected. This narrows the
TOCTOU window to near-zero while still permitting legitimate in-workspace symlink
edits (unlike a blanket O_NOFOLLOW). writeValidatedFile also dedups the
perm-preserving write shared by AST and text modes.

Tests: rejected-path edit leaves the file untouched; file mode is preserved.

2026-06-21 02:12:57 +01:00

..

concurrency_test.go

Ho hum.

2026-01-18 18:40:26 +00:00

edit_test.go

fix(edit): re-validate path immediately before write (TOCTOU hardening)

2026-06-21 02:12:57 +01:00

edit.go

fix(edit): re-validate path immediately before write (TOCTOU hardening)

2026-06-21 02:12:57 +01:00

escaping_newline_test.go

refactor(edit): remove auto-indentation and add line-ending normalization

2026-05-29 00:17:36 +01:00