filepuff-mcp/internal/parser/symbols_test.go

package parser

import (
	"context"
	"testing"

	"github.com/lukaszraczylo/mcp-filepuff/pkg/protocol"
)

func TestFindSymbolCandidates(t *testing.T) {
	r := NewRegistry()
	defer r.Close()

	// Two methods named String on different receivers, plus a unique func.
	content := `package main

type A struct{}

func (a A) String() string { return "a" }

type B struct{}

func (b B) String() string { return "b" }

func Unique() {}
`
	ctx := context.Background()
	result, err := r.Parse(ctx, "test.go", []byte(content))
	if err != nil {
		t.Fatalf("parse failed: %v", err)
	}

	t.Run("ambiguous name returns all candidates", func(t *testing.T) {
		got := FindSymbolCandidates(result.Tree, []byte(content), "test.go", "String", "")
		if len(got) != 2 {
			t.Fatalf("got %d candidates for String, want 2: %+v", len(got), got)
		}
		if got[0].StartLine >= got[1].StartLine {
			t.Errorf("candidates not in source order: %+v", got)
		}
	})

	t.Run("unique name returns one candidate", func(t *testing.T) {
		got := FindSymbolCandidates(result.Tree, []byte(content), "test.go", "Unique", "")
		if len(got) != 1 {
			t.Fatalf("got %d candidates for Unique, want 1: %+v", len(got), got)
		}
	})

	t.Run("missing name returns none", func(t *testing.T) {
		got := FindSymbolCandidates(result.Tree, []byte(content), "test.go", "Missing", "")
		if len(got) != 0 {
			t.Fatalf("got %d candidates for Missing, want 0", len(got))
		}
	})

	t.Run("FindSymbolRange returns first match", func(t *testing.T) {
		start, end, found := FindSymbolRange(result.Tree, []byte(content), "test.go", "String", "")
		if !found {
			t.Fatal("expected String to be found")
		}
		if start <= 0 || end < start {
			t.Errorf("invalid range: start=%d end=%d", start, end)
		}
	})
}

func TestExtractGoSymbols(t *testing.T) {
	r := NewRegistry()
	defer r.Close()

	content := `package main

// Hello prints a greeting
func Hello() {
	println("hello")
}

// Server handles requests
type Server struct {
	Port int
}

// Start starts the server
func (s *Server) Start() error {
	return nil
}

const MaxConnections = 100
var globalVar = "test"
`

	ctx := context.Background()
	result, err := r.Parse(ctx, "test.go", []byte(content))
	if err != nil {
		t.Fatalf("parse failed: %v", err)
	}

	symbols := ExtractSymbols(result.Tree, []byte(content), protocol.LangGo, "test.go")

	expectedSymbols := map[string]protocol.SymbolKind{
		"Hello":          protocol.SymbolFunction,
		"Server":         protocol.SymbolStruct,
		"(Server).Start": protocol.SymbolMethod,
		"MaxConnections": protocol.SymbolConstant,
		"globalVar":      protocol.SymbolVariable,
	}

	found := make(map[string]bool)
	for _, sym := range symbols {
		if expectedKind, ok := expectedSymbols[sym.Name]; ok {
			found[sym.Name] = true
			if sym.Kind != expectedKind {
				t.Errorf("symbol %s: expected kind %s, got %s", sym.Name, expectedKind, sym.Kind)
			}
		}
	}

	for name := range expectedSymbols {
		if !found[name] {
			t.Errorf("expected to find symbol %s", name)
		}
	}
}

// Grouped var/const specs declare multiple names on one spec (var a, b = 1, 2);
// every name must surface as its own symbol, not just the first.
// An Elixir defstruct must be named after its enclosing module (%Mod{}),
// not the useless literal "defstruct".
func TestExtractElixirStructNamedByModule(t *testing.T) {
	r := NewRegistry()
	defer r.Close()

	content := "defmodule MyApp.User do\n  defstruct [:name, :email]\nend\n"
	result, err := r.Parse(context.Background(), "user.ex", []byte(content))
	if err != nil {
		t.Fatalf("parse failed: %v", err)
	}

	symbols := ExtractSymbols(result.Tree, []byte(content), protocol.LangElixir, "user.ex")
	var structName string
	found := false
	for _, s := range symbols {
		if s.Kind == protocol.SymbolStruct {
			structName = s.Name
			found = true
		}
	}
	if !found {
		t.Fatalf("no struct symbol extracted, got: %+v", symbols)
	}
	if structName != "%MyApp.User{}" {
		t.Errorf("struct name = %q, want %q", structName, "%MyApp.User{}")
	}
}

func TestExtractGoVarConstMultiName(t *testing.T) {
	r := NewRegistry()
	defer r.Close()

	content := `package main

var a, b = 1, 2

const (
	C, D = 3, 4
)
`
	ctx := context.Background()
	result, err := r.Parse(ctx, "test.go", []byte(content))
	if err != nil {
		t.Fatalf("parse failed: %v", err)
	}

	symbols := ExtractSymbols(result.Tree, []byte(content), protocol.LangGo, "test.go")
	want := map[string]protocol.SymbolKind{
		"a": protocol.SymbolVariable,
		"b": protocol.SymbolVariable,
		"C": protocol.SymbolConstant,
		"D": protocol.SymbolConstant,
	}
	got := make(map[string]protocol.SymbolKind)
	for _, sym := range symbols {
		got[sym.Name] = sym.Kind
	}
	for name, kind := range want {
		if got[name] != kind {
			t.Errorf("symbol %q: got kind %q, want %q (symbols: %+v)", name, got[name], kind, symbols)
		}
	}
}

func TestExtractJSSymbols(t *testing.T) {
	r := NewRegistry()
	defer r.Close()

	content := `
function greet(name) {
  console.log("Hello, " + name);
}

class User {
  constructor(name) {
    this.name = name;
  }

  getName() {
    return this.name;
  }
}

const MAX_USERS = 100;
let currentUser = null;
`

	ctx := context.Background()
	result, err := r.Parse(ctx, "test.js", []byte(content))
	if err != nil {
		t.Fatalf("parse failed: %v", err)
	}

	symbols := ExtractSymbols(result.Tree, []byte(content), protocol.LangJavaScript, "test.js")

	expectedSymbols := map[string]protocol.SymbolKind{
		"greet":       protocol.SymbolFunction,
		"User":        protocol.SymbolClass,
		"MAX_USERS":   protocol.SymbolVariable,
		"currentUser": protocol.SymbolVariable,
	}

	found := make(map[string]bool)
	for _, sym := range symbols {
		if expectedKind, ok := expectedSymbols[sym.Name]; ok {
			found[sym.Name] = true
			if sym.Kind != expectedKind {
				t.Errorf("symbol %s: expected kind %s, got %s", sym.Name, expectedKind, sym.Kind)
			}
		}
	}

	for name := range expectedSymbols {
		if !found[name] {
			t.Errorf("expected to find symbol %s", name)
		}
	}
}

func TestExtractPythonSymbols(t *testing.T) {
	r := NewRegistry()
	defer r.Close()

	content := `
def greet(name):
    """Greet a person by name."""
    print(f"Hello, {name}")

class User:
    """Represents a user."""

    def __init__(self, name):
        self.name = name

    def get_name(self):
        return self.name
`

	ctx := context.Background()
	result, err := r.Parse(ctx, "test.py", []byte(content))
	if err != nil {
		t.Fatalf("parse failed: %v", err)
	}

	symbols := ExtractSymbols(result.Tree, []byte(content), protocol.LangPython, "test.py")

	expectedSymbols := map[string]protocol.SymbolKind{
		"greet":    protocol.SymbolFunction,
		"User":     protocol.SymbolClass,
		"__init__": protocol.SymbolMethod,
		"get_name": protocol.SymbolMethod,
	}

	found := make(map[string]bool)
	for _, sym := range symbols {
		if expectedKind, ok := expectedSymbols[sym.Name]; ok {
			found[sym.Name] = true
			if sym.Kind != expectedKind {
				t.Errorf("symbol %s: expected kind %s, got %s", sym.Name, expectedKind, sym.Kind)
			}
		}
	}

	for name := range expectedSymbols {
		if !found[name] {
			t.Errorf("expected to find symbol %s", name)
		}
	}
}

func TestExtractCSymbols(t *testing.T) {
	r := NewRegistry()
	defer r.Close()

	content := `
#include <stdio.h>

struct Point {
    int x;
    int y;
};

void print_point(struct Point p) {
    printf("(%d, %d)\n", p.x, p.y);
}

int main() {
    struct Point p = {1, 2};
    print_point(p);
    return 0;
}
`

	ctx := context.Background()
	result, err := r.Parse(ctx, "test.c", []byte(content))
	if err != nil {
		t.Fatalf("parse failed: %v", err)
	}

	symbols := ExtractSymbols(result.Tree, []byte(content), protocol.LangC, "test.c")

	// Note: C symbol extraction is complex, checking for at least main and Point
	expectedSymbols := map[string]protocol.SymbolKind{
		"Point": protocol.SymbolStruct,
		"main":  protocol.SymbolFunction,
	}

	found := make(map[string]bool)
	for _, sym := range symbols {
		if expectedKind, ok := expectedSymbols[sym.Name]; ok {
			found[sym.Name] = true
			if sym.Kind != expectedKind {
				t.Errorf("symbol %s: expected kind %s, got %s", sym.Name, expectedKind, sym.Kind)
			}
		}
	}

	for name := range expectedSymbols {
		if !found[name] {
			t.Errorf("expected to find symbol %s", name)
		}
	}
}

func TestExtractElixirSymbols(t *testing.T) {
	r := NewRegistry()
	defer r.Close()

	content := `defmodule MyApp.User do
  @moduledoc """
  User module for the application.
  """

  defstruct [:name, :email]

  @doc """
  Creates a new user.
  """
  def new(name, email) do
    %__MODULE__{name: name, email: email}
  end

  defp validate(user) do
    # Private validation function
    user
  end

  defmacro is_user(term) do
    quote do
      is_struct(unquote(term), __MODULE__)
    end
  end
end

defprotocol Greeting do
  @doc "Greet the entity"
  def greet(entity)
end

defimpl Greeting, for: MyApp.User do
  def greet(user) do
    "Hello, #{user.name}!"
  end
end
`

	ctx := context.Background()
	result, err := r.Parse(ctx, "test.ex", []byte(content))
	if err != nil {
		t.Fatalf("parse failed: %v", err)
	}

	symbols := ExtractSymbols(result.Tree, []byte(content), protocol.LangElixir, "test.ex")

	// Check that we found some symbols
	if len(symbols) == 0 {
		t.Fatal("expected to find some symbols")
	}

	// Look for specific expected symbols - we focus on top-level constructs
	// that the current implementation can reliably extract
	expectedSymbols := map[string]protocol.SymbolKind{
		"MyApp.User": protocol.SymbolModule,
		"Greeting":   protocol.SymbolInterface,
	}

	found := make(map[string]bool)
	for _, sym := range symbols {
		for name, expectedKind := range expectedSymbols {
			if sym.Name == name {
				found[name] = true
				if sym.Kind != expectedKind {
					t.Errorf("symbol %s: expected kind %s, got %s", sym.Name, expectedKind, sym.Kind)
				}
			}
		}
	}

	for name := range expectedSymbols {
		if !found[name] {
			t.Errorf("expected to find symbol %s, found symbols: %v", name, symbols)
		}
	}

	// Verify we found the defstruct
	foundStruct := false
	for _, sym := range symbols {
		if sym.Kind == protocol.SymbolStruct {
			foundStruct = true
			break
		}
	}
	if !foundStruct {
		t.Error("expected to find a struct symbol")
	}
}