mirror of
https://github.com/lukaszraczylo/filepuff-mcp.git
synced 2026-10-19 05:57:38 +00:00
fix(lsp): detect, evict, and respawn crashed language servers
A crashed language server stayed cached with ready==true: readLoop exited and drained in-flight calls but never cleared the running flag, and GetServer keyed reuse on ready alone. Every subsequent hover/definition/references then passed the running guard, wrote to a dead stdin, and blocked the full request timeout — permanently, since active use kept the server off the idle reaper. A single crash wedged that language at ~10s/call with no self-heal. - readLoop now flips running=false on exit, so Call fails fast instead of hanging. - GetServer treats ready && client.IsRunning() as the liveness condition; a stale entry is evicted (closed async — its process has already exited) and a fresh server is spawned in its place. - drainPending's send is now non-blocking, matching the dispatch path, so a duplicate-id race can't deadlock it under c.mu. Test (proven to fail without the fix): a client whose process exits is marked not-running and its next Call fails fast rather than blocking.
This commit is contained in:
@@ -1,10 +1,48 @@
|
||||
package lsp
|
||||
|
||||
import (
|
||||
"context"
|
||||
"os/exec"
|
||||
"strings"
|
||||
"testing"
|
||||
"time"
|
||||
)
|
||||
|
||||
// TestClientMarksNotRunningOnProcessExit verifies crash detection: when the
|
||||
// underlying server process exits (stdout EOF), readLoop must flip the client to
|
||||
// not-running so later Calls fail fast instead of blocking until their timeout.
|
||||
func TestClientMarksNotRunningOnProcessExit(t *testing.T) {
|
||||
cmd := exec.Command("sh", "-c", "exit 0") // exits immediately, closing stdout
|
||||
c, err := NewClient(cmd)
|
||||
if err != nil {
|
||||
t.Skipf("cannot start helper process: %v", err)
|
||||
}
|
||||
t.Cleanup(func() { _ = c.Close() })
|
||||
|
||||
deadline := time.Now().Add(2 * time.Second)
|
||||
for c.IsRunning() && time.Now().Before(deadline) {
|
||||
time.Sleep(10 * time.Millisecond)
|
||||
}
|
||||
if c.IsRunning() {
|
||||
t.Fatal("client should be marked not running after its process exits")
|
||||
}
|
||||
|
||||
// A Call on the dead client must fail fast (the running guard), not hang.
|
||||
done := make(chan error, 1)
|
||||
go func() {
|
||||
_, callErr := c.Call(context.Background(), "test/method", nil)
|
||||
done <- callErr
|
||||
}()
|
||||
select {
|
||||
case callErr := <-done:
|
||||
if callErr == nil {
|
||||
t.Error("Call on a dead client should return an error")
|
||||
}
|
||||
case <-time.After(2 * time.Second):
|
||||
t.Error("Call on a dead client hung instead of failing fast")
|
||||
}
|
||||
}
|
||||
|
||||
// drainStderr retains a bounded tail of server stderr for diagnostics; capture
|
||||
// must keep recent bytes and never grow past StderrCaptureMax.
|
||||
func TestClientStderrCapture(t *testing.T) {
|
||||
|
||||
Reference in New Issue
Block a user