mirror of
https://github.com/lukaszraczylo/filepuff-mcp.git
synced 2026-10-17 05:47:33 +00:00
perf(parser): cache syntax errors to skip walk on cache hit
extractErrors is a pure function of the parsed tree (it ignores content), so re-walking the whole tree on every cache hit wasted work on the hottest path (file_read+include_ast, ast_query, edit validation). Store []SyntaxError in CachedTree and return it directly on hits. Adds TestParseCachedErrorsMatch asserting cache-hit errors equal the cache-miss parse.
This commit is contained in:
@@ -172,6 +172,43 @@ func TestParseWithSyntaxErrors(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
// TestParseCachedErrorsMatch verifies that the syntax errors returned on a
|
||||
// cache hit are identical to those computed on the initial parse. Errors are
|
||||
// cached alongside the tree (they are a pure function of the tree), so the hot
|
||||
// cache-hit path must not lose or alter them.
|
||||
func TestParseCachedErrorsMatch(t *testing.T) {
|
||||
r := NewRegistry()
|
||||
defer r.Close()
|
||||
|
||||
content := []byte("package main\n\nfunc main( {}\n") // missing closing paren
|
||||
ctx := context.Background()
|
||||
|
||||
first, err := r.Parse(ctx, "test.go", content)
|
||||
if err != nil {
|
||||
t.Fatalf("first parse failed: %v", err)
|
||||
}
|
||||
if len(first.Errors) == 0 {
|
||||
t.Fatal("expected syntax errors on first parse")
|
||||
}
|
||||
|
||||
second, err := r.Parse(ctx, "test.go", content)
|
||||
if err != nil {
|
||||
t.Fatalf("cached parse failed: %v", err)
|
||||
}
|
||||
if second.Tree != first.Tree {
|
||||
t.Fatal("expected cache hit (same tree pointer)")
|
||||
}
|
||||
|
||||
if len(second.Errors) != len(first.Errors) {
|
||||
t.Fatalf("cached errors count = %d, want %d", len(second.Errors), len(first.Errors))
|
||||
}
|
||||
for i := range first.Errors {
|
||||
if second.Errors[i] != first.Errors[i] {
|
||||
t.Errorf("cached error[%d] = %+v, want %+v", i, second.Errors[i], first.Errors[i])
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestIsBinary(t *testing.T) {
|
||||
tests := []struct {
|
||||
name string
|
||||
|
||||
Reference in New Issue
Block a user